[INFO] cloning repository https://github.com/simess101/PDF-Reader [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/simess101/PDF-Reader" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimess101%2FPDF-Reader", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimess101%2FPDF-Reader'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8a6459d945e3eedcaa5a9f5fcdd9436c6181204d [INFO] linting simess101/PDF-Reader against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsimess101%2FPDF-Reader" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/simess101/PDF-Reader [INFO] finished tweaking git repo https://github.com/simess101/PDF-Reader [INFO] tweaked toml for git repo https://github.com/simess101/PDF-Reader written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/simess101/PDF-Reader on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/simess101/PDF-Reader already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jpeg-decoder v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b28a10e9627cc45908eea609aba4e4fc3f456735062bc021b83ec3fb1697dc6 [INFO] running `Command { std: "docker" "start" "-a" "3b28a10e9627cc45908eea609aba4e4fc3f456735062bc021b83ec3fb1697dc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b28a10e9627cc45908eea609aba4e4fc3f456735062bc021b83ec3fb1697dc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b28a10e9627cc45908eea609aba4e4fc3f456735062bc021b83ec3fb1697dc6", kill_on_drop: false }` [INFO] [stdout] 3b28a10e9627cc45908eea609aba4e4fc3f456735062bc021b83ec3fb1697dc6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 013fa4b35068b9fcfdb07dd6f5962bd207b5a629aead441e4c71546e8932849c [INFO] running `Command { std: "docker" "start" "-a" "013fa4b35068b9fcfdb07dd6f5962bd207b5a629aead441e4c71546e8932849c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling zerocopy v0.8.30 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling cc v1.2.47 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking wayland-sys v0.31.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking async-fs v1.6.0 [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stderr] Compiling glutin v0.31.3 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking async-once-cell v0.5.4 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking gif v0.13.3 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking rustix v0.37.28 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking jpeg-decoder v0.3.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.30 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking ecolor v0.27.2 [INFO] [stderr] Checking emath v0.27.2 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking epaint v0.27.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking egui v0.27.2 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking webbrowser v0.8.15 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking egui_glow v0.27.2 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking sctk-adwaita v0.8.3 [INFO] [stderr] Checking winit v0.29.15 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stderr] Checking accesskit_winit v0.16.1 [INFO] [stderr] Checking egui-winit v0.27.2 [INFO] [stderr] Checking eframe v0.27.2 [INFO] [stderr] Checking pdf-reader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:691:24 [INFO] [stdout] | [INFO] [stdout] 691 | } else if mode == Some("bfrange") { [INFO] [stdout] | ________________________^ [INFO] [stdout] 692 | | if tok.starts_with('<') && tok.ends_with('>') { [INFO] [stdout] 693 | | let start_hex = tok.trim_matches(&['<', '>'][..]); [INFO] [stdout] 694 | | let end_tok = tokens [INFO] [stdout] ... | [INFO] [stdout] 715 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 691 ~ } else if mode == Some("bfrange") [INFO] [stdout] 692 ~ && tok.starts_with('<') && tok.ends_with('>') { [INFO] [stdout] 693 | let start_hex = tok.trim_matches(&['<', '>'][..]); [INFO] [stdout] ... [INFO] [stdout] 713 | } [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:760:16 [INFO] [stdout] | [INFO] [stdout] 760 | if raw.len() % 2 == 0 && !cmap.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `raw.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:853:30 [INFO] [stdout] | [INFO] [stdout] 853 | last_name = Some(tok_str[1..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:852:9 [INFO] [stdout] | [INFO] [stdout] 852 | if tok_str.starts_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 852 ~ if let Some() = tok_str.strip_prefix('/') { [INFO] [stdout] 853 ~ last_name = Some(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:872:17 [INFO] [stdout] | [INFO] [stdout] 872 | / if in_text_object { [INFO] [stdout] 873 | | if let Some(raw) = stack.pop() { [INFO] [stdout] 874 | | let decoded = decode_string_with_font(&raw, ¤t_font, fonts); [INFO] [stdout] 875 | | full_text.push_str(&decoded); [INFO] [stdout] 876 | | } [INFO] [stdout] 877 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 871 ~ "Tj" | "TJ" [INFO] [stdout] 872 ~ if in_text_object => { [INFO] [stdout] 873 | if let Some(raw) = stack.pop() { [INFO] [stdout] ... [INFO] [stdout] 876 | } [INFO] [stdout] 877 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:895:29 [INFO] [stdout] | [INFO] [stdout] 895 | for (_name, val) in xobjs { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 895 - for (_name, val) in xobjs { [INFO] [stdout] 895 + for val in xobjs.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:691:24 [INFO] [stdout] | [INFO] [stdout] 691 | } else if mode == Some("bfrange") { [INFO] [stdout] | ________________________^ [INFO] [stdout] 692 | | if tok.starts_with('<') && tok.ends_with('>') { [INFO] [stdout] 693 | | let start_hex = tok.trim_matches(&['<', '>'][..]); [INFO] [stdout] 694 | | let end_tok = tokens [INFO] [stdout] ... | [INFO] [stdout] 715 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 691 ~ } else if mode == Some("bfrange") [INFO] [stdout] 692 ~ && tok.starts_with('<') && tok.ends_with('>') { [INFO] [stdout] 693 | let start_hex = tok.trim_matches(&['<', '>'][..]); [INFO] [stdout] ... [INFO] [stdout] 713 | } [INFO] [stdout] 714 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:760:16 [INFO] [stdout] | [INFO] [stdout] 760 | if raw.len() % 2 == 0 && !cmap.is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace with: `raw.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:853:30 [INFO] [stdout] | [INFO] [stdout] 853 | last_name = Some(tok_str[1..].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:852:9 [INFO] [stdout] | [INFO] [stdout] 852 | if tok_str.starts_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 852 ~ if let Some() = tok_str.strip_prefix('/') { [INFO] [stdout] 853 ~ last_name = Some(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:872:17 [INFO] [stdout] | [INFO] [stdout] 872 | / if in_text_object { [INFO] [stdout] 873 | | if let Some(raw) = stack.pop() { [INFO] [stdout] 874 | | let decoded = decode_string_with_font(&raw, ¤t_font, fonts); [INFO] [stdout] 875 | | full_text.push_str(&decoded); [INFO] [stdout] 876 | | } [INFO] [stdout] 877 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 871 ~ "Tj" | "TJ" [INFO] [stdout] 872 ~ if in_text_object => { [INFO] [stdout] 873 | if let Some(raw) = stack.pop() { [INFO] [stdout] ... [INFO] [stdout] 876 | } [INFO] [stdout] 877 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/main.rs:895:29 [INFO] [stdout] | [INFO] [stdout] 895 | for (_name, val) in xobjs { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 895 - for (_name, val) in xobjs { [INFO] [stdout] 895 + for val in xobjs.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "013fa4b35068b9fcfdb07dd6f5962bd207b5a629aead441e4c71546e8932849c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "013fa4b35068b9fcfdb07dd6f5962bd207b5a629aead441e4c71546e8932849c", kill_on_drop: false }` [INFO] [stdout] 013fa4b35068b9fcfdb07dd6f5962bd207b5a629aead441e4c71546e8932849c