[INFO] cloning repository https://github.com/sillygooseinapond/6502-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sillygooseinapond/6502-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsillygooseinapond%2F6502-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsillygooseinapond%2F6502-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c1a123539a4e45d2338bd40934ec637942e661f6 [INFO] linting sillygooseinapond/6502-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsillygooseinapond%2F6502-rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sillygooseinapond/6502-rust [INFO] finished tweaking git repo https://github.com/sillygooseinapond/6502-rust [INFO] tweaked toml for git repo https://github.com/sillygooseinapond/6502-rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sillygooseinapond/6502-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sillygooseinapond/6502-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b890efbe06bc9a4f67674b51c35934c54d34406c8418cf5865a4606ba726458c [INFO] running `Command { std: "docker" "start" "-a" "b890efbe06bc9a4f67674b51c35934c54d34406c8418cf5865a4606ba726458c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b890efbe06bc9a4f67674b51c35934c54d34406c8418cf5865a4606ba726458c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b890efbe06bc9a4f67674b51c35934c54d34406c8418cf5865a4606ba726458c", kill_on_drop: false }` [INFO] [stdout] b890efbe06bc9a4f67674b51c35934c54d34406c8418cf5865a4606ba726458c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3287d4638ad03e64c78f269cc15f1b9a4d7d57581a8a5918033aae679bcf45b [INFO] running `Command { std: "docker" "start" "-a" "a3287d4638ad03e64c78f269cc15f1b9a4d7d57581a8a5918033aae679bcf45b", kill_on_drop: false }` [INFO] [stderr] Checking emu_6502 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:106:14 [INFO] [stdout] | [INFO] [stdout] 106 | let hi = (((dec>>4)&0x0F)%0x0a+c); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - let hi = (((dec>>4)&0x0F)%0x0a+c); [INFO] [stdout] 106 + let hi = ((dec>>4)&0x0F)%0x0a+c ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/cpu.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | 0xfD => Some(Instr{cycles: 4, size: 3, inst_type: Instruction::SBC, mode: AddrMode::AbsX}), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xfd` or `0xFD` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] = note: `#[warn(clippy::mixed_case_hex_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:371:35 [INFO] [stdout] | [INFO] [stdout] 371 | let subtracting = (self.Mem[address as usize]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 371 - let subtracting = (self.Mem[address as usize]); [INFO] [stdout] 371 + let subtracting = self.Mem[address as usize] ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:379:35 [INFO] [stdout] | [INFO] [stdout] 379 | let subtracting = (self.Mem[address as usize]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 379 - let subtracting = (self.Mem[address as usize]); [INFO] [stdout] 379 + let subtracting = self.Mem[address as usize] ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:387:35 [INFO] [stdout] | [INFO] [stdout] 387 | let subtracting = (self.Mem[address as usize]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 387 - let subtracting = (self.Mem[address as usize]); [INFO] [stdout] 387 + let subtracting = self.Mem[address as usize] ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/cpu.rs:639:37 [INFO] [stdout] | [INFO] [stdout] 639 | self.Mem[self.S as usize] = ((self.PC & 0x00FF)) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove them: `(self.PC & 0x00FF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 219 | 0xc5 => Some(Instr{cycles: 3, size: 2, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ---- matches all the relevant values [INFO] [stdout] 220 | 0xd5 => Some(Instr{cycles: 4, size: 2, inst_type: Instruction::CMP, mode: AddrMode::ZPgX}), [INFO] [stdout] 221 | 0xc5 => Some(Instr{cycles: 4, size: 3, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu.rs:630:13 [INFO] [stdout] | [INFO] [stdout] 630 | _ => {}, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/cpu.rs:630:13 [INFO] [stdout] | [INFO] [stdout] 322 | Instruction::NOP => {}, [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] 323 | Instruction::ADC => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 346 | Instruction::SBC => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 369 | Instruction::CMP => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 630 | _ => {}, [INFO] [stdout] | ^ ...and 51 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pctmp` is never read [INFO] [stdout] --> src/cpu.rs:766:33 [INFO] [stdout] | [INFO] [stdout] 766 | let mut pctmp = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:106:14 [INFO] [stdout] | [INFO] [stdout] 106 | let hi = (((dec>>4)&0x0F)%0x0a+c); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 106 - let hi = (((dec>>4)&0x0F)%0x0a+c); [INFO] [stdout] 106 + let hi = ((dec>>4)&0x0F)%0x0a+c ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: inconsistent casing in hexadecimal literal [INFO] [stdout] --> src/cpu.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 148 | 0xfD => Some(Instr{cycles: 4, size: 3, inst_type: Instruction::SBC, mode: AddrMode::AbsX}), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `0xfd` or `0xFD` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_case_hex_literals [INFO] [stdout] = note: `#[warn(clippy::mixed_case_hex_literals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `res` is never read [INFO] [stdout] --> src/main.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 32 | let mut res = Ok(()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:371:35 [INFO] [stdout] | [INFO] [stdout] 371 | let subtracting = (self.Mem[address as usize]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 371 - let subtracting = (self.Mem[address as usize]); [INFO] [stdout] 371 + let subtracting = self.Mem[address as usize] ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | STA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:379:35 [INFO] [stdout] | [INFO] [stdout] 379 | let subtracting = (self.Mem[address as usize]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 379 - let subtracting = (self.Mem[address as usize]); [INFO] [stdout] 379 + let subtracting = self.Mem[address as usize] ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | STX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | STY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/cpu.rs:387:35 [INFO] [stdout] | [INFO] [stdout] 387 | let subtracting = (self.Mem[address as usize]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 387 - let subtracting = (self.Mem[address as usize]); [INFO] [stdout] 387 + let subtracting = self.Mem[address as usize] ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | LDA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | LDX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | LDY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | BEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | BRK, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | JSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | BMI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | BNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | BPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | BVC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | BVS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | BCC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | BCS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | CLC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/cpu.rs:639:37 [INFO] [stdout] | [INFO] [stdout] 639 | self.Mem[self.S as usize] = ((self.PC & 0x00FF)) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: remove them: `(self.PC & 0x00FF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | CLD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | CLV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | SEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | SED, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | SEI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | CMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | CPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | CPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | DEX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | DEY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | INX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | INY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | PHA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | PHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | PLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | PLP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | TAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | TAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | TSX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | TXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | TXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | ORA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | EOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | ASL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | ROL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | LSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | BIT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | RTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | return (lo + hi*10)%100; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return (lo + hi*10)%100; [INFO] [stdout] 107 + (lo + hi*10)%100 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | return (lo + (hi*16)) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return (lo + (hi*16)) as u8; [INFO] [stdout] 112 + (lo + (hi*16)) as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 112 | return (lo + (hi*16)) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(lo + (hi*16))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/cpu.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | / for i in 0..size { [INFO] [stdout] 126 | | emu.Mem[i] = memory[i]; [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `emu.Mem[..size].copy_from_slice(&memory[..size]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/cpu.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | 0xc5 => Some(Instr{cycles: 3, size: 2, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/cpu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | 0xc5 => Some(Instr{cycles: 4, size: 3, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] = note: `#[warn(clippy::match_overlapping_arm)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 318 | if DEBUG == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `DEBUG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:331:44 [INFO] [stdout] | [INFO] [stdout] 331 | if tmpA > 99 - adding {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:333:25 [INFO] [stdout] | [INFO] [stdout] 333 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 339 | if tmpA > 255 - adding {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:341:25 [INFO] [stdout] | [INFO] [stdout] 341 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:354:58 [INFO] [stdout] | [INFO] [stdout] 354 | if tmpA > 99_u8.wrapping_sub(subby) {self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:356:25 [INFO] [stdout] | [INFO] [stdout] 356 | self.Flags = self.Flags | CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:362:84 [INFO] [stdout] | [INFO] [stdout] 362 | if tmpA > 255 - subtracting.wrapping_sub(!(self.Flags&CFLAG)) {self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:364:25 [INFO] [stdout] | [INFO] [stdout] 364 | self.Flags = self.Flags | CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:373:43 [INFO] [stdout] | [INFO] [stdout] 373 | if self.A >= subtracting {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:375:21 [INFO] [stdout] | [INFO] [stdout] 375 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:381:43 [INFO] [stdout] | [INFO] [stdout] 381 | if self.X >= subtracting {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:389:43 [INFO] [stdout] | [INFO] [stdout] 389 | if self.Y >= subtracting {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:391:21 [INFO] [stdout] | [INFO] [stdout] 391 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:396:17 [INFO] [stdout] | [INFO] [stdout] 396 | self.A = self.A & self.Mem[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A &= self.Mem[address as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:404:30 [INFO] [stdout] | [INFO] [stdout] 404 | if res == 0 {self.Flags = self.Flags | ZFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ZFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:408:17 [INFO] [stdout] | [INFO] [stdout] 408 | self.A = self.A ^ self.Mem[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A ^= self.Mem[address as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | self.A = self.A | self.Mem[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A |= self.Mem[address as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:441:17 [INFO] [stdout] | [INFO] [stdout] 441 | self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:443:21 [INFO] [stdout] | [INFO] [stdout] 443 | self.Flags = self.Flags | ((self.A & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((self.A & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:444:21 [INFO] [stdout] | [INFO] [stdout] 444 | self.A = self.A << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:448:21 [INFO] [stdout] | [INFO] [stdout] 448 | self.Flags = self.Flags | ((mem & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((mem & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:454:17 [INFO] [stdout] | [INFO] [stdout] 454 | self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:456:21 [INFO] [stdout] | [INFO] [stdout] 456 | self.Flags = self.Flags | (self.A & CFLAG); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= (self.A & CFLAG)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:457:21 [INFO] [stdout] | [INFO] [stdout] 457 | self.A = self.A >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:461:21 [INFO] [stdout] | [INFO] [stdout] 461 | self.Flags = self.Flags | (mem & CFLAG); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= (mem & CFLAG)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:467:17 [INFO] [stdout] | [INFO] [stdout] 467 | self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:469:21 [INFO] [stdout] | [INFO] [stdout] 469 | self.Flags = self.Flags | ((self.A & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((self.A & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | self.A = self.A << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:475:21 [INFO] [stdout] | [INFO] [stdout] 475 | self.Flags = self.Flags | ((mem & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((mem & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:561:17 [INFO] [stdout] | [INFO] [stdout] 561 | pctmp = pctmp | (self.Mem[self.S as usize] as u16) << 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16) << 8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:563:17 [INFO] [stdout] | [INFO] [stdout] 563 | pctmp = pctmp | (self.Mem[self.S as usize] as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:569:17 [INFO] [stdout] | [INFO] [stdout] 569 | pctmp = pctmp | (self.Mem[self.S as usize] as u16) << 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16) << 8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:571:17 [INFO] [stdout] | [INFO] [stdout] 571 | pctmp = pctmp | (self.Mem[self.S as usize] as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:607:17 [INFO] [stdout] | [INFO] [stdout] 607 | self.Flags = self.Flags & !CFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:610:17 [INFO] [stdout] | [INFO] [stdout] 610 | self.Flags = self.Flags & !DFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !DFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:613:17 [INFO] [stdout] | [INFO] [stdout] 613 | self.Flags = self.Flags & !IFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !IFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:616:17 [INFO] [stdout] | [INFO] [stdout] 616 | self.Flags = self.Flags | VFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= VFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:619:17 [INFO] [stdout] | [INFO] [stdout] 619 | self.Flags = self.Flags | CFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:622:17 [INFO] [stdout] | [INFO] [stdout] 622 | self.Flags = self.Flags | DFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= DFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:625:17 [INFO] [stdout] | [INFO] [stdout] 625 | self.Flags = self.Flags | IFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= IFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 219 | 0xc5 => Some(Instr{cycles: 3, size: 2, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ---- matches all the relevant values [INFO] [stdout] 220 | 0xd5 => Some(Instr{cycles: 4, size: 2, inst_type: Instruction::CMP, mode: AddrMode::ZPgX}), [INFO] [stdout] 221 | 0xc5 => Some(Instr{cycles: 4, size: 3, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:635:9 [INFO] [stdout] | [INFO] [stdout] 635 | self.Flags = self.Flags & !BFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !BFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:636:9 [INFO] [stdout] | [INFO] [stdout] 636 | self.Flags = self.Flags | IFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= IFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:664:52 [INFO] [stdout] | [INFO] [stdout] 664 | if ((M^self.A)&(N^self.A))&0b10000000 != 0{self.Flags = self.Flags | VFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= VFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:666:13 [INFO] [stdout] | [INFO] [stdout] 666 | self.Flags = self.Flags & !VFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !VFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/cpu.rs:630:13 [INFO] [stdout] | [INFO] [stdout] 630 | _ => {}, [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/cpu.rs:630:13 [INFO] [stdout] | [INFO] [stdout] 322 | Instruction::NOP => {}, [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] 323 | Instruction::ADC => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 346 | Instruction::SBC => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 369 | Instruction::CMP => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 630 | _ => {}, [INFO] [stdout] | ^ ...and 51 other patterns collectively make this unreachable [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:670:33 [INFO] [stdout] | [INFO] [stdout] 670 | if M & 0b10000000 != 0 {self.Flags = self.Flags | NFLAG} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= NFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:672:13 [INFO] [stdout] | [INFO] [stdout] 672 | self.Flags = self.Flags & !NFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !NFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:675:20 [INFO] [stdout] | [INFO] [stdout] 675 | if M == 0 {self.Flags = self.Flags | ZFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ZFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:677:13 [INFO] [stdout] | [INFO] [stdout] 677 | self.Flags = self.Flags & !ZFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !ZFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:682:13 [INFO] [stdout] | [INFO] [stdout] 682 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 682 - return Ok(()); [INFO] [stdout] 682 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:706:13 [INFO] [stdout] | [INFO] [stdout] 706 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 706 - return Ok(()); [INFO] [stdout] 706 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:695:16 [INFO] [stdout] | [INFO] [stdout] 695 | if DEBUG == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `DEBUG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:703:16 [INFO] [stdout] | [INFO] [stdout] 703 | if DEBUG == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `DEBUG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:720:17 [INFO] [stdout] | [INFO] [stdout] 720 | return (u16::from_le_bytes([op1, op2]), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 720 - return (u16::from_le_bytes([op1, op2]), 0); [INFO] [stdout] 720 + (u16::from_le_bytes([op1, op2]), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:723:17 [INFO] [stdout] | [INFO] [stdout] 723 | return (op1 as u16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 723 - return (op1 as u16, 0); [INFO] [stdout] 723 + (op1 as u16, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:729:17 [INFO] [stdout] | [INFO] [stdout] 729 | return (u16::from_le_bytes([low_order, high_order]), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 729 - return (u16::from_le_bytes([low_order, high_order]), 0); [INFO] [stdout] 729 + (u16::from_le_bytes([low_order, high_order]), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:739:17 [INFO] [stdout] | [INFO] [stdout] 739 | return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 739 - return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] 739 + (u16::from_le_bytes([low_order, high_order]), clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:742:17 [INFO] [stdout] | [INFO] [stdout] 742 | return (self.X.wrapping_add(op1) as u16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 742 - return (self.X.wrapping_add(op1) as u16, 0); [INFO] [stdout] 742 + (self.X.wrapping_add(op1) as u16, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:745:17 [INFO] [stdout] | [INFO] [stdout] 745 | return (self.Y.wrapping_add(op1) as u16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 745 - return (self.Y.wrapping_add(op1) as u16, 0); [INFO] [stdout] 745 + (self.Y.wrapping_add(op1) as u16, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:755:17 [INFO] [stdout] | [INFO] [stdout] 755 | return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 755 - return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] 755 + (u16::from_le_bytes([low_order, high_order]), clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:763:17 [INFO] [stdout] | [INFO] [stdout] 763 | return (addr, clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 763 - return (addr, clock_penalty); [INFO] [stdout] 763 + (addr, clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:775:17 [INFO] [stdout] | [INFO] [stdout] 775 | return (pctmp, clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 775 - return (pctmp, clock_penalty); [INFO] [stdout] 775 + (pctmp, clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pctmp` is never read [INFO] [stdout] --> src/cpu.rs:766:33 [INFO] [stdout] | [INFO] [stdout] 766 | let mut pctmp = 0; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:779:17 [INFO] [stdout] | [INFO] [stdout] 779 | return (u16::from_le_bytes([self.Mem[ind_addr as usize], self.Mem[ind_addr as usize +1]]),0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 779 - return (u16::from_le_bytes([self.Mem[ind_addr as usize], self.Mem[ind_addr as usize +1]]),0); [INFO] [stdout] 779 + (u16::from_le_bytes([self.Mem[ind_addr as usize], self.Mem[ind_addr as usize +1]]),0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `res` is never read [INFO] [stdout] --> src/main.rs:32:19 [INFO] [stdout] | [INFO] [stdout] 32 | let mut res = Ok(()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 8 | if res.is_err(){ [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 9 | println!("{}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if !res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `machine_code` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:25:54 [INFO] [stdout] | [INFO] [stdout] 24 | if machine_code.is_err() { [INFO] [stdout] | ------------------------ help: try: `if let Err() = machine_code` [INFO] [stdout] 25 | return Err(format!("Error reading file: {}", machine_code.unwrap_err())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 40 | if !res.is_ok() { [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 41 | println!("{}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | STA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | STX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | STY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | LDA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | LDX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | LDY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | BEQ, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | BRK, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | JMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | JSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | RTS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | BMI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | BNE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | BPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | BVC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:46:52 [INFO] [stdout] | [INFO] [stdout] 46 | if emulator.Flags & cpu::IFLAG != 0 && IRQ == true{ [INFO] [stdout] | ^^^^^^^^^^^ help: try: `IRQ` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:49:23 [INFO] [stdout] | [INFO] [stdout] 49 | } else if NMI == true{ [INFO] [stdout] | ^^^^^^^^^^^ help: try: `NMI` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | BVS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | BCC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | BCS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | CLC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | CLD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | CLI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | CLV, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | SEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | SED, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | SEI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | CMP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | CPY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | CPX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | DEX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | DEY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | INX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | INY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | PHA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | PHP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | PLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | PLP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | TAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | TAY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | TSX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | TXA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | TXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 90 | TYA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | ORA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | EOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `DEBUG` should have a snake case name [INFO] [stdout] --> src/main.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | let mut DEBUG = false; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `debug` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `IRQ` should have a snake case name [INFO] [stdout] --> src/main.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let mut IRQ = false; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `irq` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NMI` should have a snake case name [INFO] [stdout] --> src/main.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let mut NMI = false; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nmi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `A` should have a snake case name [INFO] [stdout] --> src/cpu.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | A: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Y` should have a snake case name [INFO] [stdout] --> src/cpu.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | Y: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `X` should have a snake case name [INFO] [stdout] --> src/cpu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | X: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PC` should have a snake case name [INFO] [stdout] --> src/cpu.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | PC: u16, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cpu.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Flags` should have a snake case name [INFO] [stdout] --> src/cpu.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub Flags: u8, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `flags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mem` should have a snake case name [INFO] [stdout] --> src/cpu.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub Mem: [u8; 0xFFFF+1], [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `DEBUG` should have a snake case name [INFO] [stdout] --> src/cpu.rs:316:83 [INFO] [stdout] | [INFO] [stdout] 316 | fn run_instr(&mut self, instr: Instruction, mode: AddrMode, op1: u8, op2: u8, DEBUG: bool){ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `debug` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | ASL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:327:25 [INFO] [stdout] | [INFO] [stdout] 327 | let tmpA = dec_to_hex(self.A); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | ROL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | LSR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:337:25 [INFO] [stdout] | [INFO] [stdout] 337 | let tmpA = self.A; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | BIT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:350:25 [INFO] [stdout] | [INFO] [stdout] 350 | let tmpA = dec_to_hex(self.A); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 98 | RTI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:360:25 [INFO] [stdout] | [INFO] [stdout] 360 | let tmpA = self.A; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 107 | return (lo + hi*10)%100; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 - return (lo + hi*10)%100; [INFO] [stdout] 107 + (lo + hi*10)%100 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | return (lo + (hi*16)) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return (lo + (hi*16)) as u8; [INFO] [stdout] 112 + (lo + (hi*16)) as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:112:12 [INFO] [stdout] | [INFO] [stdout] 112 | return (lo + (hi*16)) as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(lo + (hi*16))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/cpu.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | / for i in 0..size { [INFO] [stdout] 126 | | emu.Mem[i] = memory[i]; [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ help: try replacing the loop by: `emu.Mem[..size].copy_from_slice(&memory[..size]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: some ranges overlap [INFO] [stdout] --> src/cpu.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | 0xc5 => Some(Instr{cycles: 3, size: 2, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] note: overlaps with this [INFO] [stdout] --> src/cpu.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | 0xc5 => Some(Instr{cycles: 4, size: 3, inst_type: Instruction::CMP, mode: AddrMode::ZPg}), [INFO] [stdout] | ^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stdout] = note: `#[warn(clippy::match_overlapping_arm)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stdout] --> src/cpu.rs:634:9 [INFO] [stdout] | [INFO] [stdout] 634 | self.PC.wrapping_add(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the result of the operation, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 634 | let _ = self.PC.wrapping_add(1); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/cpu.rs:662:32 [INFO] [stdout] | [INFO] [stdout] 662 | fn set_overflow(&mut self, M: u8, N: u8){ [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/cpu.rs:662:39 [INFO] [stdout] | [INFO] [stdout] 662 | fn set_overflow(&mut self, M: u8, N: u8){ [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/cpu.rs:668:31 [INFO] [stdout] | [INFO] [stdout] 668 | fn set_flagsnz(&mut self, M: u8){ [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `DEBUG` should have a snake case name [INFO] [stdout] --> src/cpu.rs:679:29 [INFO] [stdout] | [INFO] [stdout] 679 | pub fn clock(&mut self, DEBUG: bool) -> Result<(), String>{ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `debug` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 318 | if DEBUG == true { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `DEBUG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:331:44 [INFO] [stdout] | [INFO] [stdout] 331 | if tmpA > 99 - adding {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:333:25 [INFO] [stdout] | [INFO] [stdout] 333 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 339 | if tmpA > 255 - adding {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:341:25 [INFO] [stdout] | [INFO] [stdout] 341 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:354:58 [INFO] [stdout] | [INFO] [stdout] 354 | if tmpA > 99_u8.wrapping_sub(subby) {self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:356:25 [INFO] [stdout] | [INFO] [stdout] 356 | self.Flags = self.Flags | CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:362:84 [INFO] [stdout] | [INFO] [stdout] 362 | if tmpA > 255 - subtracting.wrapping_sub(!(self.Flags&CFLAG)) {self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:364:25 [INFO] [stdout] | [INFO] [stdout] 364 | self.Flags = self.Flags | CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:373:43 [INFO] [stdout] | [INFO] [stdout] 373 | if self.A >= subtracting {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:375:21 [INFO] [stdout] | [INFO] [stdout] 375 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:381:43 [INFO] [stdout] | [INFO] [stdout] 381 | if self.X >= subtracting {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:389:43 [INFO] [stdout] | [INFO] [stdout] 389 | if self.Y >= subtracting {self.Flags = self.Flags | CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:391:21 [INFO] [stdout] | [INFO] [stdout] 391 | self.Flags = self.Flags & !CFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:396:17 [INFO] [stdout] | [INFO] [stdout] 396 | self.A = self.A & self.Mem[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A &= self.Mem[address as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:404:30 [INFO] [stdout] | [INFO] [stdout] 404 | if res == 0 {self.Flags = self.Flags | ZFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ZFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:408:17 [INFO] [stdout] | [INFO] [stdout] 408 | self.A = self.A ^ self.Mem[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A ^= self.Mem[address as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | self.A = self.A | self.Mem[address as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A |= self.Mem[address as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:441:17 [INFO] [stdout] | [INFO] [stdout] 441 | self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:443:21 [INFO] [stdout] | [INFO] [stdout] 443 | self.Flags = self.Flags | ((self.A & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((self.A & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:444:21 [INFO] [stdout] | [INFO] [stdout] 444 | self.A = self.A << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:448:21 [INFO] [stdout] | [INFO] [stdout] 448 | self.Flags = self.Flags | ((mem & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((mem & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:454:17 [INFO] [stdout] | [INFO] [stdout] 454 | self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:456:21 [INFO] [stdout] | [INFO] [stdout] 456 | self.Flags = self.Flags | (self.A & CFLAG); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= (self.A & CFLAG)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:457:21 [INFO] [stdout] | [INFO] [stdout] 457 | self.A = self.A >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:461:21 [INFO] [stdout] | [INFO] [stdout] 461 | self.Flags = self.Flags | (mem & CFLAG); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= (mem & CFLAG)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:467:17 [INFO] [stdout] | [INFO] [stdout] 467 | self.Flags = self.Flags & !CFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:469:21 [INFO] [stdout] | [INFO] [stdout] 469 | self.Flags = self.Flags | ((self.A & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((self.A & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:470:21 [INFO] [stdout] | [INFO] [stdout] 470 | self.A = self.A << 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.A <<= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:475:21 [INFO] [stdout] | [INFO] [stdout] 475 | self.Flags = self.Flags | ((mem & NFLAG) >> 7); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ((mem & NFLAG) >> 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:561:17 [INFO] [stdout] | [INFO] [stdout] 561 | pctmp = pctmp | (self.Mem[self.S as usize] as u16) << 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16) << 8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:563:17 [INFO] [stdout] | [INFO] [stdout] 563 | pctmp = pctmp | (self.Mem[self.S as usize] as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:569:17 [INFO] [stdout] | [INFO] [stdout] 569 | pctmp = pctmp | (self.Mem[self.S as usize] as u16) << 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16) << 8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:571:17 [INFO] [stdout] | [INFO] [stdout] 571 | pctmp = pctmp | (self.Mem[self.S as usize] as u16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pctmp |= (self.Mem[self.S as usize] as u16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:607:17 [INFO] [stdout] | [INFO] [stdout] 607 | self.Flags = self.Flags & !CFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:610:17 [INFO] [stdout] | [INFO] [stdout] 610 | self.Flags = self.Flags & !DFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !DFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:613:17 [INFO] [stdout] | [INFO] [stdout] 613 | self.Flags = self.Flags & !IFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !IFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:616:17 [INFO] [stdout] | [INFO] [stdout] 616 | self.Flags = self.Flags | VFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= VFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:619:17 [INFO] [stdout] | [INFO] [stdout] 619 | self.Flags = self.Flags | CFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= CFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:622:17 [INFO] [stdout] | [INFO] [stdout] 622 | self.Flags = self.Flags | DFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= DFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:625:17 [INFO] [stdout] | [INFO] [stdout] 625 | self.Flags = self.Flags | IFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= IFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:635:9 [INFO] [stdout] | [INFO] [stdout] 635 | self.Flags = self.Flags & !BFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !BFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:636:9 [INFO] [stdout] | [INFO] [stdout] 636 | self.Flags = self.Flags | IFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= IFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:664:52 [INFO] [stdout] | [INFO] [stdout] 664 | if ((M^self.A)&(N^self.A))&0b10000000 != 0{self.Flags = self.Flags | VFLAG [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= VFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:666:13 [INFO] [stdout] | [INFO] [stdout] 666 | self.Flags = self.Flags & !VFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !VFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:670:33 [INFO] [stdout] | [INFO] [stdout] 670 | if M & 0b10000000 != 0 {self.Flags = self.Flags | NFLAG} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= NFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:672:13 [INFO] [stdout] | [INFO] [stdout] 672 | self.Flags = self.Flags & !NFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !NFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:675:20 [INFO] [stdout] | [INFO] [stdout] 675 | if M == 0 {self.Flags = self.Flags | ZFLAG; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags |= ZFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:677:13 [INFO] [stdout] | [INFO] [stdout] 677 | self.Flags = self.Flags & !ZFLAG;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.Flags &= !ZFLAG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:682:13 [INFO] [stdout] | [INFO] [stdout] 682 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 682 - return Ok(()); [INFO] [stdout] 682 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:706:13 [INFO] [stdout] | [INFO] [stdout] 706 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 706 - return Ok(()); [INFO] [stdout] 706 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:695:16 [INFO] [stdout] | [INFO] [stdout] 695 | if DEBUG == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `DEBUG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/cpu.rs:703:16 [INFO] [stdout] | [INFO] [stdout] 703 | if DEBUG == true{ [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `DEBUG` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:720:17 [INFO] [stdout] | [INFO] [stdout] 720 | return (u16::from_le_bytes([op1, op2]), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 720 - return (u16::from_le_bytes([op1, op2]), 0); [INFO] [stdout] 720 + (u16::from_le_bytes([op1, op2]), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:723:17 [INFO] [stdout] | [INFO] [stdout] 723 | return (op1 as u16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 723 - return (op1 as u16, 0); [INFO] [stdout] 723 + (op1 as u16, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:729:17 [INFO] [stdout] | [INFO] [stdout] 729 | return (u16::from_le_bytes([low_order, high_order]), 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 729 - return (u16::from_le_bytes([low_order, high_order]), 0); [INFO] [stdout] 729 + (u16::from_le_bytes([low_order, high_order]), 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:739:17 [INFO] [stdout] | [INFO] [stdout] 739 | return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 739 - return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] 739 + (u16::from_le_bytes([low_order, high_order]), clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:742:17 [INFO] [stdout] | [INFO] [stdout] 742 | return (self.X.wrapping_add(op1) as u16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 742 - return (self.X.wrapping_add(op1) as u16, 0); [INFO] [stdout] 742 + (self.X.wrapping_add(op1) as u16, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:745:17 [INFO] [stdout] | [INFO] [stdout] 745 | return (self.Y.wrapping_add(op1) as u16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 745 - return (self.Y.wrapping_add(op1) as u16, 0); [INFO] [stdout] 745 + (self.Y.wrapping_add(op1) as u16, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:755:17 [INFO] [stdout] | [INFO] [stdout] 755 | return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 755 - return (u16::from_le_bytes([low_order, high_order]), clock_penalty); [INFO] [stdout] 755 + (u16::from_le_bytes([low_order, high_order]), clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:763:17 [INFO] [stdout] | [INFO] [stdout] 763 | return (addr, clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 763 - return (addr, clock_penalty); [INFO] [stdout] 763 + (addr, clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:775:17 [INFO] [stdout] | [INFO] [stdout] 775 | return (pctmp, clock_penalty); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 775 - return (pctmp, clock_penalty); [INFO] [stdout] 775 + (pctmp, clock_penalty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:779:17 [INFO] [stdout] | [INFO] [stdout] 779 | return (u16::from_le_bytes([self.Mem[ind_addr as usize], self.Mem[ind_addr as usize +1]]),0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 779 - return (u16::from_le_bytes([self.Mem[ind_addr as usize], self.Mem[ind_addr as usize +1]]),0); [INFO] [stdout] 779 + (u16::from_le_bytes([self.Mem[ind_addr as usize], self.Mem[ind_addr as usize +1]]),0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 8 | if res.is_err(){ [INFO] [stdout] | --------------- help: try: `if let Err() = res` [INFO] [stdout] 9 | println!("{}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if !res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `machine_code` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:25:54 [INFO] [stdout] | [INFO] [stdout] 24 | if machine_code.is_err() { [INFO] [stdout] | ------------------------ help: try: `if let Err() = machine_code` [INFO] [stdout] 25 | return Err(format!("Error reading file: {}", machine_code.unwrap_err())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `res` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 40 | if !res.is_ok() { [INFO] [stdout] | ----------- the check is happening here [INFO] [stdout] 41 | println!("{}", res.unwrap_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:46:52 [INFO] [stdout] | [INFO] [stdout] 46 | if emulator.Flags & cpu::IFLAG != 0 && IRQ == true{ [INFO] [stdout] | ^^^^^^^^^^^ help: try: `IRQ` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/main.rs:49:23 [INFO] [stdout] | [INFO] [stdout] 49 | } else if NMI == true{ [INFO] [stdout] | ^^^^^^^^^^^ help: try: `NMI` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `DEBUG` should have a snake case name [INFO] [stdout] --> src/main.rs:13:13 [INFO] [stdout] | [INFO] [stdout] 13 | let mut DEBUG = false; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `debug` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `IRQ` should have a snake case name [INFO] [stdout] --> src/main.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let mut IRQ = false; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `irq` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `NMI` should have a snake case name [INFO] [stdout] --> src/main.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let mut NMI = false; [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `nmi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `A` should have a snake case name [INFO] [stdout] --> src/cpu.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | A: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Y` should have a snake case name [INFO] [stdout] --> src/cpu.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | Y: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `X` should have a snake case name [INFO] [stdout] --> src/cpu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | X: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `PC` should have a snake case name [INFO] [stdout] --> src/cpu.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | PC: u16, [INFO] [stdout] | ^^ help: convert the identifier to snake case: `pc` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `S` should have a snake case name [INFO] [stdout] --> src/cpu.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | S: u8, [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Flags` should have a snake case name [INFO] [stdout] --> src/cpu.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub Flags: u8, [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case (notice the capitalization): `flags` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `Mem` should have a snake case name [INFO] [stdout] --> src/cpu.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub Mem: [u8; 0xFFFF+1], [INFO] [stdout] | ^^^ help: convert the identifier to snake case: `mem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `DEBUG` should have a snake case name [INFO] [stdout] --> src/cpu.rs:316:83 [INFO] [stdout] | [INFO] [stdout] 316 | fn run_instr(&mut self, instr: Instruction, mode: AddrMode, op1: u8, op2: u8, DEBUG: bool){ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `debug` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:327:25 [INFO] [stdout] | [INFO] [stdout] 327 | let tmpA = dec_to_hex(self.A); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:337:25 [INFO] [stdout] | [INFO] [stdout] 337 | let tmpA = self.A; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:350:25 [INFO] [stdout] | [INFO] [stdout] 350 | let tmpA = dec_to_hex(self.A); [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `tmpA` should have a snake case name [INFO] [stdout] --> src/cpu.rs:360:25 [INFO] [stdout] | [INFO] [stdout] 360 | let tmpA = self.A; [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `tmp_a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::num::::wrapping_add` that must be used [INFO] [stdout] --> src/cpu.rs:634:9 [INFO] [stdout] | [INFO] [stdout] 634 | self.PC.wrapping_add(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the result of the operation, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 634 | let _ = self.PC.wrapping_add(1); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/cpu.rs:662:32 [INFO] [stdout] | [INFO] [stdout] 662 | fn set_overflow(&mut self, M: u8, N: u8){ [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/cpu.rs:662:39 [INFO] [stdout] | [INFO] [stdout] 662 | fn set_overflow(&mut self, M: u8, N: u8){ [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `M` should have a snake case name [INFO] [stdout] --> src/cpu.rs:668:31 [INFO] [stdout] | [INFO] [stdout] 668 | fn set_flagsnz(&mut self, M: u8){ [INFO] [stdout] | ^ help: convert the identifier to snake case: `m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `DEBUG` should have a snake case name [INFO] [stdout] --> src/cpu.rs:679:29 [INFO] [stdout] | [INFO] [stdout] 679 | pub fn clock(&mut self, DEBUG: bool) -> Result<(), String>{ [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `debug` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `Command { std: "docker" "inspect" "a3287d4638ad03e64c78f269cc15f1b9a4d7d57581a8a5918033aae679bcf45b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3287d4638ad03e64c78f269cc15f1b9a4d7d57581a8a5918033aae679bcf45b", kill_on_drop: false }` [INFO] [stdout] a3287d4638ad03e64c78f269cc15f1b9a4d7d57581a8a5918033aae679bcf45b