[INFO] cloning repository https://github.com/silexlabs/silex-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/silexlabs/silex-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsilexlabs%2Fsilex-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsilexlabs%2Fsilex-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bf0eb51852235a380a8611d81f9c68bc1ff00240 [INFO] linting silexlabs/silex-server against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsilexlabs%2Fsilex-server" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/silexlabs/silex-server [INFO] finished tweaking git repo https://github.com/silexlabs/silex-server [INFO] tweaked toml for git repo https://github.com/silexlabs/silex-server written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/silexlabs/silex-server on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/silexlabs/silex-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Updating axum v0.7.9 -> v0.8.8 [INFO] [stderr] Updating axum-core v0.4.5 -> v0.5.6 [INFO] [stderr] Updating axum-macros v0.4.2 -> v0.5.0 [INFO] [stderr] Adding block-buffer v0.10.4 [INFO] [stderr] Adding cpufeatures v0.2.17 [INFO] [stderr] Adding crypto-common v0.1.7 [INFO] [stderr] Adding digest v0.10.7 [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Updating libc v0.2.180 -> v0.2.183 [INFO] [stderr] Updating matchit v0.7.3 -> v0.8.4 (available: v0.8.6) [INFO] [stderr] Adding objc2-core-foundation v0.3.2 [INFO] [stderr] Adding objc2-system-configuration v0.3.2 [INFO] [stderr] Updating rand v0.8.5 -> v0.9.2 [INFO] [stderr] Updating rand_chacha v0.3.1 -> v0.9.0 [INFO] [stderr] Updating rand_core v0.6.4 -> v0.9.5 [INFO] [stderr] Adding rust-embed v8.11.0 [INFO] [stderr] Adding rust-embed-impl v8.11.0 [INFO] [stderr] Adding rust-embed-utils v8.11.0 [INFO] [stderr] Adding same-file v1.0.6 [INFO] [stderr] Adding sha2 v0.10.9 [INFO] [stderr] Updating thiserror v1.0.69 -> v2.0.18 [INFO] [stderr] Updating thiserror-impl v1.0.69 -> v2.0.18 [INFO] [stderr] Updating tower-cookies v0.10.0 -> v0.11.0 [INFO] [stderr] Updating tower-http v0.5.2 -> v0.6.8 [INFO] [stderr] Updating tower-sessions v0.12.3 -> v0.15.0 [INFO] [stderr] Updating tower-sessions-core v0.12.3 -> v0.15.0 [INFO] [stderr] Updating tower-sessions-memory-store v0.12.3 -> v0.15.0 [INFO] [stderr] Adding typenum v1.19.0 [INFO] [stderr] Adding walkdir v2.5.0 [INFO] [stderr] Adding wasi v0.14.7+wasi-0.2.4 [INFO] [stderr] Updating wasite v0.1.0 -> v1.0.2 [INFO] [stderr] Updating whoami v1.6.1 -> v2.1.1 [INFO] [stderr] Adding winapi-util v0.1.11 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded whoami v2.1.1 [INFO] [stderr] Downloaded tower-sessions-memory-store v0.15.0 [INFO] [stderr] Downloaded wasite v1.0.2 [INFO] [stderr] Downloaded tower-cookies v0.11.0 [INFO] [stderr] Downloaded tower-sessions-core v0.15.0 [INFO] [stderr] Downloaded tower-sessions v0.15.0 [INFO] [stderr] Downloaded objc2-system-configuration v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ef531918701a0013dcb8ea2f2c2f3447a9dce55358a724bc5f15e75647fc34d [INFO] running `Command { std: "docker" "start" "-a" "2ef531918701a0013dcb8ea2f2c2f3447a9dce55358a724bc5f15e75647fc34d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ef531918701a0013dcb8ea2f2c2f3447a9dce55358a724bc5f15e75647fc34d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ef531918701a0013dcb8ea2f2c2f3447a9dce55358a724bc5f15e75647fc34d", kill_on_drop: false }` [INFO] [stdout] 2ef531918701a0013dcb8ea2f2c2f3447a9dce55358a724bc5f15e75647fc34d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ebae11b61d6db0069f8bfbcedff2315a8d6ac797a9cc7fbcce8957d3668b859e [INFO] running `Command { std: "docker" "start" "-a" "ebae11b61d6db0069f8bfbcedff2315a8d6ac797a9cc7fbcce8957d3668b859e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling zerocopy v0.8.37 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling zmij v1.0.19 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Compiling time-macros v0.2.26 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Checking compression-core v0.4.31 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking compression-codecs v0.4.36 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking whoami v2.1.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking tower-cookies v0.11.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower-sessions-core v0.15.0 [INFO] [stderr] Checking async-compression v0.4.37 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking tokio-test v0.4.5 [INFO] [stderr] Checking tower-sessions-memory-store v0.15.0 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking tower-sessions v0.15.0 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking silex-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/connectors/fs_hosting.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | target_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - target_dir: &PathBuf, [INFO] [stdout] 91 + target_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/connectors/fs_storage.rs:241:22 [INFO] [stdout] | [INFO] [stdout] 241 | .map(|p| !p.get("isFile").is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.get("isFile").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/connectors/fs_storage.rs:611:18 [INFO] [stdout] | [INFO] [stdout] 611 | .map(|t| DateTime::::from(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DateTime::::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/connectors/fs_storage.rs:615:18 [INFO] [stdout] | [INFO] [stdout] 615 | .map(|t| DateTime::::from(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DateTime::::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/connectors/fs_hosting.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | target_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - target_dir: &PathBuf, [INFO] [stdout] 91 + target_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/connectors/fs_storage.rs:241:22 [INFO] [stdout] | [INFO] [stdout] 241 | .map(|p| !p.get("isFile").is_some()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.get("isFile").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/connectors/fs_storage.rs:611:18 [INFO] [stdout] | [INFO] [stdout] 611 | .map(|t| DateTime::::from(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DateTime::::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/connectors/fs_storage.rs:615:18 [INFO] [stdout] | [INFO] [stdout] 615 | .map(|t| DateTime::::from(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `DateTime::::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dashboard_index` after checking its variant with `is_some` [INFO] [stdout] --> src/services/static_files.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 124 | if dashboard_index.is_some() && editor_index.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 125 | let dash_bytes: Vec = [INFO] [stdout] 126 | std::fs::read(dashboard_index.as_ref().unwrap()).unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `editor_index` after checking its variant with `is_some` [INFO] [stdout] --> src/services/static_files.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 124 | if dashboard_index.is_some() && editor_index.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 128 | std::fs::read(editor_index.as_ref().unwrap()).unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dashboard_index` after checking its variant with `is_some` [INFO] [stdout] --> src/services/static_files.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 124 | if dashboard_index.is_some() && editor_index.is_some() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 125 | let dash_bytes: Vec = [INFO] [stdout] 126 | std::fs::read(dashboard_index.as_ref().unwrap()).unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `editor_index` after checking its variant with `is_some` [INFO] [stdout] --> src/services/static_files.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 124 | if dashboard_index.is_some() && editor_index.is_some() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 128 | std::fs::read(editor_index.as_ref().unwrap()).unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.25s [INFO] running `Command { std: "docker" "inspect" "ebae11b61d6db0069f8bfbcedff2315a8d6ac797a9cc7fbcce8957d3668b859e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebae11b61d6db0069f8bfbcedff2315a8d6ac797a9cc7fbcce8957d3668b859e", kill_on_drop: false }` [INFO] [stdout] ebae11b61d6db0069f8bfbcedff2315a8d6ac797a9cc7fbcce8957d3668b859e