[INFO] cloning repository https://github.com/sidharthsunilkumar/df2-miner [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sidharthsunilkumar/df2-miner" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsidharthsunilkumar%2Fdf2-miner", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsidharthsunilkumar%2Fdf2-miner'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 879ad3d712b63a15c1342682778afa1b8af1fb20 [INFO] linting sidharthsunilkumar/df2-miner against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsidharthsunilkumar%2Fdf2-miner" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sidharthsunilkumar/df2-miner [INFO] finished tweaking git repo https://github.com/sidharthsunilkumar/df2-miner [INFO] tweaked toml for git repo https://github.com/sidharthsunilkumar/df2-miner written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sidharthsunilkumar/df2-miner on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sidharthsunilkumar/df2-miner already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded priority-queue v1.4.0 [INFO] [stderr] Downloaded rayon-cond v0.3.0 [INFO] [stderr] Downloaded rustworkx-core v0.14.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb52c7aa0bba9749013f3e667b599dc4d91939a0fd385d0d39d78c2d21d64da5 [INFO] running `Command { std: "docker" "start" "-a" "fb52c7aa0bba9749013f3e667b599dc4d91939a0fd385d0d39d78c2d21d64da5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb52c7aa0bba9749013f3e667b599dc4d91939a0fd385d0d39d78c2d21d64da5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb52c7aa0bba9749013f3e667b599dc4d91939a0fd385d0d39d78c2d21d64da5", kill_on_drop: false }` [INFO] [stdout] fb52c7aa0bba9749013f3e667b599dc4d91939a0fd385d0d39d78c2d21d64da5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dafff8b5c6972a0b0e754e9efcee03fec7b2a5a7500030ffb095dfe5e6ee5c0f [INFO] running `Command { std: "docker" "start" "-a" "dafff8b5c6972a0b0e754e9efcee03fec7b2a5a7500030ffb095dfe5e6ee5c0f", kill_on_drop: false }` [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Compiling priority-queue v1.4.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_pcg v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking rayon-cond v0.3.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking rustworkx-core v0.14.2 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking hyper-util v0.1.12 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking dfg_visualizer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Event` and `Object` [INFO] [stdout] --> src/main.rs:8:30 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::types::{OcelJson, Event, Object, ProcessForest, TreeNode}; [INFO] [stdout] | ^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/build_relations_fns.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/build_relations_fns.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/types.rs:2:24 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::NaiveDateTime` [INFO] [stdout] --> src/divergence_free_dfg.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use chrono::NaiveDateTime; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DateTime` and `Utc` [INFO] [stdout] --> src/divergence_free_dfg.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use chrono::{DateTime, Utc}; [INFO] [stdout] | ^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/divergence_free_dfg.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/divergence_free_dfg.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if (!excl_set1.is_empty() && !excl_set2.is_empty() && is_exclusive_choice_cut_possible(&filtered_dfg, &excl_set1, &excl_set2)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - if (!excl_set1.is_empty() && !excl_set2.is_empty() && is_exclusive_choice_cut_possible(&filtered_dfg, &excl_set1, &excl_set2)) { [INFO] [stdout] 35 + if !excl_set1.is_empty() && !excl_set2.is_empty() && is_exclusive_choice_cut_possible(&filtered_dfg, &excl_set1, &excl_set2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | if (!set1.is_empty() && !set2.is_empty() && is_sequence_cut_possible(&filtered_dfg, &set1, &set2)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (!set1.is_empty() && !set2.is_empty() && is_sequence_cut_possible(&filtered_dfg, &set1, &set2)) { [INFO] [stdout] 58 + if !set1.is_empty() && !set2.is_empty() && is_sequence_cut_possible(&filtered_dfg, &set1, &set2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | if (is_parallel [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 84 | && parallel_cut_condition_check(¶_set1, ¶_set2, &start_activities, &end_activities)) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 81 ~ if is_parallel [INFO] [stdout] 82 | && !para_set1.is_empty() [INFO] [stdout] 83 | && !para_set2.is_empty() [INFO] [stdout] 84 ~ && parallel_cut_condition_check(¶_set1, ¶_set2, &start_activities, &end_activities) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | if (is_redo [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 122 | )) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 ~ if is_redo [INFO] [stdout] 114 | && !redo_set2.is_empty() [INFO] [stdout] ... [INFO] [stdout] 121 | &end_activities, [INFO] [stdout] 122 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 242 | if (r1 || r2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 242 - if (r1 || r2) { [INFO] [stdout] 242 + if r1 || r2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:570:19 [INFO] [stdout] | [INFO] [stdout] 570 | } else if (!is_s1_redo && is_s2_redo) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 570 - } else if (!is_s1_redo && is_s2_redo) { [INFO] [stdout] 570 + } else if !is_s1_redo && is_s2_redo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Event` and `Object` [INFO] [stdout] --> src/main.rs:8:30 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::types::{OcelJson, Event, Object, ProcessForest, TreeNode}; [INFO] [stdout] | ^^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde::Deserialize` [INFO] [stdout] --> src/build_relations_fns.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use serde::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/build_relations_fns.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `HashMap` and `HashSet` [INFO] [stdout] --> src/types.rs:2:24 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::NaiveDateTime` [INFO] [stdout] --> src/divergence_free_dfg.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use chrono::NaiveDateTime; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DateTime` and `Utc` [INFO] [stdout] --> src/divergence_free_dfg.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use chrono::{DateTime, Utc}; [INFO] [stdout] | ^^^^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::BufReader` [INFO] [stdout] --> src/divergence_free_dfg.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::io::BufReader; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/divergence_free_dfg.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if (!excl_set1.is_empty() && !excl_set2.is_empty() && is_exclusive_choice_cut_possible(&filtered_dfg, &excl_set1, &excl_set2)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 35 - if (!excl_set1.is_empty() && !excl_set2.is_empty() && is_exclusive_choice_cut_possible(&filtered_dfg, &excl_set1, &excl_set2)) { [INFO] [stdout] 35 + if !excl_set1.is_empty() && !excl_set2.is_empty() && is_exclusive_choice_cut_possible(&filtered_dfg, &excl_set1, &excl_set2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 58 | if (!set1.is_empty() && !set2.is_empty() && is_sequence_cut_possible(&filtered_dfg, &set1, &set2)) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 - if (!set1.is_empty() && !set2.is_empty() && is_sequence_cut_possible(&filtered_dfg, &set1, &set2)) { [INFO] [stdout] 58 + if !set1.is_empty() && !set2.is_empty() && is_sequence_cut_possible(&filtered_dfg, &set1, &set2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | if (is_parallel [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 84 | && parallel_cut_condition_check(¶_set1, ¶_set2, &start_activities, &end_activities)) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 81 ~ if is_parallel [INFO] [stdout] 82 | && !para_set1.is_empty() [INFO] [stdout] 83 | && !para_set2.is_empty() [INFO] [stdout] 84 ~ && parallel_cut_condition_check(¶_set1, ¶_set2, &start_activities, &end_activities) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | if (is_redo [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 122 | )) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 113 ~ if is_redo [INFO] [stdout] 114 | && !redo_set2.is_empty() [INFO] [stdout] ... [INFO] [stdout] 121 | &end_activities, [INFO] [stdout] 122 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:242:16 [INFO] [stdout] | [INFO] [stdout] 242 | if (r1 || r2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 242 - if (r1 || r2) { [INFO] [stdout] 242 + if r1 || r2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/start_cuts_opti.rs:570:19 [INFO] [stdout] | [INFO] [stdout] 570 | } else if (!is_s1_redo && is_s2_redo) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 570 - } else if (!is_s1_redo && is_s2_redo) { [INFO] [stdout] 570 + } else if !is_s1_redo && is_s2_redo { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> src/start_cuts_opti.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> src/start_cuts_opti.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ocel` [INFO] [stdout] --> src/interaction_patterns.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | ocel: &OcelJson, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_ocel` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next_otype` [INFO] [stdout] --> src/divergence_free_dfg.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let next_otype = &next_relation.4; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_next_otype` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filtered_dfg` [INFO] [stdout] --> src/start_cuts.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | filtered_dfg: &HashMap<(String, String), usize>, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filtered_dfg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/start_cuts_opti.rs:405:9 [INFO] [stdout] | [INFO] [stdout] 405 | let mut common_activities = intersection.clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `con` [INFO] [stdout] --> src/main.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_con` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rel` [INFO] [stdout] --> src/main.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rel` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `defi` [INFO] [stdout] --> src/main.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_defi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_object_types` [INFO] [stdout] --> src/main.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_object_types` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ocel` [INFO] [stdout] --> src/interaction_patterns.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | ocel: &OcelJson, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_ocel` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next_otype` [INFO] [stdout] --> src/divergence_free_dfg.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let next_otype = &next_relation.4; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_next_otype` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `log_sorted_map` is never used [INFO] [stdout] --> src/main.rs:76:4 [INFO] [stdout] | [INFO] [stdout] 76 | fn log_sorted_map( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `object_types` and `event_types` are never read [INFO] [stdout] --> src/types.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct OcelJson { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 8 | #[serde(rename = "objectTypes")] [INFO] [stdout] 9 | pub object_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 10 | #[serde(rename = "eventTypes")] [INFO] [stdout] 11 | pub event_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OcelJson` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `attributes` are never read [INFO] [stdout] --> src/types.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct ObjectType { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 18 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 19 | pub attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ObjectType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `attributes` are never read [INFO] [stdout] --> src/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EventType { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 24 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | pub attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `attr_type` are never read [INFO] [stdout] --> src/types.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct AttributeDefinition { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 30 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 31 | #[serde(rename = "type")] [INFO] [stdout] 32 | pub attr_type: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AttributeDefinition` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attributes` is never read [INFO] [stdout] --> src/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Event { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | pub attributes: Option>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attributes` is never read [INFO] [stdout] --> src/types.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct Object { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub attributes: Option>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `value`, and `time` are never read [INFO] [stdout] --> src/types.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub struct Attribute { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 55 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 56 | pub value: serde_json::Value, // it handle both strings and numbers [INFO] [stdout] | ^^^^^ [INFO] [stdout] 57 | pub time: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Attribute` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `qualifier` is never read [INFO] [stdout] --> src/types.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 61 | pub struct Relationship { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | pub qualifier: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Relationship` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/types.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Edge` is never constructed [INFO] [stdout] --> src/types.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct Edge { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Graph` is never constructed [INFO] [stdout] --> src/types.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub struct Graph { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_cuts` is never used [INFO] [stdout] --> src/start_cuts.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn find_cuts( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_keep_dfg` is never used [INFO] [stdout] --> src/start_cuts.rs:135:4 [INFO] [stdout] | [INFO] [stdout] 135 | fn filter_keep_dfg( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_parallel_cut_possible` is never used [INFO] [stdout] --> src/start_cuts.rs:190:4 [INFO] [stdout] | [INFO] [stdout] 190 | fn is_parallel_cut_possible( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_redo_cut_possible` is never used [INFO] [stdout] --> src/start_cuts.rs:233:4 [INFO] [stdout] | [INFO] [stdout] 233 | fn is_redo_cut_possible( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_start_and_end_activities` is never used [INFO] [stdout] --> src/start_cuts.rs:329:4 [INFO] [stdout] | [INFO] [stdout] 329 | fn get_start_and_end_activities( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_start_and_end_activities_v2` is never used [INFO] [stdout] --> src/start_cuts.rs:359:4 [INFO] [stdout] | [INFO] [stdout] 359 | fn get_start_and_end_activities_v2( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `exclusive_cut_condition_check` is never used [INFO] [stdout] --> src/start_cuts_opti.rs:232:4 [INFO] [stdout] | [INFO] [stdout] 232 | fn exclusive_cut_condition_check( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sequence_cut_condition_check` is never used [INFO] [stdout] --> src/start_cuts_opti.rs:473:4 [INFO] [stdout] | [INFO] [stdout] 473 | fn sequence_cut_condition_check( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/build_relations_fns.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | objects: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 - objects: &Vec, [INFO] [stdout] 9 + objects: &[Object], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filtered_dfg` [INFO] [stdout] --> src/start_cuts.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | filtered_dfg: &HashMap<(String, String), usize>, [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filtered_dfg` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/start_cuts_opti.rs:405:9 [INFO] [stdout] | [INFO] [stdout] 405 | let mut common_activities = intersection.clone(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `con` [INFO] [stdout] --> src/main.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_con` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rel` [INFO] [stdout] --> src/main.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_rel` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `defi` [INFO] [stdout] --> src/main.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_defi` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_object_types` [INFO] [stdout] --> src/main.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | let (div, con, rel, defi, all_activities, all_object_types) = [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_object_types` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `log_sorted_map` is never used [INFO] [stdout] --> src/main.rs:76:4 [INFO] [stdout] | [INFO] [stdout] 76 | fn log_sorted_map( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `object_types` and `event_types` are never read [INFO] [stdout] --> src/types.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct OcelJson { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 8 | #[serde(rename = "objectTypes")] [INFO] [stdout] 9 | pub object_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 10 | #[serde(rename = "eventTypes")] [INFO] [stdout] 11 | pub event_types: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `OcelJson` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `attributes` are never read [INFO] [stdout] --> src/types.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct ObjectType { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 18 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 19 | pub attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ObjectType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `attributes` are never read [INFO] [stdout] --> src/types.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct EventType { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 24 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | pub attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `attr_type` are never read [INFO] [stdout] --> src/types.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct AttributeDefinition { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] 30 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 31 | #[serde(rename = "type")] [INFO] [stdout] 32 | pub attr_type: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AttributeDefinition` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attributes` is never read [INFO] [stdout] --> src/types.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub struct Event { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | pub attributes: Option>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `attributes` is never read [INFO] [stdout] --> src/types.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct Object { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 50 | pub attributes: Option>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `value`, and `time` are never read [INFO] [stdout] --> src/types.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 54 | pub struct Attribute { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 55 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 56 | pub value: serde_json::Value, // it handle both strings and numbers [INFO] [stdout] | ^^^^^ [INFO] [stdout] 57 | pub time: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Attribute` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `qualifier` is never read [INFO] [stdout] --> src/types.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 61 | pub struct Relationship { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 64 | pub qualifier: String, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Relationship` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/types.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | pub struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Edge` is never constructed [INFO] [stdout] --> src/types.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct Edge { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Graph` is never constructed [INFO] [stdout] --> src/types.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub struct Graph { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_cuts` is never used [INFO] [stdout] --> src/start_cuts.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn find_cuts( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `filter_keep_dfg` is never used [INFO] [stdout] --> src/start_cuts.rs:135:4 [INFO] [stdout] | [INFO] [stdout] 135 | fn filter_keep_dfg( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_parallel_cut_possible` is never used [INFO] [stdout] --> src/start_cuts.rs:190:4 [INFO] [stdout] | [INFO] [stdout] 190 | fn is_parallel_cut_possible( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_redo_cut_possible` is never used [INFO] [stdout] --> src/start_cuts.rs:233:4 [INFO] [stdout] | [INFO] [stdout] 233 | fn is_redo_cut_possible( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_start_and_end_activities` is never used [INFO] [stdout] --> src/start_cuts.rs:329:4 [INFO] [stdout] | [INFO] [stdout] 329 | fn get_start_and_end_activities( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_start_and_end_activities_v2` is never used [INFO] [stdout] --> src/start_cuts.rs:359:4 [INFO] [stdout] | [INFO] [stdout] 359 | fn get_start_and_end_activities_v2( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `exclusive_cut_condition_check` is never used [INFO] [stdout] --> src/start_cuts_opti.rs:232:4 [INFO] [stdout] | [INFO] [stdout] 232 | fn exclusive_cut_condition_check( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `sequence_cut_condition_check` is never used [INFO] [stdout] --> src/start_cuts_opti.rs:473:4 [INFO] [stdout] | [INFO] [stdout] 473 | fn sequence_cut_condition_check( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/build_relations_fns.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | objects: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 9 - objects: &Vec, [INFO] [stdout] 9 + objects: &[Object], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/interaction_patterns.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 20 | | HashMap>, // divergent (sorted) [INFO] [stdout] 21 | | HashMap>, // convergent (sorted) [INFO] [stdout] 22 | | HashMap>, // related (sorted) [INFO] [stdout] ... | [INFO] [stdout] 25 | | Vec // set of all object types (sorted) [INFO] [stdout] 26 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/interaction_patterns.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | relations: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - relations: &Vec, [INFO] [stdout] 17 + relations: &[Relation], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/interaction_patterns.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | / event_object_type_sets [INFO] [stdout] 137 | | .get(*event_id) [INFO] [stdout] 138 | | .unwrap() [INFO] [stdout] 139 | | .get(otype) [INFO] [stdout] 140 | | .unwrap() [INFO] [stdout] 141 | | .len() > 0 [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 136 ~ !event_object_type_sets [INFO] [stdout] 137 + .get(*event_id) [INFO] [stdout] 138 + .unwrap() [INFO] [stdout] 139 + .get(otype) [INFO] [stdout] 140 + .unwrap().is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/divergence_free_dfg.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 14 | | HashMap<(String, String), usize>, [INFO] [stdout] 15 | | HashSet, [INFO] [stdout] 16 | | HashSet, [INFO] [stdout] 17 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/divergence_free_dfg.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 31 | let mut grouped_relations: HashMap> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/divergence_free_dfg.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:37:48 [INFO] [stdout] | [INFO] [stdout] 37 | let filtered_dfg = filter_keep_dfg(&dfg, &combined_activites); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:39:99 [INFO] [stdout] | [INFO] [stdout] 39 | ... let (filtered_start_activites,filtered_end_activites)=get_start_and_end_activities_v2(&dfg, &combined_activites, start_activit... [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:50:48 [INFO] [stdout] | [INFO] [stdout] 50 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:50:80 [INFO] [stdout] | [INFO] [stdout] 50 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:50:99 [INFO] [stdout] | [INFO] [stdout] 50 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:51:48 [INFO] [stdout] | [INFO] [stdout] 51 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:51:85 [INFO] [stdout] | [INFO] [stdout] 51 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:51:104 [INFO] [stdout] | [INFO] [stdout] 51 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:63:48 [INFO] [stdout] | [INFO] [stdout] 63 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:63:80 [INFO] [stdout] | [INFO] [stdout] 63 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:63:99 [INFO] [stdout] | [INFO] [stdout] 63 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:64:48 [INFO] [stdout] | [INFO] [stdout] 64 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:64:85 [INFO] [stdout] | [INFO] [stdout] 64 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:64:104 [INFO] [stdout] | [INFO] [stdout] 64 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:76:48 [INFO] [stdout] | [INFO] [stdout] 76 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:76:80 [INFO] [stdout] | [INFO] [stdout] 76 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:76:99 [INFO] [stdout] | [INFO] [stdout] 76 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:77:48 [INFO] [stdout] | [INFO] [stdout] 77 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:77:85 [INFO] [stdout] | [INFO] [stdout] 77 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:77:104 [INFO] [stdout] | [INFO] [stdout] 77 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:89:48 [INFO] [stdout] | [INFO] [stdout] 89 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:89:80 [INFO] [stdout] | [INFO] [stdout] 89 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:89:99 [INFO] [stdout] | [INFO] [stdout] 89 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:90:48 [INFO] [stdout] | [INFO] [stdout] 90 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:90:85 [INFO] [stdout] | [INFO] [stdout] 90 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:90:104 [INFO] [stdout] | [INFO] [stdout] 90 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | for ((from, to), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 124 - for ((from, to), _) in dfg { [INFO] [stdout] 124 + for (from, to) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts.rs:338:28 [INFO] [stdout] | [INFO] [stdout] 338 | for ((from, to), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 338 - for ((from, to), _) in dfg { [INFO] [stdout] 338 + for (from, to) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts.rs:368:24 [INFO] [stdout] | [INFO] [stdout] 368 | for ((a, b), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 368 - for ((a, b), _) in dfg { [INFO] [stdout] 368 + for (a, b) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | let filtered_dfg = filter_keep_dfg(&dfg, &all_activities); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:28:46 [INFO] [stdout] | [INFO] [stdout] 28 | let filtered_dfg = filter_keep_dfg(&dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:44 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:80 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:34:75 [INFO] [stdout] | [INFO] [stdout] 34 | let (excl_set1, excl_set2) = find_exclusive_choice_cut(&filtered_dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:57:57 [INFO] [stdout] | [INFO] [stdout] 57 | let (set1, set2) = find_sequence_cut(&filtered_dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:80:80 [INFO] [stdout] | [INFO] [stdout] 80 | let (is_parallel, para_set1, para_set2) = find_parallel_cut(&filtered_dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &all_activities, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/interaction_patterns.rs:19:6 [INFO] [stdout] | [INFO] [stdout] 19 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 20 | | HashMap>, // divergent (sorted) [INFO] [stdout] 21 | | HashMap>, // convergent (sorted) [INFO] [stdout] 22 | | HashMap>, // related (sorted) [INFO] [stdout] ... | [INFO] [stdout] 25 | | Vec // set of all object types (sorted) [INFO] [stdout] 26 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/interaction_patterns.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | relations: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 17 - relations: &Vec, [INFO] [stdout] 17 + relations: &[Relation], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts_opti.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 169 | for ((from, to), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 169 - for ((from, to), _) in dfg { [INFO] [stdout] 169 + for (from, to) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:255:46 [INFO] [stdout] | [INFO] [stdout] 255 | let sccs = strongly_connected_components(&dfg, &all_activities); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:255:52 [INFO] [stdout] | [INFO] [stdout] 255 | let sccs = strongly_connected_components(&dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:261:41 [INFO] [stdout] | [INFO] [stdout] 261 | let (dag, _) = build_scc_dag(&sccs, &dfg); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/start_cuts_opti.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 299 | / fn strongconnect( [INFO] [stdout] 300 | | node: &String, [INFO] [stdout] 301 | | graph: &HashMap>, [INFO] [stdout] 302 | | index: &mut usize, [INFO] [stdout] ... | [INFO] [stdout] 307 | | sccs: &mut Vec>, [INFO] [stdout] 308 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/interaction_patterns.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | / event_object_type_sets [INFO] [stdout] 137 | | .get(*event_id) [INFO] [stdout] 138 | | .unwrap() [INFO] [stdout] 139 | | .get(otype) [INFO] [stdout] 140 | | .unwrap() [INFO] [stdout] 141 | | .len() > 0 [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] help: using `!is_empty` is clearer and more explicit [INFO] [stdout] | [INFO] [stdout] 136 ~ !event_object_type_sets [INFO] [stdout] 137 + .get(*event_id) [INFO] [stdout] 138 + .unwrap() [INFO] [stdout] 139 + .get(otype) [INFO] [stdout] 140 + .unwrap().is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/start_cuts_opti.rs:366:11 [INFO] [stdout] | [INFO] [stdout] 366 | sccs: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 366 - sccs: &Vec>, [INFO] [stdout] 366 + sccs: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/divergence_free_dfg.rs:13:6 [INFO] [stdout] | [INFO] [stdout] 13 | ) -> ( [INFO] [stdout] | ______^ [INFO] [stdout] 14 | | HashMap<(String, String), usize>, [INFO] [stdout] 15 | | HashSet, [INFO] [stdout] 16 | | HashSet, [INFO] [stdout] 17 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/start_cuts_opti.rs:391:11 [INFO] [stdout] | [INFO] [stdout] 391 | sccs: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 391 - sccs: &Vec>, [INFO] [stdout] 391 + sccs: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/divergence_free_dfg.rs:31:32 [INFO] [stdout] | [INFO] [stdout] 31 | let mut grouped_relations: HashMap> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/divergence_free_dfg.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/start_cuts_opti.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | / if visited.insert(current) { [INFO] [stdout] 463 | | if let Some(neighbors) = dag.get(¤t) { [INFO] [stdout] 464 | | for &neighbor in neighbors { [INFO] [stdout] 465 | | stack.push(neighbor); [INFO] [stdout] ... | [INFO] [stdout] 468 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 462 ~ if visited.insert(current) [INFO] [stdout] 463 ~ && let Some(neighbors) = dag.get(¤t) { [INFO] [stdout] 464 | for &neighbor in neighbors { [INFO] [stdout] 465 | stack.push(neighbor); [INFO] [stdout] 466 | } [INFO] [stdout] 467 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/start_cuts_opti.rs:483:16 [INFO] [stdout] | [INFO] [stdout] 483 | if !(r1 && !r2) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `!r1 || r2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:37:48 [INFO] [stdout] | [INFO] [stdout] 37 | let filtered_dfg = filter_keep_dfg(&dfg, &combined_activites); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:39:99 [INFO] [stdout] | [INFO] [stdout] 39 | ... let (filtered_start_activites,filtered_end_activites)=get_start_and_end_activities_v2(&dfg, &combined_activites, start_activit... [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:50:48 [INFO] [stdout] | [INFO] [stdout] 50 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:50:80 [INFO] [stdout] | [INFO] [stdout] 50 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:50:99 [INFO] [stdout] | [INFO] [stdout] 50 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:51:48 [INFO] [stdout] | [INFO] [stdout] 51 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:51:85 [INFO] [stdout] | [INFO] [stdout] 51 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:51:104 [INFO] [stdout] | [INFO] [stdout] 51 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:63:48 [INFO] [stdout] | [INFO] [stdout] 63 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:63:80 [INFO] [stdout] | [INFO] [stdout] 63 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:63:99 [INFO] [stdout] | [INFO] [stdout] 63 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts_opti.rs:695:24 [INFO] [stdout] | [INFO] [stdout] 695 | for ((a, b), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 695 - for ((a, b), _) in dfg { [INFO] [stdout] 695 + for (a, b) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:64:48 [INFO] [stdout] | [INFO] [stdout] 64 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/start_cuts_opti.rs:747:13 [INFO] [stdout] | [INFO] [stdout] 747 | / if src == current { [INFO] [stdout] 748 | | if dfs(dst, target, end_activities, dfg, visited) { [INFO] [stdout] 749 | | return true; [INFO] [stdout] 750 | | } [INFO] [stdout] 751 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 747 ~ if src == current [INFO] [stdout] 748 ~ && dfs(dst, target, end_activities, dfg, visited) { [INFO] [stdout] 749 | return true; [INFO] [stdout] 750 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:31:46 [INFO] [stdout] | [INFO] [stdout] 31 | let file_content = stdfs::read_to_string(&file_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:64:85 [INFO] [stdout] | [INFO] [stdout] 64 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | remove_list: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 119 - remove_list: &Vec, [INFO] [stdout] 119 + remove_list: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:64:104 [INFO] [stdout] | [INFO] [stdout] 64 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | all_activities: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 130 - all_activities: &Vec, [INFO] [stdout] 130 + all_activities: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:76:48 [INFO] [stdout] | [INFO] [stdout] 76 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:131:18 [INFO] [stdout] | [INFO] [stdout] 131 | remove_list: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - remove_list: &Vec, [INFO] [stdout] 131 + remove_list: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:76:80 [INFO] [stdout] | [INFO] [stdout] 76 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:76:99 [INFO] [stdout] | [INFO] [stdout] 76 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:77:48 [INFO] [stdout] | [INFO] [stdout] 77 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:77:85 [INFO] [stdout] | [INFO] [stdout] 77 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:77:104 [INFO] [stdout] | [INFO] [stdout] 77 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:89:48 [INFO] [stdout] | [INFO] [stdout] 89 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:89:80 [INFO] [stdout] | [INFO] [stdout] 89 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:89:99 [INFO] [stdout] | [INFO] [stdout] 89 | node.children.extend(find_cuts(&dfg, &filtered_dfg, combo_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:90:48 [INFO] [stdout] | [INFO] [stdout] 90 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:90:85 [INFO] [stdout] | [INFO] [stdout] 90 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts.rs:90:104 [INFO] [stdout] | [INFO] [stdout] 90 | node.children.extend(find_cuts(&dfg, &filtered_dfg, complement_set, &start_activities, &end_activities)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | for ((from, to), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 124 - for ((from, to), _) in dfg { [INFO] [stdout] 124 + for (from, to) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts.rs:338:28 [INFO] [stdout] | [INFO] [stdout] 338 | for ((from, to), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 338 - for ((from, to), _) in dfg { [INFO] [stdout] 338 + for (from, to) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts.rs:368:24 [INFO] [stdout] | [INFO] [stdout] 368 | for ((a, b), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 368 - for ((a, b), _) in dfg { [INFO] [stdout] 368 + for (a, b) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | let filtered_dfg = filter_keep_dfg(&dfg, &all_activities); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:28:46 [INFO] [stdout] | [INFO] [stdout] 28 | let filtered_dfg = filter_keep_dfg(&dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:44 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:61 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `start_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:30:80 [INFO] [stdout] | [INFO] [stdout] 30 | get_start_and_end_activities(&dfg, &all_activities, &start_activities, &end_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `end_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:34:75 [INFO] [stdout] | [INFO] [stdout] 34 | let (excl_set1, excl_set2) = find_exclusive_choice_cut(&filtered_dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:57:57 [INFO] [stdout] | [INFO] [stdout] 57 | let (set1, set2) = find_sequence_cut(&filtered_dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:80:80 [INFO] [stdout] | [INFO] [stdout] 80 | let (is_parallel, para_set1, para_set2) = find_parallel_cut(&filtered_dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 92 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | &all_activities, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:130:13 [INFO] [stdout] | [INFO] [stdout] 130 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | &dfg, [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts_opti.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 169 | for ((from, to), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 169 - for ((from, to), _) in dfg { [INFO] [stdout] 169 + for (from, to) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:255:46 [INFO] [stdout] | [INFO] [stdout] 255 | let sccs = strongly_connected_components(&dfg, &all_activities); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:255:52 [INFO] [stdout] | [INFO] [stdout] 255 | let sccs = strongly_connected_components(&dfg, &all_activities); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `all_activities` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/start_cuts_opti.rs:261:41 [INFO] [stdout] | [INFO] [stdout] 261 | let (dag, _) = build_scc_dag(&sccs, &dfg); [INFO] [stdout] | ^^^^ help: change this to: `dfg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/start_cuts_opti.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 299 | / fn strongconnect( [INFO] [stdout] 300 | | node: &String, [INFO] [stdout] 301 | | graph: &HashMap>, [INFO] [stdout] 302 | | index: &mut usize, [INFO] [stdout] ... | [INFO] [stdout] 307 | | sccs: &mut Vec>, [INFO] [stdout] 308 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/start_cuts_opti.rs:366:11 [INFO] [stdout] | [INFO] [stdout] 366 | sccs: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 366 - sccs: &Vec>, [INFO] [stdout] 366 + sccs: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/start_cuts_opti.rs:391:11 [INFO] [stdout] | [INFO] [stdout] 391 | sccs: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 391 - sccs: &Vec>, [INFO] [stdout] 391 + sccs: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/start_cuts_opti.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 462 | / if visited.insert(current) { [INFO] [stdout] 463 | | if let Some(neighbors) = dag.get(¤t) { [INFO] [stdout] 464 | | for &neighbor in neighbors { [INFO] [stdout] 465 | | stack.push(neighbor); [INFO] [stdout] ... | [INFO] [stdout] 468 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 462 ~ if visited.insert(current) [INFO] [stdout] 463 ~ && let Some(neighbors) = dag.get(¤t) { [INFO] [stdout] 464 | for &neighbor in neighbors { [INFO] [stdout] 465 | stack.push(neighbor); [INFO] [stdout] 466 | } [INFO] [stdout] 467 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/start_cuts_opti.rs:483:16 [INFO] [stdout] | [INFO] [stdout] 483 | if !(r1 && !r2) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `!r1 || r2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/start_cuts_opti.rs:695:24 [INFO] [stdout] | [INFO] [stdout] 695 | for ((a, b), _) in dfg { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 695 - for ((a, b), _) in dfg { [INFO] [stdout] 695 + for (a, b) in dfg.keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/start_cuts_opti.rs:747:13 [INFO] [stdout] | [INFO] [stdout] 747 | / if src == current { [INFO] [stdout] 748 | | if dfs(dst, target, end_activities, dfg, visited) { [INFO] [stdout] 749 | | return true; [INFO] [stdout] 750 | | } [INFO] [stdout] 751 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 747 ~ if src == current [INFO] [stdout] 748 ~ && dfs(dst, target, end_activities, dfg, visited) { [INFO] [stdout] 749 | return true; [INFO] [stdout] 750 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:31:46 [INFO] [stdout] | [INFO] [stdout] 31 | let file_content = stdfs::read_to_string(&file_path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:119:18 [INFO] [stdout] | [INFO] [stdout] 119 | remove_list: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 119 - remove_list: &Vec, [INFO] [stdout] 119 + remove_list: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | all_activities: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 130 - all_activities: &Vec, [INFO] [stdout] 130 + all_activities: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:131:18 [INFO] [stdout] | [INFO] [stdout] 131 | remove_list: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 131 - remove_list: &Vec, [INFO] [stdout] 131 + remove_list: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.68s [INFO] running `Command { std: "docker" "inspect" "dafff8b5c6972a0b0e754e9efcee03fec7b2a5a7500030ffb095dfe5e6ee5c0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dafff8b5c6972a0b0e754e9efcee03fec7b2a5a7500030ffb095dfe5e6ee5c0f", kill_on_drop: false }` [INFO] [stdout] dafff8b5c6972a0b0e754e9efcee03fec7b2a5a7500030ffb095dfe5e6ee5c0f