[INFO] cloning repository https://github.com/siIverfish/apcsp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/siIverfish/apcsp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FsiIverfish%2Fapcsp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FsiIverfish%2Fapcsp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a6a4fc7ea85e1c5c4001b95a31797f1b9af328fd [INFO] linting siIverfish/apcsp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FsiIverfish%2Fapcsp" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/siIverfish/apcsp [INFO] finished tweaking git repo https://github.com/siIverfish/apcsp [INFO] tweaked toml for git repo https://github.com/siIverfish/apcsp written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/siIverfish/apcsp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/siIverfish/apcsp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc9fa226f914c48137bc7597ddb36a77489c5510403770d5288900f4c71c3dc9 [INFO] running `Command { std: "docker" "start" "-a" "fc9fa226f914c48137bc7597ddb36a77489c5510403770d5288900f4c71c3dc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc9fa226f914c48137bc7597ddb36a77489c5510403770d5288900f4c71c3dc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc9fa226f914c48137bc7597ddb36a77489c5510403770d5288900f4c71c3dc9", kill_on_drop: false }` [INFO] [stdout] fc9fa226f914c48137bc7597ddb36a77489c5510403770d5288900f4c71c3dc9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec982eb6324ac90a1513744143e64367af15c16ed62403ffc5a88cefbf2df476 [INFO] running `Command { std: "docker" "start" "-a" "ec982eb6324ac90a1513744143e64367af15c16ed62403ffc5a88cefbf2df476", kill_on_drop: false }` [INFO] [stderr] Checking apcsp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/values/mod.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | / /// Will call the closure on parents as well as children. [INFO] [stdout] 130 | | [INFO] [stdout] | |____^ [INFO] [stdout] 131 | // todo: less copying here [INFO] [stdout] 132 | fn apply_to_all(&self, func: &impl Fn(&Value) -> Value) -> Value { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `apply_to_all` then comment it out [INFO] [stdout] | [INFO] [stdout] 125 ~ // /// Always returns a `Vec::String`. [INFO] [stdout] 126 ~ // /// [INFO] [stdout] 127 ~ // /// Applies a closure to every subelement, starting with the most deeply nested. [INFO] [stdout] 128 ~ // /// [INFO] [stdout] 129 ~ // /// Will call the closure on parents as well as children. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/values/mod.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | / /// Will call the closure on parents as well as children. [INFO] [stdout] 130 | | [INFO] [stdout] | |____^ [INFO] [stdout] 131 | // todo: less copying here [INFO] [stdout] 132 | fn apply_to_all(&self, func: &impl Fn(&Value) -> Value) -> Value { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `apply_to_all` then comment it out [INFO] [stdout] | [INFO] [stdout] 125 ~ // /// Always returns a `Vec::String`. [INFO] [stdout] 126 ~ // /// [INFO] [stdout] 127 ~ // /// Applies a closure to every subelement, starting with the most deeply nested. [INFO] [stdout] 128 ~ // /// [INFO] [stdout] 129 ~ // /// Will call the closure on parents as well as children. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::ok_or` [INFO] [stdout] --> src/basics.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / Self::FROM_STRING_MAP [INFO] [stdout] 32 | | .into_iter() [INFO] [stdout] 33 | | .find(|map| [INFO] [stdout] 34 | | value.starts_with(map.0) && [INFO] [stdout] ... | [INFO] [stdout] 37 | | .map(|m| m.3) [INFO] [stdout] 38 | | .map_or(Err(()), Ok) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_or [INFO] [stdout] = note: `#[warn(clippy::manual_ok_or)]` on by default [INFO] [stdout] help: replace with [INFO] [stdout] | [INFO] [stdout] 31 ~ Self::FROM_STRING_MAP [INFO] [stdout] 32 + .into_iter() [INFO] [stdout] 33 + .find(|map| [INFO] [stdout] 34 + value.starts_with(map.0) && [INFO] [stdout] 35 + value.ends_with(map.2) [INFO] [stdout] 36 + ) [INFO] [stdout] 37 + .map(|m| m.3).ok_or(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/values/tidying.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | let value = parse_string_types(value); [INFO] [stdout] | -------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | [INFO] [stdout] 8 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 | [INFO] [stdout] 8 ~ parse_string_types(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/values/tidying.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | &Value::Group(ref values) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 14 - &Value::Group(ref values) => { [INFO] [stdout] 14 + Value::Group(values) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/values/lists.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|values| parse_tokenized_value(values)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_tokenized_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/values/mod.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 58 | let value = tidy(value); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 59 | [INFO] [stdout] 60 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 58 ~ [INFO] [stdout] 59 | [INFO] [stdout] 60 ~ tidy(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/values/mod.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 133 | func(&match self { [INFO] [stdout] | _______________^ [INFO] [stdout] 134 | | &Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] 135 | | Value::Operation { [INFO] [stdout] 136 | | operator: operator.clone(), [INFO] [stdout] ... | [INFO] [stdout] 166 | | _ => self.clone() [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 133 ~ func(&match *self { [INFO] [stdout] 134 ~ Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] 135 | Value::Operation { [INFO] [stdout] ... [INFO] [stdout] 144 | [INFO] [stdout] 145 ~ Value::Group(ref values) => { [INFO] [stdout] 146 | Value::Group( [INFO] [stdout] ... [INFO] [stdout] 154 | [INFO] [stdout] 155 ~ Value::ProcedureCall { ref name, ref args } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/values/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | &Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 134 - &Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] 134 + Value::Operation { args, operator, .. } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/values/mod.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | &Value::Group(ref values) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 145 - &Value::Group(ref values) => { [INFO] [stdout] 145 + Value::Group(values) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/values/mod.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | &Value::ProcedureCall { ref name, ref args } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 155 - &Value::ProcedureCall { ref name, ref args } => { [INFO] [stdout] 155 + Value::ProcedureCall { name, args } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/values/mod.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | while !chars.peek().is_some_and(|c| c == &'"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars.peek().is_none_or(|c| c != &'"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::ok_or` [INFO] [stdout] --> src/basics.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / Self::FROM_STRING_MAP [INFO] [stdout] 32 | | .into_iter() [INFO] [stdout] 33 | | .find(|map| [INFO] [stdout] 34 | | value.starts_with(map.0) && [INFO] [stdout] ... | [INFO] [stdout] 37 | | .map(|m| m.3) [INFO] [stdout] 38 | | .map_or(Err(()), Ok) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_or [INFO] [stdout] = note: `#[warn(clippy::manual_ok_or)]` on by default [INFO] [stdout] help: replace with [INFO] [stdout] | [INFO] [stdout] 31 ~ Self::FROM_STRING_MAP [INFO] [stdout] 32 + .into_iter() [INFO] [stdout] 33 + .find(|map| [INFO] [stdout] 34 + value.starts_with(map.0) && [INFO] [stdout] 35 + value.ends_with(map.2) [INFO] [stdout] 36 + ) [INFO] [stdout] 37 + .map(|m| m.3).ok_or(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/values/tidying.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 6 | let value = parse_string_types(value); [INFO] [stdout] | -------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | [INFO] [stdout] 8 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 | [INFO] [stdout] 8 ~ parse_string_types(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/values/tidying.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | &Value::Group(ref values) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 14 - &Value::Group(ref values) => { [INFO] [stdout] 14 + Value::Group(values) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/values/lists.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | .map(|values| parse_tokenized_value(values)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_tokenized_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/values/mod.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 58 | let value = tidy(value); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 59 | [INFO] [stdout] 60 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 58 ~ [INFO] [stdout] 59 | [INFO] [stdout] 60 ~ tidy(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/values/mod.rs:133:15 [INFO] [stdout] | [INFO] [stdout] 133 | func(&match self { [INFO] [stdout] | _______________^ [INFO] [stdout] 134 | | &Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] 135 | | Value::Operation { [INFO] [stdout] 136 | | operator: operator.clone(), [INFO] [stdout] ... | [INFO] [stdout] 166 | | _ => self.clone() [INFO] [stdout] 167 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 133 ~ func(&match *self { [INFO] [stdout] 134 ~ Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] 135 | Value::Operation { [INFO] [stdout] ... [INFO] [stdout] 144 | [INFO] [stdout] 145 ~ Value::Group(ref values) => { [INFO] [stdout] 146 | Value::Group( [INFO] [stdout] ... [INFO] [stdout] 154 | [INFO] [stdout] 155 ~ Value::ProcedureCall { ref name, ref args } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/values/mod.rs:134:13 [INFO] [stdout] | [INFO] [stdout] 134 | &Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 134 - &Value::Operation { ref args, ref operator, .. } => { [INFO] [stdout] 134 + Value::Operation { args, operator, .. } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/values/mod.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | &Value::Group(ref values) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 145 - &Value::Group(ref values) => { [INFO] [stdout] 145 + Value::Group(values) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/values/mod.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | &Value::ProcedureCall { ref name, ref args } => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 155 - &Value::ProcedureCall { ref name, ref args } => { [INFO] [stdout] 155 + Value::ProcedureCall { name, args } => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/values/mod.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | while !chars.peek().is_some_and(|c| c == &'"') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars.peek().is_none_or(|c| c != &'"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `Command { std: "docker" "inspect" "ec982eb6324ac90a1513744143e64367af15c16ed62403ffc5a88cefbf2df476", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec982eb6324ac90a1513744143e64367af15c16ed62403ffc5a88cefbf2df476", kill_on_drop: false }` [INFO] [stdout] ec982eb6324ac90a1513744143e64367af15c16ed62403ffc5a88cefbf2df476