[INFO] cloning repository https://github.com/shimekukuri/backup_v0 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/shimekukuri/backup_v0" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshimekukuri%2Fbackup_v0", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshimekukuri%2Fbackup_v0'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ddbb246bdae843961aa28ef6d27d4c99ef8f4589 [INFO] linting shimekukuri/backup_v0 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshimekukuri%2Fbackup_v0" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/shimekukuri/backup_v0 [INFO] finished tweaking git repo https://github.com/shimekukuri/backup_v0 [INFO] tweaked toml for git repo https://github.com/shimekukuri/backup_v0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/shimekukuri/backup_v0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/shimekukuri/backup_v0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libc v0.2.148 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24549048649e3dfdda60d10171207ee8e6ca5f2c40611e775810a23f2d3b337d [INFO] running `Command { std: "docker" "start" "-a" "24549048649e3dfdda60d10171207ee8e6ca5f2c40611e775810a23f2d3b337d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24549048649e3dfdda60d10171207ee8e6ca5f2c40611e775810a23f2d3b337d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24549048649e3dfdda60d10171207ee8e6ca5f2c40611e775810a23f2d3b337d", kill_on_drop: false }` [INFO] [stdout] 24549048649e3dfdda60d10171207ee8e6ca5f2c40611e775810a23f2d3b337d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7eb40528d004c54f50d2333c29fe02f98aae48896d109fdca0d82c2bbf75418c [INFO] running `Command { std: "docker" "start" "-a" "7eb40528d004c54f50d2333c29fe02f98aae48896d109fdca0d82c2bbf75418c", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking backup_v0 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `PathBuf` and `Path` [INFO] [stdout] --> src/modules/io/fs/mod.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | path::{Path, PathBuf}, [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `modules::hash` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use modules::hash; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PathBuf` and `Path` [INFO] [stdout] --> src/modules/io/fs/mod.rs:7:12 [INFO] [stdout] | [INFO] [stdout] 7 | path::{Path, PathBuf}, [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::Scope` [INFO] [stdout] --> src/modules/io/fs/mod.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | use rayon::Scope; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `modules::hash` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use modules::hash; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path` [INFO] [stdout] --> src/modules/io/fs/mod.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn scan_tree(path: &std::path::Path, handle_file: F) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/modules/io/fs/mod.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `hash_file` is never used [INFO] [stdout] --> src/modules/hash/mod.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn hash_file() {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `scan_tree` is never used [INFO] [stdout] --> src/modules/io/fs/mod.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn scan_tree(path: &std::path::Path, handle_file: F) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_into_queue` is never used [INFO] [stdout] --> src/modules/io/fs/mod.rs:43:4 [INFO] [stdout] | [INFO] [stdout] 43 | fn read_into_queue(path: &std::path::Path, queue: &mut VecDeque) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `send_file_to_server` is never used [INFO] [stdout] --> src/modules/io/fs/mod.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn send_file_to_server( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parrallel_tcp` is never used [INFO] [stdout] --> src/modules/io/fs/mod.rs:89:4 [INFO] [stdout] | [INFO] [stdout] 89 | fn parrallel_tcp(file_paths: &Vec) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using a reference to `Cow` is not recommended [INFO] [stdout] --> src/modules/Logging/mod.rs:11:30 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn set(&mut self, k: &Cow<'_, str>, v: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/modules/Logging/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | let logger = ErrorLog { map: error_map }; [INFO] [stdout] | ----------------------------------------- unnecessary `let` binding [INFO] [stdout] 19 | logger [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 ~ ErrorLog { map: error_map } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/modules/io/fs/mod.rs:14:33 [INFO] [stdout] | [INFO] [stdout] 14 | let metadata = fs::metadata(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/modules/io/fs/mod.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | F: Fn(DirEntry) -> (), [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/io/fs/mod.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 33 | while queue.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/modules/io/fs/mod.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | &queue.push_back(x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `queue.push_back(x);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/modules/io/fs/mod.rs:99:62 [INFO] [stdout] | [INFO] [stdout] 99 | println!("File {} sent to server successfully.", "m"); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 - println!("File {} sent to server successfully.", "m"); [INFO] [stdout] 99 + println!("File m sent to server successfully."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | match get_metadata(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: path statement with no effect [INFO] [stdout] --> src/main.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | x; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(path_statements)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Logging` should have a snake case name [INFO] [stdout] --> src/modules/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod Logging; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `logging` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/modules/io/fs/mod.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | &queue.push_back(x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = &queue.push_back(x); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/modules/Logging/mod.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 54 | ErrorLog => Ok(()), [INFO] [stdout] | -------- matches any value [INFO] [stdout] 55 | _ => Err("MEEP"), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ErrorLog` [INFO] [stdout] --> src/modules/Logging/mod.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | ErrorLog => Ok(()), [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_ErrorLog` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `path` [INFO] [stdout] --> src/modules/io/fs/mod.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn scan_tree(path: &std::path::Path, handle_file: F) [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_path` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/modules/io/fs/mod.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/modules/io/fs/mod.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | Err(e) => (), [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modules/io/fs/mod.rs:159:17 [INFO] [stdout] | [INFO] [stdout] 159 | for mut stream in listener.incoming() { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `hash_file` is never used [INFO] [stdout] --> src/modules/hash/mod.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn hash_file() {} [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using a reference to `Cow` is not recommended [INFO] [stdout] --> src/modules/Logging/mod.rs:11:30 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn set(&mut self, k: &Cow<'_, str>, v: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/modules/Logging/mod.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | let logger = ErrorLog { map: error_map }; [INFO] [stdout] | ----------------------------------------- unnecessary `let` binding [INFO] [stdout] 19 | logger [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 18 ~ [INFO] [stdout] 19 ~ ErrorLog { map: error_map } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/modules/io/fs/mod.rs:14:33 [INFO] [stdout] | [INFO] [stdout] 14 | let metadata = fs::metadata(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/modules/io/fs/mod.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | F: Fn(DirEntry) -> (), [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/modules/io/fs/mod.rs:33:11 [INFO] [stdout] | [INFO] [stdout] 33 | while queue.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> src/modules/io/fs/mod.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | &queue.push_back(x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `queue.push_back(x);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/modules/io/fs/mod.rs:99:62 [INFO] [stdout] | [INFO] [stdout] 99 | println!("File {} sent to server successfully.", "m"); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 - println!("File {} sent to server successfully.", "m"); [INFO] [stdout] 99 + println!("File m sent to server successfully."); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/io/fs/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if !fs::metadata(&directory_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&directory_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/modules/io/fs/mod.rs:146:26 [INFO] [stdout] | [INFO] [stdout] 146 | if !fs::metadata(&directory_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `directory_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/modules/io/fs/mod.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | if let Err(err) = fs::create_dir(&directory_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `directory_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `extend` instead of `append` for adding the full range of a second vector [INFO] [stdout] --> src/modules/io/fs/mod.rs:187:21 [INFO] [stdout] | [INFO] [stdout] 187 | vecb.extend(v.drain(..)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vecb.append(&mut v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extend_with_drain [INFO] [stdout] = note: `#[warn(clippy::extend_with_drain)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/modules/io/fs/mod.rs:188:21 [INFO] [stdout] | [INFO] [stdout] 188 | let _ = parrallel_tcp(&vecb).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 188 - let _ = parrallel_tcp(&vecb).unwrap(); [INFO] [stdout] 188 + parrallel_tcp(&vecb).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | match get_metadata(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: path statement with no effect [INFO] [stdout] --> src/main.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | x; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(path_statements)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `Logging` should have a snake case name [INFO] [stdout] --> src/modules/mod.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod Logging; [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `logging` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `ErrorLog` should have a snake case name [INFO] [stdout] --> src/modules/Logging/mod.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | ErrorLog => Ok(()), [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `error_log` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/modules/io/fs/mod.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | &queue.push_back(x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = &queue.push_back(x); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.54s [INFO] running `Command { std: "docker" "inspect" "7eb40528d004c54f50d2333c29fe02f98aae48896d109fdca0d82c2bbf75418c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7eb40528d004c54f50d2333c29fe02f98aae48896d109fdca0d82c2bbf75418c", kill_on_drop: false }` [INFO] [stdout] 7eb40528d004c54f50d2333c29fe02f98aae48896d109fdca0d82c2bbf75418c