[INFO] cloning repository https://github.com/shilei-massclouds/f_a [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/shilei-massclouds/f_a" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshilei-massclouds%2Ff_a", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshilei-massclouds%2Ff_a'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4c7df2b960ae63d02dd947ed4e403b815613ddde [INFO] linting shilei-massclouds/f_a against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshilei-massclouds%2Ff_a" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/shilei-massclouds/f_a [INFO] finished tweaking git repo https://github.com/shilei-massclouds/f_a [INFO] tweaked toml for git repo https://github.com/shilei-massclouds/f_a written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/shilei-massclouds/f_a on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/shilei-massclouds/f_a already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syscalls v0.6.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] acfd2defa897461cc72a930d275ebab0ca7569e64b8ed276e8efc45b3d20bb77 [INFO] running `Command { std: "docker" "start" "-a" "acfd2defa897461cc72a930d275ebab0ca7569e64b8ed276e8efc45b3d20bb77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "acfd2defa897461cc72a930d275ebab0ca7569e64b8ed276e8efc45b3d20bb77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acfd2defa897461cc72a930d275ebab0ca7569e64b8ed276e8efc45b3d20bb77", kill_on_drop: false }` [INFO] [stdout] acfd2defa897461cc72a930d275ebab0ca7569e64b8ed276e8efc45b3d20bb77 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f94796eeaab27f5617404ce7cebacf05cfee71b30525f218325e10568f1684bd [INFO] running `Command { std: "docker" "start" "-a" "f94796eeaab27f5617404ce7cebacf05cfee71b30525f218325e10568f1684bd", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking abi v0.1.0 (/opt/rustwide/workdir/abi) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> abi/src/main.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | Two(usize), [INFO] [stdout] | --- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EnumNumber` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 47 - Two(usize), [INFO] [stdout] 47 + Two(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> abi/src/main.rs:48:11 [INFO] [stdout] | [INFO] [stdout] 48 | Three(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EnumNumber` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 48 - Three(String), [INFO] [stdout] 48 + Three(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> abi/src/main.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | assert!(!layout.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `layout.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> abi/src/main.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | Two(usize), [INFO] [stdout] | --- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EnumNumber` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 47 - Two(usize), [INFO] [stdout] 47 + Two(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> abi/src/main.rs:48:11 [INFO] [stdout] | [INFO] [stdout] 48 | Three(String), [INFO] [stdout] | ----- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EnumNumber` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 48 - Three(String), [INFO] [stdout] 48 + Three(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> abi/src/main.rs:226:17 [INFO] [stdout] | [INFO] [stdout] 226 | assert!(!layout.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `layout.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling syscalls v0.6.13 [INFO] [stderr] Checking sys v0.1.0 (/opt/rustwide/workdir/sys) [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | let ptr = &(*val) as *const _; [INFO] [stdout] | ^^^^^^^ help: if you would like to reborrow, try removing `&*`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 61 | let ptr = &(*layout) as *const _; [INFO] [stdout] | ^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | let ptr = &(*s) as *const _; [INFO] [stdout] | ^^^^^ help: if you would like to reborrow, try removing `&*`: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | let ptr = &(*v) as *const _; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 85 - let ptr = &(*v) as *const _; [INFO] [stdout] 85 + let ptr = v as *const _; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 85 - let ptr = &(*v) as *const _; [INFO] [stdout] 85 + let ptr = &**v as *const _; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:108:15 [INFO] [stdout] | [INFO] [stdout] 108 | let ptr = &(*n) as *const _; [INFO] [stdout] | ^^^^^ help: if you would like to reborrow, try removing `&*`: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> sys/src/lib.rs:171:55 [INFO] [stdout] | [INFO] [stdout] 171 | println!("[callee]: ret {:?}; vec.buf {:?}", ptr, (&v).as_ptr()); [INFO] [stdout] | ^^^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used a field initializer for a tuple struct [INFO] [stdout] --> sys/src/lib.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | Self { 0: n } [INFO] [stdout] | ^^^^^^^^^^^^^ help: use tuple initialization: `Self(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields [INFO] [stdout] = note: `#[warn(clippy::init_numbered_fields)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> sys/src/lib.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | let buf_ptr = (&v).as_ptr(); [INFO] [stdout] | ^^^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | let ptr = &(*val) as *const _; [INFO] [stdout] | ^^^^^^^ help: if you would like to reborrow, try removing `&*`: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 61 | let ptr = &(*layout) as *const _; [INFO] [stdout] | ^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | let ptr = &(*s) as *const _; [INFO] [stdout] | ^^^^^ help: if you would like to reborrow, try removing `&*`: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | let ptr = &(*v) as *const _; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 85 - let ptr = &(*v) as *const _; [INFO] [stdout] 85 + let ptr = v as *const _; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 85 - let ptr = &(*v) as *const _; [INFO] [stdout] 85 + let ptr = &**v as *const _; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> sys/src/lib.rs:108:15 [INFO] [stdout] | [INFO] [stdout] 108 | let ptr = &(*n) as *const _; [INFO] [stdout] | ^^^^^ help: if you would like to reborrow, try removing `&*`: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> sys/src/lib.rs:171:55 [INFO] [stdout] | [INFO] [stdout] 171 | println!("[callee]: ret {:?}; vec.buf {:?}", ptr, (&v).as_ptr()); [INFO] [stdout] | ^^^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used a field initializer for a tuple struct [INFO] [stdout] --> sys/src/lib.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | Self { 0: n } [INFO] [stdout] | ^^^^^^^^^^^^^ help: use tuple initialization: `Self(n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#init_numbered_fields [INFO] [stdout] = note: `#[warn(clippy::init_numbered_fields)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> sys/src/lib.rs:208:19 [INFO] [stdout] | [INFO] [stdout] 208 | let buf_ptr = (&v).as_ptr(); [INFO] [stdout] | ^^^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking func v0.1.0 (/opt/rustwide/workdir/func) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> func/src/main.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(!layout.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `layout.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> func/src/main.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(!layout.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `layout.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `Command { std: "docker" "inspect" "f94796eeaab27f5617404ce7cebacf05cfee71b30525f218325e10568f1684bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f94796eeaab27f5617404ce7cebacf05cfee71b30525f218325e10568f1684bd", kill_on_drop: false }` [INFO] [stdout] f94796eeaab27f5617404ce7cebacf05cfee71b30525f218325e10568f1684bd