[INFO] cloning repository https://github.com/sheosi/to_appimage [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sheosi/to_appimage" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsheosi%2Fto_appimage", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsheosi%2Fto_appimage'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d61e411ba7f63fbdcbea6a02136f81804491f6e [INFO] linting sheosi/to_appimage/6d61e411ba7f63fbdcbea6a02136f81804491f6e against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsheosi%2Fto_appimage" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/sheosi/to_appimage [INFO] finished tweaking git repo https://github.com/sheosi/to_appimage [INFO] tweaked toml for git repo https://github.com/sheosi/to_appimage written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sheosi/to_appimage on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sheosi/to_appimage already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded which v7.0.1 [INFO] [stderr] Downloaded thiserror-impl v2.0.11 [INFO] [stderr] Downloaded thiserror v2.0.11 [INFO] [stderr] Downloaded env_home v0.1.0 [INFO] [stderr] Downloaded redox_users v0.5.0 [INFO] [stderr] Downloaded path-utils v0.1.0 [INFO] [stderr] Downloaded ravif v0.11.11 [INFO] [stderr] Downloaded lebe v0.5.2 [INFO] [stderr] Downloaded version-compare v0.2.0 [INFO] [stderr] Downloaded libredox v0.0.1 [INFO] [stderr] Downloaded redox_users v0.4.4 [INFO] [stderr] Downloaded bit_field v0.10.2 [INFO] [stderr] Downloaded dirs v2.0.2 [INFO] [stderr] Downloaded profiling-procmacros v1.0.16 [INFO] [stderr] Downloaded serde_spanned v0.6.8 [INFO] [stderr] Downloaded rgb v0.8.50 [INFO] [stderr] Downloaded clap_derive v4.5.18 [INFO] [stderr] Downloaded av1-grain v0.2.3 [INFO] [stderr] Downloaded clap v4.5.18 [INFO] [stderr] Downloaded rustversion v1.0.19 [INFO] [stderr] Downloaded imgref v1.11.0 [INFO] [stderr] Downloaded cc v1.2.10 [INFO] [stderr] Downloaded libfuzzer-sys v0.4.8 [INFO] [stderr] Downloaded flate2 v1.0.35 [INFO] [stderr] Downloaded clap_builder v4.5.18 [INFO] [stderr] Downloaded winnow v0.6.24 [INFO] [stderr] Downloaded quick-xml v0.37.2 [INFO] [stderr] Downloaded indexmap v2.2.2 [INFO] [stderr] Downloaded serde v1.0.196 [INFO] [stderr] Downloaded image v0.25.5 [INFO] [stderr] Downloaded syn v2.0.96 [INFO] [stderr] Downloaded unsafe-libyaml v0.2.10 [INFO] [stderr] Downloaded zune-jpeg v0.4.14 [INFO] [stderr] Downloaded serde_derive v1.0.196 [INFO] [stderr] Downloaded rustix v0.38.30 [INFO] [stderr] Downloaded serde_yaml v0.9.31 [INFO] [stderr] Downloaded half v2.4.1 [INFO] [stderr] Downloaded image-webp v0.2.1 [INFO] [stderr] Downloaded winsafe v0.0.19 [INFO] [stderr] Downloaded bytemuck v1.21.0 [INFO] [stderr] Downloaded anyhow v1.0.95 [INFO] [stderr] Downloaded miniz_oxide v0.8.3 [INFO] [stderr] Downloaded arbitrary v1.4.1 [INFO] [stderr] Downloaded thiserror v1.0.56 [INFO] [stderr] Downloaded log v0.4.25 [INFO] [stderr] Downloaded weezl v0.1.8 [INFO] [stderr] Downloaded rpassword v2.1.0 [INFO] [stderr] Downloaded gif v0.13.1 [INFO] [stderr] Downloaded avif-serialize v0.8.2 [INFO] [stderr] Downloaded built v0.7.5 [INFO] [stderr] Downloaded regex-automata v0.4.5 [INFO] [stderr] Downloaded pkg-config v0.3.31 [INFO] [stderr] Downloaded proc-macro2 v1.0.93 [INFO] [stderr] Downloaded thiserror-impl v1.0.56 [INFO] [stderr] Downloaded jpeg-decoder v0.3.1 [INFO] [stderr] Downloaded libc v0.2.152 [INFO] [stderr] Downloaded aligned-vec v0.5.0 [INFO] [stderr] Downloaded dialog v0.3.0 [INFO] [stderr] Downloaded v_frame v0.3.8 [INFO] [stderr] Downloaded tiff v0.9.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7e47bdcc85d6b4d2d3761830a3aba1558828676e4a5002160e254c4c65e78e4 [INFO] running `Command { std: "docker" "start" "-a" "f7e47bdcc85d6b4d2d3761830a3aba1558828676e4a5002160e254c4c65e78e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7e47bdcc85d6b4d2d3761830a3aba1558828676e4a5002160e254c4c65e78e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7e47bdcc85d6b4d2d3761830a3aba1558828676e4a5002160e254c4c65e78e4", kill_on_drop: false }` [INFO] [stdout] f7e47bdcc85d6b4d2d3761830a3aba1558828676e4a5002160e254c4c65e78e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c76b0136359e70b5aeadb1475d96636ddf82ce68af4d86c76d4547b295c73bfb [INFO] running `Command { std: "docker" "start" "-a" "c76b0136359e70b5aeadb1475d96636ddf82ce68af4d86c76d4547b295c73bfb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling anyhow v1.0.95 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling built v0.7.5 [INFO] [stderr] Checking miniz_oxide v0.8.3 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking log v0.4.25 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking imgref v1.11.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking bitstream-io v2.6.0 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking avif-serialize v0.8.2 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling thiserror v2.0.11 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking bytemuck v1.21.0 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking zune-jpeg v0.4.14 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking indexmap v2.2.2 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking image-webp v0.2.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking rpassword v2.1.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking which v7.0.1 [INFO] [stderr] Checking dialog v0.3.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking path-utils v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling profiling-procmacros v1.0.16 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Compiling thiserror-impl v2.0.11 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking serde_yaml v0.9.31 [INFO] [stderr] Checking quick-xml v0.37.2 [INFO] [stderr] Checking ravif v0.11.11 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking to_appimage v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `resize_img` is never used [INFO] [stdout] --> src/main.rs:272:4 [INFO] [stdout] | [INFO] [stdout] 272 | fn resize_img(input: &Path, output: &Path) -> image::ImageResult<()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:80:6 [INFO] [stdout] | [INFO] [stdout] 80 | impl<'a> ser::Serializer for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 80 - impl<'a> ser::Serializer for &'a mut Serializer { [INFO] [stdout] 80 + impl ser::Serializer for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:341:6 [INFO] [stdout] | [INFO] [stdout] 341 | impl<'a> ser::SerializeSeq for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 341 - impl<'a> ser::SerializeSeq for &'a mut Serializer { [INFO] [stdout] 341 + impl ser::SerializeSeq for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:367:6 [INFO] [stdout] | [INFO] [stdout] 367 | impl<'a> ser::SerializeTuple for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 367 - impl<'a> ser::SerializeTuple for &'a mut Serializer { [INFO] [stdout] 367 + impl ser::SerializeTuple for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:388:6 [INFO] [stdout] | [INFO] [stdout] 388 | impl<'a> ser::SerializeTupleStruct for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 388 - impl<'a> ser::SerializeTupleStruct for &'a mut Serializer { [INFO] [stdout] 388 + impl ser::SerializeTupleStruct for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 417 | impl<'a> ser::SerializeTupleVariant for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 417 - impl<'a> ser::SerializeTupleVariant for &'a mut Serializer { [INFO] [stdout] 417 + impl ser::SerializeTupleVariant for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:445:6 [INFO] [stdout] | [INFO] [stdout] 445 | impl<'a> ser::SerializeMap for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 445 - impl<'a> ser::SerializeMap for &'a mut Serializer { [INFO] [stdout] 445 + impl ser::SerializeMap for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:504:6 [INFO] [stdout] | [INFO] [stdout] 504 | impl<'a> ser::SerializeStruct for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 504 - impl<'a> ser::SerializeStruct for &'a mut Serializer { [INFO] [stdout] 504 + impl ser::SerializeStruct for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:542:6 [INFO] [stdout] | [INFO] [stdout] 542 | impl<'a> ser::SerializeStructVariant for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 542 - impl<'a> ser::SerializeStructVariant for &'a mut Serializer { [INFO] [stdout] 542 + impl ser::SerializeStructVariant for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/licensing.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | UniversalPermisiveLicense, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/licensing.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | fn is_license(p: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn is_license(p: &PathBuf) -> bool { [INFO] [stdout] 32 + fn is_license(p: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual case-insensitive ASCII comparison [INFO] [stdout] --> src/licensing.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | p.is_file() && p.file_name().unwrap_or_default().to_ascii_lowercase() == "license" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ignore_case_cmp [INFO] [stdout] = note: `#[warn(clippy::manual_ignore_case_cmp)]` on by default [INFO] [stdout] help: consider using `.eq_ignore_ascii_case()` instead [INFO] [stdout] | [INFO] [stdout] 33 - p.is_file() && p.file_name().unwrap_or_default().to_ascii_lowercase() == "license" [INFO] [stdout] 33 + p.is_file() && p.file_name().unwrap_or_default().eq_ignore_ascii_case("license") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/licensing.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | let file = std::fs::read_dir(path) [INFO] [stdout] | ____________________^ [INFO] [stdout] 37 | | .unwrap() [INFO] [stdout] 38 | | .flatten() [INFO] [stdout] 39 | | .map(|d| d.path()) [INFO] [stdout] 40 | | .filter(is_license) [INFO] [stdout] 41 | | .next(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ let file = std::fs::read_dir(path) [INFO] [stdout] 37 + .unwrap() [INFO] [stdout] 38 + .flatten() [INFO] [stdout] 39 ~ .map(|d| d.path()).find(is_license); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:467:29 [INFO] [stdout] | [INFO] [stdout] 467 | "aarch64"=> &self.arch64, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.arch64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:468:29 [INFO] [stdout] | [INFO] [stdout] 468 | "x86_64" => &self.x86_64, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.x86_64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: written amount is not handled [INFO] [stdout] --> src/main.rs:615:21 [INFO] [stdout] | [INFO] [stdout] 615 | ... File::create(actual_input.join("AppIcon.svg")).expect("This should be possible").write(DEFAULT_ICON).expect("Failed to write icon"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use `Write::write_all` instead, or handle partial writes [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stdout] = note: `#[deny(clippy::unused_io_amount)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:642:43 [INFO] [stdout] | [INFO] [stdout] 642 | fn filename_len(path: &PathBuf) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 642 - fn filename_len(path: &PathBuf) -> usize { [INFO] [stdout] 642 + fn filename_len(path: &Path) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:647:21 [INFO] [stdout] | [INFO] [stdout] 647 | exes.sort_by(|a,b |filename_len(a).cmp(&filename_len(b))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 647 - exes.sort_by(|a,b |filename_len(a).cmp(&filename_len(b))); [INFO] [stdout] 647 + exes.sort_by_key(|a| filename_len(a)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `to_appimage` (bin "to_appimage" test) due to 1 previous error; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `resize_img` is never used [INFO] [stdout] --> src/main.rs:272:4 [INFO] [stdout] | [INFO] [stdout] 272 | fn resize_img(input: &Path, output: &Path) -> image::ImageResult<()> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:80:6 [INFO] [stdout] | [INFO] [stdout] 80 | impl<'a> ser::Serializer for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 80 - impl<'a> ser::Serializer for &'a mut Serializer { [INFO] [stdout] 80 + impl ser::Serializer for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:341:6 [INFO] [stdout] | [INFO] [stdout] 341 | impl<'a> ser::SerializeSeq for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 341 - impl<'a> ser::SerializeSeq for &'a mut Serializer { [INFO] [stdout] 341 + impl ser::SerializeSeq for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:367:6 [INFO] [stdout] | [INFO] [stdout] 367 | impl<'a> ser::SerializeTuple for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 367 - impl<'a> ser::SerializeTuple for &'a mut Serializer { [INFO] [stdout] 367 + impl ser::SerializeTuple for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:388:6 [INFO] [stdout] | [INFO] [stdout] 388 | impl<'a> ser::SerializeTupleStruct for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 388 - impl<'a> ser::SerializeTupleStruct for &'a mut Serializer { [INFO] [stdout] 388 + impl ser::SerializeTupleStruct for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 417 | impl<'a> ser::SerializeTupleVariant for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 417 - impl<'a> ser::SerializeTupleVariant for &'a mut Serializer { [INFO] [stdout] 417 + impl ser::SerializeTupleVariant for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:445:6 [INFO] [stdout] | [INFO] [stdout] 445 | impl<'a> ser::SerializeMap for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 445 - impl<'a> ser::SerializeMap for &'a mut Serializer { [INFO] [stdout] 445 + impl ser::SerializeMap for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:504:6 [INFO] [stdout] | [INFO] [stdout] 504 | impl<'a> ser::SerializeStruct for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 504 - impl<'a> ser::SerializeStruct for &'a mut Serializer { [INFO] [stdout] 504 + impl ser::SerializeStruct for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/desktop_entry/mod.rs:542:6 [INFO] [stdout] | [INFO] [stdout] 542 | impl<'a> ser::SerializeStructVariant for &'a mut Serializer { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 542 - impl<'a> ser::SerializeStructVariant for &'a mut Serializer { [INFO] [stdout] 542 + impl ser::SerializeStructVariant for &mut Serializer { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/licensing.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | UniversalPermisiveLicense, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/licensing.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | fn is_license(p: &PathBuf) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn is_license(p: &PathBuf) -> bool { [INFO] [stdout] 32 + fn is_license(p: &Path) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual case-insensitive ASCII comparison [INFO] [stdout] --> src/licensing.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | p.is_file() && p.file_name().unwrap_or_default().to_ascii_lowercase() == "license" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ignore_case_cmp [INFO] [stdout] = note: `#[warn(clippy::manual_ignore_case_cmp)]` on by default [INFO] [stdout] help: consider using `.eq_ignore_ascii_case()` instead [INFO] [stdout] | [INFO] [stdout] 33 - p.is_file() && p.file_name().unwrap_or_default().to_ascii_lowercase() == "license" [INFO] [stdout] 33 + p.is_file() && p.file_name().unwrap_or_default().eq_ignore_ascii_case("license") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/licensing.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | let file = std::fs::read_dir(path) [INFO] [stdout] | ____________________^ [INFO] [stdout] 37 | | .unwrap() [INFO] [stdout] 38 | | .flatten() [INFO] [stdout] 39 | | .map(|d| d.path()) [INFO] [stdout] 40 | | .filter(is_license) [INFO] [stdout] 41 | | .next(); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ let file = std::fs::read_dir(path) [INFO] [stdout] 37 + .unwrap() [INFO] [stdout] 38 + .flatten() [INFO] [stdout] 39 ~ .map(|d| d.path()).find(is_license); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:467:29 [INFO] [stdout] | [INFO] [stdout] 467 | "aarch64"=> &self.arch64, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.arch64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:468:29 [INFO] [stdout] | [INFO] [stdout] 468 | "x86_64" => &self.x86_64, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.x86_64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: written amount is not handled [INFO] [stdout] --> src/main.rs:615:21 [INFO] [stdout] | [INFO] [stdout] 615 | ... File::create(actual_input.join("AppIcon.svg")).expect("This should be possible").write(DEFAULT_ICON).expect("Failed to write icon"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use `Write::write_all` instead, or handle partial writes [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stdout] = note: `#[deny(clippy::unused_io_amount)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:642:43 [INFO] [stdout] | [INFO] [stdout] 642 | fn filename_len(path: &PathBuf) -> usize { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 642 - fn filename_len(path: &PathBuf) -> usize { [INFO] [stdout] 642 + fn filename_len(path: &Path) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:647:21 [INFO] [stdout] | [INFO] [stdout] 647 | exes.sort_by(|a,b |filename_len(a).cmp(&filename_len(b))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 647 - exes.sort_by(|a,b |filename_len(a).cmp(&filename_len(b))); [INFO] [stdout] 647 + exes.sort_by_key(|a| filename_len(a)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `to_appimage` (bin "to_appimage") due to 1 previous error; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c76b0136359e70b5aeadb1475d96636ddf82ce68af4d86c76d4547b295c73bfb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c76b0136359e70b5aeadb1475d96636ddf82ce68af4d86c76d4547b295c73bfb", kill_on_drop: false }` [INFO] [stdout] c76b0136359e70b5aeadb1475d96636ddf82ce68af4d86c76d4547b295c73bfb