[INFO] cloning repository https://github.com/shashibhat/ShopWire [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/shashibhat/ShopWire" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshashibhat%2FShopWire", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshashibhat%2FShopWire'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 828387ee13af4e74c80c2ad6cd5786c7f9be0092 [INFO] linting shashibhat/ShopWire against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fshashibhat%2FShopWire" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/shashibhat/ShopWire [INFO] finished tweaking git repo https://github.com/shashibhat/ShopWire [INFO] tweaked toml for git repo https://github.com/shashibhat/ShopWire written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/shashibhat/ShopWire on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/shashibhat/ShopWire already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redis v0.32.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9a3810d99ae86b26f49412822aca386bcf5478ab7622fafaeab5cbf8f26de5e [INFO] running `Command { std: "docker" "start" "-a" "c9a3810d99ae86b26f49412822aca386bcf5478ab7622fafaeab5cbf8f26de5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9a3810d99ae86b26f49412822aca386bcf5478ab7622fafaeab5cbf8f26de5e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9a3810d99ae86b26f49412822aca386bcf5478ab7622fafaeab5cbf8f26de5e", kill_on_drop: false }` [INFO] [stdout] c9a3810d99ae86b26f49412822aca386bcf5478ab7622fafaeab5cbf8f26de5e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70e76c575b9f9a561638c9230c445528d05f3bd7d84b996f680056b8fa0fc013 [INFO] running `Command { std: "docker" "start" "-a" "70e76c575b9f9a561638c9230c445528d05f3bd7d84b996f680056b8fa0fc013", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling pin-project-lite v0.2.17 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling rustls-pki-types v1.14.0 [INFO] [stderr] Compiling futures-core v0.3.32 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling tinyvec v1.10.0 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling webpki-roots v1.0.6 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Compiling futures-io v0.3.32 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.7 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Compiling webpki-roots v0.26.11 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling unicode-bidi v0.3.18 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Compiling tokio v1.50.0 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling futures-channel v0.3.32 [INFO] [stderr] Compiling home v0.5.12 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling bytestring v1.5.0 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking cookie v0.16.2 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking actix-router v0.5.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Compiling icu_properties v2.1.2 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Checking redis v0.32.7 [INFO] [stderr] Checking actix-http v3.12.0 [INFO] [stderr] Checking actix-web v4.13.0 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking shopwire v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/handlers.rs:302:28 [INFO] [stdout] | [INFO] [stdout] 302 | "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 302 - "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] 302 + "discount_desc" => filtered.sort_by_key(|b| std::cmp::Reverse(b.discount_pct)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/handlers.rs:302:28 [INFO] [stdout] | [INFO] [stdout] 302 | "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 302 - "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] 302 + "discount_desc" => filtered.sort_by_key(|b| std::cmp::Reverse(b.discount_pct)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/handlers.rs:302:28 [INFO] [stdout] | [INFO] [stdout] 302 | "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 302 - "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] 302 + "discount_desc" => filtered.sort_by_key(|b| std::cmp::Reverse(b.discount_pct)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/handlers.rs:302:28 [INFO] [stdout] | [INFO] [stdout] 302 | "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 302 - "discount_desc" => filtered.sort_by(|a, b| b.discount_pct.cmp(&a.discount_pct)), [INFO] [stdout] 302 + "discount_desc" => filtered.sort_by_key(|b| std::cmp::Reverse(b.discount_pct)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 36s [INFO] running `Command { std: "docker" "inspect" "70e76c575b9f9a561638c9230c445528d05f3bd7d84b996f680056b8fa0fc013", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70e76c575b9f9a561638c9230c445528d05f3bd7d84b996f680056b8fa0fc013", kill_on_drop: false }` [INFO] [stdout] 70e76c575b9f9a561638c9230c445528d05f3bd7d84b996f680056b8fa0fc013