[INFO] cloning repository https://github.com/sergentbne/rust-qr-code [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sergentbne/rust-qr-code" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsergentbne%2Frust-qr-code", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsergentbne%2Frust-qr-code'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c38a2fb11acc5c946587d51618f9a00cb78a2820 [INFO] linting sergentbne/rust-qr-code against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsergentbne%2Frust-qr-code" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sergentbne/rust-qr-code [INFO] finished tweaking git repo https://github.com/sergentbne/rust-qr-code [INFO] tweaked toml for git repo https://github.com/sergentbne/rust-qr-code written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sergentbne/rust-qr-code on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sergentbne/rust-qr-code already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded avif-serialize v0.8.3 [INFO] [stderr] Downloaded image-webp v0.2.1 [INFO] [stderr] Downloaded g2poly v1.2.2 [INFO] [stderr] Downloaded luma v0.1.0 [INFO] [stderr] Downloaded g2p v1.2.2 [INFO] [stderr] Downloaded ffmpeg-sys-next v7.1.0 [INFO] [stderr] Downloaded rqrr v0.9.3 [INFO] [stderr] Downloaded xz v0.1.0 [INFO] [stderr] Downloaded qrcode v0.14.1 [INFO] [stderr] Downloaded ffmpeg-next v7.1.0 [INFO] [stderr] Downloaded g2gen v1.2.2 [INFO] [stderr] Downloaded libfuzzer-sys v0.4.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b87a2847b40ed4079483df1277d3003381e0418d1a84f6ca43717a5b1e9abf64 [INFO] running `Command { std: "docker" "start" "-a" "b87a2847b40ed4079483df1277d3003381e0418d1a84f6ca43717a5b1e9abf64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b87a2847b40ed4079483df1277d3003381e0418d1a84f6ca43717a5b1e9abf64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b87a2847b40ed4079483df1277d3003381e0418d1a84f6ca43717a5b1e9abf64", kill_on_drop: false }` [INFO] [stdout] b87a2847b40ed4079483df1277d3003381e0418d1a84f6ca43717a5b1e9abf64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b1cedbffe281d051ce1053d1c1c3f35f5c71e61612a42c6cb5e3d0abc92a0c3 [INFO] running `Command { std: "docker" "start" "-a" "7b1cedbffe281d051ce1053d1c1c3f35f5c71e61612a42c6cb5e3d0abc92a0c3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cc v1.2.16 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling libloading v0.8.6 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling bindgen v0.70.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling bitflags v2.9.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking bytemuck v1.22.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Checking imgref v1.11.0 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking flate2 v1.1.0 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking avif-serialize v0.8.3 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking zune-jpeg v0.4.14 [INFO] [stderr] Compiling num_cpus v1.16.0 [INFO] [stderr] Checking image-webp v0.2.1 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Compiling quote v1.0.39 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling syn v2.0.99 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Compiling g2poly v1.2.2 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling ffmpeg-next v7.1.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking luma v0.1.0 [INFO] [stderr] Compiling lzma-sys v0.1.20 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking xz2 v0.1.7 [INFO] [stderr] Checking xz v0.1.0 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Compiling profiling-procmacros v1.0.16 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling g2gen v1.2.2 [INFO] [stderr] Checking profiling v1.0.16 [INFO] [stderr] Checking g2p v1.2.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking rav1e v0.7.1 [INFO] [stderr] Compiling ffmpeg-sys-next v7.1.0 [INFO] [stderr] Checking ravif v0.11.11 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking rqrr v0.9.3 [INFO] [stderr] Checking qrcode v0.14.1 [INFO] [stderr] Checking rust-qr-code v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `image::imageops::FilterType` [INFO] [stdout] --> src/convert_to_mp4.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use image::imageops::FilterType; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | framerate: framerate, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | images: images, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | scaler: scaler, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `scaler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | octx: octx, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `octx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sender` [INFO] [stdout] --> src/qr_generation.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::mpsc::{self, Sender}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `image::imageops::FilterType` [INFO] [stdout] --> src/convert_to_mp4.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use image::imageops::FilterType; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | framerate: framerate, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | images: images, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | scaler: scaler, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `scaler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | octx: octx, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `octx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sender` [INFO] [stdout] --> src/qr_generation.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::mpsc::{self, Sender}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | if !inputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `inputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !outputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `outputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/args.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] 37 + Ok([inputf, outputf, framerate, Some(decode)]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | args: &'a Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - args: &'a Vec, [INFO] [stdout] 4 + args: &'a [String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args.rs:12:47 [INFO] [stdout] | [INFO] [stdout] 12 | let mut framerate: Option<&String> = Some(&default_framerate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `default_framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/convert_to_mp4.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/convert_to_mp4.rs:157:34 [INFO] [stdout] | [INFO] [stdout] 157 | let dst_offset = y * frame_linesizes as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `frame_linesizes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/convert_to_mp4.rs:199:33 [INFO] [stdout] | [INFO] [stdout] 199 | self.frame_count += 1 * (15360 / self.framerate as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((15360 / self.framerate as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/convert_to_mp4.rs:230:21 [INFO] [stdout] | [INFO] [stdout] 230 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/convert_to_mp4.rs:271:54 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 271 - pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] 271 + pub fn convert_func(output_file: &String, framerate: &str, nb_of_images: u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/convert_to_mp4.rs:291:50 [INFO] [stdout] | [INFO] [stdout] 291 | format::context::output::dump(&octx, 0, Some(&output_file)); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `output_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:49 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `frame_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:69 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `frame_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/decode_from_mp4.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 102 - let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] 102 + decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/decode_from_mp4.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/decode_from_mp4.rs:126:47 [INFO] [stdout] | [INFO] [stdout] 126 | || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 126 - || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] 126 + || -> Result { uncompressed.read_to_end(&mut buffer_vec) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | if !inputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `inputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/decode_from_mp4.rs:133:10 [INFO] [stdout] | [INFO] [stdout] 133 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/decode_from_mp4.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 137 | .open(&parsed_arguments[1].unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `parsed_arguments[1].unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return data; [INFO] [stdout] 165 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !outputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `outputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/args.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] 37 + Ok([inputf, outputf, framerate, Some(decode)]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | args: &'a Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - args: &'a Vec, [INFO] [stdout] 4 + args: &'a [String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args.rs:12:47 [INFO] [stdout] | [INFO] [stdout] 12 | let mut framerate: Option<&String> = Some(&default_framerate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `default_framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return data; [INFO] [stdout] 179 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/qr_generation.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn create_environement() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - } [INFO] [stdout] 96 - return; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:108:11 [INFO] [stdout] | [INFO] [stdout] 108 | while data.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/convert_to_mp4.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/qr_generation.rs:127:55 [INFO] [stdout] | [INFO] [stdout] 127 | (total_size as f32 / total_data_of_file * 100 as f32).floor() [INFO] [stdout] | ^^^^^^^^^^ help: try: `100_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/convert_to_mp4.rs:157:34 [INFO] [stdout] | [INFO] [stdout] 157 | let dst_offset = y * frame_linesizes as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `frame_linesizes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 139 | while threads.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_generation.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | let nb_of_images: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `nb_of_images` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 153 ~ [INFO] [stdout] 154 | let (sync_device, reciever) = mpsc::channel(); [INFO] [stdout] ... [INFO] [stdout] 177 | let _ = sync_device.send(()); [INFO] [stdout] 178 ~ let nb_of_images: u32 = match compress_file( [INFO] [stdout] 179 | parsed_arguments[0].unwrap(), [INFO] [stdout] ... [INFO] [stdout] 189 | [INFO] [stdout] 190 ~ get_data_from_file(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/convert_to_mp4.rs:199:33 [INFO] [stdout] | [INFO] [stdout] 199 | self.frame_count += 1 * (15360 / self.framerate as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((15360 / self.framerate as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - println!(""); [INFO] [stdout] 173 - return; [INFO] [stdout] 172 + println!(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/qr_generation.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/convert_to_mp4.rs:230:21 [INFO] [stdout] | [INFO] [stdout] 230 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/convert_to_mp4.rs:271:54 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 271 - pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] 271 + pub fn convert_func(output_file: &String, framerate: &str, nb_of_images: u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sort_lib.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return a_int.cmp(&b_int); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return a_int.cmp(&b_int); [INFO] [stdout] 24 + a_int.cmp(&b_int) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &Path, b: &PathBuf) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:46 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &PathBuf, b: &Path) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/convert_to_mp4.rs:291:50 [INFO] [stdout] | [INFO] [stdout] 291 | format::context::output::dump(&octx, 0, Some(&output_file)); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `output_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:49 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `frame_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:69 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `frame_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/decode_from_mp4.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 102 - let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] 102 + decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/decode_from_mp4.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/decode_from_mp4.rs:126:47 [INFO] [stdout] | [INFO] [stdout] 126 | || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 126 - || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] 126 + || -> Result { uncompressed.read_to_end(&mut buffer_vec) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/decode_from_mp4.rs:133:10 [INFO] [stdout] | [INFO] [stdout] 133 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/decode_from_mp4.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 137 | .open(&parsed_arguments[1].unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `parsed_arguments[1].unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return data; [INFO] [stdout] 165 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return data; [INFO] [stdout] 179 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/qr_generation.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn create_environement() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - } [INFO] [stdout] 96 - return; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:108:11 [INFO] [stdout] | [INFO] [stdout] 108 | while data.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/qr_generation.rs:127:55 [INFO] [stdout] | [INFO] [stdout] 127 | (total_size as f32 / total_data_of_file * 100 as f32).floor() [INFO] [stdout] | ^^^^^^^^^^ help: try: `100_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 139 | while threads.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_generation.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | let nb_of_images: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `nb_of_images` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 153 ~ [INFO] [stdout] 154 | let (sync_device, reciever) = mpsc::channel(); [INFO] [stdout] ... [INFO] [stdout] 177 | let _ = sync_device.send(()); [INFO] [stdout] 178 ~ let nb_of_images: u32 = match compress_file( [INFO] [stdout] 179 | parsed_arguments[0].unwrap(), [INFO] [stdout] ... [INFO] [stdout] 189 | [INFO] [stdout] 190 ~ get_data_from_file(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - println!(""); [INFO] [stdout] 173 - return; [INFO] [stdout] 172 + println!(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/qr_generation.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sort_lib.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return a_int.cmp(&b_int); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return a_int.cmp(&b_int); [INFO] [stdout] 24 + a_int.cmp(&b_int) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &Path, b: &PathBuf) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:46 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &PathBuf, b: &Path) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `image::imageops::FilterType` [INFO] [stdout] --> src/convert_to_mp4.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use image::imageops::FilterType; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | framerate: framerate, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | images: images, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | scaler: scaler, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `scaler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | octx: octx, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `octx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sender` [INFO] [stdout] --> src/qr_generation.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::mpsc::{self, Sender}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `image::imageops::FilterType` [INFO] [stdout] --> src/convert_to_mp4.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use image::imageops::FilterType; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | framerate: framerate, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | images: images, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | scaler: scaler, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `scaler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/convert_to_mp4.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | octx: octx, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `octx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Sender` [INFO] [stdout] --> src/qr_generation.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | use std::sync::mpsc::{self, Sender}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | if !inputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `inputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !outputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `outputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/args.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] 37 + Ok([inputf, outputf, framerate, Some(decode)]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | args: &'a Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - args: &'a Vec, [INFO] [stdout] 4 + args: &'a [String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args.rs:12:47 [INFO] [stdout] | [INFO] [stdout] 12 | let mut framerate: Option<&String> = Some(&default_framerate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `default_framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/convert_to_mp4.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/convert_to_mp4.rs:157:34 [INFO] [stdout] | [INFO] [stdout] 157 | let dst_offset = y * frame_linesizes as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `frame_linesizes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/convert_to_mp4.rs:199:33 [INFO] [stdout] | [INFO] [stdout] 199 | self.frame_count += 1 * (15360 / self.framerate as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((15360 / self.framerate as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/convert_to_mp4.rs:230:21 [INFO] [stdout] | [INFO] [stdout] 230 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/convert_to_mp4.rs:271:54 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 271 - pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] 271 + pub fn convert_func(output_file: &String, framerate: &str, nb_of_images: u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/convert_to_mp4.rs:291:50 [INFO] [stdout] | [INFO] [stdout] 291 | format::context::output::dump(&octx, 0, Some(&output_file)); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `output_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:49 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `frame_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:69 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `frame_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/decode_from_mp4.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 102 - let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] 102 + decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | if !inputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `inputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/decode_from_mp4.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/decode_from_mp4.rs:126:47 [INFO] [stdout] | [INFO] [stdout] 126 | || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 126 - || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] 126 + || -> Result { uncompressed.read_to_end(&mut buffer_vec) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !outputf.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `outputf.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/args.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Ok([inputf, outputf, framerate, Some(decode)]); [INFO] [stdout] 37 + Ok([inputf, outputf, framerate, Some(decode)]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/args.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | args: &'a Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - args: &'a Vec, [INFO] [stdout] 4 + args: &'a [String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/args.rs:12:47 [INFO] [stdout] | [INFO] [stdout] 12 | let mut framerate: Option<&String> = Some(&default_framerate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `default_framerate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/decode_from_mp4.rs:133:10 [INFO] [stdout] | [INFO] [stdout] 133 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/decode_from_mp4.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 137 | .open(&parsed_arguments[1].unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `parsed_arguments[1].unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return data; [INFO] [stdout] 165 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return data; [INFO] [stdout] 179 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/qr_generation.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn create_environement() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/convert_to_mp4.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 115 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - } [INFO] [stdout] 96 - return; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/convert_to_mp4.rs:157:34 [INFO] [stdout] | [INFO] [stdout] 157 | let dst_offset = y * frame_linesizes as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `frame_linesizes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:108:11 [INFO] [stdout] | [INFO] [stdout] 108 | while data.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/qr_generation.rs:127:55 [INFO] [stdout] | [INFO] [stdout] 127 | (total_size as f32 / total_data_of_file * 100 as f32).floor() [INFO] [stdout] | ^^^^^^^^^^ help: try: `100_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/convert_to_mp4.rs:199:33 [INFO] [stdout] | [INFO] [stdout] 199 | self.frame_count += 1 * (15360 / self.framerate as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((15360 / self.framerate as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 139 | while threads.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/convert_to_mp4.rs:230:21 [INFO] [stdout] | [INFO] [stdout] 230 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_generation.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | let nb_of_images: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `nb_of_images` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 153 ~ [INFO] [stdout] 154 | let (sync_device, reciever) = mpsc::channel(); [INFO] [stdout] ... [INFO] [stdout] 177 | let _ = sync_device.send(()); [INFO] [stdout] 178 ~ let nb_of_images: u32 = match compress_file( [INFO] [stdout] 179 | parsed_arguments[0].unwrap(), [INFO] [stdout] ... [INFO] [stdout] 189 | [INFO] [stdout] 190 ~ get_data_from_file(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - println!(""); [INFO] [stdout] 173 - return; [INFO] [stdout] 172 + println!(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/qr_generation.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/convert_to_mp4.rs:271:54 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 271 - pub fn convert_func(output_file: &String, framerate: &String, nb_of_images: u32) { [INFO] [stdout] 271 + pub fn convert_func(output_file: &String, framerate: &str, nb_of_images: u32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/convert_to_mp4.rs:291:50 [INFO] [stdout] | [INFO] [stdout] 291 | format::context::output::dump(&octx, 0, Some(&output_file)); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `output_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sort_lib.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return a_int.cmp(&b_int); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return a_int.cmp(&b_int); [INFO] [stdout] 24 + a_int.cmp(&b_int) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &Path, b: &PathBuf) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:46 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &PathBuf, b: &Path) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:49 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `frame_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/decode_from_mp4.rs:68:69 [INFO] [stdout] | [INFO] [stdout] 68 | image::ImageBuffer::new(frame_width as u32, frame_height as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `frame_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/decode_from_mp4.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 102 - let _ = decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] 102 + decode_vid(parsed_arguments).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/decode_from_mp4.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | images.sort_by(|a, b| sort_the_vector_right(a, b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `sort_the_vector_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/decode_from_mp4.rs:126:47 [INFO] [stdout] | [INFO] [stdout] 126 | || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 126 - || -> Result { Ok(uncompressed.read_to_end(&mut buffer_vec)?) }; [INFO] [stdout] 126 + || -> Result { uncompressed.read_to_end(&mut buffer_vec) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/decode_from_mp4.rs:133:10 [INFO] [stdout] | [INFO] [stdout] 133 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/decode_from_mp4.rs:137:15 [INFO] [stdout] | [INFO] [stdout] 137 | .open(&parsed_arguments[1].unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `parsed_arguments[1].unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return data; [INFO] [stdout] 165 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/decode_from_mp4.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | return data; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - return data; [INFO] [stdout] 179 + data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/decode_from_mp4.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | assert!(data.len() != 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/qr_generation.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn create_environement() -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - } [INFO] [stdout] 96 - return; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:108:11 [INFO] [stdout] | [INFO] [stdout] 108 | while data.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/qr_generation.rs:127:55 [INFO] [stdout] | [INFO] [stdout] 127 | (total_size as f32 / total_data_of_file * 100 as f32).floor() [INFO] [stdout] | ^^^^^^^^^^ help: try: `100_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/qr_generation.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 139 | while threads.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_generation.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | let nb_of_images: u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `nb_of_images` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 153 ~ [INFO] [stdout] 154 | let (sync_device, reciever) = mpsc::channel(); [INFO] [stdout] ... [INFO] [stdout] 177 | let _ = sync_device.send(()); [INFO] [stdout] 178 ~ let nb_of_images: u32 = match compress_file( [INFO] [stdout] 179 | parsed_arguments[0].unwrap(), [INFO] [stdout] ... [INFO] [stdout] 189 | [INFO] [stdout] 190 ~ get_data_from_file(n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_generation.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - println!(""); [INFO] [stdout] 173 - return; [INFO] [stdout] 172 + println!(""); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/qr_generation.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sort_lib.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return a_int.cmp(&b_int); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return a_int.cmp(&b_int); [INFO] [stdout] 24 + a_int.cmp(&b_int) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:33 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &Path, b: &PathBuf) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/sort_lib.rs:4:46 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - pub fn sort_the_vector_right(a: &PathBuf, b: &PathBuf) -> Ordering { [INFO] [stdout] 4 + pub fn sort_the_vector_right(a: &PathBuf, b: &Path) -> Ordering { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 47.14s [INFO] running `Command { std: "docker" "inspect" "7b1cedbffe281d051ce1053d1c1c3f35f5c71e61612a42c6cb5e3d0abc92a0c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b1cedbffe281d051ce1053d1c1c3f35f5c71e61612a42c6cb5e3d0abc92a0c3", kill_on_drop: false }` [INFO] [stdout] 7b1cedbffe281d051ce1053d1c1c3f35f5c71e61612a42c6cb5e3d0abc92a0c3