[INFO] cloning repository https://github.com/sents/emojipicker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sents/emojipicker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsents%2Femojipicker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsents%2Femojipicker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3c4f407d09c5a22c9d07b4c55698ae60637d621d [INFO] linting sents/emojipicker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsents%2Femojipicker" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sents/emojipicker [INFO] finished tweaking git repo https://github.com/sents/emojipicker [INFO] tweaked toml for git repo https://github.com/sents/emojipicker written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sents/emojipicker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sents/emojipicker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pango-sys v0.20.4 [INFO] [stderr] Downloaded relm4-css v0.9.0 [INFO] [stderr] Downloaded tracker-macros v0.2.2 [INFO] [stderr] Downloaded tracker v0.2.2 [INFO] [stderr] Downloaded gdk-pixbuf-sys v0.20.4 [INFO] [stderr] Downloaded system-deps v7.0.3 [INFO] [stderr] Downloaded graphene-sys v0.20.4 [INFO] [stderr] Downloaded pango v0.20.4 [INFO] [stderr] Downloaded cairo-sys-rs v0.20.0 [INFO] [stderr] Downloaded gsk4-sys v0.9.3 [INFO] [stderr] Downloaded gdk-pixbuf v0.20.4 [INFO] [stderr] Downloaded gsk4 v0.9.3 [INFO] [stderr] Downloaded cairo-rs v0.20.5 [INFO] [stderr] Downloaded gdk4-sys v0.9.3 [INFO] [stderr] Downloaded gio-sys v0.20.5 [INFO] [stderr] Downloaded gdk4 v0.9.3 [INFO] [stderr] Downloaded gtk4-sys v0.9.3 [INFO] [stderr] Downloaded emojis v0.6.4 [INFO] [stderr] Downloaded gio v0.20.5 [INFO] [stderr] Downloaded relm4 v0.9.1 [INFO] [stderr] Downloaded serde v1.0.214 [INFO] [stderr] Downloaded glib-macros v0.20.5 [INFO] [stderr] Downloaded serde_derive v1.0.214 [INFO] [stderr] Downloaded glib-sys v0.20.5 [INFO] [stderr] Downloaded cfg-expr v0.17.0 [INFO] [stderr] Downloaded relm4-macros v0.9.1 [INFO] [stderr] Downloaded graphene-rs v0.20.4 [INFO] [stderr] Downloaded glib v0.20.5 [INFO] [stderr] Downloaded gtk4-macros v0.9.3 [INFO] [stderr] Downloaded gobject-sys v0.20.4 [INFO] [stderr] Downloaded gtk4 v0.9.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61df3add568abef1b4bb410ef3af5ddfc665d6ed09e809944fb8e3edaa3a9179 [INFO] running `Command { std: "docker" "start" "-a" "61df3add568abef1b4bb410ef3af5ddfc665d6ed09e809944fb8e3edaa3a9179", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61df3add568abef1b4bb410ef3af5ddfc665d6ed09e809944fb8e3edaa3a9179", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61df3add568abef1b4bb410ef3af5ddfc665d6ed09e809944fb8e3edaa3a9179", kill_on_drop: false }` [INFO] [stdout] 61df3add568abef1b4bb410ef3af5ddfc665d6ed09e809944fb8e3edaa3a9179 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c7ab0fc26f4989b2af828de843353f4dcc3ec76fbaf8c3172ad8505d81637dc [INFO] running `Command { std: "docker" "start" "-a" "1c7ab0fc26f4989b2af828de843353f4dcc3ec76fbaf8c3172ad8505d81637dc", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling hashbrown v0.15.1 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Compiling version-compare v0.2.0 [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling gio v0.20.5 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Compiling relm4-css v0.9.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking bytes v1.8.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking emojis v0.6.4 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling cfg-expr v0.17.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling indexmap v2.6.0 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking flume v0.11.1 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde_spanned v0.6.8 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling relm4-macros v0.9.1 [INFO] [stderr] Compiling tracker-macros v0.2.2 [INFO] [stderr] Compiling system-deps v7.0.3 [INFO] [stderr] Compiling glib-macros v0.20.5 [INFO] [stderr] Compiling gtk4-macros v0.9.3 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Checking tracker v0.2.2 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling glib-sys v0.20.5 [INFO] [stderr] Compiling gobject-sys v0.20.4 [INFO] [stderr] Compiling gio-sys v0.20.5 [INFO] [stderr] Compiling pango-sys v0.20.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.20.4 [INFO] [stderr] Compiling cairo-sys-rs v0.20.0 [INFO] [stderr] Compiling gdk4-sys v0.9.3 [INFO] [stderr] Compiling graphene-sys v0.20.4 [INFO] [stderr] Compiling gsk4-sys v0.9.3 [INFO] [stderr] Compiling gtk4-sys v0.9.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking glib v0.20.5 [INFO] [stderr] Checking cairo-rs v0.20.5 [INFO] [stderr] Checking graphene-rs v0.20.4 [INFO] [stderr] Checking pango v0.20.4 [INFO] [stderr] Checking gdk-pixbuf v0.20.4 [INFO] [stderr] Checking gdk4 v0.9.3 [INFO] [stderr] Checking gsk4 v0.9.3 [INFO] [stderr] Checking gtk4 v0.9.3 [INFO] [stderr] Checking relm4 v0.9.1 [INFO] [stderr] Checking emojipicker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/components/emoji_picker.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 78 | / let model = Self { [INFO] [stdout] 79 | | emoji: value, [INFO] [stdout] 80 | | tone_picker, [INFO] [stdout] 81 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 82 | model [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 78 ~ [INFO] [stdout] 79 ~ Self { [INFO] [stdout] 80 + emoji: value, [INFO] [stdout] 81 + tone_picker, [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/emoji_picker.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 100 | let has_picker = !self.tone_picker.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tone_picker.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/debounce.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let _ = tokio::spawn(async move { [INFO] [stdout] 31 | | tokio::select! { [INFO] [stdout] 32 | | _ = sleep(duration) => { [INFO] [stdout] 33 | | cloned_func(arg) [INFO] [stdout] ... | [INFO] [stdout] 37 | | }); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Duration` which implements the `Copy` trait [INFO] [stdout] --> src/debounce.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | let cloned_delay = self.delay.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.delay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/components/emoji_picker.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 78 | / let model = Self { [INFO] [stdout] 79 | | emoji: value, [INFO] [stdout] 80 | | tone_picker, [INFO] [stdout] 81 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 82 | model [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 78 ~ [INFO] [stdout] 79 ~ Self { [INFO] [stdout] 80 + emoji: value, [INFO] [stdout] 81 + tone_picker, [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/components/emoji_picker.rs:100:26 [INFO] [stdout] | [INFO] [stdout] 100 | let has_picker = !self.tone_picker.is_none(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.tone_picker.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> src/debounce.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let _ = tokio::spawn(async move { [INFO] [stdout] 31 | | tokio::select! { [INFO] [stdout] 32 | | _ = sleep(duration) => { [INFO] [stdout] 33 | | cloned_func(arg) [INFO] [stdout] ... | [INFO] [stdout] 37 | | }); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Duration` which implements the `Copy` trait [INFO] [stdout] --> src/debounce.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | let cloned_delay = self.delay.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.delay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 27s [INFO] running `Command { std: "docker" "inspect" "1c7ab0fc26f4989b2af828de843353f4dcc3ec76fbaf8c3172ad8505d81637dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c7ab0fc26f4989b2af828de843353f4dcc3ec76fbaf8c3172ad8505d81637dc", kill_on_drop: false }` [INFO] [stdout] 1c7ab0fc26f4989b2af828de843353f4dcc3ec76fbaf8c3172ad8505d81637dc