[INFO] cloning repository https://github.com/senpaiss69/uzakiiiiiiiiiiii [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/senpaiss69/uzakiiiiiiiiiiii" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsenpaiss69%2Fuzakiiiiiiiiiiii", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsenpaiss69%2Fuzakiiiiiiiiiiii'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 109baabb1e6986bcf31d4e2144a4bc0adc0de499 [INFO] linting senpaiss69/uzakiiiiiiiiiiii against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsenpaiss69%2Fuzakiiiiiiiiiiii" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/senpaiss69/uzakiiiiiiiiiiii [INFO] finished tweaking git repo https://github.com/senpaiss69/uzakiiiiiiiiiiii [INFO] tweaked toml for git repo https://github.com/senpaiss69/uzakiiiiiiiiiiii written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/senpaiss69/uzakiiiiiiiiiiii on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/senpaiss69/uzakiiiiiiiiiiii already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sha1_smol v1.0.1 [INFO] [stderr] Downloaded xdg-home v1.1.0 [INFO] [stderr] Downloaded enumflags2_derive v0.7.9 [INFO] [stderr] Downloaded zvariant_derive v4.1.1 [INFO] [stderr] Downloaded zbus_macros v4.2.2 [INFO] [stderr] Downloaded enumflags2 v0.7.9 [INFO] [stderr] Downloaded copypasta v0.10.1 [INFO] [stderr] Downloaded zvariant v4.1.1 [INFO] [stderr] Downloaded anstyle-query v1.0.3 [INFO] [stderr] Downloaded x11-clipboard v0.9.2 [INFO] [stderr] Downloaded async-process v2.2.2 [INFO] [stderr] Downloaded clipboard-win v5.3.1 [INFO] [stderr] Downloaded clap v4.5.13 [INFO] [stderr] Downloaded sctk-adwaita v0.8.1 [INFO] [stderr] Downloaded wayland-backend v0.3.3 [INFO] [stderr] Downloaded clap_builder v4.5.13 [INFO] [stderr] Downloaded quinn-proto v0.11.8 [INFO] [stderr] Downloaded xkeysym v0.2.0 [INFO] [stderr] Downloaded owned_ttf_parser v0.21.0 [INFO] [stderr] Downloaded zbus v4.2.2 [INFO] [stderr] Downloaded egui-notify v0.15.0 [INFO] [stderr] Downloaded flexi_logger v0.29.8 [INFO] [stderr] Downloaded quinn v0.11.2 [INFO] [stderr] Downloaded quick-xml v0.37.1 [INFO] [stderr] Downloaded event-listener v5.3.0 [INFO] [stderr] Downloaded async-io v2.3.2 [INFO] [stderr] Downloaded wayland-client v0.31.2 [INFO] [stderr] Downloaded tauri-winrt-notification v0.2.1 [INFO] [stderr] Downloaded notify-rust v4.11.3 [INFO] [stderr] Downloaded polling v3.7.0 [INFO] [stderr] Downloaded async-signal v0.2.6 [INFO] [stderr] Downloaded piper v0.2.2 [INFO] [stderr] Downloaded wayland-scanner v0.31.1 [INFO] [stderr] Downloaded wayland-cursor v0.31.1 [INFO] [stderr] Downloaded wayland-sys v0.31.1 [INFO] [stderr] Downloaded ab_glyph v0.2.26 [INFO] [stderr] Downloaded mac-notification-sys v0.6.1 [INFO] [stderr] Downloaded windows-version v0.1.1 [INFO] [stderr] Downloaded poll-promise v0.3.0 [INFO] [stderr] Downloaded async-broadcast v0.7.0 [INFO] [stderr] Downloaded mio v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cb3db8dfb4c25e32ab019e4226d5f7d07b51edacad388cd6e95f261b2774fe7 [INFO] running `Command { std: "docker" "start" "-a" "1cb3db8dfb4c25e32ab019e4226d5f7d07b51edacad388cd6e95f261b2774fe7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cb3db8dfb4c25e32ab019e4226d5f7d07b51edacad388cd6e95f261b2774fe7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cb3db8dfb4c25e32ab019e4226d5f7d07b51edacad388cd6e95f261b2774fe7", kill_on_drop: false }` [INFO] [stdout] 1cb3db8dfb4c25e32ab019e4226d5f7d07b51edacad388cd6e95f261b2774fe7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96730205c903e3215261cfb52226551fd5ef4a4c0bd5503fde2a773020d8167c [INFO] running `Command { std: "docker" "start" "-a" "96730205c903e3215261cfb52226551fd5ef4a4c0bd5503fde2a773020d8167c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.214 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.2 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling syn v2.0.91 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-executor v1.12.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Compiling xml-rs v0.8.20 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking xdg-home v1.1.0 [INFO] [stderr] Compiling wayland-scanner v0.31.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking owned_ttf_parser v0.21.0 [INFO] [stderr] Compiling wayland-backend v0.3.3 [INFO] [stderr] Checking ab_glyph v0.2.26 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling winit v0.29.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking endi v1.1.0 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking async-broadcast v0.7.0 [INFO] [stderr] Compiling glutin v0.31.3 [INFO] [stderr] Checking async-once-cell v0.5.3 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Compiling thiserror v2.0.9 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Compiling document-features v0.2.8 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling serde_json v1.0.134 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Compiling rfd v0.14.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling zvariant_utils v2.0.0 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking quick-xml v0.37.1 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.214 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling enumflags2_derive v0.7.9 [INFO] [stderr] Compiling bytemuck_derive v1.7.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling enumn v0.1.13 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Compiling zvariant_derive v4.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling zbus_macros v4.2.2 [INFO] [stderr] Compiling thiserror-impl v2.0.9 [INFO] [stderr] Checking tokio v1.41.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking bytemuck v1.16.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking flexi_logger v0.29.8 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking enumflags2 v0.7.9 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking accesskit v0.12.3 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking poll-promise v0.3.0 [INFO] [stderr] Checking zvariant v4.1.1 [INFO] [stderr] Checking webbrowser v1.0.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking egui v0.28.1 [INFO] [stderr] Checking zbus_names v3.0.0 [INFO] [stderr] Checking polling v3.7.0 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking wayland-client v0.31.2 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking zbus v4.2.2 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking arboard v3.4.0 [INFO] [stderr] Checking x11-clipboard v0.9.2 [INFO] [stderr] Checking egui_glow v0.28.1 [INFO] [stderr] Checking egui-notify v0.15.0 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking ashpd v0.8.1 [INFO] [stderr] Checking notify-rust v4.11.3 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking sctk-adwaita v0.8.1 [INFO] [stderr] Checking smithay-clipboard v0.7.1 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stderr] Checking copypasta v0.10.1 [INFO] [stderr] Checking accesskit_winit v0.16.1 [INFO] [stderr] Checking egui-winit v0.28.1 [INFO] [stderr] Checking eframe v0.28.1 [INFO] [stderr] Checking rusty-psn v0.5.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/psn/manifest_parser.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/psn/manifest_parser.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MergeFailure` is never constructed [INFO] [stdout] --> src/psn/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub enum MergeStatus { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 28 | MergeFailure [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MergeStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | FilepathMismatch(String), [INFO] [stdout] | ---------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MergeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 33 - FilepathMismatch(String), [INFO] [stdout] 33 + FilepathMismatch(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:35:24 [INFO] [stdout] | [INFO] [stdout] 35 | PackagesUnmergable(String), [INFO] [stdout] | ------------------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MergeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 35 - PackagesUnmergable(String), [INFO] [stdout] 35 + PackagesUnmergable(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 43 | Tokio(tokio::io::Error), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DownloadError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 43 - Tokio(tokio::io::Error), [INFO] [stdout] 43 + Tokio(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | Reqwest(reqwest::Error) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DownloadError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 44 - Reqwest(reqwest::Error) [INFO] [stdout] 44 + Reqwest(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/psn/utils.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return None [INFO] [stdout] 33 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.titles.get(0)` [INFO] [stdout] --> src/psn/mod.rs:80:30 [INFO] [stdout] | [INFO] [stdout] 80 | if let Some(title) = self.titles.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.titles.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/psn/mod.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 130 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `MergeFailure` is never constructed [INFO] [stdout] --> src/psn/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub enum MergeStatus { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 28 | MergeFailure [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MergeStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | FilepathMismatch(String), [INFO] [stdout] | ---------------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MergeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 33 - FilepathMismatch(String), [INFO] [stdout] 33 + FilepathMismatch(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:35:24 [INFO] [stdout] | [INFO] [stdout] 35 | PackagesUnmergable(String), [INFO] [stdout] | ------------------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MergeError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 35 - PackagesUnmergable(String), [INFO] [stdout] 35 + PackagesUnmergable(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 43 | Tokio(tokio::io::Error), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DownloadError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 43 - Tokio(tokio::io::Error), [INFO] [stdout] 43 + Tokio(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/psn/mod.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | Reqwest(reqwest::Error) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DownloadError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 44 - Reqwest(reqwest::Error) [INFO] [stdout] 44 + Reqwest(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/psn/utils.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return None [INFO] [stdout] 33 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/psn/mod.rs:180:57 [INFO] [stdout] | [INFO] [stdout] 180 | let package_download_path = create_new_pkg_path(&download_path, &self.title_id, &self.title()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `download_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/psn/mod.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | / return title_id [INFO] [stdout] 220 | | .trim() [INFO] [stdout] 221 | | .replace("-", "") // strip the dash that some sites put in a title id, eg. BCES-xxxxx [INFO] [stdout] 222 | | .to_uppercase(); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 ~ title_id [INFO] [stdout] 220 + .trim() [INFO] [stdout] 221 + .replace("-", "") // strip the dash that some sites put in a title id, eg. BCES-xxxxx [INFO] [stdout] 222 ~ .to_uppercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/psn/mod.rs:218:33 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn parse_title_id(title_id: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 218 - pub fn parse_title_id(title_id: &String) -> String { [INFO] [stdout] 218 + pub fn parse_title_id(title_id: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/psn/mod.rs:278:27 [INFO] [stdout] | [INFO] [stdout] 278 | .and_then(|s| s.last()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 278 - .and_then(|s| s.last()) [INFO] [stdout] 278 + .and_then(|mut s| s.next_back()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `download_path` [INFO] [stdout] --> src/psn/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | let download_path = download_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `download_path` is initially defined here [INFO] [stdout] --> src/psn/mod.rs:258:68 [INFO] [stdout] | [INFO] [stdout] 258 | pub async fn start_download(&self, tx: Sender, download_path: PathBuf, serial: String, title: String) -> Result... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/psn/mod.rs:361:27 [INFO] [stdout] | [INFO] [stdout] 361 | .and_then(|s| s.last()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - .and_then(|s| s.last()) [INFO] [stdout] 361 + .and_then(|mut s| s.next_back()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 24 | fn create_old_pkg_path(download_path: &PathBuf, serial: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 24 ~ fn create_old_pkg_path(download_path: &Path, serial: &str) -> PathBuf { [INFO] [stdout] 25 ~ let mut target_path = download_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:30:43 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn create_new_pkg_path(download_path: &PathBuf, serial: &str, title: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 ~ pub fn create_new_pkg_path(download_path: &Path, serial: &str, title: &str) -> PathBuf { [INFO] [stdout] 31 ~ let mut target_path = download_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:38:71 [INFO] [stdout] | [INFO] [stdout] 38 | let mut target_path = create_new_pkg_path(&download_path, serial, &title); [INFO] [stdout] | ^^^^^^ help: change this to: `title` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 64 | return Err(DownloadError::Tokio(io::Error::new(io::ErrorKind::Other, "Target path has no parent directory"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 64 - return Err(DownloadError::Tokio(io::Error::new(io::ErrorKind::Other, "Target path has no parent directory"))); [INFO] [stdout] 64 + return Err(DownloadError::Tokio(io::Error::other("Target path has no parent directory"))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | processed_length = processed_length + chunk_length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_length += chunk_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/utils.rs:115:38 [INFO] [stdout] | [INFO] [stdout] 115 | let last_before_suffix = (file_length_without_suffix - previously_processed_length) [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 116 | | .try_into() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | &chunk_buffer [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `chunk_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:123:23 [INFO] [stdout] | [INFO] [stdout] 123 | hasher.update(&hashable_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `hashable_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.titles.get(0)` [INFO] [stdout] --> src/psn/mod.rs:80:30 [INFO] [stdout] | [INFO] [stdout] 80 | if let Some(title) = self.titles.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.titles.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/psn/mod.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 130 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/psn/mod.rs:180:57 [INFO] [stdout] | [INFO] [stdout] 180 | let package_download_path = create_new_pkg_path(&download_path, &self.title_id, &self.title()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `download_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/psn/mod.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | / return title_id [INFO] [stdout] 220 | | .trim() [INFO] [stdout] 221 | | .replace("-", "") // strip the dash that some sites put in a title id, eg. BCES-xxxxx [INFO] [stdout] 222 | | .to_uppercase(); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 ~ title_id [INFO] [stdout] 220 + .trim() [INFO] [stdout] 221 + .replace("-", "") // strip the dash that some sites put in a title id, eg. BCES-xxxxx [INFO] [stdout] 222 ~ .to_uppercase() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/psn/mod.rs:218:33 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn parse_title_id(title_id: &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 218 - pub fn parse_title_id(title_id: &String) -> String { [INFO] [stdout] 218 + pub fn parse_title_id(title_id: &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/psn/mod.rs:278:27 [INFO] [stdout] | [INFO] [stdout] 278 | .and_then(|s| s.last()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 278 - .and_then(|s| s.last()) [INFO] [stdout] 278 + .and_then(|mut s| s.next_back()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `download_path` [INFO] [stdout] --> src/psn/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | let download_path = download_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `download_path` is initially defined here [INFO] [stdout] --> src/psn/mod.rs:258:68 [INFO] [stdout] | [INFO] [stdout] 258 | pub async fn start_download(&self, tx: Sender, download_path: PathBuf, serial: String, title: String) -> Result... [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/psn/mod.rs:361:27 [INFO] [stdout] | [INFO] [stdout] 361 | .and_then(|s| s.last()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 361 - .and_then(|s| s.last()) [INFO] [stdout] 361 + .and_then(|mut s| s.next_back()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 24 | fn create_old_pkg_path(download_path: &PathBuf, serial: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 24 ~ fn create_old_pkg_path(download_path: &Path, serial: &str) -> PathBuf { [INFO] [stdout] 25 ~ let mut target_path = download_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:30:43 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn create_new_pkg_path(download_path: &PathBuf, serial: &str, title: &str) -> PathBuf { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 ~ pub fn create_new_pkg_path(download_path: &Path, serial: &str, title: &str) -> PathBuf { [INFO] [stdout] 31 ~ let mut target_path = download_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:38:71 [INFO] [stdout] | [INFO] [stdout] 38 | let mut target_path = create_new_pkg_path(&download_path, serial, &title); [INFO] [stdout] | ^^^^^^ help: change this to: `title` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/utils.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 64 | return Err(DownloadError::Tokio(io::Error::new(io::ErrorKind::Other, "Target path has no parent directory"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 64 - return Err(DownloadError::Tokio(io::Error::new(io::ErrorKind::Other, "Target path has no parent directory"))); [INFO] [stdout] 64 + return Err(DownloadError::Tokio(io::Error::other("Target path has no parent directory"))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/utils.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | processed_length = processed_length + chunk_length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `processed_length += chunk_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/utils.rs:115:38 [INFO] [stdout] | [INFO] [stdout] 115 | let last_before_suffix = (file_length_without_suffix - previously_processed_length) [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 116 | | .try_into() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | &chunk_buffer [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `chunk_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:123:23 [INFO] [stdout] | [INFO] [stdout] 123 | hasher.update(&hashable_buffer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `hashable_buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/egui/mod.rs:527:53 [INFO] [stdout] | [INFO] [stdout] 527 | if self.get_active_download(&title_id, pkg).is_none() { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `title_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:538:21 [INFO] [stdout] | [INFO] [stdout] 538 | return self.pkg_download_status(title_id, pkg) == ActiveDownloadStatus::Completed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return self.pkg_download_status(title_id, pkg) == ActiveDownloadStatus::Completed; [INFO] [stdout] 538 + self.pkg_download_status(title_id, pkg) == ActiveDownloadStatus::Completed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/egui/mod.rs:596:40 [INFO] [stdout] | [INFO] [stdout] 596 | let download_enabled = match download_status { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 597 | | ActiveDownloadStatus::Downloading(_) | ActiveDownloadStatus::Verifying => false, [INFO] [stdout] 598 | | _ => true [INFO] [stdout] 599 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 596 - let download_enabled = match download_status { [INFO] [stdout] 597 - ActiveDownloadStatus::Downloading(_) | ActiveDownloadStatus::Verifying => false, [INFO] [stdout] 598 - _ => true [INFO] [stdout] 599 - }; [INFO] [stdout] 596 + let download_enabled = !matches!(download_status, ActiveDownloadStatus::Downloading(_) | ActiveDownloadStatus::Verifying); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:738:9 [INFO] [stdout] | [INFO] [stdout] 738 | / return self.v.download_queue [INFO] [stdout] 739 | | .iter() [INFO] [stdout] 740 | | .find(| d | d.title_id == title_id && d.pkg_id == pkg.id()); [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 738 ~ self.v.download_queue [INFO] [stdout] 739 + .iter() [INFO] [stdout] 740 ~ .find(| d | d.title_id == title_id && d.pkg_id == pkg.id()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:744:9 [INFO] [stdout] | [INFO] [stdout] 744 | / return self.v.merge_queue [INFO] [stdout] 745 | | .iter() [INFO] [stdout] 746 | | .find(| d | d.title_id == title_id); [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 744 ~ self.v.merge_queue [INFO] [stdout] 745 + .iter() [INFO] [stdout] 746 ~ .find(| d | d.title_id == title_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:759:9 [INFO] [stdout] | [INFO] [stdout] 759 | return ActiveMergeStatus::NotStarted; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 759 - return ActiveMergeStatus::NotStarted; [INFO] [stdout] 759 + ActiveMergeStatus::NotStarted [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/egui/mod.rs:753:19 [INFO] [stdout] | [INFO] [stdout] 753 | } else if self.v.completed_merges.iter().any(|id| *id == update.title_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.v.completed_merges.contains(&update.title_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/egui/mod.rs:755:19 [INFO] [stdout] | [INFO] [stdout] 755 | } else if self.v.failed_merges.iter().any(|id| *id == update.title_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.v.failed_merges.contains(&update.title_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:779:17 [INFO] [stdout] | [INFO] [stdout] 779 | return ActiveDownloadStatus::Downloading(download.progress as f32 / download.size as f32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 779 - return ActiveDownloadStatus::Downloading(download.progress as f32 / download.size as f32) [INFO] [stdout] 779 + ActiveDownloadStatus::Downloading(download.progress as f32 / download.size as f32) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | return ActiveDownloadStatus::Verifying [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 782 - return ActiveDownloadStatus::Verifying [INFO] [stdout] 782 + ActiveDownloadStatus::Verifying [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:785:17 [INFO] [stdout] | [INFO] [stdout] 785 | return ActiveDownloadStatus::NotStarted [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 785 - return ActiveDownloadStatus::NotStarted [INFO] [stdout] 785 + ActiveDownloadStatus::NotStarted [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:810:9 [INFO] [stdout] | [INFO] [stdout] 810 | return ActiveMergeStatus::NotStarted [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 810 - return ActiveMergeStatus::NotStarted [INFO] [stdout] 810 + ActiveMergeStatus::NotStarted [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/egui/mod.rs:527:53 [INFO] [stdout] | [INFO] [stdout] 527 | if self.get_active_download(&title_id, pkg).is_none() { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `title_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:538:21 [INFO] [stdout] | [INFO] [stdout] 538 | return self.pkg_download_status(title_id, pkg) == ActiveDownloadStatus::Completed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 538 - return self.pkg_download_status(title_id, pkg) == ActiveDownloadStatus::Completed; [INFO] [stdout] 538 + self.pkg_download_status(title_id, pkg) == ActiveDownloadStatus::Completed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/egui/mod.rs:596:40 [INFO] [stdout] | [INFO] [stdout] 596 | let download_enabled = match download_status { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 597 | | ActiveDownloadStatus::Downloading(_) | ActiveDownloadStatus::Verifying => false, [INFO] [stdout] 598 | | _ => true [INFO] [stdout] 599 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 596 - let download_enabled = match download_status { [INFO] [stdout] 597 - ActiveDownloadStatus::Downloading(_) | ActiveDownloadStatus::Verifying => false, [INFO] [stdout] 598 - _ => true [INFO] [stdout] 599 - }; [INFO] [stdout] 596 + let download_enabled = !matches!(download_status, ActiveDownloadStatus::Downloading(_) | ActiveDownloadStatus::Verifying); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:738:9 [INFO] [stdout] | [INFO] [stdout] 738 | / return self.v.download_queue [INFO] [stdout] 739 | | .iter() [INFO] [stdout] 740 | | .find(| d | d.title_id == title_id && d.pkg_id == pkg.id()); [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 738 ~ self.v.download_queue [INFO] [stdout] 739 + .iter() [INFO] [stdout] 740 ~ .find(| d | d.title_id == title_id && d.pkg_id == pkg.id()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:744:9 [INFO] [stdout] | [INFO] [stdout] 744 | / return self.v.merge_queue [INFO] [stdout] 745 | | .iter() [INFO] [stdout] 746 | | .find(| d | d.title_id == title_id); [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 744 ~ self.v.merge_queue [INFO] [stdout] 745 + .iter() [INFO] [stdout] 746 ~ .find(| d | d.title_id == title_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:759:9 [INFO] [stdout] | [INFO] [stdout] 759 | return ActiveMergeStatus::NotStarted; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 759 - return ActiveMergeStatus::NotStarted; [INFO] [stdout] 759 + ActiveMergeStatus::NotStarted [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/egui/mod.rs:753:19 [INFO] [stdout] | [INFO] [stdout] 753 | } else if self.v.completed_merges.iter().any(|id| *id == update.title_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.v.completed_merges.contains(&update.title_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/egui/mod.rs:755:19 [INFO] [stdout] | [INFO] [stdout] 755 | } else if self.v.failed_merges.iter().any(|id| *id == update.title_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.v.failed_merges.contains(&update.title_id)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:779:17 [INFO] [stdout] | [INFO] [stdout] 779 | return ActiveDownloadStatus::Downloading(download.progress as f32 / download.size as f32) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 779 - return ActiveDownloadStatus::Downloading(download.progress as f32 / download.size as f32) [INFO] [stdout] 779 + ActiveDownloadStatus::Downloading(download.progress as f32 / download.size as f32) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:782:17 [INFO] [stdout] | [INFO] [stdout] 782 | return ActiveDownloadStatus::Verifying [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 782 - return ActiveDownloadStatus::Verifying [INFO] [stdout] 782 + ActiveDownloadStatus::Verifying [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:785:17 [INFO] [stdout] | [INFO] [stdout] 785 | return ActiveDownloadStatus::NotStarted [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 785 - return ActiveDownloadStatus::NotStarted [INFO] [stdout] 785 + ActiveDownloadStatus::NotStarted [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egui/mod.rs:810:9 [INFO] [stdout] | [INFO] [stdout] 810 | return ActiveMergeStatus::NotStarted [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 810 - return ActiveMergeStatus::NotStarted [INFO] [stdout] 810 + ActiveMergeStatus::NotStarted [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 59.50s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: ashpd v0.8.1, document-features v0.2.8 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "96730205c903e3215261cfb52226551fd5ef4a4c0bd5503fde2a773020d8167c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96730205c903e3215261cfb52226551fd5ef4a4c0bd5503fde2a773020d8167c", kill_on_drop: false }` [INFO] [stdout] 96730205c903e3215261cfb52226551fd5ef4a4c0bd5503fde2a773020d8167c