[INFO] cloning repository https://github.com/selassje/chip8-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/selassje/chip8-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fselassje%2Fchip8-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fselassje%2Fchip8-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c3d8b1b0d348361a53fe68f518834b22e979a03e [INFO] linting selassje/chip8-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fselassje%2Fchip8-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/selassje/chip8-rs [INFO] finished tweaking git repo https://github.com/selassje/chip8-rs [INFO] tweaked toml for git repo https://github.com/selassje/chip8-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/selassje/chip8-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/selassje/chip8-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 [INFO] [stderr] Adding c_vec v1.3.3 [INFO] [stderr] Adding cfg-if v1.0.4 [INFO] [stderr] Adding cloudabi v0.0.3 [INFO] [stderr] Adding fuchsia-cprng v0.1.1 [INFO] [stderr] Adding getrandom v0.1.16 [INFO] [stderr] Updating libc v0.2.62 -> v0.2.183 [INFO] [stderr] Downgrading num v0.2.0 -> v0.1.43 [INFO] [stderr] Adding ppv-lite86 v0.2.21 [INFO] [stderr] Adding proc-macro2 v1.0.106 [INFO] [stderr] Adding quote v1.0.45 [INFO] [stderr] Adding rand v0.6.5 [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.0) [INFO] [stderr] Adding rand_chacha v0.1.1 [INFO] [stderr] Adding rand_chacha v0.2.2 [INFO] [stderr] Adding rand_core v0.3.1 [INFO] [stderr] Adding rand_core v0.4.2 [INFO] [stderr] Adding rand_core v0.5.1 [INFO] [stderr] Adding rand_hc v0.1.0 [INFO] [stderr] Adding rand_hc v0.2.0 [INFO] [stderr] Adding rand_isaac v0.1.1 [INFO] [stderr] Adding rand_jitter v0.1.4 [INFO] [stderr] Adding rand_os v0.1.3 [INFO] [stderr] Adding rand_pcg v0.1.2 [INFO] [stderr] Adding rand_xorshift v0.1.1 [INFO] [stderr] Adding rdrand v0.4.0 [INFO] [stderr] Adding sdl2 v0.32.2 (available: v0.38.0) [INFO] [stderr] Adding sdl2-sys v0.32.6 [INFO] [stderr] Adding syn v2.0.117 [INFO] [stderr] Adding unicode-ident v1.0.24 [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 [INFO] [stderr] Adding zerocopy v0.8.42 [INFO] [stderr] Adding zerocopy-derive v0.8.42 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded c_vec v1.3.3 [INFO] [stderr] Downloaded num v0.1.43 [INFO] [stderr] Downloaded autocfg v0.1.6 [INFO] [stderr] Downloaded sdl2 v0.32.2 [INFO] [stderr] Downloaded sdl2-sys v0.32.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0fe29454bb463c2ec44ea3fc7a2441a149b36a3ad67d3ac357bb18ab51090cf5 [INFO] running `Command { std: "docker" "start" "-a" "0fe29454bb463c2ec44ea3fc7a2441a149b36a3ad67d3ac357bb18ab51090cf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0fe29454bb463c2ec44ea3fc7a2441a149b36a3ad67d3ac357bb18ab51090cf5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0fe29454bb463c2ec44ea3fc7a2441a149b36a3ad67d3ac357bb18ab51090cf5", kill_on_drop: false }` [INFO] [stdout] 0fe29454bb463c2ec44ea3fc7a2441a149b36a3ad67d3ac357bb18ab51090cf5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a170e3ff92d374876140288c1cf817cc7f32e482e6cff9c66825fbcf1b666096 [INFO] running `Command { std: "docker" "start" "-a" "a170e3ff92d374876140288c1cf817cc7f32e482e6cff9c66825fbcf1b666096", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling cfg-if v0.1.9 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking c_vec v1.3.3 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking num v0.1.43 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chip-8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | ram : ram, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | screen_tx : screen_tx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | keyboard_rx : keyboard_rx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyboard_rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | audio_tx : audio_tx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | ram : ram, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | screen_tx : screen_tx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | keyboard_rx : keyboard_rx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyboard_rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cpu.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | audio_tx : audio_tx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/io_sdl.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | } else [INFO] [stdout] | ______________________^ [INFO] [stdout] 119 | | { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/audio.rs:47:11 [INFO] [stdout] | [INFO] [stdout] 47 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is an `else {..}` but the formatting might hide it [INFO] [stdout] --> src/io_sdl.rs:118:22 [INFO] [stdout] | [INFO] [stdout] 118 | } else [INFO] [stdout] | ______________________^ [INFO] [stdout] 119 | | { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, remove the `else` or remove the new line between `else` and `{..}` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stdout] = note: `#[warn(clippy::suspicious_else_formatting)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/audio.rs:47:11 [INFO] [stdout] | [INFO] [stdout] 47 | device: device, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ScreenController` is never used [INFO] [stdout] --> src/screen.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait ScreenController [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RAM` contains a capitalized acronym [INFO] [stdout] --> src/memory.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct RAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/memory.rs:15:55 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn store_bytes(&mut self, addr : u16, bytes : &Vec){ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - pub fn store_bytes(&mut self, addr : u16, bytes : &Vec){ [INFO] [stdout] 15 + pub fn store_bytes(&mut self, addr : u16, bytes : &[u8]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct CPU<'a> [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 65 | let mut ins = [0 as u8;4]; [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ScreenController` is never used [INFO] [stdout] --> src/screen.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait ScreenController [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RAM` contains a capitalized acronym [INFO] [stdout] --> src/memory.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct RAM { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ram` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/memory.rs:15:55 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn store_bytes(&mut self, addr : u16, bytes : &Vec){ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - pub fn store_bytes(&mut self, addr : u16, bytes : &Vec){ [INFO] [stdout] 15 + pub fn store_bytes(&mut self, addr : u16, bytes : &[u8]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct CPU<'a> [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/cpu.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 65 | let mut ins = [0 as u8;4]; [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:562:47 [INFO] [stdout] | [INFO] [stdout] 562 | self.screen[disp_x][disp_y] = ! (bit == self.screen[disp_x][disp_y]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bit != self.screen[disp_x][disp_y])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:562:47 [INFO] [stdout] | [INFO] [stdout] 562 | self.screen[disp_x][disp_y] = ! (bit == self.screen[disp_x][disp_y]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bit != self.screen[disp_x][disp_y])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/io_sdl.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | / if keycode == Keycode::Escape { [INFO] [stdout] 86 | | break 'main [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ Event::KeyDown {keycode: Some(keycode), ..} [INFO] [stdout] 85 ~ if keycode == Keycode::Escape => { [INFO] [stdout] 86 | break 'main [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/io_sdl.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 125 | if let Ok(_) = self.audio_rx.try_recv() { [INFO] [stdout] | -------^^^^^--------------------------- help: try: `if self.audio_rx.try_recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:17:31 [INFO] [stdout] | [INFO] [stdout] 17 | let mut file = File::open(&file_name).expect("Unable to open ROM"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/io_sdl.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | / if keycode == Keycode::Escape { [INFO] [stdout] 86 | | break 'main [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ Event::KeyDown {keycode: Some(keycode), ..} [INFO] [stdout] 85 ~ if keycode == Keycode::Escape => { [INFO] [stdout] 86 | break 'main [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/io_sdl.rs:125:20 [INFO] [stdout] | [INFO] [stdout] 125 | if let Ok(_) = self.audio_rx.try_recv() { [INFO] [stdout] | -------^^^^^--------------------------- help: try: `if self.audio_rx.try_recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:17:31 [INFO] [stdout] | [INFO] [stdout] 17 | let mut file = File::open(&file_name).expect("Unable to open ROM"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.70s [INFO] running `Command { std: "docker" "inspect" "a170e3ff92d374876140288c1cf817cc7f32e482e6cff9c66825fbcf1b666096", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a170e3ff92d374876140288c1cf817cc7f32e482e6cff9c66825fbcf1b666096", kill_on_drop: false }` [INFO] [stdout] a170e3ff92d374876140288c1cf817cc7f32e482e6cff9c66825fbcf1b666096