[INFO] cloning repository https://github.com/seemethere/aoc2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/seemethere/aoc2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fseemethere%2Faoc2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fseemethere%2Faoc2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 662e6f74f06e1318c51e0048ee20cdfd9126fd19 [INFO] linting seemethere/aoc2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fseemethere%2Faoc2024" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/seemethere/aoc2024 [INFO] finished tweaking git repo https://github.com/seemethere/aoc2024 [INFO] tweaked toml for git repo https://github.com/seemethere/aoc2024 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/seemethere/aoc2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/seemethere/aoc2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a4fdb19e387e72652d722aa1c97bb6035576cba59d2ff91edbff1a6dd19e874 [INFO] running `Command { std: "docker" "start" "-a" "1a4fdb19e387e72652d722aa1c97bb6035576cba59d2ff91edbff1a6dd19e874", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a4fdb19e387e72652d722aa1c97bb6035576cba59d2ff91edbff1a6dd19e874", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a4fdb19e387e72652d722aa1c97bb6035576cba59d2ff91edbff1a6dd19e874", kill_on_drop: false }` [INFO] [stdout] 1a4fdb19e387e72652d722aa1c97bb6035576cba59d2ff91edbff1a6dd19e874 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9f0aa0cb7d2b3892fab1deec1232c05e23e00084615eed9df29c7fabe7812e85 [INFO] running `Command { std: "docker" "start" "-a" "9f0aa0cb7d2b3892fab1deec1232c05e23e00084615eed9df29c7fabe7812e85", kill_on_drop: false }` [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking aoc2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return Ok((list1, list2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Ok((list1, list2)); [INFO] [stdout] 32 + Ok((list1, list2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return input_vec.iter().cloned().sorted().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return input_vec.iter().cloned().sorted().collect(); [INFO] [stdout] 36 + input_vec.iter().cloned().sorted().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day1.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | fn sort_vector(input_vec: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 35 - fn sort_vector(input_vec: &Vec) -> Vec { [INFO] [stdout] 35 + fn sort_vector(input_vec: &[i32]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return total_distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return total_distance; [INFO] [stdout] 48 + total_distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return similarity_score; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return similarity_score; [INFO] [stdout] 67 + similarity_score [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day1.rs:51:54 [INFO] [stdout] | [INFO] [stdout] 51 | fn compute_similarity_score(list1: &Vec, list2: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - fn compute_similarity_score(list1: &Vec, list2: &Vec) -> i32 { [INFO] [stdout] 51 + fn compute_similarity_score(list1: &Vec, list2: &[i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | if occurence_map.contains_key(&x) { [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:57:52 [INFO] [stdout] | [INFO] [stdout] 57 | occurence_map.insert(*x, occurence_map[&x] + 1); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:63:39 [INFO] [stdout] | [INFO] [stdout] 63 | if occurence_map.contains_key(&key) { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:64:53 [INFO] [stdout] | [INFO] [stdout] 64 | similarity_score += key * occurence_map[&key]; [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return Ok(list); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(list); [INFO] [stdout] 25 + Ok(list) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return true; [INFO] [stdout] 39 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return true; [INFO] [stdout] 54 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day2.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | fn vector_is_safe(vec: &Vec, dampener: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn vector_is_safe(vec: &Vec, dampener: i32) -> bool { [INFO] [stdout] 42 + fn vector_is_safe(vec: &[i32], dampener: i32) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return safe_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return safe_count; [INFO] [stdout] 64 + safe_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day3.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return fs::read_to_string(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return fs::read_to_string(path); [INFO] [stdout] 15 + fs::read_to_string(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day3.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return result; [INFO] [stdout] 26 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day3.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return result; [INFO] [stdout] 49 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day4.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return Ok(list); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return Ok(list); [INFO] [stdout] 22 + Ok(list) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day4.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | ... if inner_x as usize > input.len() - 1 [INFO] [stdout] | __________________________^ [INFO] [stdout] 48 | | ... || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 | | ... || inner_x < 0 [INFO] [stdout] 50 | | ... || inner_x < 0 [INFO] [stdout] 51 | | ... || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] | |_________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 51 - || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] 47 + if !(inner_x as usize <= input.len() - 1 && inner_y as usize <= input.len() - 1 && inner_x >= 0 && input[inner_x as usize][inner_y as usize] == word_vec[w + 1]) [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 51 - || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] 47 + if inner_x as usize > input.len() - 1 || inner_y as usize > input.len() - 1 || inner_x < 0 || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day4.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | ... if inner_x as usize > input.len() - 1 [INFO] [stdout] | __________________________^ [INFO] [stdout] 48 | | ... || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 | | ... || inner_x < 0 [INFO] [stdout] 50 | | ... || inner_x < 0 [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 47 + if !(inner_x as usize <= input.len() - 1 && inner_y as usize <= input.len() - 1 && inner_x >= 0) [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 47 + if inner_x as usize > input.len() - 1 || inner_y as usize > input.len() - 1 || inner_x < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day4.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return num_found; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return num_found; [INFO] [stdout] 65 + num_found [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/days/day1.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | impl Day1Command { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return Ok((list1, list2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Ok((list1, list2)); [INFO] [stdout] 32 + Ok((list1, list2)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return input_vec.iter().cloned().sorted().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return input_vec.iter().cloned().sorted().collect(); [INFO] [stdout] 36 + input_vec.iter().cloned().sorted().collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day1.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | fn sort_vector(input_vec: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 35 - fn sort_vector(input_vec: &Vec) -> Vec { [INFO] [stdout] 35 + fn sort_vector(input_vec: &[i32]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return total_distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return total_distance; [INFO] [stdout] 48 + total_distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day1.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return similarity_score; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return similarity_score; [INFO] [stdout] 67 + similarity_score [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day1.rs:51:54 [INFO] [stdout] | [INFO] [stdout] 51 | fn compute_similarity_score(list1: &Vec, list2: &Vec) -> i32 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 51 - fn compute_similarity_score(list1: &Vec, list2: &Vec) -> i32 { [INFO] [stdout] 51 + fn compute_similarity_score(list1: &Vec, list2: &[i32]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | if occurence_map.contains_key(&x) { [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:57:52 [INFO] [stdout] | [INFO] [stdout] 57 | occurence_map.insert(*x, occurence_map[&x] + 1); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:63:39 [INFO] [stdout] | [INFO] [stdout] 63 | if occurence_map.contains_key(&key) { [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/days/day1.rs:64:53 [INFO] [stdout] | [INFO] [stdout] 64 | similarity_score += key * occurence_map[&key]; [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/days/day2.rs:68:1 [INFO] [stdout] | [INFO] [stdout] 68 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 118 | impl Day2Command { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return Ok(list); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(list); [INFO] [stdout] 25 + Ok(list) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return true; [INFO] [stdout] 39 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return true; [INFO] [stdout] 54 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/day2.rs:42:24 [INFO] [stdout] | [INFO] [stdout] 42 | fn vector_is_safe(vec: &Vec, dampener: i32) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 42 - fn vector_is_safe(vec: &Vec, dampener: i32) -> bool { [INFO] [stdout] 42 + fn vector_is_safe(vec: &[i32], dampener: i32) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day2.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | return safe_count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return safe_count; [INFO] [stdout] 64 + safe_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(vector_is_safe(&vec![7, 6, 4, 2, 1], 0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 73 - assert_eq!(vector_is_safe(&vec![7, 6, 4, 2, 1], 0), true); [INFO] [stdout] 73 + assert!(vector_is_safe(&vec![7, 6, 4, 2, 1], 0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | assert_eq!(vector_is_safe(&vec![1, 2, 7, 8, 9], 0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 74 - assert_eq!(vector_is_safe(&vec![1, 2, 7, 8, 9], 0), false); [INFO] [stdout] 74 + assert!(!vector_is_safe(&vec![1, 2, 7, 8, 9], 0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | assert_eq!(vector_is_safe(&vec![9, 7, 6, 2, 1], 0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 75 - assert_eq!(vector_is_safe(&vec![9, 7, 6, 2, 1], 0), false); [INFO] [stdout] 75 + assert!(!vector_is_safe(&vec![9, 7, 6, 2, 1], 0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(vector_is_safe(&vec![1, 3, 2, 4, 5], 0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(vector_is_safe(&vec![1, 3, 2, 4, 5], 0), false); [INFO] [stdout] 76 + assert!(!vector_is_safe(&vec![1, 3, 2, 4, 5], 0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | assert_eq!(vector_is_safe(&vec![8, 6, 4, 4, 1], 0), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 77 - assert_eq!(vector_is_safe(&vec![8, 6, 4, 4, 1], 0), false); [INFO] [stdout] 77 + assert!(!vector_is_safe(&vec![8, 6, 4, 4, 1], 0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(vector_is_safe(&vec![1, 3, 6, 7, 9], 0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 78 - assert_eq!(vector_is_safe(&vec![1, 3, 6, 7, 9], 0), true); [INFO] [stdout] 78 + assert!(vector_is_safe(&vec![1, 3, 6, 7, 9], 0)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | assert_eq!(vector_is_safe(&vec![7, 6, 4, 2, 1], 1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 83 - assert_eq!(vector_is_safe(&vec![7, 6, 4, 2, 1], 1), true); [INFO] [stdout] 83 + assert!(vector_is_safe(&vec![7, 6, 4, 2, 1], 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | assert_eq!(vector_is_safe(&vec![1, 2, 7, 8, 9], 1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 84 - assert_eq!(vector_is_safe(&vec![1, 2, 7, 8, 9], 1), false); [INFO] [stdout] 84 + assert!(!vector_is_safe(&vec![1, 2, 7, 8, 9], 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | assert_eq!(vector_is_safe(&vec![9, 7, 6, 2, 1], 1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 85 - assert_eq!(vector_is_safe(&vec![9, 7, 6, 2, 1], 1), false); [INFO] [stdout] 85 + assert!(!vector_is_safe(&vec![9, 7, 6, 2, 1], 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | assert_eq!(vector_is_safe(&vec![1, 3, 2, 4, 5], 1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 86 - assert_eq!(vector_is_safe(&vec![1, 3, 2, 4, 5], 1), true); [INFO] [stdout] 86 + assert!(vector_is_safe(&vec![1, 3, 2, 4, 5], 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(vector_is_safe(&vec![8, 6, 4, 4, 1], 1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(vector_is_safe(&vec![8, 6, 4, 4, 1], 1), true); [INFO] [stdout] 87 + assert!(vector_is_safe(&vec![8, 6, 4, 4, 1], 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/days/day2.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | assert_eq!(vector_is_safe(&vec![1, 3, 6, 7, 9], 1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 88 - assert_eq!(vector_is_safe(&vec![1, 3, 6, 7, 9], 1), true); [INFO] [stdout] 88 + assert!(vector_is_safe(&vec![1, 3, 6, 7, 9], 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/days/day3.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 77 | impl Day3Command { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day3.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return fs::read_to_string(path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return fs::read_to_string(path); [INFO] [stdout] 15 + fs::read_to_string(path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day3.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return result; [INFO] [stdout] 26 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day3.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return result; [INFO] [stdout] 49 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/days/day4.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 99 | impl Day4Command { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day4.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | return Ok(list); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return Ok(list); [INFO] [stdout] 22 + Ok(list) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day4.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | ... if inner_x as usize > input.len() - 1 [INFO] [stdout] | __________________________^ [INFO] [stdout] 48 | | ... || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 | | ... || inner_x < 0 [INFO] [stdout] 50 | | ... || inner_x < 0 [INFO] [stdout] 51 | | ... || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] | |_________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 51 - || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] 47 + if !(inner_x as usize <= input.len() - 1 && inner_y as usize <= input.len() - 1 && inner_x >= 0 && input[inner_x as usize][inner_y as usize] == word_vec[w + 1]) [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 51 - || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] 47 + if inner_x as usize > input.len() - 1 || inner_y as usize > input.len() - 1 || inner_x < 0 || input[inner_x as usize][inner_y as usize] != word_vec[w + 1] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/day4.rs:47:32 [INFO] [stdout] | [INFO] [stdout] 47 | ... if inner_x as usize > input.len() - 1 [INFO] [stdout] | __________________________^ [INFO] [stdout] 48 | | ... || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 | | ... || inner_x < 0 [INFO] [stdout] 50 | | ... || inner_x < 0 [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 47 + if !(inner_x as usize <= input.len() - 1 && inner_y as usize <= input.len() - 1 && inner_x >= 0) [INFO] [stdout] | [INFO] [stdout] 47 - if inner_x as usize > input.len() - 1 [INFO] [stdout] 48 - || inner_y as usize > input.len() - 1 [INFO] [stdout] 49 - || inner_x < 0 [INFO] [stdout] 50 - || inner_x < 0 [INFO] [stdout] 47 + if inner_x as usize > input.len() - 1 || inner_y as usize > input.len() - 1 || inner_x < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/day4.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return num_found; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return num_found; [INFO] [stdout] 65 + num_found [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.34s [INFO] running `Command { std: "docker" "inspect" "9f0aa0cb7d2b3892fab1deec1232c05e23e00084615eed9df29c7fabe7812e85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f0aa0cb7d2b3892fab1deec1232c05e23e00084615eed9df29c7fabe7812e85", kill_on_drop: false }` [INFO] [stdout] 9f0aa0cb7d2b3892fab1deec1232c05e23e00084615eed9df29c7fabe7812e85