[INFO] cloning repository https://github.com/sebastiantuyu/rapi [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sebastiantuyu/rapi" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebastiantuyu%2Frapi", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebastiantuyu%2Frapi'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e7f73137b6289747ffcc9b9c0e4ddcc7dc0f0f76 [INFO] linting sebastiantuyu/rapi against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsebastiantuyu%2Frapi" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sebastiantuyu/rapi [INFO] finished tweaking git repo https://github.com/sebastiantuyu/rapi [INFO] tweaked toml for git repo https://github.com/sebastiantuyu/rapi written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sebastiantuyu/rapi on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sebastiantuyu/rapi already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pretty_assertions v1.4.0 [INFO] [stderr] Downloaded syn v2.0.27 [INFO] [stderr] Downloaded syn v1.0.48 [INFO] [stderr] Downloaded regex v1.9.4 [INFO] [stderr] Downloaded regex-automata v0.3.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dbe7da1b973903cda203da7b7470dd54a60c173e48cf07f9cbfd5d08b3f2b8b0 [INFO] running `Command { std: "docker" "start" "-a" "dbe7da1b973903cda203da7b7470dd54a60c173e48cf07f9cbfd5d08b3f2b8b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dbe7da1b973903cda203da7b7470dd54a60c173e48cf07f9cbfd5d08b3f2b8b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbe7da1b973903cda203da7b7470dd54a60c173e48cf07f9cbfd5d08b3f2b8b0", kill_on_drop: false }` [INFO] [stdout] dbe7da1b973903cda203da7b7470dd54a60c173e48cf07f9cbfd5d08b3f2b8b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f8135edec627fbd4f3d11413c3becbc0d1688a820bca4e39db51b684cdc5b69e [INFO] running `Command { std: "docker" "start" "-a" "f8135edec627fbd4f3d11413c3becbc0d1688a820bca4e39db51b684cdc5b69e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.27 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking regex-automata v0.3.7 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking regex v1.9.4 [INFO] [stderr] Checking http-server-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `base_url` is never read [INFO] [stdout] --> src/server.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct ServerOptions { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 4 | pub base_url: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `base_url` is never read [INFO] [stdout] --> src/server.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct ServerOptions { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 4 | pub base_url: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:6:45 [INFO] [stdout] | [INFO] [stdout] 6 | let raw_request = String::from_utf8_lossy(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:6:45 [INFO] [stdout] | [INFO] [stdout] 6 | let raw_request = String::from_utf8_lossy(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/parser.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | / if body_char == &'\r' { [INFO] [stdout] 41 | | // consume '\r' [INFO] [stdout] 42 | | char_request.next(); [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 39 ~ Some(body_char) [INFO] [stdout] 40 ~ if body_char == &'\r' => { [INFO] [stdout] 41 | // consume '\r' [INFO] [stdout] ... [INFO] [stdout] 50 | } [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/parser.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 37 | / match char_request.peek() { [INFO] [stdout] 38 | | // actual consume of the body [INFO] [stdout] 39 | | Some(body_char) => { [INFO] [stdout] 40 | | if body_char == &'\r' { [INFO] [stdout] ... | [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Some(body_char) = char_request.peek() { [INFO] [stdout] 38 + if body_char == &'\r' { [INFO] [stdout] 39 + // consume '\r' [INFO] [stdout] 40 + char_request.next(); [INFO] [stdout] 41 + // consume '\n' [INFO] [stdout] 42 + char_request.next(); [INFO] [stdout] 43 + while let Some(bc) = char_request.peek() { [INFO] [stdout] 44 + if bc == &'\r' { [INFO] [stdout] 45 + break; [INFO] [stdout] 46 + } [INFO] [stdout] 47 + body += &char_request.next().unwrap().to_string(); [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:59:14 [INFO] [stdout] | [INFO] [stdout] 59 | if sections.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sections.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/parser.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | / if body_char == &'\r' { [INFO] [stdout] 41 | | // consume '\r' [INFO] [stdout] 42 | | char_request.next(); [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 39 ~ Some(body_char) [INFO] [stdout] 40 ~ if body_char == &'\r' => { [INFO] [stdout] 41 | // consume '\r' [INFO] [stdout] ... [INFO] [stdout] 50 | } [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/parser.rs:37:11 [INFO] [stdout] | [INFO] [stdout] 37 | / match char_request.peek() { [INFO] [stdout] 38 | | // actual consume of the body [INFO] [stdout] 39 | | Some(body_char) => { [INFO] [stdout] 40 | | if body_char == &'\r' { [INFO] [stdout] ... | [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ if let Some(body_char) = char_request.peek() { [INFO] [stdout] 38 + if body_char == &'\r' { [INFO] [stdout] 39 + // consume '\r' [INFO] [stdout] 40 + char_request.next(); [INFO] [stdout] 41 + // consume '\n' [INFO] [stdout] 42 + char_request.next(); [INFO] [stdout] 43 + while let Some(bc) = char_request.peek() { [INFO] [stdout] 44 + if bc == &'\r' { [INFO] [stdout] 45 + break; [INFO] [stdout] 46 + } [INFO] [stdout] 47 + body += &char_request.next().unwrap().to_string(); [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] 50 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:59:14 [INFO] [stdout] | [INFO] [stdout] 59 | if sections.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `sections.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/request.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn to_request(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/request.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn to_request(&mut self) -> Option { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/request.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | if self.parsed.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.parsed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/request.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | if self.parsed.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.parsed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/dispatcher.rs:76:65 [INFO] [stdout] | [INFO] [stdout] 76 | let target_addr = format!("{addr}/{}", req.params[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/dispatcher.rs:76:65 [INFO] [stdout] | [INFO] [stdout] 76 | let target_addr = format!("{addr}/{}", req.params[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/dispatcher.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match req.get_context() { [INFO] [stdout] 96 | | Some(v) => { base_url = v.to_string(); } [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(v) = req.get_context() { base_url = v.to_string(); }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/dispatcher.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / match req.get_context() { [INFO] [stdout] 96 | | Some(v) => { base_url = v.to_string(); } [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(v) = req.get_context() { base_url = v.to_string(); }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/dispatcher.rs:99:63 [INFO] [stdout] | [INFO] [stdout] 99 | let file_addr = format!("{base_url}/{}", req.params[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/dispatcher.rs:99:63 [INFO] [stdout] | [INFO] [stdout] 99 | let file_addr = format!("{base_url}/{}", req.params[0].to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/dispatcher.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / match cap { [INFO] [stdout] 124 | | Some(parameter) => { [INFO] [stdout] 125 | | _ = &request.add_param(parameter.as_str().to_string()); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(parameter) = cap { [INFO] [stdout] 124 + _ = &request.add_param(parameter.as_str().to_string()); [INFO] [stdout] 125 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/dispatcher.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / match cap { [INFO] [stdout] 124 | | Some(parameter) => { [INFO] [stdout] 125 | | _ = &request.add_param(parameter.as_str().to_string()); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 123 ~ if let Some(parameter) = cap { [INFO] [stdout] 124 + _ = &request.add_param(parameter.as_str().to_string()); [INFO] [stdout] 125 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/response.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | let response: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 66 ~ [INFO] [stdout] 67 | let header_response = { [INFO] [stdout] ... [INFO] [stdout] 85 | [INFO] [stdout] 86 ~ let response: String = if raw_response.len() == 1 { [INFO] [stdout] 87 ~ raw_response[0].to_string() + "\r\n\r\n" [INFO] [stdout] 88 | } else { [INFO] [stdout] 89 ~ raw_response.join("\r\n") [INFO] [stdout] 90 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/response.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | let response: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `response` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 66 ~ [INFO] [stdout] 67 | let header_response = { [INFO] [stdout] ... [INFO] [stdout] 85 | [INFO] [stdout] 86 ~ let response: String = if raw_response.len() == 1 { [INFO] [stdout] 87 ~ raw_response[0].to_string() + "\r\n\r\n" [INFO] [stdout] 88 | } else { [INFO] [stdout] 89 ~ raw_response.join("\r\n") [INFO] [stdout] 90 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/response.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | format!("Content-Type: text/plain"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Content-Type: text/plain".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/response.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | format!("Content-Type: text/plain"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Content-Type: text/plain".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/response.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | format!(""), [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/response.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | format!("{}", body), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `body.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:25:34 [INFO] [stdout] | [INFO] [stdout] 25 | if self.options.is_none() && !base_url.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `base_url.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/response.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | format!(""), [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/response.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | format!("{}", body), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `body.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:25:34 [INFO] [stdout] | [INFO] [stdout] 25 | if self.options.is_none() && !base_url.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `base_url.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `base_url` after checking its variant with `is_none` [INFO] [stdout] --> src/server.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | if self.options.is_none() && !base_url.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 26 | self.options = Some(ServerOptions { [INFO] [stdout] 27 | base_url: base_url.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `base_url` after checking its variant with `is_none` [INFO] [stdout] --> src/server.rs:27:19 [INFO] [stdout] | [INFO] [stdout] 25 | if self.options.is_none() && !base_url.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 26 | self.options = Some(ServerOptions { [INFO] [stdout] 27 | base_url: base_url.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/server.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | / match stream_incoming { [INFO] [stdout] 43 | | Ok(stream) => { [INFO] [stdout] 44 | | _ = cb(stream); [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ if let Ok(stream) = stream_incoming { [INFO] [stdout] 43 + _ = cb(stream); [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/server.rs:42:7 [INFO] [stdout] | [INFO] [stdout] 42 | / match stream_incoming { [INFO] [stdout] 43 | | Ok(stream) => { [INFO] [stdout] 44 | | _ = cb(stream); [INFO] [stdout] ... | [INFO] [stdout] 47 | | } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ if let Ok(stream) = stream_incoming { [INFO] [stdout] 43 + _ = cb(stream); [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/server.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | _ = cb(stream); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 44 - _ = cb(stream); [INFO] [stdout] 44 + cb(stream); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/options.rs:14:35 [INFO] [stdout] | [INFO] [stdout] 14 | for (_, argument) in args.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 14 - for (_, argument) in args.iter().enumerate() { [INFO] [stdout] 14 + for argument in args.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/server.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | _ = cb(stream); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 44 - _ = cb(stream); [INFO] [stdout] 44 + cb(stream); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/options.rs:14:35 [INFO] [stdout] | [INFO] [stdout] 14 | for (_, argument) in args.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 14 - for (_, argument) in args.iter().enumerate() { [INFO] [stdout] 14 + for argument in args.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/response.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 39 | let raw_response = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 40 | | format!("HTTP/1.1 {} {}", self.data.status, header_response), [INFO] [stdout] 41 | | format!("Content-Type: application/octet-stream"), [INFO] [stdout] 42 | | format!("Content-Length: {}", data.len()), [INFO] [stdout] 43 | | "\r\n".to_string(), [INFO] [stdout] 44 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 39 ~ let raw_response = [format!("HTTP/1.1 {} {}", self.data.status, header_response), [INFO] [stdout] 40 + format!("Content-Type: application/octet-stream"), [INFO] [stdout] 41 + format!("Content-Length: {}", data.len()), [INFO] [stdout] 42 ~ "\r\n".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/response.rs:39:24 [INFO] [stdout] | [INFO] [stdout] 39 | let raw_response = vec![ [INFO] [stdout] | ________________________^ [INFO] [stdout] 40 | | format!("HTTP/1.1 {} {}", self.data.status, header_response), [INFO] [stdout] 41 | | format!("Content-Type: application/octet-stream"), [INFO] [stdout] 42 | | format!("Content-Length: {}", data.len()), [INFO] [stdout] 43 | | "\r\n".to_string(), [INFO] [stdout] 44 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 39 ~ let raw_response = [format!("HTTP/1.1 {} {}", self.data.status, header_response), [INFO] [stdout] 40 + format!("Content-Type: application/octet-stream"), [INFO] [stdout] 41 + format!("Content-Length: {}", data.len()), [INFO] [stdout] 42 ~ "\r\n".to_string()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.87s [INFO] running `Command { std: "docker" "inspect" "f8135edec627fbd4f3d11413c3becbc0d1688a820bca4e39db51b684cdc5b69e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8135edec627fbd4f3d11413c3becbc0d1688a820bca4e39db51b684cdc5b69e", kill_on_drop: false }` [INFO] [stdout] f8135edec627fbd4f3d11413c3becbc0d1688a820bca4e39db51b684cdc5b69e