[INFO] cloning repository https://github.com/seb-odessa/evetech [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/seb-odessa/evetech" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fseb-odessa%2Fevetech", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fseb-odessa%2Fevetech'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab06768471f4cbb0627ea3fa0bbad3ee112d3049 [INFO] linting seb-odessa/evetech against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fseb-odessa%2Fevetech" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/seb-odessa/evetech [INFO] finished tweaking git repo https://github.com/seb-odessa/evetech [INFO] tweaked toml for git repo https://github.com/seb-odessa/evetech written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/seb-odessa/evetech on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 355 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding itertools v0.13.0 (available: v0.14.0) [INFO] [stderr] Adding reqwest v0.12.28 (available: v0.13.2) [INFO] [stderr] Adding tokio-tungstenite v0.24.0 (available: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded colorchoice v1.0.5 [INFO] [stderr] Downloaded diesel_migrations v2.3.1 [INFO] [stderr] Downloaded migrations_macros v2.3.0 [INFO] [stderr] Downloaded migrations_internals v2.3.0 [INFO] [stderr] Downloaded anstyle v1.0.14 [INFO] [stderr] Downloaded docopt v1.1.1 [INFO] [stderr] Downloaded septem v1.1.0 [INFO] [stderr] Downloaded actix-cors v0.7.1 [INFO] [stderr] Downloaded actix-router v0.5.4 [INFO] [stderr] Downloaded rsqlite-vfs v0.1.0 [INFO] [stderr] Downloaded actix-files v0.6.10 [INFO] [stderr] Downloaded websockets v0.3.0 [INFO] [stderr] Downloaded actix-http v3.12.0 [INFO] [stderr] Downloaded diesel_derives v2.3.7 [INFO] [stderr] Downloaded actix-web v4.13.0 [INFO] [stderr] Downloaded sqlite-wasm-rs v0.5.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cc34ed9f9363940a68a8ad953f8a0a7df566c533bb01c012f09f87ca6c3d59dd [INFO] running `Command { std: "docker" "start" "-a" "cc34ed9f9363940a68a8ad953f8a0a7df566c533bb01c012f09f87ca6c3d59dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cc34ed9f9363940a68a8ad953f8a0a7df566c533bb01c012f09f87ca6c3d59dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc34ed9f9363940a68a8ad953f8a0a7df566c533bb01c012f09f87ca6c3d59dd", kill_on_drop: false }` [INFO] [stdout] cc34ed9f9363940a68a8ad953f8a0a7df566c533bb01c012f09f87ca6c3d59dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4195fa57b6deb2498fd504692ea3b40df07631a85fbaebf9e6723a4444efdec [INFO] running `Command { std: "docker" "start" "-a" "f4195fa57b6deb2498fd504692ea3b40df07631a85fbaebf9e6723a4444efdec", kill_on_drop: false }` [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling tracing-core v0.1.36 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking bytestring v1.5.0 [INFO] [stderr] Checking actix-service v2.0.3 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling regex-lite v0.1.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Compiling libsqlite3-sys v0.36.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling diesel_derives v2.3.7 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.3.0 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking anstyle v1.0.14 [INFO] [stderr] Checking colorchoice v1.0.5 [INFO] [stderr] Checking downcast-rs v2.0.2 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking pest v2.8.6 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking jiff v0.2.23 [INFO] [stderr] Checking http-range v0.1.5 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking septem v1.1.0 [INFO] [stderr] Compiling actix-router v0.5.4 [INFO] [stderr] Compiling winnow v1.0.0 [INFO] [stderr] Compiling serde_spanned v1.0.4 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling dsl_auto_type v0.2.0 [INFO] [stderr] Checking env_filter v1.0.0 [INFO] [stderr] Checking handlebars v6.4.0 [INFO] [stderr] Checking docopt v1.1.1 [INFO] [stderr] Compiling toml_parser v1.0.10+spec-1.1.0 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Compiling winnow v0.7.15 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking toml v0.9.12+spec-1.1.0 [INFO] [stderr] Checking env_logger v0.11.9 [INFO] [stderr] Checking migrations_internals v2.3.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Compiling migrations_macros v2.3.0 [INFO] [stderr] Checking websockets v0.3.0 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking diesel v2.3.7 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking actix-http v3.12.0 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking actix-web v4.13.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking actix-files v0.6.10 [INFO] [stderr] Checking actix-cors v0.7.1 [INFO] [stderr] Checking evetech v0.3.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking diesel_migrations v2.3.1 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apps/route.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/common/position.rs:23:24 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn distance_to(self: &Self, other: &Self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 23 - pub fn distance_to(self: &Self, other: &Self) -> f64 { [INFO] [stdout] 23 + pub fn distance_to(&self, other: &Self) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/common/search_result.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | pub const STATUS: &'static str = "https://esi.evetech.net/latest/status"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub const MARKETS: &'static str = "https://esi.evetech.net/latest/markets"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub const KILLMAILS: &'static str = "https://esi.evetech.net/latest/killmails"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | pub const UNIVERSE: &'static str = "https://esi.evetech.net/latest/universe"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub const ALLIANCES: &'static str = "https://esi.evetech.net/latest/alliances"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | pub const CORPORATIONS: &'static str = "https://esi.evetech.net/latest/corporations"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:18:24 [INFO] [stdout] | [INFO] [stdout] 18 | pub const CHARACTERS: &'static str = "https://esi.evetech.net/latest/characters"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | pub const PARAM: &'static str = "datasource=tranquility&language=en"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/apps/route.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | start: start, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/common/position.rs:23:24 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn distance_to(self: &Self, other: &Self) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 23 - pub fn distance_to(self: &Self, other: &Self) -> f64 { [INFO] [stdout] 23 + pub fn distance_to(&self, other: &Self) -> f64 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/common/search_result.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:11:20 [INFO] [stdout] | [INFO] [stdout] 11 | pub const STATUS: &'static str = "https://esi.evetech.net/latest/status"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:12:21 [INFO] [stdout] | [INFO] [stdout] 12 | pub const MARKETS: &'static str = "https://esi.evetech.net/latest/markets"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | pub const KILLMAILS: &'static str = "https://esi.evetech.net/latest/killmails"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | pub const UNIVERSE: &'static str = "https://esi.evetech.net/latest/universe"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:16:23 [INFO] [stdout] | [INFO] [stdout] 16 | pub const ALLIANCES: &'static str = "https://esi.evetech.net/latest/alliances"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | pub const CORPORATIONS: &'static str = "https://esi.evetech.net/latest/corporations"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:18:24 [INFO] [stdout] | [INFO] [stdout] 18 | pub const CHARACTERS: &'static str = "https://esi.evetech.net/latest/characters"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/esi/mod.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 20 | pub const PARAM: &'static str = "datasource=tranquility&language=en"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/alliance/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod alliance; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/route.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return distance; [INFO] [stdout] 80 + distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/apps/route.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .expect(&format!("The {id} must be in map")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {id} must be in map"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/route.rs:76:49 [INFO] [stdout] | [INFO] [stdout] 76 | distance += current.distance_to(&waipoint); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `waipoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/route.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | current = Some(&waipoint); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `waipoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/apps/route.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | .expect(&format!("The {id} must be in map")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {id} must be in map"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/apps/route.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | .expect(&format!("The {id} must be in map")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {id} must be in map"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/apps/route.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | / if current.id != waypoint.id { [INFO] [stdout] 132 | | if !visited.contains(&waypoint.id) { [INFO] [stdout] 133 | | let distance = current.distance_to(waypoint); [INFO] [stdout] 134 | | if distance < min_distance { [INFO] [stdout] ... | [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 131 ~ if current.id != waypoint.id [INFO] [stdout] 132 ~ && !visited.contains(&waypoint.id) { [INFO] [stdout] 133 | let distance = current.distance_to(waypoint); [INFO] [stdout] ... [INFO] [stdout] 137 | } [INFO] [stdout] 138 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/apps/route.rs:148:24 [INFO] [stdout] | [INFO] [stdout] 148 | for (_, wp) in &self.waypoints { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 148 - for (_, wp) in &self.waypoints { [INFO] [stdout] 148 + for wp in self.waypoints.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/apps/mod.rs:25:32 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(id: &i32, name: &String, position: &Position) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 ~ pub fn new(id: &i32, name: &str, position: &Position) -> Self { [INFO] [stdout] 26 | let tokens = name.trim().split_whitespace().collect::>(); [INFO] [stdout] ... [INFO] [stdout] 30 | id: id.clone(), [INFO] [stdout] 31 ~ name: name.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/apps/mod.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | let tokens = name.trim().split_whitespace().collect::>(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/apps/mod.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/apps/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / if let Some(belt) = self.places.get(id) { [INFO] [stdout] 54 | | Some(belt.name.clone()) [INFO] [stdout] 55 | | } else { [INFO] [stdout] 56 | | None [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ help: try: `self.places.get(id).map(|belt| belt.name.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:61:35 [INFO] [stdout] | [INFO] [stdout] 61 | let belt = Place::new(id, &name, &position); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:61:42 [INFO] [stdout] | [INFO] [stdout] 61 | let belt = Place::new(id, &name, &position); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:64:47 [INFO] [stdout] | [INFO] [stdout] 64 | let distance = Position::distance(&position, &belt.position); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/apps/mod.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 69 | .or_insert(HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/apps/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .or_insert(HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return None; [INFO] [stdout] 87 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/apps/mod.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | if let Some(ref value) = self.distances.get(a) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if let Some(ref value) = self.distances.get(a) { [INFO] [stdout] 84 + if let Some(value) = self.distances.get(a) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return distance; [INFO] [stdout] 96 + distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return b; [INFO] [stdout] 94 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:93:47 [INFO] [stdout] | [INFO] [stdout] 93 | distance += self.distance_between(&a, &b).unwrap_or(0.0); [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:93:51 [INFO] [stdout] | [INFO] [stdout] 93 | distance += self.distance_between(&a, &b).unwrap_or(0.0); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | return (min_dist, min_route); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return (min_dist, min_route); [INFO] [stdout] 156 + (min_dist, min_route) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | return self.lazzy_walker_impl(route, points); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return self.lazzy_walker_impl(route, points); [INFO] [stdout] 175 + self.lazzy_walker_impl(route, points) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | return (minimal, route); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return (minimal, route); [INFO] [stdout] 196 + (minimal, route) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/apps/mod.rs:178:35 [INFO] [stdout] | [INFO] [stdout] 178 | fn brute_force(&self, points: &Vec) -> (f64, Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 178 - fn brute_force(&self, points: &Vec) -> (f64, Vec) { [INFO] [stdout] 178 + fn brute_force(&self, points: &[i32]) -> (f64, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/character/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod character; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/corporation/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod corporation; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common/position.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | Position::distance(&self, other) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EveApi` [INFO] [stdout] --> src/esi/api.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Self { [INFO] [stdout] 25 | | client: Client::new(), [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for EveApi { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/alliance/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod alliance; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/api.rs:88:47 [INFO] [stdout] | [INFO] [stdout] 88 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/api.rs:88:55 [INFO] [stdout] | [INFO] [stdout] 88 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/api.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/api.rs:89:53 [INFO] [stdout] | [INFO] [stdout] 89 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/route.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return distance; [INFO] [stdout] 80 + distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/apps/route.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .expect(&format!("The {id} must be in map")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {id} must be in map"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/route.rs:76:49 [INFO] [stdout] | [INFO] [stdout] 76 | distance += current.distance_to(&waipoint); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `waipoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/route.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | current = Some(&waipoint); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `waipoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/apps/route.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | .expect(&format!("The {id} must be in map")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {id} must be in map"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/apps/route.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | .expect(&format!("The {id} must be in map")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("The {id} must be in map"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/apps/route.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | / if current.id != waypoint.id { [INFO] [stdout] 132 | | if !visited.contains(&waypoint.id) { [INFO] [stdout] 133 | | let distance = current.distance_to(waypoint); [INFO] [stdout] 134 | | if distance < min_distance { [INFO] [stdout] ... | [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 131 ~ if current.id != waypoint.id [INFO] [stdout] 132 ~ && !visited.contains(&waypoint.id) { [INFO] [stdout] 133 | let distance = current.distance_to(waypoint); [INFO] [stdout] ... [INFO] [stdout] 137 | } [INFO] [stdout] 138 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/apps/route.rs:148:24 [INFO] [stdout] | [INFO] [stdout] 148 | for (_, wp) in &self.waypoints { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 148 - for (_, wp) in &self.waypoints { [INFO] [stdout] 148 + for wp in self.waypoints.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/apps/mod.rs:25:32 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(id: &i32, name: &String, position: &Position) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 25 ~ pub fn new(id: &i32, name: &str, position: &Position) -> Self { [INFO] [stdout] 26 | let tokens = name.trim().split_whitespace().collect::>(); [INFO] [stdout] ... [INFO] [stdout] 30 | id: id.clone(), [INFO] [stdout] 31 ~ name: name.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/apps/mod.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | let tokens = name.trim().split_whitespace().collect::>(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/apps/mod.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/apps/mod.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / if let Some(belt) = self.places.get(id) { [INFO] [stdout] 54 | | Some(belt.name.clone()) [INFO] [stdout] 55 | | } else { [INFO] [stdout] 56 | | None [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________^ help: try: `self.places.get(id).map(|belt| belt.name.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:61:35 [INFO] [stdout] | [INFO] [stdout] 61 | let belt = Place::new(id, &name, &position); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:61:42 [INFO] [stdout] | [INFO] [stdout] 61 | let belt = Place::new(id, &name, &position); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:64:47 [INFO] [stdout] | [INFO] [stdout] 64 | let distance = Position::distance(&position, &belt.position); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `position` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/apps/mod.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 69 | .or_insert(HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/apps/mod.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .or_insert(HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return None; [INFO] [stdout] 87 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/apps/mod.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | if let Some(ref value) = self.distances.get(a) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 84 - if let Some(ref value) = self.distances.get(a) { [INFO] [stdout] 84 + if let Some(value) = self.distances.get(a) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return distance; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return distance; [INFO] [stdout] 96 + distance [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/models/api.rs:453:10 [INFO] [stdout] | [INFO] [stdout] 453 | ) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | return b; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return b; [INFO] [stdout] 94 + b [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:93:47 [INFO] [stdout] | [INFO] [stdout] 93 | distance += self.distance_between(&a, &b).unwrap_or(0.0); [INFO] [stdout] | ^^ help: change this to: `a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/apps/mod.rs:93:51 [INFO] [stdout] | [INFO] [stdout] 93 | distance += self.distance_between(&a, &b).unwrap_or(0.0); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/models/api.rs:493:10 [INFO] [stdout] | [INFO] [stdout] 493 | ) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | return (min_dist, min_route); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return (min_dist, min_route); [INFO] [stdout] 156 + (min_dist, min_route) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | return self.lazzy_walker_impl(route, points); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 175 - return self.lazzy_walker_impl(route, points); [INFO] [stdout] 175 + self.lazzy_walker_impl(route, points) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/apps/mod.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | return (minimal, route); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return (minimal, route); [INFO] [stdout] 196 + (minimal, route) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/apps/mod.rs:178:35 [INFO] [stdout] | [INFO] [stdout] 178 | fn brute_force(&self, points: &Vec) -> (f64, Vec) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 178 - fn brute_force(&self, points: &Vec) -> (f64, Vec) { [INFO] [stdout] 178 + fn brute_force(&self, points: &[i32]) -> (f64, Vec) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/character/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod character; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/models/attacker.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | impl Into for Attacker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 38 ~ impl From for killmails::Attacker { [INFO] [stdout] 39 ~ fn from(val: Attacker) -> Self { [INFO] [stdout] 40 | killmails::Attacker { [INFO] [stdout] 41 ~ character_id: as_option(val.character_id), [INFO] [stdout] 42 ~ corporation_id: as_option(val.corporation_id), [INFO] [stdout] 43 ~ alliance_id: as_option(val.alliance_id), [INFO] [stdout] 44 ~ faction_id: as_option(val.faction_id), [INFO] [stdout] 45 ~ damage_done: val.damage_done, [INFO] [stdout] 46 ~ final_blow: val.final_blow, [INFO] [stdout] 47 ~ security_status: val.security_status, [INFO] [stdout] 48 ~ ship_type_id: as_option(val.ship_type_id), [INFO] [stdout] 49 ~ weapon_type_id: as_option(val.weapon_type_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/corporation/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod corporation; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/killmail.rs:22:39 [INFO] [stdout] | [INFO] [stdout] 22 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/killmail.rs:22:47 [INFO] [stdout] | [INFO] [stdout] 22 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/killmail.rs:23:37 [INFO] [stdout] | [INFO] [stdout] 23 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/killmail.rs:23:45 [INFO] [stdout] | [INFO] [stdout] 23 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/models/victim.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | impl Into for Victim { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 33 ~ impl From for killmails::Victim { [INFO] [stdout] 34 ~ fn from(val: Victim) -> Self { [INFO] [stdout] 35 | killmails::Victim { [INFO] [stdout] 36 ~ character_id: as_option(val.character_id), [INFO] [stdout] 37 ~ corporation_id: as_option(val.corporation_id), [INFO] [stdout] 38 ~ alliance_id: as_option(val.alliance_id), [INFO] [stdout] 39 ~ faction_id: as_option(val.faction_id), [INFO] [stdout] 40 ~ damage_taken: val.damage_taken, [INFO] [stdout] 41 ~ ship_type_id: val.ship_type_id, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/corporation/corporation.rs:72:51 [INFO] [stdout] | [INFO] [stdout] 72 | assert_relative_eq!(corporation.tax_rate, 0.10000000149); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 72 - assert_relative_eq!(corporation.tax_rate, 0.10000000149); [INFO] [stdout] 72 + assert_relative_eq!(corporation.tax_rate, 0.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/corporation/corporation.rs:100:43 [INFO] [stdout] | [INFO] [stdout] 100 | assert_relative_eq!(obj.tax_rate, 0.10000000149); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 100 - assert_relative_eq!(obj.tax_rate, 0.10000000149); [INFO] [stdout] 100 + assert_relative_eq!(obj.tax_rate, 0.1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/common/position.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | Position::distance(&self, other) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EveApi` [INFO] [stdout] --> src/esi/api.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn new() -> Self { [INFO] [stdout] 24 | | Self { [INFO] [stdout] 25 | | client: Client::new(), [INFO] [stdout] 26 | | } [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 22 + impl Default for EveApi { [INFO] [stdout] 23 + fn default() -> Self { [INFO] [stdout] 24 + Self::new() [INFO] [stdout] 25 + } [INFO] [stdout] 26 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/killmails/attacker.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | assert_eq!(attacker.final_blow, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 39 - assert_eq!(attacker.final_blow, true); [INFO] [stdout] 39 + assert!(attacker.final_blow); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/market/orders.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | assert_eq!(order.is_buy_order, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 71 - assert_eq!(order.is_buy_order, false); [INFO] [stdout] 71 + assert!(!order.is_buy_order); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/api.rs:88:47 [INFO] [stdout] | [INFO] [stdout] 88 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/api.rs:88:55 [INFO] [stdout] | [INFO] [stdout] 88 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/api.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/api.rs:89:53 [INFO] [stdout] | [INFO] [stdout] 89 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/models/api.rs:453:10 [INFO] [stdout] | [INFO] [stdout] 453 | ) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/models/api.rs:493:10 [INFO] [stdout] | [INFO] [stdout] 493 | ) -> anyhow::Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/models/attacker.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | impl Into for Attacker { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 38 ~ impl From for killmails::Attacker { [INFO] [stdout] 39 ~ fn from(val: Attacker) -> Self { [INFO] [stdout] 40 | killmails::Attacker { [INFO] [stdout] 41 ~ character_id: as_option(val.character_id), [INFO] [stdout] 42 ~ corporation_id: as_option(val.corporation_id), [INFO] [stdout] 43 ~ alliance_id: as_option(val.alliance_id), [INFO] [stdout] 44 ~ faction_id: as_option(val.faction_id), [INFO] [stdout] 45 ~ damage_done: val.damage_done, [INFO] [stdout] 46 ~ final_blow: val.final_blow, [INFO] [stdout] 47 ~ security_status: val.security_status, [INFO] [stdout] 48 ~ ship_type_id: as_option(val.ship_type_id), [INFO] [stdout] 49 ~ weapon_type_id: as_option(val.weapon_type_id), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/killmail.rs:22:39 [INFO] [stdout] | [INFO] [stdout] 22 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/killmail.rs:22:47 [INFO] [stdout] | [INFO] [stdout] 22 | moon_id: killmail.moon_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/models/killmail.rs:23:37 [INFO] [stdout] | [INFO] [stdout] 23 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|x| x.try_into().ok())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `i32` [INFO] [stdout] --> src/models/killmail.rs:23:45 [INFO] [stdout] | [INFO] [stdout] 23 | war_id: killmail.war_id.map(|x| x.try_into().ok()).flatten(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/models/victim.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | impl Into for Victim { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 33 ~ impl From for killmails::Victim { [INFO] [stdout] 34 ~ fn from(val: Victim) -> Self { [INFO] [stdout] 35 | killmails::Victim { [INFO] [stdout] 36 ~ character_id: as_option(val.character_id), [INFO] [stdout] 37 ~ corporation_id: as_option(val.corporation_id), [INFO] [stdout] 38 ~ alliance_id: as_option(val.alliance_id), [INFO] [stdout] 39 ~ faction_id: as_option(val.faction_id), [INFO] [stdout] 40 ~ damage_taken: val.damage_taken, [INFO] [stdout] 41 ~ ship_type_id: val.ship_type_id, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/killmail.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/bin/route.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | const USAGE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/bin/evetech.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | const USAGE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/bin/evetech.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 207 | fn display(object: &T) [INFO] [stdout] | ^ [INFO] [stdout] 208 | where [INFO] [stdout] 209 | T: for<'se> Serialize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/bin/evetech.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | async fn print(api: &EveApi, args: &Vec) -> anyhow::Result<()> [INFO] [stdout] | ^ [INFO] [stdout] 218 | where [INFO] [stdout] 219 | T: Uri + Debug + for<'de> Deserialize<'de> + for<'se> Serialize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/bin/evetech.rs:228:19 [INFO] [stdout] | [INFO] [stdout] 228 | async fn load_ids(api: &EveApi, args: &Vec) -> anyhow::Result> [INFO] [stdout] | ^ [INFO] [stdout] 229 | where [INFO] [stdout] 230 | T: Uri + Debug + for<'de> Deserialize<'de> + for<'se> Serialize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/ws_client.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/bin/route.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | const USAGE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/zkbinfo.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/killmail.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/zkb_client.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/zkb_client.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/bin/evetech.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | const USAGE: &'static str = " [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/bin/evetech.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 207 | fn display(object: &T) [INFO] [stdout] | ^ [INFO] [stdout] 208 | where [INFO] [stdout] 209 | T: for<'se> Serialize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/bin/evetech.rs:217:16 [INFO] [stdout] | [INFO] [stdout] 217 | async fn print(api: &EveApi, args: &Vec) -> anyhow::Result<()> [INFO] [stdout] | ^ [INFO] [stdout] 218 | where [INFO] [stdout] 219 | T: Uri + Debug + for<'de> Deserialize<'de> + for<'se> Serialize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/bin/evetech.rs:228:19 [INFO] [stdout] | [INFO] [stdout] 228 | async fn load_ids(api: &EveApi, args: &Vec) -> anyhow::Result> [INFO] [stdout] | ^ [INFO] [stdout] 229 | where [INFO] [stdout] 230 | T: Uri + Debug + for<'de> Deserialize<'de> + for<'se> Serialize, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/killmail.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | date.format("%Y%m%d").to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/killmail.rs:38:40 [INFO] [stdout] | [INFO] [stdout] 38 | date.format("%Y-%m-%d").to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/bin/killmail.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 88 | fn usage(app: &String) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/ws_client.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/bin/zkbinfo.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/bin/ws_client.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn new(api: &String) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 ~ pub fn new(api: &str) -> Self { [INFO] [stdout] 79 | Self { [INFO] [stdout] 80 ~ api: api.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/ws_client.rs:86:48 [INFO] [stdout] | [INFO] [stdout] 86 | match serde_json::from_str::(&payload) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/bin/zkb_client.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 32 | payload: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ payload: &str, [INFO] [stdout] 33 | _continuation: bool, [INFO] [stdout] 34 | fin: bool, [INFO] [stdout] 35 | ) -> anyhow::Result<()> { [INFO] [stdout] 36 ~ self.payloads.push(payload.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/bin/route.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | async fn build_route(system: &String, mode: &Mode) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 ~ async fn build_route(system: &str, mode: &Mode) -> anyhow::Result<()> { [INFO] [stdout] 53 | let api = EveApi::new(); [INFO] [stdout] 54 ~ let names = vec![system.to_owned()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/route.rs:102:45 [INFO] [stdout] | [INFO] [stdout] 102 | best_route(&api, id, start, &mode).await?; [INFO] [stdout] | ^^^^^ help: change this to: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/route.rs:148:27 [INFO] [stdout] | [INFO] [stdout] 148 | print(&route, &mut idx); [INFO] [stdout] | ^^^^^^ help: change this to: `route` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/killmail.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | date.format("%Y%m%d").to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/bin/killmail.rs:38:40 [INFO] [stdout] | [INFO] [stdout] 38 | date.format("%Y-%m-%d").to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/bin/killmail.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 88 | fn usage(app: &String) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/bin/zkb_client.rs:32:18 [INFO] [stdout] | [INFO] [stdout] 32 | payload: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 ~ payload: &str, [INFO] [stdout] 33 | _continuation: bool, [INFO] [stdout] 34 | fin: bool, [INFO] [stdout] 35 | ) -> anyhow::Result<()> { [INFO] [stdout] 36 ~ self.payloads.push(payload.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/bin/route.rs:52:30 [INFO] [stdout] | [INFO] [stdout] 52 | async fn build_route(system: &String, mode: &Mode) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 52 ~ async fn build_route(system: &str, mode: &Mode) -> anyhow::Result<()> { [INFO] [stdout] 53 | let api = EveApi::new(); [INFO] [stdout] 54 ~ let names = vec![system.to_owned()]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/route.rs:102:45 [INFO] [stdout] | [INFO] [stdout] 102 | best_route(&api, id, start, &mode).await?; [INFO] [stdout] | ^^^^^ help: change this to: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/route.rs:148:27 [INFO] [stdout] | [INFO] [stdout] 148 | print(&route, &mut idx); [INFO] [stdout] | ^^^^^^ help: change this to: `route` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:154:26 [INFO] [stdout] | [INFO] [stdout] 154 | let obj = api.search(&names).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `names` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/evetech.rs:171:36 [INFO] [stdout] | [INFO] [stdout] 171 | async fn names(api: &EveApi, args: &Vec) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 171 - async fn names(api: &EveApi, args: &Vec) -> anyhow::Result<()> { [INFO] [stdout] 171 + async fn names(api: &EveApi, args: &[String]) -> anyhow::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:183:61 [INFO] [stdout] | [INFO] [stdout] 183 | Univesrse::Region => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:184:75 [INFO] [stdout] | [INFO] [stdout] 184 | Univesrse::Constellation => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:185:61 [INFO] [stdout] | [INFO] [stdout] 185 | Univesrse::System => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:186:57 [INFO] [stdout] | [INFO] [stdout] 186 | Univesrse::Star => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:187:61 [INFO] [stdout] | [INFO] [stdout] 187 | Univesrse::Planet => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:188:57 [INFO] [stdout] | [INFO] [stdout] 188 | Univesrse::Moon => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:189:65 [INFO] [stdout] | [INFO] [stdout] 189 | Univesrse::Stargate => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:190:63 [INFO] [stdout] | [INFO] [stdout] 190 | Univesrse::Station => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:191:65 [INFO] [stdout] | [INFO] [stdout] 191 | Univesrse::Belt => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:192:57 [INFO] [stdout] | [INFO] [stdout] 192 | Univesrse::Type => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:193:59 [INFO] [stdout] | [INFO] [stdout] 193 | Univesrse::Group => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:194:65 [INFO] [stdout] | [INFO] [stdout] 194 | Univesrse::Category => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/bin/ws_client.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn new(api: &String) -> Self { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 ~ pub fn new(api: &str) -> Self { [INFO] [stdout] 79 | Self { [INFO] [stdout] 80 ~ api: api.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:202:54 [INFO] [stdout] | [INFO] [stdout] 202 | Market::Group => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/evetech.rs:228:51 [INFO] [stdout] | [INFO] [stdout] 228 | async fn load_ids(api: &EveApi, args: &Vec) -> anyhow::Result> [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 228 - async fn load_ids(api: &EveApi, args: &Vec) -> anyhow::Result> [INFO] [stdout] 228 + async fn load_ids(api: &EveApi, args: &[String]) -> anyhow::Result> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/ws_client.rs:86:48 [INFO] [stdout] | [INFO] [stdout] 86 | match serde_json::from_str::(&payload) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `payload` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:154:26 [INFO] [stdout] | [INFO] [stdout] 154 | let obj = api.search(&names).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `names` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/evetech.rs:171:36 [INFO] [stdout] | [INFO] [stdout] 171 | async fn names(api: &EveApi, args: &Vec) -> anyhow::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 171 - async fn names(api: &EveApi, args: &Vec) -> anyhow::Result<()> { [INFO] [stdout] 171 + async fn names(api: &EveApi, args: &[String]) -> anyhow::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:183:61 [INFO] [stdout] | [INFO] [stdout] 183 | Univesrse::Region => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:184:75 [INFO] [stdout] | [INFO] [stdout] 184 | Univesrse::Constellation => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:185:61 [INFO] [stdout] | [INFO] [stdout] 185 | Univesrse::System => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:186:57 [INFO] [stdout] | [INFO] [stdout] 186 | Univesrse::Star => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:187:61 [INFO] [stdout] | [INFO] [stdout] 187 | Univesrse::Planet => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:188:57 [INFO] [stdout] | [INFO] [stdout] 188 | Univesrse::Moon => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:189:65 [INFO] [stdout] | [INFO] [stdout] 189 | Univesrse::Stargate => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:190:63 [INFO] [stdout] | [INFO] [stdout] 190 | Univesrse::Station => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:191:65 [INFO] [stdout] | [INFO] [stdout] 191 | Univesrse::Belt => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:192:57 [INFO] [stdout] | [INFO] [stdout] 192 | Univesrse::Type => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:193:59 [INFO] [stdout] | [INFO] [stdout] 193 | Univesrse::Group => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:194:65 [INFO] [stdout] | [INFO] [stdout] 194 | Univesrse::Category => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/evetech.rs:202:54 [INFO] [stdout] | [INFO] [stdout] 202 | Market::Group => print::(api, &args).await?, [INFO] [stdout] | ^^^^^ help: change this to: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/evetech.rs:228:51 [INFO] [stdout] | [INFO] [stdout] 228 | async fn load_ids(api: &EveApi, args: &Vec) -> anyhow::Result> [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 228 - async fn load_ids(api: &EveApi, args: &Vec) -> anyhow::Result> [INFO] [stdout] 228 + async fn load_ids(api: &EveApi, args: &[String]) -> anyhow::Result> [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `Command { std: "docker" "inspect" "f4195fa57b6deb2498fd504692ea3b40df07631a85fbaebf9e6723a4444efdec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4195fa57b6deb2498fd504692ea3b40df07631a85fbaebf9e6723a4444efdec", kill_on_drop: false }` [INFO] [stdout] f4195fa57b6deb2498fd504692ea3b40df07631a85fbaebf9e6723a4444efdec