[INFO] cloning repository https://github.com/sdancer/protodump [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sdancer/protodump" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsdancer%2Fprotodump", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsdancer%2Fprotodump'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5a4ee1fbb3b2e14fc767e0048d36607ea019d506 [INFO] linting sdancer/protodump against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsdancer%2Fprotodump" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sdancer/protodump [INFO] finished tweaking git repo https://github.com/sdancer/protodump [INFO] tweaked toml for git repo https://github.com/sdancer/protodump written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sdancer/protodump on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sdancer/protodump already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded scroll_derive v0.12.1 [INFO] [stderr] Downloaded scroll v0.12.0 [INFO] [stderr] Downloaded cc v1.2.21 [INFO] [stderr] Downloaded capstone v0.13.0 [INFO] [stderr] Downloaded goblin v0.8.2 [INFO] [stderr] Downloaded capstone-sys v0.17.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85b084cc2835679543960cb9007be1d3577d0fd037c0c311e69a9e134abef7f5 [INFO] running `Command { std: "docker" "start" "-a" "85b084cc2835679543960cb9007be1d3577d0fd037c0c311e69a9e134abef7f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85b084cc2835679543960cb9007be1d3577d0fd037c0c311e69a9e134abef7f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85b084cc2835679543960cb9007be1d3577d0fd037c0c311e69a9e134abef7f5", kill_on_drop: false }` [INFO] [stdout] 85b084cc2835679543960cb9007be1d3577d0fd037c0c311e69a9e134abef7f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f4649fa1d7009b769b114f66d3a7e857c881307a5cb23a8087cb6eb81d4d082 [INFO] running `Command { std: "docker" "start" "-a" "2f4649fa1d7009b769b114f66d3a7e857c881307a5cb23a8087cb6eb81d4d082", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling cc v1.2.21 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Compiling capstone-sys v0.17.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling scroll_derive v0.12.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking goblin v0.8.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking capstone v0.13.0 [INFO] [stderr] Checking extractor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `repr` [INFO] [stdout] --> src/main.rs:247:38 [INFO] [stdout] | [INFO] [stdout] 247 | if let FieldType::Enum { ref mut repr, .. } = fields[i + 1].f_type.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try ignoring the field: `repr: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:378:41 [INFO] [stdout] | [INFO] [stdout] 378 | let detail = cs.insn_detail(&insn)?; [INFO] [stdout] | ^^^^^ help: change this to: `insn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&String>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:444:27 [INFO] [stdout] | [INFO] [stdout] 444 | let ty_name = mem.addr2name.get(&func_desc).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `mem.addr2name.get(&func_desc)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&String>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:456:18 [INFO] [stdout] | [INFO] [stdout] 456 | let ty_ptr = ty_name_opt.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ty_name_opt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:565:12 [INFO] [stdout] | [INFO] [stdout] 565 | if !q0.is_ok() || q0.unwrap() != common_source { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `q0.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `64usize` is never smaller than `1` and has therefore no effect [INFO] [stdout] --> src/main.rs:601:17 [INFO] [stdout] | [INFO] [stdout] 601 | let parts = 64usize.max(1); // never 0 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `64usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:602:20 [INFO] [stdout] | [INFO] [stdout] 602 | let per_part = (packets.len() + parts - 1) / parts; // ceil div [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `packets.len().div_ceil(parts)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `repr` [INFO] [stdout] --> src/main.rs:247:38 [INFO] [stdout] | [INFO] [stdout] 247 | if let FieldType::Enum { ref mut repr, .. } = fields[i + 1].f_type.clone() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try ignoring the field: `repr: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:378:41 [INFO] [stdout] | [INFO] [stdout] 378 | let detail = cs.insn_detail(&insn)?; [INFO] [stdout] | ^^^^^ help: change this to: `insn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&String>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:444:27 [INFO] [stdout] | [INFO] [stdout] 444 | let ty_name = mem.addr2name.get(&func_desc).clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `mem.addr2name.get(&func_desc)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<&String>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:456:18 [INFO] [stdout] | [INFO] [stdout] 456 | let ty_ptr = ty_name_opt.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ty_name_opt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:565:12 [INFO] [stdout] | [INFO] [stdout] 565 | if !q0.is_ok() || q0.unwrap() != common_source { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `q0.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `64usize` is never smaller than `1` and has therefore no effect [INFO] [stdout] --> src/main.rs:601:17 [INFO] [stdout] | [INFO] [stdout] 601 | let parts = 64usize.max(1); // never 0 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `64usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_min_or_max [INFO] [stdout] = note: `#[warn(clippy::unnecessary_min_or_max)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/main.rs:602:20 [INFO] [stdout] | [INFO] [stdout] 602 | let per_part = (packets.len() + parts - 1) / parts; // ceil div [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `packets.len().div_ceil(parts)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.81s [INFO] running `Command { std: "docker" "inspect" "2f4649fa1d7009b769b114f66d3a7e857c881307a5cb23a8087cb6eb81d4d082", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f4649fa1d7009b769b114f66d3a7e857c881307a5cb23a8087cb6eb81d4d082", kill_on_drop: false }` [INFO] [stdout] 2f4649fa1d7009b769b114f66d3a7e857c881307a5cb23a8087cb6eb81d4d082