[INFO] cloning repository https://github.com/sbuggay/rnes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sbuggay/rnes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsbuggay%2Frnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsbuggay%2Frnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cd26a016b689589dd14089667bdede8ab9459e96 [INFO] linting sbuggay/rnes against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsbuggay%2Frnes" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sbuggay/rnes [INFO] finished tweaking git repo https://github.com/sbuggay/rnes [INFO] tweaked toml for git repo https://github.com/sbuggay/rnes written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sbuggay/rnes on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sbuggay/rnes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating git repository `https://github.com/AngryLawyer/rust-sdl2` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num v0.1.42 [INFO] [stderr] Downloaded num-integer v0.1.39 [INFO] [stderr] Downloaded num-iter v0.1.37 [INFO] [stderr] Downloaded lazy_static v0.2.11 [INFO] [stderr] Downloaded bitflags v1.0.3 [INFO] [stderr] Downloaded num-traits v0.2.5 [INFO] [stderr] Downloaded cfg-if v0.1.4 [INFO] [stderr] Downloaded rand v0.4.2 [INFO] [stderr] Downloaded winapi v0.3.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 355b224a3357955970d348e819954c8286e99f8b8e052bbb6369a29b2b5d5117 [INFO] running `Command { std: "docker" "start" "-a" "355b224a3357955970d348e819954c8286e99f8b8e052bbb6369a29b2b5d5117", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "355b224a3357955970d348e819954c8286e99f8b8e052bbb6369a29b2b5d5117", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "355b224a3357955970d348e819954c8286e99f8b8e052bbb6369a29b2b5d5117", kill_on_drop: false }` [INFO] [stdout] 355b224a3357955970d348e819954c8286e99f8b8e052bbb6369a29b2b5d5117 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 61dd2f64aec10c311867c1f5190228d5208126d9e8fe9d9e3245a92398f5ff4b [INFO] running `Command { std: "docker" "start" "-a" "61dd2f64aec10c311867c1f5190228d5208126d9e8fe9d9e3245a92398f5ff4b", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling num-traits v0.2.5 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling cfg-if v0.1.4 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling sdl2-sys v0.31.0 (https://github.com/AngryLawyer/rust-sdl2#4bb6b9ab) [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking sdl2 v0.31.0 (https://github.com/AngryLawyer/rust-sdl2#4bb6b9ab) [INFO] [stderr] Checking nes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/cpu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt` [INFO] [stdout] --> src/instructions.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/instructions.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | let start = (((arr[0] as usize)) & 0xFF) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove them: `(arr[0] as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind` and `Error` [INFO] [stdout] --> src/rom.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{Error, ErrorKind, Read, Seek, SeekFrom}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/rom.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | mapper: mapper, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:95:4 [INFO] [stdout] | [INFO] [stdout] 95 | rom: rom, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:96:4 [INFO] [stdout] | [INFO] [stdout] 96 | video_rom: video_rom, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `video_rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:97:4 [INFO] [stdout] | [INFO] [stdout] 97 | save_ram_length: save_ram_length, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `save_ram_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:98:4 [INFO] [stdout] | [INFO] [stdout] 98 | mirroring: mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mirroring` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind`, `Error`, and `SeekFrom` [INFO] [stdout] --> src/simulate.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufRead, Error, ErrorKind, Read, Seek, SeekFrom}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/simulate.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 23 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::*` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::time::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::event::Event` [INFO] [stdout] --> src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use sdl2::event::Event; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::keyboard::Keycode` [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use sdl2::keyboard::Keycode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time` [INFO] [stdout] --> src/cpu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fmt` [INFO] [stdout] --> src/instructions.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::fmt; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/instructions.rs:182:18 [INFO] [stdout] | [INFO] [stdout] 182 | let start = (((arr[0] as usize)) & 0xFF) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: remove them: `(arr[0] as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind` and `Error` [INFO] [stdout] --> src/rom.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{Error, ErrorKind, Read, Seek, SeekFrom}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/rom.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 18 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | mapper: mapper, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mapper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:95:4 [INFO] [stdout] | [INFO] [stdout] 95 | rom: rom, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:96:4 [INFO] [stdout] | [INFO] [stdout] 96 | video_rom: video_rom, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `video_rom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:97:4 [INFO] [stdout] | [INFO] [stdout] 97 | save_ram_length: save_ram_length, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `save_ram_length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rom.rs:98:4 [INFO] [stdout] | [INFO] [stdout] 98 | mirroring: mirroring, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mirroring` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ErrorKind`, `Error`, and `SeekFrom` [INFO] [stdout] --> src/simulate.rs:3:24 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{BufRead, Error, ErrorKind, Read, Seek, SeekFrom}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/simulate.rs:23:3 [INFO] [stdout] | [INFO] [stdout] 23 | try!(write!( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::*` [INFO] [stdout] --> src/main.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::time::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::event::Event` [INFO] [stdout] --> src/main.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | use sdl2::event::Event; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::keyboard::Keycode` [INFO] [stdout] --> src/main.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use sdl2::keyboard::Keycode; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cycles` [INFO] [stdout] --> src/cpu.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | let cycles = CYCLE_TABLE[opcode as usize]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cycles` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | let mut simulated_cpu = simulate::Simulate::load(&mut nestest); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | let mut event_pump = sdl_context.event_pump().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 57 | let mut last_frame = std::time::Instant::now(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 58 | let mut frames = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | let mut i = 1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `simulated_cpu` [INFO] [stdout] --> src/main.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | let mut simulated_cpu = simulate::Simulate::load(&mut nestest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_simulated_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_pump` [INFO] [stdout] --> src/main.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | let mut event_pump = sdl_context.event_pump().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_pump` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_frame` [INFO] [stdout] --> src/main.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 57 | let mut last_frame = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frames` [INFO] [stdout] --> src/main.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 58 | let mut frames = 0; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frames` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | let mut i = 1; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `dump`, `rom_bank_count`, and `video_rom_bank_count` are never used [INFO] [stdout] --> src/rom.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 45 | impl Rom { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 102 | pub fn dump(&self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 109 | pub fn rom_bank_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | pub fn video_rom_bank_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `index` and `states` are never read [INFO] [stdout] --> src/simulate.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct Simulate { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 34 | pub index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 35 | pub states: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `step` is never used [INFO] [stdout] --> src/simulate.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 38 | impl Simulate { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn step(&mut self) -> CpuState { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cycles` [INFO] [stdout] --> src/cpu.rs:82:7 [INFO] [stdout] | [INFO] [stdout] 82 | let cycles = CYCLE_TABLE[opcode as usize]; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cycles` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/cpu.rs:89:3 [INFO] [stdout] | [INFO] [stdout] 89 | / let constructed_opcode = match parsed_opcode { [INFO] [stdout] 90 | | (instruction, amode) => { [INFO] [stdout] 91 | | let extra_bytes = amode.extra_bytes(); [INFO] [stdout] 92 | | let slice = &self.mem [INFO] [stdout] ... | [INFO] [stdout] 98 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 89 ~ let (instruction, amode) = parsed_opcode; [INFO] [stdout] 90 + let constructed_opcode = { [INFO] [stdout] 91 ~ let extra_bytes = amode.extra_bytes(); [INFO] [stdout] 92 ~ let slice = &self.mem [INFO] [stdout] 93 ~ [((self.pc + 1) as usize)..(((self.pc + 1) + extra_bytes as u16) as usize)]; [INFO] [stdout] 94 ~ let opinput = amode.process(self, slice); [INFO] [stdout] 95 ~ self.pc += 1 + extra_bytes as u16; [INFO] [stdout] 96 ~ (instruction, opinput) [INFO] [stdout] 97 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:246:74 [INFO] [stdout] | [INFO] [stdout] 246 | (Instruction::STA, OpInput::Address(val)) => self.mem[val as usize] = self.a as u8, [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `self.a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:247:74 [INFO] [stdout] | [INFO] [stdout] 247 | (Instruction::STX, OpInput::Address(val)) => self.mem[val as usize] = self.x as u8, [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `self.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:248:74 [INFO] [stdout] | [INFO] [stdout] 248 | (Instruction::STY, OpInput::Address(val)) => self.mem[val as usize] = self.y as u8, [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `self.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:346:34 [INFO] [stdout] | [INFO] [stdout] 346 | self.set_flag(Flags::Overflow, !(((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((a ^ val as u8) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:346:42 [INFO] [stdout] | [INFO] [stdout] 346 | self.set_flag(Flags::Overflow, !(((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:346:77 [INFO] [stdout] | [INFO] [stdout] 346 | self.set_flag(Flags::Overflow, !(((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:485:24 [INFO] [stdout] | [INFO] [stdout] 485 | self.a = self.set_zn(val as u8); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:490:24 [INFO] [stdout] | [INFO] [stdout] 490 | self.x = self.set_zn(val as u8); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:495:24 [INFO] [stdout] | [INFO] [stdout] 495 | self.y = self.set_zn(val as u8); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:549:41 [INFO] [stdout] | [INFO] [stdout] 549 | self.set_flag(Flags::Overflow, (((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:549:76 [INFO] [stdout] | [INFO] [stdout] 549 | self.set_flag(Flags::Overflow, (((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:562:3 [INFO] [stdout] | [INFO] [stdout] 561 | let ret = self.get_mem(0x100 + self.sp as u16); [INFO] [stdout] | ----------------------------------------------- unnecessary `let` binding [INFO] [stdout] 562 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 561 ~ [INFO] [stdout] 562 ~ self.get_mem(0x100 + self.sp as u16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | let mut simulated_cpu = simulate::Simulate::load(&mut nestest); [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | let mut event_pump = sdl_context.event_pump().unwrap(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 57 | let mut last_frame = std::time::Instant::now(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 58 | let mut frames = 0; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | let mut i = 1; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `simulated_cpu` [INFO] [stdout] --> src/main.rs:26:6 [INFO] [stdout] | [INFO] [stdout] 26 | let mut simulated_cpu = simulate::Simulate::load(&mut nestest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_simulated_cpu` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `event_pump` [INFO] [stdout] --> src/main.rs:56:6 [INFO] [stdout] | [INFO] [stdout] 56 | let mut event_pump = sdl_context.event_pump().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_event_pump` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `last_frame` [INFO] [stdout] --> src/main.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 57 | let mut last_frame = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_frame` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frames` [INFO] [stdout] --> src/main.rs:58:6 [INFO] [stdout] | [INFO] [stdout] 58 | let mut frames = 0; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frames` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/main.rs:59:6 [INFO] [stdout] | [INFO] [stdout] 59 | let mut i = 1; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `dump`, `rom_bank_count`, and `video_rom_bank_count` are never used [INFO] [stdout] --> src/rom.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 45 | impl Rom { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 102 | pub fn dump(&self) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 109 | pub fn rom_bank_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | pub fn video_rom_bank_count(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cpu.rs:598:6 [INFO] [stdout] | [INFO] [stdout] 598 | if (addr >= 0x800) && (addr <= 0x1FFF) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x800..=0x1FFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `index` and `states` are never read [INFO] [stdout] --> src/simulate.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct Simulate { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 34 | pub index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 35 | pub states: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `step` is never used [INFO] [stdout] --> src/simulate.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 38 | impl Simulate { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn step(&mut self) -> CpuState { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cpu.rs:608:6 [INFO] [stdout] | [INFO] [stdout] 608 | if (addr >= 0x800) && (addr <= 0x1FFF) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x800..=0x1FFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | ADC, // ADd with Carry................ | NV ...ZC A = A + M + C [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 9 | AND, // logical AND (bitwise)......... | N. ...Z. A = A && M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | ASL, // Arithmetic Shift Left......... | N. ...ZC A = M << 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | BCC, // Branch if Carry Clear......... | .. ..... PC = !C [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | BCS, // Branch if Carry Set........... | .. ..... PC = C [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | BEQ, // Branch if Equal (to zero?).... | .. ..... PC = Z [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | BIT, // BIT test...................... | NV ...Z. = A & M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | BMI, // Branch if Minus............... | .. ..... PC = N [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | BNE, // Branch if Not Equal........... | .. ..... PC = !Z [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:17:2 [INFO] [stdout] | [INFO] [stdout] 17 | BPL, // Branch if Positive............ | .. ..... PC = Z [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | BRK, // BReaK......................... | .. B.... S PC = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | BVC, // Branch if oVerflow Clear...... | .. ..... PC = !V [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 20 | BVS, // Branch if oVerflow Set........ | .. ..... PC = V [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 21 | CLC, // CLear Carry flag.............. | .. ....C = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | CLD, // Clear Decimal Mode............ | .. .D... = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | CLI, // Clear Interrupt Disable....... | .. ..I.. = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:24:2 [INFO] [stdout] | [INFO] [stdout] 24 | CLV, // Clear oVerflow flag........... | .V ..... = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPU` contains a capitalized acronym [INFO] [stdout] --> src/cpu.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct CPU { [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:25:2 [INFO] [stdout] | [INFO] [stdout] 25 | CMP, // Compare....................... | N. ...ZC = A - M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 26 | CPX, // Compare X register............ | N. ...ZC = X - M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 27 | CPY, // Compare Y register............ | N. ...ZC = Y - M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:28:2 [INFO] [stdout] | [INFO] [stdout] 28 | DEC, // DECrement memory.............. | N. ...Z. M = M - 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | DEX, // DEcrement X register.......... | N. ...Z. X = X - 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | DEY, // DEcrement Y register.......... | N. ...Z. Y = Y - 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | EOR, // Exclusive OR (bitwise)........ | N. ...Z. A = A ^ M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:32:2 [INFO] [stdout] | [INFO] [stdout] 32 | INC, // INCrement memory.............. | N. ...Z. M = M + 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | INX, // INcrement X register.......... | N. ...Z. X = X + 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:34:2 [INFO] [stdout] | [INFO] [stdout] 34 | INY, // INcrement Y register.......... | N. ...Z. Y = Y + 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:35:2 [INFO] [stdout] | [INFO] [stdout] 35 | JMP, // JuMP.......................... | .. ..... S PC = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 36 | JSR, // Jump to SubRoutine............ | .. ..... S PC = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | LDA, // LoaD Accumulator.............. | N. ...Z. A = M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | LDX, // LoaD X register............... | N. ...Z. X = M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:39:2 [INFO] [stdout] | [INFO] [stdout] 39 | LDY, // LoaD Y register............... | N. ...Z. Y = M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:40:2 [INFO] [stdout] | [INFO] [stdout] 40 | LSR, // Logical Shift Right........... | N. ...ZC A = A/2 // or N. ...ZC ... [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | NOP, // No OPeration.................. | .. ..... = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | ORA, // inclusive OR (bitwise)........ | N. ...Z. A = A | M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:43:2 [INFO] [stdout] | [INFO] [stdout] 43 | PHA, // PusH Accumulator.............. | .. ..... S M = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | PHP, // PusH Processor status......... | .. ..... S M = F [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:45:2 [INFO] [stdout] | [INFO] [stdout] 45 | PLA, // PuLl Accumulator.............. | N. ...Z. A S = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:46:2 [INFO] [stdout] | [INFO] [stdout] 46 | PLP, // PuLl Processor status......... | NV BDIZC S = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | ROL, // ROtate Left................... | N. ...ZC A = C A rotated // or N. ...ZC ... [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 48 | ROR, // ROtate Right.................. | N. ...ZC A = C A rotated // or N. ...ZC ... [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:49:2 [INFO] [stdout] | [INFO] [stdout] 49 | RTI, // ReTurn from Interrupt......... | NV BDIZC PC = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:50:2 [INFO] [stdout] | [INFO] [stdout] 50 | RTS, // ReTurn from Subroutine........ | .. ..... PC = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:51:2 [INFO] [stdout] | [INFO] [stdout] 51 | SBC, // SuBtract with Carry........... | NV ...ZC A = A-M-(1-C) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:52:2 [INFO] [stdout] | [INFO] [stdout] 52 | SEC, // SEt Carry flag................ | .. ....C = 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:53:2 [INFO] [stdout] | [INFO] [stdout] 53 | SED, // SEt Decimal flag.............. | .. .D... = 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:54:2 [INFO] [stdout] | [INFO] [stdout] 54 | SEI, // SEt Interrupt disable......... | .. ..I.. = 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:55:2 [INFO] [stdout] | [INFO] [stdout] 55 | STA, // STore Accumulator............. | .. ..... M = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:56:2 [INFO] [stdout] | [INFO] [stdout] 56 | STX, // STore X register.............. | .. ..... M = X [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:57:2 [INFO] [stdout] | [INFO] [stdout] 57 | STY, // STore Y register.............. | .. ..... M = Y [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:58:2 [INFO] [stdout] | [INFO] [stdout] 58 | TAX, // Transfer Accumulator to X..... | N. ...Z. X = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:59:2 [INFO] [stdout] | [INFO] [stdout] 59 | TAY, // Transfer Accumulator to Y..... | N. ...Z. Y = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:60:2 [INFO] [stdout] | [INFO] [stdout] 60 | TSX, // Transfer Stack pointer to X... | N. ...Z. X = S [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:61:2 [INFO] [stdout] | [INFO] [stdout] 61 | TXA, // Transfer X to Accumulator..... | N. ...Z. A = X [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:62:2 [INFO] [stdout] | [INFO] [stdout] 62 | TXS, // Transfer X to Stack pointer... | .. ..... S = X [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:63:2 [INFO] [stdout] | [INFO] [stdout] 63 | TYA, // Transfer Y to Accumulator..... | N. ...Z. A = Y [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ALR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:65:2 [INFO] [stdout] | [INFO] [stdout] 65 | ALR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Alr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AHX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:66:2 [INFO] [stdout] | [INFO] [stdout] 66 | AHX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ahx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:67:2 [INFO] [stdout] | [INFO] [stdout] 67 | ARR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Arr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ANC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:68:2 [INFO] [stdout] | [INFO] [stdout] 68 | ANC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Anc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AXS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:69:2 [INFO] [stdout] | [INFO] [stdout] 69 | AXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Axs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DCP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:70:2 [INFO] [stdout] | [INFO] [stdout] 70 | DCP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dcp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ISC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:71:2 [INFO] [stdout] | [INFO] [stdout] 71 | ISC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Isc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LAS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:72:2 [INFO] [stdout] | [INFO] [stdout] 72 | LAS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Las` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LAX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:73:2 [INFO] [stdout] | [INFO] [stdout] 73 | LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/cpu.rs:89:3 [INFO] [stdout] | [INFO] [stdout] 89 | / let constructed_opcode = match parsed_opcode { [INFO] [stdout] 90 | | (instruction, amode) => { [INFO] [stdout] 91 | | let extra_bytes = amode.extra_bytes(); [INFO] [stdout] 92 | | let slice = &self.mem [INFO] [stdout] ... | [INFO] [stdout] 98 | | }; [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 89 ~ let (instruction, amode) = parsed_opcode; [INFO] [stdout] 90 + let constructed_opcode = { [INFO] [stdout] 91 ~ let extra_bytes = amode.extra_bytes(); [INFO] [stdout] 92 ~ let slice = &self.mem [INFO] [stdout] 93 ~ [((self.pc + 1) as usize)..(((self.pc + 1) + extra_bytes as u16) as usize)]; [INFO] [stdout] 94 ~ let opinput = amode.process(self, slice); [INFO] [stdout] 95 ~ self.pc += 1 + extra_bytes as u16; [INFO] [stdout] 96 ~ (instruction, opinput) [INFO] [stdout] 97 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:74:2 [INFO] [stdout] | [INFO] [stdout] 74 | RLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:75:2 [INFO] [stdout] | [INFO] [stdout] 75 | RRA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SAX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:76:2 [INFO] [stdout] | [INFO] [stdout] 76 | SAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:77:2 [INFO] [stdout] | [INFO] [stdout] 77 | SHX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:78:2 [INFO] [stdout] | [INFO] [stdout] 78 | SHY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SRE` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:79:2 [INFO] [stdout] | [INFO] [stdout] 79 | SRE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SLO` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:80:2 [INFO] [stdout] | [INFO] [stdout] 80 | SLO, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Slo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:81:2 [INFO] [stdout] | [INFO] [stdout] 81 | TAS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tas` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XAA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:82:2 [INFO] [stdout] | [INFO] [stdout] 82 | XAA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xaa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `KIL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:84:2 [INFO] [stdout] | [INFO] [stdout] 84 | KIL [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Kil` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/instructions.rs:141:11 [INFO] [stdout] | [INFO] [stdout] 141 | let x = cpu.x as u8; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cpu.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/instructions.rs:142:11 [INFO] [stdout] | [INFO] [stdout] 142 | let y = cpu.y as u8; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cpu.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:246:74 [INFO] [stdout] | [INFO] [stdout] 246 | (Instruction::STA, OpInput::Address(val)) => self.mem[val as usize] = self.a as u8, [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `self.a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:247:74 [INFO] [stdout] | [INFO] [stdout] 247 | (Instruction::STX, OpInput::Address(val)) => self.mem[val as usize] = self.x as u8, [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `self.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:248:74 [INFO] [stdout] | [INFO] [stdout] 248 | (Instruction::STY, OpInput::Address(val)) => self.mem[val as usize] = self.y as u8, [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `self.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/instructions.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | let start = (((arr[0] as usize) + x as usize) & 0xFF) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((arr[0] as usize) + x as usize) & 0xFF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/instructions.rs:173:29 [INFO] [stdout] | [INFO] [stdout] 173 | let end = (start + 1) & 0xFF as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `0xFF_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/instructions.rs:182:17 [INFO] [stdout] | [INFO] [stdout] 182 | let start = (((arr[0] as usize)) & 0xFF) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((arr[0] as usize)) & 0xFF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/instructions.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | let end = (start + 1) & 0xFF as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `0xFF_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:346:34 [INFO] [stdout] | [INFO] [stdout] 346 | self.set_flag(Flags::Overflow, !(((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((a ^ val as u8) & 0x80) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:346:42 [INFO] [stdout] | [INFO] [stdout] 346 | self.set_flag(Flags::Overflow, !(((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:346:77 [INFO] [stdout] | [INFO] [stdout] 346 | self.set_flag(Flags::Overflow, !(((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:485:24 [INFO] [stdout] | [INFO] [stdout] 485 | self.a = self.set_zn(val as u8); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:490:24 [INFO] [stdout] | [INFO] [stdout] 490 | self.x = self.set_zn(val as u8); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:495:24 [INFO] [stdout] | [INFO] [stdout] 495 | self.y = self.set_zn(val as u8); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | return val[0]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return val[0]; [INFO] [stdout] 42 + val[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:549:41 [INFO] [stdout] | [INFO] [stdout] 549 | self.set_flag(Flags::Overflow, (((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^ help: try: `val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/cpu.rs:549:76 [INFO] [stdout] | [INFO] [stdout] 549 | self.set_flag(Flags::Overflow, (((a ^ val as u8) & 0x80) != 0) && (((a ^ result as u8) & 0x80) != 0)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/rom.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | if magic[0] != 'N' as u8 && magic[1] != 'E' as u8 && magic[2] != 'S' as u8 && magic[3] != 0x1a { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'N'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:562:3 [INFO] [stdout] | [INFO] [stdout] 561 | let ret = self.get_mem(0x100 + self.sp as u16); [INFO] [stdout] | ----------------------------------------------- unnecessary `let` binding [INFO] [stdout] 562 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 561 ~ [INFO] [stdout] 562 ~ self.get_mem(0x100 + self.sp as u16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/rom.rs:50:43 [INFO] [stdout] | [INFO] [stdout] 50 | if magic[0] != 'N' as u8 && magic[1] != 'E' as u8 && magic[2] != 'S' as u8 && magic[3] != 0x1a { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'E'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/rom.rs:50:68 [INFO] [stdout] | [INFO] [stdout] 50 | if magic[0] != 'N' as u8 && magic[1] != 'E' as u8 && magic[2] != 'S' as u8 && magic[3] != 0x1a { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'S'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cpu.rs:598:6 [INFO] [stdout] | [INFO] [stdout] 598 | if (addr >= 0x800) && (addr <= 0x1FFF) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x800..=0x1FFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cpu.rs:608:6 [INFO] [stdout] | [INFO] [stdout] 608 | if (addr >= 0x800) && (addr <= 0x1FFF) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x800..=0x1FFF).contains(&addr)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:8:2 [INFO] [stdout] | [INFO] [stdout] 8 | ADC, // ADd with Carry................ | NV ...ZC A = A + M + C [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:9:2 [INFO] [stdout] | [INFO] [stdout] 9 | AND, // logical AND (bitwise)......... | N. ...Z. A = A && M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ASL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:10:2 [INFO] [stdout] | [INFO] [stdout] 10 | ASL, // Arithmetic Shift Left......... | N. ...ZC A = M << 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Asl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:11:2 [INFO] [stdout] | [INFO] [stdout] 11 | BCC, // Branch if Carry Clear......... | .. ..... PC = !C [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/rom.rs:106:3 [INFO] [stdout] | [INFO] [stdout] 106 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BCS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:12:2 [INFO] [stdout] | [INFO] [stdout] 12 | BCS, // Branch if Carry Set........... | .. ..... PC = C [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bcs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BEQ` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:13:2 [INFO] [stdout] | [INFO] [stdout] 13 | BEQ, // Branch if Equal (to zero?).... | .. ..... PC = Z [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Beq` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BIT` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:14:2 [INFO] [stdout] | [INFO] [stdout] 14 | BIT, // BIT test...................... | NV ...Z. = A & M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bit` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BMI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | BMI, // Branch if Minus............... | .. ..... PC = N [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bmi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BNE` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | BNE, // Branch if Not Equal........... | .. ..... PC = !Z [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bne` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BPL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:17:2 [INFO] [stdout] | [INFO] [stdout] 17 | BPL, // Branch if Positive............ | .. ..... PC = Z [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Bpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BRK` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:18:2 [INFO] [stdout] | [INFO] [stdout] 18 | BRK, // BReaK......................... | .. B.... S PC = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Brk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:19:2 [INFO] [stdout] | [INFO] [stdout] 19 | BVC, // Branch if oVerflow Clear...... | .. ..... PC = !V [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `BVS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:20:2 [INFO] [stdout] | [INFO] [stdout] 20 | BVS, // Branch if oVerflow Set........ | .. ..... PC = V [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Bvs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:21:2 [INFO] [stdout] | [INFO] [stdout] 21 | CLC, // CLear Carry flag.............. | .. ....C = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLD` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | CLD, // Clear Decimal Mode............ | .. .D... = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:23:2 [INFO] [stdout] | [INFO] [stdout] 23 | CLI, // Clear Interrupt Disable....... | .. ..I.. = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cli` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CLV` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:24:2 [INFO] [stdout] | [INFO] [stdout] 24 | CLV, // Clear oVerflow flag........... | .V ..... = 0 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Clv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CMP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:25:2 [INFO] [stdout] | [INFO] [stdout] 25 | CMP, // Compare....................... | N. ...ZC = A - M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:26:2 [INFO] [stdout] | [INFO] [stdout] 26 | CPX, // Compare X register............ | N. ...ZC = X - M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:27:2 [INFO] [stdout] | [INFO] [stdout] 27 | CPY, // Compare Y register............ | N. ...ZC = Y - M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:28:2 [INFO] [stdout] | [INFO] [stdout] 28 | DEC, // DECrement memory.............. | N. ...Z. M = M - 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:29:2 [INFO] [stdout] | [INFO] [stdout] 29 | DEX, // DEcrement X register.......... | N. ...Z. X = X - 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dex` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:30:2 [INFO] [stdout] | [INFO] [stdout] 30 | DEY, // DEcrement Y register.......... | N. ...Z. Y = Y - 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:31:2 [INFO] [stdout] | [INFO] [stdout] 31 | EOR, // Exclusive OR (bitwise)........ | N. ...Z. A = A ^ M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Eor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:32:2 [INFO] [stdout] | [INFO] [stdout] 32 | INC, // INCrement memory.............. | N. ...Z. M = M + 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | INX, // INcrement X register.......... | N. ...Z. X = X + 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:34:2 [INFO] [stdout] | [INFO] [stdout] 34 | INY, // INcrement Y register.......... | N. ...Z. Y = Y + 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Iny` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JMP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:35:2 [INFO] [stdout] | [INFO] [stdout] 35 | JMP, // JuMP.......................... | .. ..... S PC = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jmp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 36 | JSR, // Jump to SubRoutine............ | .. ..... S PC = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Jsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | LDA, // LoaD Accumulator.............. | N. ...Z. A = M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lda` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:38:2 [INFO] [stdout] | [INFO] [stdout] 38 | LDX, // LoaD X register............... | N. ...Z. X = M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:39:2 [INFO] [stdout] | [INFO] [stdout] 39 | LDY, // LoaD Y register............... | N. ...Z. Y = M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LSR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:40:2 [INFO] [stdout] | [INFO] [stdout] 40 | LSR, // Logical Shift Right........... | N. ...ZC A = A/2 // or N. ...ZC ... [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lsr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | NOP, // No OPeration.................. | .. ..... = [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ORA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | ORA, // inclusive OR (bitwise)........ | N. ...Z. A = A | M [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ora` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:43:2 [INFO] [stdout] | [INFO] [stdout] 43 | PHA, // PusH Accumulator.............. | .. ..... S M = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PHP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:44:2 [INFO] [stdout] | [INFO] [stdout] 44 | PHP, // PusH Processor status......... | .. ..... S M = F [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Php` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/simulate.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::u16; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u16::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/simulate.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::u8; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u8::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:45:2 [INFO] [stdout] | [INFO] [stdout] 45 | PLA, // PuLl Accumulator.............. | N. ...Z. A S = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:46:2 [INFO] [stdout] | [INFO] [stdout] 46 | PLP, // PuLl Processor status......... | NV BDIZC S = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Plp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:47:2 [INFO] [stdout] | [INFO] [stdout] 47 | ROL, // ROtate Left................... | N. ...ZC A = C A rotated // or N. ...ZC ... [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rol` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ROR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:48:2 [INFO] [stdout] | [INFO] [stdout] 48 | ROR, // ROtate Right.................. | N. ...ZC A = C A rotated // or N. ...ZC ... [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ror` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:49:2 [INFO] [stdout] | [INFO] [stdout] 49 | RTI, // ReTurn from Interrupt......... | NV BDIZC PC = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RTS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:50:2 [INFO] [stdout] | [INFO] [stdout] 50 | RTS, // ReTurn from Subroutine........ | .. ..... PC = M (stack) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:51:2 [INFO] [stdout] | [INFO] [stdout] 51 | SBC, // SuBtract with Carry........... | NV ...ZC A = A-M-(1-C) [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:52:2 [INFO] [stdout] | [INFO] [stdout] 52 | SEC, // SEt Carry flag................ | .. ....C = 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SED` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:53:2 [INFO] [stdout] | [INFO] [stdout] 53 | SED, // SEt Decimal flag.............. | .. .D... = 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEI` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:54:2 [INFO] [stdout] | [INFO] [stdout] 54 | SEI, // SEt Interrupt disable......... | .. ..I.. = 1 [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sei` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:55:2 [INFO] [stdout] | [INFO] [stdout] 55 | STA, // STore Accumulator............. | .. ..... M = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:56:2 [INFO] [stdout] | [INFO] [stdout] 56 | STX, // STore X register.............. | .. ..... M = X [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:57:2 [INFO] [stdout] | [INFO] [stdout] 57 | STY, // STore Y register.............. | .. ..... M = Y [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sty` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:58:2 [INFO] [stdout] | [INFO] [stdout] 58 | TAX, // Transfer Accumulator to X..... | N. ...Z. X = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:59:2 [INFO] [stdout] | [INFO] [stdout] 59 | TAY, // Transfer Accumulator to Y..... | N. ...Z. Y = A [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tay` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TSX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:60:2 [INFO] [stdout] | [INFO] [stdout] 60 | TSX, // Transfer Stack pointer to X... | N. ...Z. X = S [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Tsx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:61:2 [INFO] [stdout] | [INFO] [stdout] 61 | TXA, // Transfer X to Accumulator..... | N. ...Z. A = X [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Txa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TXS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:62:2 [INFO] [stdout] | [INFO] [stdout] 62 | TXS, // Transfer X to Stack pointer... | .. ..... S = X [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Txs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TYA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:63:2 [INFO] [stdout] | [INFO] [stdout] 63 | TYA, // Transfer Y to Accumulator..... | N. ...Z. A = Y [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tya` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ALR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:65:2 [INFO] [stdout] | [INFO] [stdout] 65 | ALR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Alr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AHX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:66:2 [INFO] [stdout] | [INFO] [stdout] 66 | AHX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ahx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ARR` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:67:2 [INFO] [stdout] | [INFO] [stdout] 67 | ARR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Arr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ANC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:68:2 [INFO] [stdout] | [INFO] [stdout] 68 | ANC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Anc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AXS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:69:2 [INFO] [stdout] | [INFO] [stdout] 69 | AXS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Axs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DCP` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:70:2 [INFO] [stdout] | [INFO] [stdout] 70 | DCP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dcp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ISC` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:71:2 [INFO] [stdout] | [INFO] [stdout] 71 | ISC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Isc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LAS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:72:2 [INFO] [stdout] | [INFO] [stdout] 72 | LAS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Las` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LAX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:73:2 [INFO] [stdout] | [INFO] [stdout] 73 | LAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Lax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:74:2 [INFO] [stdout] | [INFO] [stdout] 74 | RLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:75:2 [INFO] [stdout] | [INFO] [stdout] 75 | RRA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SAX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:76:2 [INFO] [stdout] | [INFO] [stdout] 76 | SAX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHX` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:77:2 [INFO] [stdout] | [INFO] [stdout] 77 | SHX, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SHY` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:78:2 [INFO] [stdout] | [INFO] [stdout] 78 | SHY, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Shy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SRE` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:79:2 [INFO] [stdout] | [INFO] [stdout] 79 | SRE, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SLO` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:80:2 [INFO] [stdout] | [INFO] [stdout] 80 | SLO, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Slo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TAS` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:81:2 [INFO] [stdout] | [INFO] [stdout] 81 | TAS, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Tas` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XAA` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:82:2 [INFO] [stdout] | [INFO] [stdout] 82 | XAA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xaa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `KIL` contains a capitalized acronym [INFO] [stdout] --> src/instructions.rs:84:2 [INFO] [stdout] | [INFO] [stdout] 84 | KIL [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Kil` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/instructions.rs:141:11 [INFO] [stdout] | [INFO] [stdout] 141 | let x = cpu.x as u8; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cpu.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/instructions.rs:142:11 [INFO] [stdout] | [INFO] [stdout] 142 | let y = cpu.y as u8; [INFO] [stdout] | ^^^^^^^^^^^ help: try: `cpu.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/instructions.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | let start = (((arr[0] as usize) + x as usize) & 0xFF) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((arr[0] as usize) + x as usize) & 0xFF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/instructions.rs:173:29 [INFO] [stdout] | [INFO] [stdout] 173 | let end = (start + 1) & 0xFF as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `0xFF_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/instructions.rs:182:17 [INFO] [stdout] | [INFO] [stdout] 182 | let start = (((arr[0] as usize)) & 0xFF) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(((arr[0] as usize)) & 0xFF)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/instructions.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | let end = (start + 1) & 0xFF as usize; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `0xFF_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CpuState` which implements the `Copy` trait [INFO] [stdout] --> src/simulate.rs:54:15 [INFO] [stdout] | [INFO] [stdout] 54 | let state = self.states[self.index].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.states[self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/simulate.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn parse_line(line: &String) -> CpuState { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - pub fn parse_line(line: &String) -> CpuState { [INFO] [stdout] 60 + pub fn parse_line(line: &str) -> CpuState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:9:43 [INFO] [stdout] | [INFO] [stdout] 9 | (Instruction::ASL, OpInput::Implied) => format!("ASL"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ASL".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/rom.rs:42:2 [INFO] [stdout] | [INFO] [stdout] 42 | return val[0]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return val[0]; [INFO] [stdout] 42 + val[0] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | (Instruction::CLC, OpInput::Implied) => format!("CLC"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLC".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | (Instruction::CLD, OpInput::Implied) => format!("CLD"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLD".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:23:43 [INFO] [stdout] | [INFO] [stdout] 23 | (Instruction::CLI, OpInput::Implied) => format!("CLI"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLI".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/rom.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 50 | if magic[0] != 'N' as u8 && magic[1] != 'E' as u8 && magic[2] != 'S' as u8 && magic[3] != 0x1a { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'N'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | (Instruction::CLV, OpInput::Implied) => format!("CLV"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLV".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/rom.rs:50:43 [INFO] [stdout] | [INFO] [stdout] 50 | if magic[0] != 'N' as u8 && magic[1] != 'E' as u8 && magic[2] != 'S' as u8 && magic[3] != 0x1a { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'E'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/rom.rs:50:68 [INFO] [stdout] | [INFO] [stdout] 50 | if magic[0] != 'N' as u8 && magic[1] != 'E' as u8 && magic[2] != 'S' as u8 && magic[3] != 0x1a { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'S'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:32:43 [INFO] [stdout] | [INFO] [stdout] 32 | (Instruction::DEX, OpInput::Implied) => format!("DEX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DEX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | (Instruction::DEY, OpInput::Implied) => format!("DEY"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DEY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/rom.rs:106:3 [INFO] [stdout] | [INFO] [stdout] 106 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | (Instruction::INX, OpInput::Implied) => format!("INX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"INX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/simulate.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::u16; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u16::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/simulate.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use std::u8; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u8::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:38:43 [INFO] [stdout] | [INFO] [stdout] 38 | (Instruction::INY, OpInput::Implied) => format!("INY"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"INY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:47:43 [INFO] [stdout] | [INFO] [stdout] 47 | (Instruction::LSR, OpInput::Implied) => format!("LSR"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"LSR".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | (Instruction::PHA, OpInput::Implied) => format!("PHA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PHA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | (Instruction::PHP, OpInput::Implied) => format!("PHP"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PHP".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:53:43 [INFO] [stdout] | [INFO] [stdout] 53 | (Instruction::PLA, OpInput::Implied) => format!("PLA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PLA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | (Instruction::PLP, OpInput::Implied) => format!("PLP"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PLP".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | (Instruction::ROL, OpInput::Implied) => format!("ROL"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ROL".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:57:43 [INFO] [stdout] | [INFO] [stdout] 57 | (Instruction::ROR, OpInput::Implied) => format!("ROR"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ROR".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:59:43 [INFO] [stdout] | [INFO] [stdout] 59 | (Instruction::RTI, OpInput::Implied) => format!("RTI"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"RTI".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:60:43 [INFO] [stdout] | [INFO] [stdout] 60 | (Instruction::RTS, OpInput::Implied) => format!("RTS"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"RTS".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:63:43 [INFO] [stdout] | [INFO] [stdout] 63 | (Instruction::SEC, OpInput::Implied) => format!("SEC"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SEC".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | (Instruction::SED, OpInput::Implied) => format!("SED"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SED".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:65:43 [INFO] [stdout] | [INFO] [stdout] 65 | (Instruction::SEI, OpInput::Implied) => format!("SEI"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SEI".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:69:43 [INFO] [stdout] | [INFO] [stdout] 69 | (Instruction::TAX, OpInput::Implied) => format!("TAX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TAX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:70:43 [INFO] [stdout] | [INFO] [stdout] 70 | (Instruction::TAY, OpInput::Implied) => format!("TAY"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TAY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:71:43 [INFO] [stdout] | [INFO] [stdout] 71 | (Instruction::TSX, OpInput::Implied) => format!("TSX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TSX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:72:43 [INFO] [stdout] | [INFO] [stdout] 72 | (Instruction::TXA, OpInput::Implied) => format!("TXA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TXA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:73:43 [INFO] [stdout] | [INFO] [stdout] 73 | (Instruction::TXS, OpInput::Implied) => format!("TXS"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TXS".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:74:43 [INFO] [stdout] | [INFO] [stdout] 74 | (Instruction::TYA, OpInput::Implied) => format!("TYA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TYA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CpuState` which implements the `Copy` trait [INFO] [stdout] --> src/simulate.rs:54:15 [INFO] [stdout] | [INFO] [stdout] 54 | let state = self.states[self.index].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.states[self.index]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/simulate.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn parse_line(line: &String) -> CpuState { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 60 - pub fn parse_line(line: &String) -> CpuState { [INFO] [stdout] 60 + pub fn parse_line(line: &str) -> CpuState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/main.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | for b in r.rom.into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, b) in (0x8000..).zip(r.rom.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | fp.read_exact(&mut val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | let _ = fp.read_exact(&mut val); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:9:43 [INFO] [stdout] | [INFO] [stdout] 9 | (Instruction::ASL, OpInput::Implied) => format!("ASL"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ASL".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 48 | fp.read_exact(&mut magic); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = fp.read_exact(&mut magic); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:63:3 [INFO] [stdout] | [INFO] [stdout] 63 | fp.seek(SeekFrom::Current(7)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = fp.seek(SeekFrom::Current(7)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fp.seek(SeekFrom::Current(512)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 87 | let _ = fp.seek(SeekFrom::Current(512)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:90:3 [INFO] [stdout] | [INFO] [stdout] 90 | fp.read_exact(&mut rom[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 90 | let _ = fp.read_exact(&mut rom[..]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:91:3 [INFO] [stdout] | [INFO] [stdout] 91 | fp.read_exact(&mut video_rom[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 91 | let _ = fp.read_exact(&mut video_rom[..]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | (Instruction::CLC, OpInput::Implied) => format!("CLC"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLC".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | (Instruction::CLD, OpInput::Implied) => format!("CLD"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLD".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:23:43 [INFO] [stdout] | [INFO] [stdout] 23 | (Instruction::CLI, OpInput::Implied) => format!("CLI"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLI".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | (Instruction::CLV, OpInput::Implied) => format!("CLV"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"CLV".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:32:43 [INFO] [stdout] | [INFO] [stdout] 32 | (Instruction::DEX, OpInput::Implied) => format!("DEX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DEX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | (Instruction::DEY, OpInput::Implied) => format!("DEY"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DEY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | (Instruction::INX, OpInput::Implied) => format!("INX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"INX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:38:43 [INFO] [stdout] | [INFO] [stdout] 38 | (Instruction::INY, OpInput::Implied) => format!("INY"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"INY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:47:43 [INFO] [stdout] | [INFO] [stdout] 47 | (Instruction::LSR, OpInput::Implied) => format!("LSR"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"LSR".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:51:43 [INFO] [stdout] | [INFO] [stdout] 51 | (Instruction::PHA, OpInput::Implied) => format!("PHA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PHA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | (Instruction::PHP, OpInput::Implied) => format!("PHP"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PHP".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:53:43 [INFO] [stdout] | [INFO] [stdout] 53 | (Instruction::PLA, OpInput::Implied) => format!("PLA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PLA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | (Instruction::PLP, OpInput::Implied) => format!("PLP"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"PLP".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | (Instruction::ROL, OpInput::Implied) => format!("ROL"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ROL".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:57:43 [INFO] [stdout] | [INFO] [stdout] 57 | (Instruction::ROR, OpInput::Implied) => format!("ROR"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ROR".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:59:43 [INFO] [stdout] | [INFO] [stdout] 59 | (Instruction::RTI, OpInput::Implied) => format!("RTI"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"RTI".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:60:43 [INFO] [stdout] | [INFO] [stdout] 60 | (Instruction::RTS, OpInput::Implied) => format!("RTS"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"RTS".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:63:43 [INFO] [stdout] | [INFO] [stdout] 63 | (Instruction::SEC, OpInput::Implied) => format!("SEC"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SEC".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:64:43 [INFO] [stdout] | [INFO] [stdout] 64 | (Instruction::SED, OpInput::Implied) => format!("SED"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SED".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:65:43 [INFO] [stdout] | [INFO] [stdout] 65 | (Instruction::SEI, OpInput::Implied) => format!("SEI"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SEI".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:69:43 [INFO] [stdout] | [INFO] [stdout] 69 | (Instruction::TAX, OpInput::Implied) => format!("TAX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TAX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:70:43 [INFO] [stdout] | [INFO] [stdout] 70 | (Instruction::TAY, OpInput::Implied) => format!("TAY"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TAY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:71:43 [INFO] [stdout] | [INFO] [stdout] 71 | (Instruction::TSX, OpInput::Implied) => format!("TSX"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TSX".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:72:43 [INFO] [stdout] | [INFO] [stdout] 72 | (Instruction::TXA, OpInput::Implied) => format!("TXA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TXA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:73:43 [INFO] [stdout] | [INFO] [stdout] 73 | (Instruction::TXS, OpInput::Implied) => format!("TXS"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TXS".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/disasm.rs:74:43 [INFO] [stdout] | [INFO] [stdout] 74 | (Instruction::TYA, OpInput::Implied) => format!("TYA"), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"TYA".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/main.rs:33:2 [INFO] [stdout] | [INFO] [stdout] 33 | for b in r.rom.into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, b) in (0x8000..).zip(r.rom.into_iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:41:2 [INFO] [stdout] | [INFO] [stdout] 41 | fp.read_exact(&mut val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 41 | let _ = fp.read_exact(&mut val); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:48:3 [INFO] [stdout] | [INFO] [stdout] 48 | fp.read_exact(&mut magic); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 48 | let _ = fp.read_exact(&mut magic); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:63:3 [INFO] [stdout] | [INFO] [stdout] 63 | fp.seek(SeekFrom::Current(7)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = fp.seek(SeekFrom::Current(7)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fp.seek(SeekFrom::Current(512)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 87 | let _ = fp.seek(SeekFrom::Current(512)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:90:3 [INFO] [stdout] | [INFO] [stdout] 90 | fp.read_exact(&mut rom[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 90 | let _ = fp.read_exact(&mut rom[..]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/rom.rs:91:3 [INFO] [stdout] | [INFO] [stdout] 91 | fp.read_exact(&mut video_rom[..]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 91 | let _ = fp.read_exact(&mut video_rom[..]); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.56s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "61dd2f64aec10c311867c1f5190228d5208126d9e8fe9d9e3245a92398f5ff4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61dd2f64aec10c311867c1f5190228d5208126d9e8fe9d9e3245a92398f5ff4b", kill_on_drop: false }` [INFO] [stdout] 61dd2f64aec10c311867c1f5190228d5208126d9e8fe9d9e3245a92398f5ff4b