[INFO] cloning repository https://github.com/sbpann/todos-with-axum [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sbpann/todos-with-axum" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsbpann%2Ftodos-with-axum", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsbpann%2Ftodos-with-axum'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6aa9a5e2caea39a9375594bf8b72e0594ed3fdf2 [INFO] linting sbpann/todos-with-axum against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsbpann%2Ftodos-with-axum" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sbpann/todos-with-axum [INFO] finished tweaking git repo https://github.com/sbpann/todos-with-axum [INFO] tweaked toml for git repo https://github.com/sbpann/todos-with-axum written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sbpann/todos-with-axum on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sbpann/todos-with-axum already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sqlx-macros v0.7.3 [INFO] [stderr] Downloaded temp-env v0.3.6 [INFO] [stderr] Downloaded fastrand v2.0.2 [INFO] [stderr] Downloaded sqlx-macros-core v0.7.3 [INFO] [stderr] Downloaded sync_wrapper v1.0.0 [INFO] [stderr] Downloaded atomic-write-file v0.1.3 [INFO] [stderr] Downloaded sqlx-sqlite v0.7.3 [INFO] [stderr] Downloaded sqlx-mysql v0.7.3 [INFO] [stderr] Downloaded sqlx-postgres v0.7.3 [INFO] [stderr] Downloaded sqlx-core v0.7.3 [INFO] [stderr] Downloaded sqlx v0.7.3 [INFO] [stderr] Downloaded hyper v1.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a6757109130dc8b963b84d46a080205fca28cc6b40390311e52f03007cdd518a [INFO] running `Command { std: "docker" "start" "-a" "a6757109130dc8b963b84d46a080205fca28cc6b40390311e52f03007cdd518a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a6757109130dc8b963b84d46a080205fca28cc6b40390311e52f03007cdd518a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6757109130dc8b963b84d46a080205fca28cc6b40390311e52f03007cdd518a", kill_on_drop: false }` [INFO] [stdout] a6757109130dc8b963b84d46a080205fca28cc6b40390311e52f03007cdd518a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f84d5741c006d2bcad2da9dbe008985505fb29d5a1f3db8c5c842fe21c7a4de0 [INFO] running `Command { std: "docker" "start" "-a" "f84d5741c006d2bcad2da9dbe008985505fb29d5a1f3db8c5c842fe21c7a4de0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling zerocopy v0.7.32 [INFO] [stderr] Compiling allocator-api2 v0.2.16 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling ryu v1.0.17 [INFO] [stderr] Compiling futures-util v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling crc v3.0.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.11 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling getrandom v0.2.12 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling mio v0.8.11 [INFO] [stderr] Compiling socket2 v0.5.6 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling tokio v1.37.0 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling finl_unicode v1.2.0 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling stringprep v0.1.4 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling sha1 v0.10.6 [INFO] [stderr] Compiling fastrand v2.0.2 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Compiling atomic-write-file v0.1.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling tokio-stream v0.1.15 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking sync_wrapper v1.0.0 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling relative-path v1.9.2 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking uuid v1.8.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking temp-env v0.3.6 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Compiling sqlformat v0.2.3 [INFO] [stderr] Checking sqlx-core v0.7.3 [INFO] [stderr] Checking sqlx-postgres v0.7.3 [INFO] [stderr] Compiling sqlx-macros-core v0.7.3 [INFO] [stderr] Compiling sqlx-macros v0.7.3 [INFO] [stderr] Checking sqlx v0.7.3 [INFO] [stderr] Checking todos-with-axum v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/tests/configs/state.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[cfg(test)] [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | mod tests { [INFO] [stdout] | --------- the attribute applies to this module [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the attribute should apply to the parent module use an inner attribute [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg(test)] [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/utils/app.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn build_router(modules: Vec<(&str, fn() -> Router)>) -> Router [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/app.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return format!("{}:{}", host, port); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return format!("{}:{}", host, port); [INFO] [stdout] 19 + format!("{}:{}", host, port) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | let mut module_list: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / let mut module_list: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] 21 | | module_list.push(("/todos", router::todos_router)); [INFO] [stdout] | |_______________________________________________________^ help: consider using the `vec![]` macro: `let module_list: Vec<(&str, fn() -> Router>)> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/utils/app.rs:5:33 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn build_router(modules: Vec<(&str, fn() -> Router)>) -> Router [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/app.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return format!("{}:{}", host, port); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return format!("{}:{}", host, port); [INFO] [stdout] 19 + format!("{}:{}", host, port) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tests/configs/db.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | let pg_pool = new_pg_pool(&database_url).await; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `database_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/tests/configs/db.rs:14:29 [INFO] [stdout] | [INFO] [stdout] 14 | Ok(mut conn) => match conn.ping().await { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 15 | | Err(error) => panic!("{}", error), [INFO] [stdout] 16 | | Ok(_) => {} [INFO] [stdout] 17 | | }, [INFO] [stdout] | |_____________^ help: try: `if let Err(error) = conn.ping().await { panic!("{}", error) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/configs/state.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | assert!(!database.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `database.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tests/utils/app.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | let modules: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tests/utils/app.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 35 | let mut modules: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tests/utils/app.rs:51:26 [INFO] [stdout] | [INFO] [stdout] 51 | let mut modules: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/utils/app.rs:69:17 [INFO] [stdout] | [INFO] [stdout] 69 | assert!(!local_addr_result.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `local_addr_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | let mut module_list: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/main.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | / let mut module_list: Vec<(&str, fn() -> Router>)> = vec![]; [INFO] [stdout] 21 | | module_list.push(("/todos", router::todos_router)); [INFO] [stdout] | |_______________________________________________________^ help: consider using the `vec![]` macro: `let module_list: Vec<(&str, fn() -> Router>)> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 06s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: sqlx-postgres v0.7.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "f84d5741c006d2bcad2da9dbe008985505fb29d5a1f3db8c5c842fe21c7a4de0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f84d5741c006d2bcad2da9dbe008985505fb29d5a1f3db8c5c842fe21c7a4de0", kill_on_drop: false }` [INFO] [stdout] f84d5741c006d2bcad2da9dbe008985505fb29d5a1f3db8c5c842fe21c7a4de0