[INFO] cloning repository https://github.com/sandeshgrangdan/antivirus [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sandeshgrangdan/antivirus" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsandeshgrangdan%2Fantivirus", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsandeshgrangdan%2Fantivirus'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 46b81c21a33dd9a27ec88723734907559e129a46 [INFO] linting sandeshgrangdan/antivirus against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsandeshgrangdan%2Fantivirus" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sandeshgrangdan/antivirus [INFO] finished tweaking git repo https://github.com/sandeshgrangdan/antivirus [INFO] tweaked toml for git repo https://github.com/sandeshgrangdan/antivirus written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sandeshgrangdan/antivirus on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sandeshgrangdan/antivirus already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5f6cf70d10d8f0111a7f1c223be38c003124654a40ba6bf4cd27036bb59246d [INFO] running `Command { std: "docker" "start" "-a" "b5f6cf70d10d8f0111a7f1c223be38c003124654a40ba6bf4cd27036bb59246d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5f6cf70d10d8f0111a7f1c223be38c003124654a40ba6bf4cd27036bb59246d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5f6cf70d10d8f0111a7f1c223be38c003124654a40ba6bf4cd27036bb59246d", kill_on_drop: false }` [INFO] [stdout] b5f6cf70d10d8f0111a7f1c223be38c003124654a40ba6bf4cd27036bb59246d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 169de82b61558007a3f48062d731d067d6edba1ce129a0668252e7049009cbd6 [INFO] running `Command { std: "docker" "start" "-a" "169de82b61558007a3f48062d731d067d6edba1ce129a0668252e7049009cbd6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking antivirus v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/antivirus/linux.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(io::Error::new(io::ErrorKind::Other, "Unsupported distribution")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 68 - return Err(io::Error::new(io::ErrorKind::Other, "Unsupported distribution")); [INFO] [stdout] 68 + return Err(io::Error::other("Unsupported distribution")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/antivirus/linux.rs:68:24 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(io::Error::new(io::ErrorKind::Other, "Unsupported distribution")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 68 - return Err(io::Error::new(io::ErrorKind::Other, "Unsupported distribution")); [INFO] [stdout] 68 + return Err(io::Error::other("Unsupported distribution")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/antivirus/macos.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !Command::new("brew").output().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Command::new("brew").output().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/antivirus/macos.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !Command::new("brew").output().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Command::new("brew").output().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:63:37 [INFO] [stdout] | [INFO] [stdout] 63 | fs::copy(freshclam_conf_source, &freshclam_conf_destination)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:63:37 [INFO] [stdout] | [INFO] [stdout] 63 | fs::copy(freshclam_conf_source, &freshclam_conf_destination)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | fs::rename(&temp_config_path, &freshclam_conf_destination)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `temp_config_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:85:20 [INFO] [stdout] | [INFO] [stdout] 85 | fs::rename(&temp_config_path, &freshclam_conf_destination)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `temp_config_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | fs::rename(&temp_config_path, &freshclam_conf_destination)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | fs::rename(&temp_config_path, &freshclam_conf_destination)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:89:50 [INFO] [stdout] | [INFO] [stdout] 89 | let freshclam_permissions = fs::metadata(&freshclam_conf_destination)?.permissions(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:89:50 [INFO] [stdout] | [INFO] [stdout] 89 | let freshclam_permissions = fs::metadata(&freshclam_conf_destination)?.permissions(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | .arg(&freshclam_conf_destination) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:95:18 [INFO] [stdout] | [INFO] [stdout] 95 | .arg(&freshclam_conf_destination) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `freshclam_conf_destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/antivirus.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | Err(io::Error::new(io::ErrorKind::Other, "Command failed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 196 - Err(io::Error::new(io::ErrorKind::Other, "Command failed")) [INFO] [stdout] 196 + Err(io::Error::other("Command failed")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/antivirus.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | let _ = handle_freshclam_copy_windows("C:\\ProgramData\\.clamav")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 208 - let _ = handle_freshclam_copy_windows("C:\\ProgramData\\.clamav")?; [INFO] [stdout] 208 + handle_freshclam_copy_windows("C:\\ProgramData\\.clamav")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/antivirus.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | Err(io::Error::new(io::ErrorKind::Other, "Failed to run freshclam with sudo")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 222 - Err(io::Error::new(io::ErrorKind::Other, "Failed to run freshclam with sudo")) [INFO] [stdout] 222 + Err(io::Error::other("Failed to run freshclam with sudo")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/antivirus.rs:196:17 [INFO] [stdout] | [INFO] [stdout] 196 | Err(io::Error::new(io::ErrorKind::Other, "Command failed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 196 - Err(io::Error::new(io::ErrorKind::Other, "Command failed")) [INFO] [stdout] 196 + Err(io::Error::other("Command failed")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/antivirus.rs:208:13 [INFO] [stdout] | [INFO] [stdout] 208 | let _ = handle_freshclam_copy_windows("C:\\ProgramData\\.clamav")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 208 - let _ = handle_freshclam_copy_windows("C:\\ProgramData\\.clamav")?; [INFO] [stdout] 208 + handle_freshclam_copy_windows("C:\\ProgramData\\.clamav")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/antivirus.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | Err(io::Error::new(io::ErrorKind::Other, "Failed to run freshclam with sudo")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 222 - Err(io::Error::new(io::ErrorKind::Other, "Failed to run freshclam with sudo")) [INFO] [stdout] 222 + Err(io::Error::other("Failed to run freshclam with sudo")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/antivirus.rs:251:31 [INFO] [stdout] | [INFO] [stdout] 251 | let google_chat_url = match env::var("ANTIVIRUS_GOOGLE_CHAT_URL=") { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 252 | | Ok(url) => url, [INFO] [stdout] 253 | | _ => String::new() [INFO] [stdout] 254 | | }; [INFO] [stdout] | |_________^ help: replace it with: `env::var("ANTIVIRUS_GOOGLE_CHAT_URL=").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/antivirus.rs:251:31 [INFO] [stdout] | [INFO] [stdout] 251 | let google_chat_url = match env::var("ANTIVIRUS_GOOGLE_CHAT_URL=") { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 252 | | Ok(url) => url, [INFO] [stdout] 253 | | _ => String::new() [INFO] [stdout] 254 | | }; [INFO] [stdout] | |_________^ help: replace it with: `env::var("ANTIVIRUS_GOOGLE_CHAT_URL=").unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:274:15 [INFO] [stdout] | [INFO] [stdout] 274 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 275 | | "--archive-verbose", [INFO] [stdout] 276 | | "--alert-exceeds-max=yes", [INFO] [stdout] 277 | | "--alert-encrypted=yes", [INFO] [stdout] ... | [INFO] [stdout] 287 | | dir [INFO] [stdout] 288 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 274 ~ .args([ [INFO] [stdout] 275 + "--archive-verbose", [INFO] [stdout] 276 + "--alert-exceeds-max=yes", [INFO] [stdout] 277 + "--alert-encrypted=yes", [INFO] [stdout] 278 + "--max-filesize=10000M", [INFO] [stdout] 279 + "--max-scansize=10000M", [INFO] [stdout] 280 + "--max-files=1000000", [INFO] [stdout] 281 + "--max-recursion=512", [INFO] [stdout] 282 + "--max-htmlnotags=256M", [INFO] [stdout] 283 + "--max-scriptnormalize=256M", [INFO] [stdout] 284 + "--max-ziptypercg=16M", [INFO] [stdout] 285 + "--pcre-max-filesize=4095M", [INFO] [stdout] 286 + "-r", [INFO] [stdout] 287 + dir [INFO] [stdout] 288 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/antivirus.rs:274:15 [INFO] [stdout] | [INFO] [stdout] 274 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 275 | | "--archive-verbose", [INFO] [stdout] 276 | | "--alert-exceeds-max=yes", [INFO] [stdout] 277 | | "--alert-encrypted=yes", [INFO] [stdout] ... | [INFO] [stdout] 287 | | dir [INFO] [stdout] 288 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 274 ~ .args([ [INFO] [stdout] 275 + "--archive-verbose", [INFO] [stdout] 276 + "--alert-exceeds-max=yes", [INFO] [stdout] 277 + "--alert-encrypted=yes", [INFO] [stdout] 278 + "--max-filesize=10000M", [INFO] [stdout] 279 + "--max-scansize=10000M", [INFO] [stdout] 280 + "--max-files=1000000", [INFO] [stdout] 281 + "--max-recursion=512", [INFO] [stdout] 282 + "--max-htmlnotags=256M", [INFO] [stdout] 283 + "--max-scriptnormalize=256M", [INFO] [stdout] 284 + "--max-ziptypercg=16M", [INFO] [stdout] 285 + "--pcre-max-filesize=4095M", [INFO] [stdout] 286 + "-r", [INFO] [stdout] 287 + dir [INFO] [stdout] 288 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/antivirus.rs:327:32 [INFO] [stdout] | [INFO] [stdout] 327 | ... if found_infected == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!found_infected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/antivirus.rs:327:32 [INFO] [stdout] | [INFO] [stdout] 327 | ... if found_infected == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!found_infected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 342 | if self.infected_files != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.infected_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 342 | if self.infected_files != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.infected_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 353 | if self.google_chat_url != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.google_chat_url.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:355:16 [INFO] [stdout] | [INFO] [stdout] 355 | if self.infected_files != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.infected_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/antivirus.rs:356:35 [INFO] [stdout] | [INFO] [stdout] 356 | self.google_chat(&format!("{}",&self.infected_files)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&self.infected_files).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 353 | if self.google_chat_url != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.google_chat_url.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:355:16 [INFO] [stdout] | [INFO] [stdout] 355 | if self.infected_files != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.infected_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/antivirus.rs:356:35 [INFO] [stdout] | [INFO] [stdout] 356 | self.google_chat(&format!("{}",&self.infected_files)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(&self.infected_files).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:386:12 [INFO] [stdout] | [INFO] [stdout] 386 | if self.infected_files != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.infected_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/antivirus.rs:308:39 [INFO] [stdout] | [INFO] [stdout] 308 | let infected_regex_patterns = vec![ [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 309 | | Regex::new(r" FOUND$").unwrap(), [INFO] [stdout] 310 | | ]; [INFO] [stdout] | |_________^ help: you can use an array directly: `[Regex::new(r" FOUND$").unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/antivirus.rs:386:12 [INFO] [stdout] | [INFO] [stdout] 386 | if self.infected_files != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.infected_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/antivirus.rs:308:39 [INFO] [stdout] | [INFO] [stdout] 308 | let infected_regex_patterns = vec![ [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 309 | | Regex::new(r" FOUND$").unwrap(), [INFO] [stdout] 310 | | ]; [INFO] [stdout] | |_________^ help: you can use an array directly: `[Regex::new(r" FOUND$").unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.17s [INFO] running `Command { std: "docker" "inspect" "169de82b61558007a3f48062d731d067d6edba1ce129a0668252e7049009cbd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "169de82b61558007a3f48062d731d067d6edba1ce129a0668252e7049009cbd6", kill_on_drop: false }` [INFO] [stdout] 169de82b61558007a3f48062d731d067d6edba1ce129a0668252e7049009cbd6