[INFO] cloning repository https://github.com/samuelselleck/particle-based-fluid-simulation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/samuelselleck/particle-based-fluid-simulation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuelselleck%2Fparticle-based-fluid-simulation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuelselleck%2Fparticle-based-fluid-simulation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0c510cf036a0d6116f3feb2995a0200d6971426f [INFO] linting samuelselleck/particle-based-fluid-simulation against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuelselleck%2Fparticle-based-fluid-simulation" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/samuelselleck/particle-based-fluid-simulation [INFO] finished tweaking git repo https://github.com/samuelselleck/particle-based-fluid-simulation [INFO] tweaked toml for git repo https://github.com/samuelselleck/particle-based-fluid-simulation written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/samuelselleck/particle-based-fluid-simulation on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/samuelselleck/particle-based-fluid-simulation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded piston-viewport v1.0.0 [INFO] [stderr] Downloaded piston-float v1.0.0 [INFO] [stderr] Downloaded pistoncore-window v0.47.0 [INFO] [stderr] Downloaded piston-graphics_api_version v1.0.0 [INFO] [stderr] Downloaded shader_version v0.7.0 [INFO] [stderr] Downloaded glutin_wgl_sys v0.1.4 [INFO] [stderr] Downloaded pistoncore-input v1.0.0 [INFO] [stderr] Downloaded glutin v0.21.2 [INFO] [stderr] Downloaded piston v0.52.0 [INFO] [stderr] Downloaded interpolation v0.2.0 [INFO] [stderr] Downloaded piston-texture v0.8.0 [INFO] [stderr] Downloaded pistoncore-event_loop v0.52.0 [INFO] [stderr] Downloaded piston2d-graphics v0.36.0 [INFO] [stderr] Downloaded gleam v0.6.19 [INFO] [stderr] Downloaded png v0.16.7 [INFO] [stderr] Downloaded wayland-client v0.21.13 [INFO] [stderr] Downloaded smithay-client-toolkit v0.4.6 [INFO] [stderr] Downloaded wayland-protocols v0.21.13 [INFO] [stderr] Downloaded cocoa v0.18.5 [INFO] [stderr] Downloaded libloading v0.6.2 [INFO] [stderr] Downloaded gl_generator v0.13.1 [INFO] [stderr] Downloaded syn v1.0.38 [INFO] [stderr] Downloaded image v0.23.8 [INFO] [stderr] Downloaded winit v0.19.5 [INFO] [stderr] Downloaded wayland-commons v0.21.13 [INFO] [stderr] Downloaded bytemuck v1.3.1 [INFO] [stderr] Downloaded gif v0.10.3 [INFO] [stderr] Downloaded tiff v0.5.0 [INFO] [stderr] Downloaded gl v0.11.0 [INFO] [stderr] Downloaded wayland-scanner v0.21.13 [INFO] [stderr] Downloaded khronos_api v2.2.0 [INFO] [stderr] Downloaded glutin_gles2_sys v0.1.4 [INFO] [stderr] Downloaded glutin_glx_sys v0.1.6 [INFO] [stderr] Downloaded piston-shaders_graphics2d v0.3.1 [INFO] [stderr] Downloaded piston2d-opengl_graphics v0.73.0 [INFO] [stderr] Downloaded read_color v1.0.0 [INFO] [stderr] Downloaded vecmath v1.0.0 [INFO] [stderr] Downloaded glutin_egl_sys v0.1.4 [INFO] [stderr] Downloaded ordered-float v1.1.0 [INFO] [stderr] Downloaded wayland-sys v0.21.13 [INFO] [stderr] Downloaded pistoncore-glutin_window v0.66.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58748548fa85dd399f01331113c9b8a114e00527505f0eac59bbf5f5a5166ced [INFO] running `Command { std: "docker" "start" "-a" "58748548fa85dd399f01331113c9b8a114e00527505f0eac59bbf5f5a5166ced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58748548fa85dd399f01331113c9b8a114e00527505f0eac59bbf5f5a5166ced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58748548fa85dd399f01331113c9b8a114e00527505f0eac59bbf5f5a5166ced", kill_on_drop: false }` [INFO] [stdout] 58748548fa85dd399f01331113c9b8a114e00527505f0eac59bbf5f5a5166ced [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f75d8edb4d80130e51998a990b608777c1e6a9eac7168f7693edc12324d4a757 [INFO] running `Command { std: "docker" "start" "-a" "f75d8edb4d80130e51998a990b608777c1e6a9eac7168f7693edc12324d4a757", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling libloading v0.6.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking piston-float v1.0.0 [INFO] [stderr] Compiling syn v1.0.38 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking piston-graphics_api_version v1.0.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking piston-viewport v1.0.0 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling cc v1.0.58 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking rayon-core v1.7.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking shader_version v0.7.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking rayon v1.3.1 [INFO] [stderr] Checking vecmath v1.0.0 [INFO] [stderr] Checking read_color v1.0.0 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Checking piston-texture v0.8.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking bytemuck v1.3.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking interpolation v0.2.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Compiling glutin_glx_sys v0.1.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking piston-shaders_graphics2d v0.3.1 [INFO] [stderr] Checking piston2d-graphics v0.36.0 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking image v0.23.8 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking piston2d-opengl_graphics v0.73.0 [INFO] [stderr] Checking pistoncore-input v1.0.0 [INFO] [stderr] Checking pistoncore-window v0.47.0 [INFO] [stderr] Checking pistoncore-event_loop v0.52.0 [INFO] [stderr] Checking piston v0.52.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.21.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.66.0 [INFO] [stderr] Checking piston_project v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:113:50 [INFO] [stdout] | [INFO] [stdout] 113 | Some(points) => {points.push(i); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:114:59 [INFO] [stdout] | [INFO] [stdout] 114 | None => {buckets.insert(bucket, vec![i]); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:257:21 [INFO] [stdout] | [INFO] [stdout] 257 | ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:262:63 [INFO] [stdout] | [INFO] [stdout] 262 | Some(points) => {points.push(particle_index); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:263:76 [INFO] [stdout] | [INFO] [stdout] 263 | None => {buckets.insert(new_bucket, vec![particle_index]); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:113:50 [INFO] [stdout] | [INFO] [stdout] 113 | Some(points) => {points.push(i); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:114:59 [INFO] [stdout] | [INFO] [stdout] 114 | None => {buckets.insert(bucket, vec![i]); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:257:21 [INFO] [stdout] | [INFO] [stdout] 257 | ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:262:63 [INFO] [stdout] | [INFO] [stdout] 262 | Some(points) => {points.push(particle_index); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit expression [INFO] [stdout] --> src/particle_fluid.rs:263:76 [INFO] [stdout] | [INFO] [stdout] 263 | None => {buckets.insert(new_bucket, vec![particle_index]); ()}, [INFO] [stdout] | ^^ help: remove the final `()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `particles` [INFO] [stdout] --> src/particle_fluid.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 110 | for i in 0..particles.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 110 - for i in 0..particles.len() { [INFO] [stdout] 110 + for (i, ) in particles.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:136:18 [INFO] [stdout] | [INFO] [stdout] 136 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 136 - for i in 0..p.len() { [INFO] [stdout] 136 + for in &mut p { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:156:18 [INFO] [stdout] | [INFO] [stdout] 156 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 156 - for i in 0..p.len() { [INFO] [stdout] 156 + for in &mut p { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 166 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 166 - for i in 0..p.len() { [INFO] [stdout] 166 + for in &mut p { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `particles` [INFO] [stdout] --> src/particle_fluid.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 110 | for i in 0..particles.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 110 - for i in 0..particles.len() { [INFO] [stdout] 110 + for (i, ) in particles.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/particle_fluid.rs:201:36 [INFO] [stdout] | [INFO] [stdout] 201 | p[i].force.add((&mut j_vel_copy).sub(&p[i].velocity).mult(factor)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `j_vel_copy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:211:18 [INFO] [stdout] | [INFO] [stdout] 211 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 211 - for i in 0..p.len() { [INFO] [stdout] 211 + for (i, ) in p.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:136:18 [INFO] [stdout] | [INFO] [stdout] 136 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 136 - for i in 0..p.len() { [INFO] [stdout] 136 + for in &mut p { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:156:18 [INFO] [stdout] | [INFO] [stdout] 156 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 156 - for i in 0..p.len() { [INFO] [stdout] 156 + for in &mut p { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 166 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 166 - for i in 0..p.len() { [INFO] [stdout] 166 + for in &mut p { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/particle_fluid.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 250 | if !(old_bucket == new_bucket) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(old_bucket != new_bucket)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/particle_fluid.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | / match buckets.get_mut(&old_bucket) { [INFO] [stdout] 252 | | Some(points) => { [INFO] [stdout] 253 | | points.retain(|&x| x != particle_index); [INFO] [stdout] 254 | | if points.len() == 0 { [INFO] [stdout] ... | [INFO] [stdout] 258 | | None => (), [INFO] [stdout] 259 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 251 ~ if let Some(points) = buckets.get_mut(&old_bucket) { [INFO] [stdout] 252 + points.retain(|&x| x != particle_index); [INFO] [stdout] 253 + if points.len() == 0 { [INFO] [stdout] 254 + buckets.remove(&old_bucket); [INFO] [stdout] 255 + } [INFO] [stdout] 256 ~ ()}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/particle_fluid.rs:254:24 [INFO] [stdout] | [INFO] [stdout] 254 | if points.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `points.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/particle_fluid.rs:201:36 [INFO] [stdout] | [INFO] [stdout] 201 | p[i].force.add((&mut j_vel_copy).sub(&p[i].velocity).mult(factor)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `j_vel_copy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `p` [INFO] [stdout] --> src/particle_fluid.rs:211:18 [INFO] [stdout] | [INFO] [stdout] 211 | for i in 0..p.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 211 - for i in 0..p.len() { [INFO] [stdout] 211 + for (i, ) in p.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/particle_fluid.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / match buckets.get(&bucket_index) { [INFO] [stdout] 289 | | Some(points) => for p in points { main.push(*p) }, [INFO] [stdout] 290 | | None => (), [INFO] [stdout] 291 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(points) = buckets.get(&bucket_index) { for p in points { main.push(*p) } }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/particle_fluid.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | / match buckets.get(&(bucket_index + offset)) { [INFO] [stdout] 296 | | Some(points) => for p in points { all.push(*p) }, [INFO] [stdout] 297 | | None => (), [INFO] [stdout] 298 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(points) = buckets.get(&(bucket_index + offset)) { for p in points { all.push(*p) } }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/particle_fluid.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 250 | if !(old_bucket == new_bucket) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(old_bucket != new_bucket)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/particle_fluid.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | / match buckets.get_mut(&old_bucket) { [INFO] [stdout] 252 | | Some(points) => { [INFO] [stdout] 253 | | points.retain(|&x| x != particle_index); [INFO] [stdout] 254 | | if points.len() == 0 { [INFO] [stdout] ... | [INFO] [stdout] 258 | | None => (), [INFO] [stdout] 259 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 251 ~ if let Some(points) = buckets.get_mut(&old_bucket) { [INFO] [stdout] 252 + points.retain(|&x| x != particle_index); [INFO] [stdout] 253 + if points.len() == 0 { [INFO] [stdout] 254 + buckets.remove(&old_bucket); [INFO] [stdout] 255 + } [INFO] [stdout] 256 ~ ()}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/particle_fluid.rs:254:24 [INFO] [stdout] | [INFO] [stdout] 254 | if points.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `points.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/particle_fluid.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / match buckets.get(&bucket_index) { [INFO] [stdout] 289 | | Some(points) => for p in points { main.push(*p) }, [INFO] [stdout] 290 | | None => (), [INFO] [stdout] 291 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(points) = buckets.get(&bucket_index) { for p in points { main.push(*p) } }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/particle_fluid.rs:295:13 [INFO] [stdout] | [INFO] [stdout] 295 | / match buckets.get(&(bucket_index + offset)) { [INFO] [stdout] 296 | | Some(points) => for p in points { all.push(*p) }, [INFO] [stdout] 297 | | None => (), [INFO] [stdout] 298 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(points) = buckets.get(&(bucket_index + offset)) { for p in points { all.push(*p) } }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.43s [INFO] running `Command { std: "docker" "inspect" "f75d8edb4d80130e51998a990b608777c1e6a9eac7168f7693edc12324d4a757", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f75d8edb4d80130e51998a990b608777c1e6a9eac7168f7693edc12324d4a757", kill_on_drop: false }` [INFO] [stdout] f75d8edb4d80130e51998a990b608777c1e6a9eac7168f7693edc12324d4a757