[INFO] cloning repository https://github.com/sahandevs/tsmatch
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sahandevs/tsmatch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsahandevs%2Ftsmatch", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsahandevs%2Ftsmatch'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] c128d1d96110abe7e6916c0e4c65aefced35dad0
[INFO] linting sahandevs/tsmatch against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsahandevs%2Ftsmatch" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/sahandevs/tsmatch
[INFO] finished tweaking git repo https://github.com/sahandevs/tsmatch
[INFO] tweaked toml for git repo https://github.com/sahandevs/tsmatch written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/sahandevs/tsmatch on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/sahandevs/tsmatch already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 86320c45002f6803ae02da25b1adee69a58d8bc596f3166f21747c2958e65f21
[INFO] running `Command { std: "docker" "start" "-a" "86320c45002f6803ae02da25b1adee69a58d8bc596f3166f21747c2958e65f21", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "86320c45002f6803ae02da25b1adee69a58d8bc596f3166f21747c2958e65f21", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "86320c45002f6803ae02da25b1adee69a58d8bc596f3166f21747c2958e65f21", kill_on_drop: false }`
[INFO] [stdout] 86320c45002f6803ae02da25b1adee69a58d8bc596f3166f21747c2958e65f21
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 11465e3d13510b38c523117469e851f9e0198697ac7208723ed2d179a79d1363
[INFO] running `Command { std: "docker" "start" "-a" "11465e3d13510b38c523117469e851f9e0198697ac7208723ed2d179a79d1363", kill_on_drop: false }`
[INFO] [stderr]     Checking tsmatch v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/pattern/trend.rs:18:16
[INFO] [stdout]    |
[INFO] [stdout] 18 |             if segment.len() > 0 {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!segment.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/pattern/trend.rs:67:8
[INFO] [stdout]    |
[INFO] [stdout] 67 |     if out.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `TimeSeriesPattern<T>`
[INFO] [stdout]   --> src/pattern/trend2.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     pub fn new() -> Self {
[INFO] [stdout] 19 | |         Self { phases: Vec::new() }
[INFO] [stdout] 20 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 14 + impl<T> Default for TimeSeriesPattern<T>
[INFO] [stdout] 15 + where
[INFO] [stdout] 16 +     T: Copy + Ord + Debug,
[INFO] [stdout] 17 +  {
[INFO] [stdout] 18 +     fn default() -> Self {
[INFO] [stdout] 19 +         Self::new()
[INFO] [stdout] 20 +     }
[INFO] [stdout] 21 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/pattern/trend2.rs:41:17
[INFO] [stdout]    |
[INFO] [stdout] 41 |         assert!(self.phases.len() > 0);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.phases.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/pattern/trend2.rs:84:21
[INFO] [stdout]    |
[INFO] [stdout] 84 |                     view_start = view_start + 1;
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_start += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/pattern/trend2.rs:113:21
[INFO] [stdout]     |
[INFO] [stdout] 113 |                     view_start = view_start + 1;
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_start += 1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a
[INFO] [stdout]  --> src/utils/noise.rs:3:30
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub fn remove_small_segments<'a, 'b, T>(
[INFO] [stdout]   |                              ^^
[INFO] [stdout] 4 |     segments: &'a [Segment<'b, T>],
[INFO] [stdout]   |                ^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stdout]   = note: `#[warn(clippy::needless_lifetimes)]` on by default
[INFO] [stdout] help: elide the lifetimes
[INFO] [stdout]   |
[INFO] [stdout] 3 ~ pub fn remove_small_segments<'b, T>(
[INFO] [stdout] 4 ~     segments: &[Segment<'b, T>],
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/utils/noise.rs:7:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | /     segments
[INFO] [stdout]  8 | |         .into_iter()
[INFO] [stdout]  9 | |         .filter(|x| x.len() > threshold)
[INFO] [stdout] 10 | |         .map(|x| *x)
[INFO] [stdout]    | |____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] help: consider calling the dedicated `copied` method
[INFO] [stdout]    |
[INFO] [stdout]  7 ~     segments
[INFO] [stdout]  8 +         .into_iter()
[INFO] [stdout]  9 +         .filter(|x| x.len() > threshold).copied()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
[INFO] [stdout]  --> src/utils/noise.rs:8:10
[INFO] [stdout]   |
[INFO] [stdout] 8 |         .into_iter()
[INFO] [stdout]   |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]   = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/pattern/trend.rs:18:16
[INFO] [stdout]    |
[INFO] [stdout] 18 |             if segment.len() > 0 {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!segment.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/pattern/trend.rs:67:8
[INFO] [stdout]    |
[INFO] [stdout] 67 |     if out.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `TimeSeriesPattern<T>`
[INFO] [stdout]   --> src/pattern/trend2.rs:18:5
[INFO] [stdout]    |
[INFO] [stdout] 18 | /     pub fn new() -> Self {
[INFO] [stdout] 19 | |         Self { phases: Vec::new() }
[INFO] [stdout] 20 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 14 + impl<T> Default for TimeSeriesPattern<T>
[INFO] [stdout] 15 + where
[INFO] [stdout] 16 +     T: Copy + Ord + Debug,
[INFO] [stdout] 17 +  {
[INFO] [stdout] 18 +     fn default() -> Self {
[INFO] [stdout] 19 +         Self::new()
[INFO] [stdout] 20 +     }
[INFO] [stdout] 21 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/pattern/trend2.rs:41:17
[INFO] [stdout]    |
[INFO] [stdout] 41 |         assert!(self.phases.len() > 0);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.phases.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/pattern/trend2.rs:84:21
[INFO] [stdout]    |
[INFO] [stdout] 84 |                     view_start = view_start + 1;
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_start += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]    = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/pattern/trend2.rs:113:21
[INFO] [stdout]     |
[INFO] [stdout] 113 |                     view_start = view_start + 1;
[INFO] [stdout]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_start += 1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/pattern/trend2.rs:198:17
[INFO] [stdout]     |
[INFO] [stdout] 198 |         assert!(!pattern.matches(&samples10).is_ok());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pattern.matches(&samples10).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/pattern/trend2.rs:199:17
[INFO] [stdout]     |
[INFO] [stdout] 199 |         assert!(!pattern.matches(&samples11).is_ok());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pattern.matches(&samples11).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a
[INFO] [stdout]  --> src/utils/noise.rs:3:30
[INFO] [stdout]   |
[INFO] [stdout] 3 | pub fn remove_small_segments<'a, 'b, T>(
[INFO] [stdout]   |                              ^^
[INFO] [stdout] 4 |     segments: &'a [Segment<'b, T>],
[INFO] [stdout]   |                ^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stdout]   = note: `#[warn(clippy::needless_lifetimes)]` on by default
[INFO] [stdout] help: elide the lifetimes
[INFO] [stdout]   |
[INFO] [stdout] 3 ~ pub fn remove_small_segments<'b, T>(
[INFO] [stdout] 4 ~     segments: &[Segment<'b, T>],
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/utils/noise.rs:7:5
[INFO] [stdout]    |
[INFO] [stdout]  7 | /     segments
[INFO] [stdout]  8 | |         .into_iter()
[INFO] [stdout]  9 | |         .filter(|x| x.len() > threshold)
[INFO] [stdout] 10 | |         .map(|x| *x)
[INFO] [stdout]    | |____________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] help: consider calling the dedicated `copied` method
[INFO] [stdout]    |
[INFO] [stdout]  7 ~     segments
[INFO] [stdout]  8 +         .into_iter()
[INFO] [stdout]  9 +         .filter(|x| x.len() > threshold).copied()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`
[INFO] [stdout]  --> src/utils/noise.rs:8:10
[INFO] [stdout]   |
[INFO] [stdout] 8 |         .into_iter()
[INFO] [stdout]   |          ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]   = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.34s
[INFO] running `Command { std: "docker" "inspect" "11465e3d13510b38c523117469e851f9e0198697ac7208723ed2d179a79d1363", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "11465e3d13510b38c523117469e851f9e0198697ac7208723ed2d179a79d1363", kill_on_drop: false }`
[INFO] [stdout] 11465e3d13510b38c523117469e851f9e0198697ac7208723ed2d179a79d1363