[INFO] cloning repository https://github.com/sagarreddypatil/language [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sagarreddypatil/language" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsagarreddypatil%2Flanguage", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsagarreddypatil%2Flanguage'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 29bd8e578ce0a93f8b5159cd7dbec5e2b3692014 [INFO] linting sagarreddypatil/language against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsagarreddypatil%2Flanguage" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sagarreddypatil/language [INFO] finished tweaking git repo https://github.com/sagarreddypatil/language [INFO] tweaked toml for git repo https://github.com/sagarreddypatil/language written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sagarreddypatil/language on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sagarreddypatil/language already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded logos-derive v0.14.2 [INFO] [stderr] Downloaded logos-codegen v0.14.2 [INFO] [stderr] Downloaded syn v2.0.58 [INFO] [stderr] Downloaded logos v0.14.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28381b237598885ad8252a2dec115db5401a787ebcea5a3351ba805b971ff4b2 [INFO] running `Command { std: "docker" "start" "-a" "28381b237598885ad8252a2dec115db5401a787ebcea5a3351ba805b971ff4b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28381b237598885ad8252a2dec115db5401a787ebcea5a3351ba805b971ff4b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28381b237598885ad8252a2dec115db5401a787ebcea5a3351ba805b971ff4b2", kill_on_drop: false }` [INFO] [stdout] 28381b237598885ad8252a2dec115db5401a787ebcea5a3351ba805b971ff4b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a51885fc6d6ec2acd0c3b342551b7105b80f6ae46733635af29b06b0364a2be5 [INFO] running `Command { std: "docker" "start" "-a" "a51885fc6d6ec2acd0c3b342551b7105b80f6ae46733635af29b06b0364a2be5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling logos-codegen v0.14.2 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Compiling logos-derive v0.14.2 [INFO] [stderr] Checking logos v0.14.2 [INFO] [stderr] Checking language v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ops::Rem` [INFO] [stdout] --> src/passes.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, ops::Rem}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/passes.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | "&&" => (args[0] & args[1]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - "&&" => (args[0] & args[1]), [INFO] [stdout] 127 + "&&" => args[0] & args[1] , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/passes.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | "||" => (args[0] | args[1]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 128 - "||" => (args[0] | args[1]), [INFO] [stdout] 128 + "||" => args[0] | args[1] , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ops::Rem` [INFO] [stdout] --> src/passes.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, ops::Rem}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/passes.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | "&&" => (args[0] & args[1]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 127 - "&&" => (args[0] & args[1]), [INFO] [stdout] 127 + "&&" => args[0] & args[1] , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/passes.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | "||" => (args[0] | args[1]), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 128 - "||" => (args[0] | args[1]), [INFO] [stdout] 128 + "||" => args[0] | args[1] , [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/checker.rs:312:42 [INFO] [stdout] | [INFO] [stdout] 312 | fn infer_constraints_simp(&mut self, mut env: TyEnv, simp: &Simp) -> (Type, TyConstraints) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/checker.rs:312:42 [INFO] [stdout] | [INFO] [stdout] 312 | fn infer_constraints_simp(&mut self, mut env: TyEnv, simp: &Simp) -> (Type, TyConstraints) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/ast_to_cps.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 351 | _ => unimplemented!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/ast_to_cps.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 265 | Pattern::Var(name, _) => CpsExpr::Prim { [INFO] [stdout] | --------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 271 | Pattern::Int(n) => { [INFO] [stdout] | --------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 296 | Pattern::Bool(b) => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 301 | Pattern::Data(data_def, tag, pats) => { [INFO] [stdout] | ---------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 351 | _ => unimplemented!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/ast_to_cps.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 351 | _ => unimplemented!(), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/ast_to_cps.rs:351:13 [INFO] [stdout] | [INFO] [stdout] 265 | Pattern::Var(name, _) => CpsExpr::Prim { [INFO] [stdout] | --------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 271 | Pattern::Int(n) => { [INFO] [stdout] | --------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 296 | Pattern::Bool(b) => { [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 301 | Pattern::Data(data_def, tag, pats) => { [INFO] [stdout] | ---------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 351 | _ => unimplemented!(), [INFO] [stdout] | ^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let mut pass = Shrinking::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypeDef` is never constructed [INFO] [stdout] --> src/ast.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct TypeDef { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `insert` are never used [INFO] [stdout] --> src/cps.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 153 | impl Subst { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 154 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn insert(&mut self, key: Name, value: Name) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/cps.rs:333:12 [INFO] [stdout] | [INFO] [stdout] 317 | impl CpsExpr { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 333 | pub fn free(&self) -> HashSet { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/cps.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 367 | impl CntDef { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 372 | pub fn free(&self) -> HashSet { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/cps.rs:382:12 [INFO] [stdout] | [INFO] [stdout] 377 | impl FunDef { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 382 | pub fn free(&self) -> HashSet { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let mut pass = Shrinking::new(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypeDef` is never constructed [INFO] [stdout] --> src/ast.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub struct TypeDef { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `insert` are never used [INFO] [stdout] --> src/cps.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 153 | impl Subst { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 154 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn insert(&mut self, key: Name, value: Name) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/cps.rs:333:12 [INFO] [stdout] | [INFO] [stdout] 317 | impl CpsExpr { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 333 | pub fn free(&self) -> HashSet { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/cps.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 367 | impl CntDef { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 372 | pub fn free(&self) -> HashSet { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `free` is never used [INFO] [stdout] --> src/cps.rs:382:12 [INFO] [stdout] | [INFO] [stdout] 377 | impl FunDef { [INFO] [stdout] | --------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 382 | pub fn free(&self) -> HashSet { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / match peek { [INFO] [stdout] 27 | | Some(true) => false, [INFO] [stdout] 28 | | _ => true, [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 26 - match peek { [INFO] [stdout] 27 - Some(true) => false, [INFO] [stdout] 28 - _ => true, [INFO] [stdout] 29 - } [INFO] [stdout] 26 + !matches!(peek, Some(true)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | let token = token.unwrap().unwrap(); [INFO] [stdout] | ------------------------------------ unnecessary `let` binding [INFO] [stdout] 43 | [INFO] [stdout] 44 | token [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 | [INFO] [stdout] 44 ~ token.unwrap().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | / match self.peek() { [INFO] [stdout] 150 | | Token::POpen => { [INFO] [stdout] 151 | | self.accept(); [INFO] [stdout] 152 | | pats.push(self.parse_pattern()); [INFO] [stdout] ... | [INFO] [stdout] 168 | | _ => {} [INFO] [stdout] 169 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 ~ if self.peek() == &Token::POpen { [INFO] [stdout] 150 + self.accept(); [INFO] [stdout] 151 + pats.push(self.parse_pattern()); [INFO] [stdout] 152 + [INFO] [stdout] 153 + loop { [INFO] [stdout] 154 + match self.peek() { [INFO] [stdout] 155 + Token::Comma => { [INFO] [stdout] 156 + self.accept(); [INFO] [stdout] 157 + pats.push(self.parse_pattern()); [INFO] [stdout] 158 + } [INFO] [stdout] 159 + Token::PClose => { [INFO] [stdout] 160 + self.accept(); [INFO] [stdout] 161 + break; [INFO] [stdout] 162 + } [INFO] [stdout] 163 + _ => panic!("Expected ',' or ')', got {:?}", self.peek()), [INFO] [stdout] 164 + } [INFO] [stdout] 165 + } [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/parser.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / match peek { [INFO] [stdout] 27 | | Some(true) => false, [INFO] [stdout] 28 | | _ => true, [INFO] [stdout] 29 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 26 - match peek { [INFO] [stdout] 27 - Some(true) => false, [INFO] [stdout] 28 - _ => true, [INFO] [stdout] 29 - } [INFO] [stdout] 26 + !matches!(peek, Some(true)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | / loop { [INFO] [stdout] 231 | | let name = match self.peek() { [INFO] [stdout] 232 | | Token::Ident(name) => Name(name.clone()), [INFO] [stdout] 233 | | _ => break, [INFO] [stdout] ... | [INFO] [stdout] 246 | | lhs = Simp::FnCall(fname, vec![lhs, rhs]); [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 ~ while let Token::Ident(name) = self.peek() { [INFO] [stdout] 231 + let name = Name(name.clone()); [INFO] [stdout] 232 + .. [INFO] [stdout] 233 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 42 | let token = token.unwrap().unwrap(); [INFO] [stdout] | ------------------------------------ unnecessary `let` binding [INFO] [stdout] 43 | [INFO] [stdout] 44 | token [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 | [INFO] [stdout] 44 ~ token.unwrap().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | / match self.peek() { [INFO] [stdout] 320 | | Token::POpen => { [INFO] [stdout] 321 | | self.accept(); [INFO] [stdout] 322 | | slist.push(self.parse_simp()); [INFO] [stdout] ... | [INFO] [stdout] 339 | | _ => {} [INFO] [stdout] 340 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 319 ~ if self.peek() == &Token::POpen { [INFO] [stdout] 320 + self.accept(); [INFO] [stdout] 321 + slist.push(self.parse_simp()); [INFO] [stdout] 322 + [INFO] [stdout] 323 + loop { [INFO] [stdout] 324 + let token = self.peek(); [INFO] [stdout] 325 + match token { [INFO] [stdout] 326 + Token::Comma => { [INFO] [stdout] 327 + self.accept(); [INFO] [stdout] 328 + slist.push(self.parse_simp()); [INFO] [stdout] 329 + } [INFO] [stdout] 330 + Token::PClose => { [INFO] [stdout] 331 + self.accept(); [INFO] [stdout] 332 + break; [INFO] [stdout] 333 + } [INFO] [stdout] 334 + _ => panic!("Expected ',' or ')', got {:?}", token), [INFO] [stdout] 335 + } [INFO] [stdout] 336 + } [INFO] [stdout] 337 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | / loop { [INFO] [stdout] 370 | | match self.peek() { [INFO] [stdout] 371 | | Token::Pipe => { [INFO] [stdout] 372 | | self.accept(); [INFO] [stdout] ... | [INFO] [stdout] 380 | | } [INFO] [stdout] | |_________^ help: try: `while let Token::Pipe = self.peek() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | / match self.peek() { [INFO] [stdout] 150 | | Token::POpen => { [INFO] [stdout] 151 | | self.accept(); [INFO] [stdout] 152 | | pats.push(self.parse_pattern()); [INFO] [stdout] ... | [INFO] [stdout] 168 | | _ => {} [INFO] [stdout] 169 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 149 ~ if self.peek() == &Token::POpen { [INFO] [stdout] 150 + self.accept(); [INFO] [stdout] 151 + pats.push(self.parse_pattern()); [INFO] [stdout] 152 + [INFO] [stdout] 153 + loop { [INFO] [stdout] 154 + match self.peek() { [INFO] [stdout] 155 + Token::Comma => { [INFO] [stdout] 156 + self.accept(); [INFO] [stdout] 157 + pats.push(self.parse_pattern()); [INFO] [stdout] 158 + } [INFO] [stdout] 159 + Token::PClose => { [INFO] [stdout] 160 + self.accept(); [INFO] [stdout] 161 + break; [INFO] [stdout] 162 + } [INFO] [stdout] 163 + _ => panic!("Expected ',' or ')', got {:?}", self.peek()), [INFO] [stdout] 164 + } [INFO] [stdout] 165 + } [INFO] [stdout] 166 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:382:12 [INFO] [stdout] | [INFO] [stdout] 382 | if cases.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cases.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | / loop { [INFO] [stdout] 400 | | match self.peek() { [INFO] [stdout] 401 | | Token::Pipe => { [INFO] [stdout] 402 | | self.accept(); [INFO] [stdout] ... | [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________^ help: try: `while let Token::Pipe = self.peek() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:230:9 [INFO] [stdout] | [INFO] [stdout] 230 | / loop { [INFO] [stdout] 231 | | let name = match self.peek() { [INFO] [stdout] 232 | | Token::Ident(name) => Name(name.clone()), [INFO] [stdout] 233 | | _ => break, [INFO] [stdout] ... | [INFO] [stdout] 246 | | lhs = Simp::FnCall(fname, vec![lhs, rhs]); [INFO] [stdout] 247 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 ~ while let Token::Ident(name) = self.peek() { [INFO] [stdout] 231 + let name = Name(name.clone()); [INFO] [stdout] 232 + .. [INFO] [stdout] 233 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:447:17 [INFO] [stdout] | [INFO] [stdout] 446 | let ty = lhs.pop().unwrap(); [INFO] [stdout] | ---------------------------- unnecessary `let` binding [INFO] [stdout] 447 | ty [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 446 ~ [INFO] [stdout] 447 ~ lhs.pop().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/parser.rs:319:9 [INFO] [stdout] | [INFO] [stdout] 319 | / match self.peek() { [INFO] [stdout] 320 | | Token::POpen => { [INFO] [stdout] 321 | | self.accept(); [INFO] [stdout] 322 | | slist.push(self.parse_simp()); [INFO] [stdout] ... | [INFO] [stdout] 339 | | _ => {} [INFO] [stdout] 340 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 319 ~ if self.peek() == &Token::POpen { [INFO] [stdout] 320 + self.accept(); [INFO] [stdout] 321 + slist.push(self.parse_simp()); [INFO] [stdout] 322 + [INFO] [stdout] 323 + loop { [INFO] [stdout] 324 + let token = self.peek(); [INFO] [stdout] 325 + match token { [INFO] [stdout] 326 + Token::Comma => { [INFO] [stdout] 327 + self.accept(); [INFO] [stdout] 328 + slist.push(self.parse_simp()); [INFO] [stdout] 329 + } [INFO] [stdout] 330 + Token::PClose => { [INFO] [stdout] 331 + self.accept(); [INFO] [stdout] 332 + break; [INFO] [stdout] 333 + } [INFO] [stdout] 334 + _ => panic!("Expected ',' or ')', got {:?}", token), [INFO] [stdout] 335 + } [INFO] [stdout] 336 + } [INFO] [stdout] 337 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | / loop { [INFO] [stdout] 370 | | match self.peek() { [INFO] [stdout] 371 | | Token::Pipe => { [INFO] [stdout] 372 | | self.accept(); [INFO] [stdout] ... | [INFO] [stdout] 380 | | } [INFO] [stdout] | |_________^ help: try: `while let Token::Pipe = self.peek() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:382:12 [INFO] [stdout] | [INFO] [stdout] 382 | if cases.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cases.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | / loop { [INFO] [stdout] 400 | | match self.peek() { [INFO] [stdout] 401 | | Token::Pipe => { [INFO] [stdout] 402 | | self.accept(); [INFO] [stdout] ... | [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________^ help: try: `while let Token::Pipe = self.peek() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/parser.rs:447:17 [INFO] [stdout] | [INFO] [stdout] 446 | let ty = lhs.pop().unwrap(); [INFO] [stdout] | ---------------------------- unnecessary `let` binding [INFO] [stdout] 447 | ty [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 446 ~ [INFO] [stdout] 447 ~ lhs.pop().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `new_constraints` [INFO] [stdout] --> src/checker.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | let mut new_constraints = new_constraints; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `new_constraints` is initially defined here [INFO] [stdout] --> src/checker.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | let mut new_constraints = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `new_constraints` [INFO] [stdout] --> src/checker.rs:169:13 [INFO] [stdout] | [INFO] [stdout] 169 | let mut new_constraints = new_constraints; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `new_constraints` is initially defined here [INFO] [stdout] --> src/checker.rs:164:17 [INFO] [stdout] | [INFO] [stdout] 164 | let mut new_constraints = vec![]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/checker.rs:271:77 [INFO] [stdout] | [INFO] [stdout] 271 | let (t_fbody, x_fbody) = self.infer_constraints_simp(fnenv, &*f.body); [INFO] [stdout] | ^^^^^^^^ help: try: `&f.body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/checker.rs:271:77 [INFO] [stdout] | [INFO] [stdout] 271 | let (t_fbody, x_fbody) = self.infer_constraints_simp(fnenv, &*f.body); [INFO] [stdout] | ^^^^^^^^ help: try: `&f.body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/ast.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / match self.0.as_str() { [INFO] [stdout] 22 | | "+" | "-" | "*" | "/" | "%" | "~" => true, [INFO] [stdout] 23 | | "==" | "!=" | "<" | ">" | "<=" | ">=" => true, [INFO] [stdout] 24 | | "&&" | "||" => true, [INFO] [stdout] 25 | | "!" => true, [INFO] [stdout] 26 | | _ => false, [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 21 - match self.0.as_str() { [INFO] [stdout] 22 - "+" | "-" | "*" | "/" | "%" | "~" => true, [INFO] [stdout] 23 - "==" | "!=" | "<" | ">" | "<=" | ">=" => true, [INFO] [stdout] 24 - "&&" | "||" => true, [INFO] [stdout] 25 - "!" => true, [INFO] [stdout] 26 - _ => false, [INFO] [stdout] 27 - } [INFO] [stdout] 21 + matches!(self.0.as_str(), "+" | "-" | "*" | "/" | "%" | "~" | "==" | "!=" | "<" | ">" | "<=" | ">=" | "&&" | "||" | "!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/ast.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / match self.0.as_str() { [INFO] [stdout] 22 | | "+" | "-" | "*" | "/" | "%" | "~" => true, [INFO] [stdout] 23 | | "==" | "!=" | "<" | ">" | "<=" | ">=" => true, [INFO] [stdout] 24 | | "&&" | "||" => true, [INFO] [stdout] 25 | | "!" => true, [INFO] [stdout] 26 | | _ => false, [INFO] [stdout] 27 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 21 - match self.0.as_str() { [INFO] [stdout] 22 - "+" | "-" | "*" | "/" | "%" | "~" => true, [INFO] [stdout] 23 - "==" | "!=" | "<" | ">" | "<=" | ">=" => true, [INFO] [stdout] 24 - "&&" | "||" => true, [INFO] [stdout] 25 - "!" => true, [INFO] [stdout] 26 - _ => false, [INFO] [stdout] 27 - } [INFO] [stdout] 21 + matches!(self.0.as_str(), "+" | "-" | "*" | "/" | "%" | "~" | "==" | "!=" | "<" | ">" | "<=" | ">=" | "&&" | "||" | "!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/interp.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | write!(f, "Env {{\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 49 - write!(f, "Env {{\n")?; [INFO] [stdout] 49 + writeln!(f, "Env {{")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/interp.rs:52:32 [INFO] [stdout] | [INFO] [stdout] 52 | Some(value) => write!(f, " {}: {},\n", name, value)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 52 - Some(value) => write!(f, " {}: {},\n", name, value)?, [INFO] [stdout] 52 + Some(value) => writeln!(f, " {}: {},", name, value)?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/interp.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | None => write!(f, " {}: ,\n", name)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 53 - None => write!(f, " {}: ,\n", name)?, [INFO] [stdout] 53 + None => writeln!(f, " {}: ,", name)?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/interp.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | write!(f, "Env {{\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 49 - write!(f, "Env {{\n")?; [INFO] [stdout] 49 + writeln!(f, "Env {{")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/interp.rs:52:32 [INFO] [stdout] | [INFO] [stdout] 52 | Some(value) => write!(f, " {}: {},\n", name, value)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 52 - Some(value) => write!(f, " {}: {},\n", name, value)?, [INFO] [stdout] 52 + Some(value) => writeln!(f, " {}: {},", name, value)?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/interp.rs:53:25 [INFO] [stdout] | [INFO] [stdout] 53 | None => write!(f, " {}: ,\n", name)?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 53 - None => write!(f, " {}: ,\n", name)?, [INFO] [stdout] 53 + None => writeln!(f, " {}: ,", name)?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/interp.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 180 | .chain(free_body.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 180 - .chain(free_body.into_iter()) [INFO] [stdout] 180 + .chain(free_body) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/interp.rs:212:34 [INFO] [stdout] | [INFO] [stdout] 212 | let free_arms = arms.into_iter().flat_map(|(pat, body)| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/interp.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 180 | .chain(free_body.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:510:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 180 - .chain(free_body.into_iter()) [INFO] [stdout] 180 + .chain(free_body) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/interp.rs:230:31 [INFO] [stdout] | [INFO] [stdout] 230 | Data(_, args) => args.into_iter().flat_map(free_vars_simp).collect(), [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/interp.rs:212:34 [INFO] [stdout] | [INFO] [stdout] 212 | let free_arms = arms.into_iter().flat_map(|(pat, body)| { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/interp.rs:230:31 [INFO] [stdout] | [INFO] [stdout] 230 | Data(_, args) => args.into_iter().flat_map(free_vars_simp).collect(), [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | write!(f, "{}\n", fn_def)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 95 - write!(f, "{}\n", fn_def)?; [INFO] [stdout] 95 + writeln!(f, "{}", fn_def)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | write!(f, "match {} {{\n", expr)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 108 - write!(f, "match {} {{\n", expr)?; [INFO] [stdout] 108 + writeln!(f, "match {} {{", expr)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | write!(f, "{}\n", fn_def)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 95 - write!(f, "{}\n", fn_def)?; [INFO] [stdout] 95 + writeln!(f, "{}", fn_def)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | write!(f, "match {} {{\n", expr)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 108 - write!(f, "match {} {{\n", expr)?; [INFO] [stdout] 108 + writeln!(f, "match {} {{", expr)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:112:25 [INFO] [stdout] | [INFO] [stdout] 112 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 112 - write!(f, "\n")?; [INFO] [stdout] 112 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:112:25 [INFO] [stdout] | [INFO] [stdout] 112 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 112 - write!(f, "\n")?; [INFO] [stdout] 112 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | write!(f, "{}\n", data_def)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 170 - write!(f, "{}\n", data_def)?; [INFO] [stdout] 170 + writeln!(f, "{}", data_def)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/display_impls.rs:170:13 [INFO] [stdout] | [INFO] [stdout] 170 | write!(f, "{}\n", data_def)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 170 - write!(f, "{}\n", data_def)?; [INFO] [stdout] 170 + writeln!(f, "{}", data_def)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | assert!(arms.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!arms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | assert!(arms.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!arms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:216:17 [INFO] [stdout] | [INFO] [stdout] 216 | assert!(pats.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pats.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 222 | if pats.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pats.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:216:17 [INFO] [stdout] | [INFO] [stdout] 216 | assert!(pats.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pats.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:222:12 [INFO] [stdout] | [INFO] [stdout] 222 | if pats.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pats.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:318:30 [INFO] [stdout] | [INFO] [stdout] 318 | body: if pats.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pats.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ast_to_cps.rs:318:30 [INFO] [stdout] | [INFO] [stdout] 318 | body: if pats.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pats.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/passes.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | "!" => !(args[0] > 0) as i64, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(args[0] <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/passes.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | "!" => !(args[0] > 0) as i64, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(args[0] <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.03s [INFO] running `Command { std: "docker" "inspect" "a51885fc6d6ec2acd0c3b342551b7105b80f6ae46733635af29b06b0364a2be5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a51885fc6d6ec2acd0c3b342551b7105b80f6ae46733635af29b06b0364a2be5", kill_on_drop: false }` [INFO] [stdout] a51885fc6d6ec2acd0c3b342551b7105b80f6ae46733635af29b06b0364a2be5