[INFO] cloning repository https://github.com/sadilekivan/sudoku-solver [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/sadilekivan/sudoku-solver" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsadilekivan%2Fsudoku-solver", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsadilekivan%2Fsudoku-solver'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 164b6003bca0d74c2c6882af3f5e5948fc5011f2 [INFO] linting sadilekivan/sudoku-solver against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsadilekivan%2Fsudoku-solver" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/sadilekivan/sudoku-solver [INFO] finished tweaking git repo https://github.com/sadilekivan/sudoku-solver [INFO] tweaked toml for git repo https://github.com/sadilekivan/sudoku-solver written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/sadilekivan/sudoku-solver on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/sadilekivan/sudoku-solver already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 326b99a0097a6682a1ac08fa499a2560ba5dcae211c7e4e2ccd6299743a31c16 [INFO] running `Command { std: "docker" "start" "-a" "326b99a0097a6682a1ac08fa499a2560ba5dcae211c7e4e2ccd6299743a31c16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "326b99a0097a6682a1ac08fa499a2560ba5dcae211c7e4e2ccd6299743a31c16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "326b99a0097a6682a1ac08fa499a2560ba5dcae211c7e4e2ccd6299743a31c16", kill_on_drop: false }` [INFO] [stdout] 326b99a0097a6682a1ac08fa499a2560ba5dcae211c7e4e2ccd6299743a31c16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ae10048f79b451fcca05e1a6f6a08a0c6fc648d073203709679bbba76f05ef11 [INFO] running `Command { std: "docker" "start" "-a" "ae10048f79b451fcca05e1a6f6a08a0c6fc648d073203709679bbba76f05ef11", kill_on_drop: false }` [INFO] [stderr] Checking sudoku-solver v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Lrtb` is never constructed [INFO] [stdout] --> src/strategy/lrtb.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | struct Lrtb; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_valid` is never used [INFO] [stdout] --> src/strategy/lrtb.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn is_valid(board: &mut impl SudokuBoard, row: usize, col: usize, n: u32) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `solve_step` is never used [INFO] [stdout] --> src/strategy/lrtb.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 44 | impl Lrtb { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 48 | fn solve_step(board: &mut impl SudokuBoard, row: usize, col: usize) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Lap` is never constructed [INFO] [stdout] --> src/strategy/lap.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct Lap; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_valid_numbers` is never used [INFO] [stdout] --> src/strategy/lap.rs:8:4 [INFO] [stdout] | [INFO] [stdout] 8 | fn get_valid_numbers(board: &mut impl SudokuBoard, p: Point) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LowestValid` is never constructed [INFO] [stdout] --> src/strategy/lap.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | struct LowestValid { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/strategy/lap.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | impl LowestValid { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 37 | fn new(p: Point, valid_moves: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `first_lowest_valid` is never used [INFO] [stdout] --> src/strategy/lap.rs:43:4 [INFO] [stdout] | [INFO] [stdout] 43 | fn first_lowest_valid(board: &mut impl SudokuBoard) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/board.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `solve_step` is never used [INFO] [stdout] --> src/strategy/lap.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 64 | impl Lap { [INFO] [stdout] | -------- associated function in this implementation [INFO] [stdout] 65 | fn solve_step(board: &mut impl SudokuBoard) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LapMc` is never constructed [INFO] [stdout] --> src/strategy/lapmc.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | struct LapMc; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_valid_numbers` is never used [INFO] [stdout] --> src/strategy/lapmc.rs:10:4 [INFO] [stdout] | [INFO] [stdout] 10 | fn get_valid_numbers(board: &mut impl SudokuBoard, p: Point) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LowestValid` is never constructed [INFO] [stdout] --> src/strategy/lapmc.rs:33:8 [INFO] [stdout] | [INFO] [stdout] 33 | struct LowestValid { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/strategy/lapmc.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 38 | impl LowestValid { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 39 | fn new(p: Point, valid_moves: Vec) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return true; [INFO] [stdout] 41 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `first_lowest_valid` is never used [INFO] [stdout] --> src/strategy/lapmc.rs:45:4 [INFO] [stdout] | [INFO] [stdout] 45 | fn first_lowest_valid(board: &mut impl SudokuBoard) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `solve_step` is never used [INFO] [stdout] --> src/strategy/lapmc.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 66 | impl LapMc { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 67 | fn solve_step(board: &mut impl SudokuBoard) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return true; [INFO] [stdout] 52 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | return Self::solve_step(board, row + 1, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Self::solve_step(board, row + 1, 0); [INFO] [stdout] 55 + Self::solve_step(board, row + 1, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return Self::solve_step(board, row, col + 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return Self::solve_step(board, row, col + 1); [INFO] [stdout] 58 + Self::solve_step(board, row, col + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return false; [INFO] [stdout] 76 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | return Some(board) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return Some(board) [INFO] [stdout] 84 + Some(board) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return None [INFO] [stdout] 86 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/strategy/lap.rs:23:39 [INFO] [stdout] | [INFO] [stdout] 23 | valid_number_v.retain(|n| !(*n == board.read(p))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*n != board.read(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/strategy/lap.rs:44:49 [INFO] [stdout] | [INFO] [stdout] 44 | let v: Vec = board.into_iter().filter_map(|f| if f.1 == 0 {Some(f)} else {None} ).map(|(p, _)| [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return false; [INFO] [stdout] 77 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return true; [INFO] [stdout] 79 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | return Some(board) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Some(board) [INFO] [stdout] 87 + Some(board) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return None [INFO] [stdout] 89 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/strategy/lapmc.rs:25:39 [INFO] [stdout] | [INFO] [stdout] 25 | valid_number_v.retain(|n| !(*n == board.read(p))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*n != board.read(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/strategy/lapmc.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | let v: Vec = board.into_iter().filter_map(|f| if f.1 == 0 {Some(f)} else {None} ).map(|(p, _)| [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return false; [INFO] [stdout] 79 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return true; [INFO] [stdout] 81 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | return Some(board) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Some(board) [INFO] [stdout] 89 + Some(board) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return None [INFO] [stdout] 91 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/board.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return true; [INFO] [stdout] 41 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return true; [INFO] [stdout] 52 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | return Self::solve_step(board, row + 1, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Self::solve_step(board, row + 1, 0); [INFO] [stdout] 55 + Self::solve_step(board, row + 1, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return Self::solve_step(board, row, col + 1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return Self::solve_step(board, row, col + 1); [INFO] [stdout] 58 + Self::solve_step(board, row, col + 1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return false; [INFO] [stdout] 76 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | return Some(board) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return Some(board) [INFO] [stdout] 84 + Some(board) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lrtb.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return None [INFO] [stdout] 86 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/strategy/lap.rs:23:39 [INFO] [stdout] | [INFO] [stdout] 23 | valid_number_v.retain(|n| !(*n == board.read(p))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*n != board.read(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/strategy/lap.rs:44:49 [INFO] [stdout] | [INFO] [stdout] 44 | let v: Vec = board.into_iter().filter_map(|f| if f.1 == 0 {Some(f)} else {None} ).map(|(p, _)| [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return false; [INFO] [stdout] 77 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return true; [INFO] [stdout] 79 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | return Some(board) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return Some(board) [INFO] [stdout] 87 + Some(board) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lap.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return None [INFO] [stdout] 89 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/strategy/lapmc.rs:25:39 [INFO] [stdout] | [INFO] [stdout] 25 | valid_number_v.retain(|n| !(*n == board.read(p))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*n != board.read(p))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/strategy/lapmc.rs:46:49 [INFO] [stdout] | [INFO] [stdout] 46 | let v: Vec = board.into_iter().filter_map(|f| if f.1 == 0 {Some(f)} else {None} ).map(|(p, _)| [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return false; [INFO] [stdout] 79 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return true; [INFO] [stdout] 81 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | return Some(board) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Some(board) [INFO] [stdout] 89 + Some(board) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/strategy/lapmc.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return None [INFO] [stdout] 91 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.46s [INFO] running `Command { std: "docker" "inspect" "ae10048f79b451fcca05e1a6f6a08a0c6fc648d073203709679bbba76f05ef11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae10048f79b451fcca05e1a6f6a08a0c6fc648d073203709679bbba76f05ef11", kill_on_drop: false }` [INFO] [stdout] ae10048f79b451fcca05e1a6f6a08a0c6fc648d073203709679bbba76f05ef11