[INFO] cloning repository https://github.com/s8chsteu/Observational-Causality-Analysis-Tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/s8chsteu/Observational-Causality-Analysis-Tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs8chsteu%2FObservational-Causality-Analysis-Tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs8chsteu%2FObservational-Causality-Analysis-Tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2f0a2c99efaa812b3314573568f3c4ab702e5237 [INFO] linting s8chsteu/Observational-Causality-Analysis-Tool against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs8chsteu%2FObservational-Causality-Analysis-Tool" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/s8chsteu/Observational-Causality-Analysis-Tool [INFO] finished tweaking git repo https://github.com/s8chsteu/Observational-Causality-Analysis-Tool [INFO] tweaked toml for git repo https://github.com/s8chsteu/Observational-Causality-Analysis-Tool written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/s8chsteu/Observational-Causality-Analysis-Tool on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/s8chsteu/Observational-Causality-Analysis-Tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fallible-iterator v0.3.0 [INFO] [stderr] Downloaded fallible-streaming-iterator v0.1.9 [INFO] [stderr] Downloaded cc v1.2.19 [INFO] [stderr] Downloaded rusqlite v0.34.0 [INFO] [stderr] Downloaded libsqlite3-sys v0.32.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 152aae0e4d28c86f9b5bb1d8d9a07de8072f8cf094cc3e83549c658c02667d61 [INFO] running `Command { std: "docker" "start" "-a" "152aae0e4d28c86f9b5bb1d8d9a07de8072f8cf094cc3e83549c658c02667d61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "152aae0e4d28c86f9b5bb1d8d9a07de8072f8cf094cc3e83549c658c02667d61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "152aae0e4d28c86f9b5bb1d8d9a07de8072f8cf094cc3e83549c658c02667d61", kill_on_drop: false }` [INFO] [stdout] 152aae0e4d28c86f9b5bb1d8d9a07de8072f8cf094cc3e83549c658c02667d61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8f99ad4f44d72a10e2cce79da7e77c2fa20906aac2a50c161fa0e5b4835b4fd [INFO] running `Command { std: "docker" "start" "-a" "a8f99ad4f44d72a10e2cce79da7e77c2fa20906aac2a50c161fa0e5b4835b4fd", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling libsqlite3-sys v0.32.0 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking rusqlite v0.34.0 [INFO] [stderr] Checking final_prototype v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 165 | if !(expected_next_argument == "option") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(expected_next_argument != "option")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:296:8 [INFO] [stdout] | [INFO] [stdout] 296 | if !traces_folder_iterator_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `traces_folder_iterator_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 305 | if !trace_file_direntry_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 313 | if !trace_file_direntry.path().to_str().is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry.path().to_str().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if !trace_file_opened_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_opened_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd_line.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | return (parsed_command_line_arguments, error_message) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 409 - return (parsed_command_line_arguments, error_message) [INFO] [stdout] 409 + (parsed_command_line_arguments, error_message) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `command_line_arguments_index` is used to index `command_line_arguments` [INFO] [stdout] --> src/cmd_line.rs:55:41 [INFO] [stdout] | [INFO] [stdout] 55 | for command_line_arguments_index in 0..command_line_arguments.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 55 - for command_line_arguments_index in 0..command_line_arguments.len() [INFO] [stdout] 55 + for (command_line_arguments_index, ) in command_line_arguments.iter().enumerate() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:190:38 [INFO] [stdout] | [INFO] [stdout] 190 | ...sh_str(&(format!("Neither of the mandatory, mutually exclusive options --hypothesis and --grammar are present\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Neither of the mandatory, mutually exclusive options --hypothesis and --grammar are present\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:199:25 [INFO] [stdout] | [INFO] [stdout] 199 | if error_message != "".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:209:34 [INFO] [stdout] | [INFO] [stdout] 209 | error_message.push_str(&(format!("The argument of --rtlola-cli does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --rtlola-cli does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:219:46 [INFO] [stdout] | [INFO] [stdout] 219 | ...e.push_str(&(format!("The argument of --rtlola-cli does not point towards the RTLola CLI binary/executable\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --rtlola-cli does not point towards the RTLola CLI binary/executable\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:224:42 [INFO] [stdout] | [INFO] [stdout] 224 | error_message.push_str(&(format!("The argument of --rtlola-cli does not point towards a binary/ an executable\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --rtlola-cli does not point towards a binary/ an executable\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:232:34 [INFO] [stdout] | [INFO] [stdout] 232 | error_message.push_str(&(format!("The argument of --traces does not point towards a directory\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --traces does not point towards a directory\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:233:34 [INFO] [stdout] | [INFO] [stdout] 233 | error_message.push_str(&(format!("Therefore, the argument of --actual-world also does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Therefore, the argument of --actual-world also does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:242:38 [INFO] [stdout] | [INFO] [stdout] 242 | error_message.push_str(&(format!("The argument of --actual-world does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --actual-world does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:246:38 [INFO] [stdout] | [INFO] [stdout] 246 | error_message.push_str(&(format!("The argument of --actual-world does not point towards a file with type \".csv\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --actual-world does not point towards a file with type \".csv\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:253:34 [INFO] [stdout] | [INFO] [stdout] 253 | error_message.push_str(&(format!("The argument of --effect-property does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --effect-property does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:258:34 [INFO] [stdout] | [INFO] [stdout] 258 | error_message.push_str(&(format!("The argument of --effect-property does not point towards a file with type \".lola\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --effect-property does not point towards a file with type \".lola\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:264:34 [INFO] [stdout] | [INFO] [stdout] 264 | error_message.push_str(&(format!("The argument of --distance-metric does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --distance-metric does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:269:34 [INFO] [stdout] | [INFO] [stdout] 269 | error_message.push_str(&(format!("The argument of --distance-metric does not point towards a file with type \".lola\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --distance-metric does not point towards a file with type \".lola\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | error_message.push_str(&(format!("The argument of --grammar/--hypothesis does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --grammar/--hypothesis does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:280:34 [INFO] [stdout] | [INFO] [stdout] 280 | error_message.push_str(&(format!("The argument of --hypothesis does not point towards a file with type \".lola\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --hypothesis does not point towards a file with type \".lola\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:285:34 [INFO] [stdout] | [INFO] [stdout] 285 | error_message.push_str(&(format!("The argument of --grammar does not point towards a file with type \".json\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --grammar does not point towards a file with type \".json\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:289:25 [INFO] [stdout] | [INFO] [stdout] 289 | if error_message != "".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:362:94 [INFO] [stdout] | [INFO] [stdout] 362 | if trace_file_column_names[parsed_command_line_arguments.csv_time_column_index-1] == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:369:32 [INFO] [stdout] | [INFO] [stdout] 369 | if time_column_name == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:418:5 [INFO] [stdout] | [INFO] [stdout] 418 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:424:5 [INFO] [stdout] | [INFO] [stdout] 424 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:429:5 [INFO] [stdout] | [INFO] [stdout] 429 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:435:5 [INFO] [stdout] | [INFO] [stdout] 435 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:441:5 [INFO] [stdout] | [INFO] [stdout] 441 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 448 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/trace_operations.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return (false, "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return (false, "".to_owned()); [INFO] [stdout] 36 + (false, "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/trace_operations.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return (String::from(""), "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return (String::from(""), "".to_owned()); [INFO] [stdout] 77 + (String::from(""), "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | return (distance_as_number, "".to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (distance_as_number, "".to_owned()) [INFO] [stdout] 39 + (distance_as_number, "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | _ => return (-1.0, format!("The distance of {} and {} was not a number", first_trace, second_trace)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - _ => return (-1.0, format!("The distance of {} and {} was not a number", first_trace, second_trace)) [INFO] [stdout] 41 + _ => (-1.0, format!("The distance of {} and {} was not a number", first_trace, second_trace)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 359 | return (merged_file_full_path_to_str.to_owned(), error_message) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - return (merged_file_full_path_to_str.to_owned(), error_message) [INFO] [stdout] 359 + (merged_file_full_path_to_str.to_owned(), error_message) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/distance.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | let merged_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `merged_file` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 ~ let merged_file = match File::create(merged_file_full_path_to_str) [INFO] [stdout] 159 | { [INFO] [stdout] 160 ~ Ok(m) => m, [INFO] [stdout] 161 | _ => return ("".to_owned(), format!("While merging, merge file {} could not be created\n", merged_file_full_path_to_str)) [INFO] [stdout] 162 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:165:65 [INFO] [stdout] | [INFO] [stdout] 165 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", first_file_column_names[time_column_index-1]))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `first_file_column_names[time_column_index-1].to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:168:69 [INFO] [stdout] | [INFO] [stdout] 168 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:169:69 [INFO] [stdout] | [INFO] [stdout] 169 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", merged_column_from_first_file.as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `merged_column_from_first_file.as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:173:69 [INFO] [stdout] | [INFO] [stdout] 173 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:174:69 [INFO] [stdout] | [INFO] [stdout] 174 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", merged_column_from_second_file.as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `merged_column_from_second_file.as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:176:65 [INFO] [stdout] | [INFO] [stdout] 176 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 208 | if first_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 218 | if second_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | if first_file_current_line_as_string == "" && second_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:236:55 [INFO] [stdout] | [INFO] [stdout] 236 | if first_file_current_line_as_string == "" && second_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:246:91 [INFO] [stdout] | [INFO] [stdout] 246 | if first_file_current_line_entries_vector.len() != column_count_including_time && first_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:251:92 [INFO] [stdout] | [INFO] [stdout] 251 | if second_file_current_line_entries_vector.len() != column_count_including_time && second_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 260 | if first_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 269 | if second_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:287:73 [INFO] [stdout] | [INFO] [stdout] 287 | ..._wrapper(&merged_file, format!("{}", first_file_current_line_timestamp.to_string().as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `first_file_current_line_timestamp.to_string().as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `first_file_current_line_column_index` is used to index `first_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:288:57 [INFO] [stdout] | [INFO] [stdout] 288 | for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 288 - for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 288 + for (first_file_current_line_column_index, ) in first_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:292:81 [INFO] [stdout] | [INFO] [stdout] 292 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:293:81 [INFO] [stdout] | [INFO] [stdout] 293 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 294 | | first_file_current_line_entries_vector[first_file_current_line_column_index].as_str()))); [INFO] [stdout] | |______________________________________________________________________________________________________________^ help: consider using `.to_string()`: `first_file_current_line_entries_vector[first_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `second_file_current_line_column_index` is used to index `second_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:297:58 [INFO] [stdout] | [INFO] [stdout] 297 | for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 297 - for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 297 + for (second_file_current_line_column_index, ) in second_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:301:81 [INFO] [stdout] | [INFO] [stdout] 301 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:302:81 [INFO] [stdout] | [INFO] [stdout] 302 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 303 | | second_file_current_line_entries_vector[second_file_current_line_column_index].as_str()))); [INFO] [stdout] | |________________________________________________________________________________________________________________^ help: consider using `.to_string()`: `second_file_current_line_entries_vector[second_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:306:73 [INFO] [stdout] | [INFO] [stdout] 306 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:314:73 [INFO] [stdout] | [INFO] [stdout] 314 | ..._wrapper(&merged_file, format!("{}", first_file_current_line_timestamp.to_string().as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `first_file_current_line_timestamp.to_string().as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `first_file_current_line_column_index` is used to index `first_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:315:57 [INFO] [stdout] | [INFO] [stdout] 315 | for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 315 - for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 315 + for (first_file_current_line_column_index, ) in first_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:319:81 [INFO] [stdout] | [INFO] [stdout] 319 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:320:81 [INFO] [stdout] | [INFO] [stdout] 320 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 321 | | first_file_current_line_entries_vector[first_file_current_line_column_index].as_str()))); [INFO] [stdout] | |______________________________________________________________________________________________________________^ help: consider using `.to_string()`: `first_file_current_line_entries_vector[first_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:326:77 [INFO] [stdout] | [INFO] [stdout] 326 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:327:77 [INFO] [stdout] | [INFO] [stdout] 327 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("#"))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `"#".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:329:73 [INFO] [stdout] | [INFO] [stdout] 329 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:335:73 [INFO] [stdout] | [INFO] [stdout] 335 | ..._wrapper(&merged_file, format!("{}", second_file_current_line_timestamp.to_string().as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `second_file_current_line_timestamp.to_string().as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:338:77 [INFO] [stdout] | [INFO] [stdout] 338 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:339:77 [INFO] [stdout] | [INFO] [stdout] 339 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("#"))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `"#".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `second_file_current_line_column_index` is used to index `second_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:341:58 [INFO] [stdout] | [INFO] [stdout] 341 | for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 341 - for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 341 + for (second_file_current_line_column_index, ) in second_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:345:81 [INFO] [stdout] | [INFO] [stdout] 345 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:346:81 [INFO] [stdout] | [INFO] [stdout] 346 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 347 | | second_file_current_line_entries_vector[second_file_current_line_column_index].as_str()))); [INFO] [stdout] | |________________________________________________________________________________________________________________^ help: consider using `.to_string()`: `second_file_current_line_entries_vector[second_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:350:73 [INFO] [stdout] | [INFO] [stdout] 350 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:355:8 [INFO] [stdout] | [INFO] [stdout] 355 | if error_message != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!error_message.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:367:18 [INFO] [stdout] | [INFO] [stdout] 367 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 367 - Ok(_) => return "".to_owned(), [INFO] [stdout] 367 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:368:14 [INFO] [stdout] | [INFO] [stdout] 368 | _ => return format!("unable to write '{}' to merge file\n", content) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 368 - _ => return format!("unable to write '{}' to merge file\n", content) [INFO] [stdout] 368 + _ => format!("unable to write '{}' to merge file\n", content) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/hypothesis.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | if error_message != "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/hypothesis.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | if error_message != "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hypothesis.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if !trace_file_direntry_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hypothesis.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return "".to_string(); [INFO] [stdout] 99 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | let actual_world_full_path_as_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `actual_world_full_path_as_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 59 ~ [INFO] [stdout] 60 ~ let actual_world_full_path_as_str:String = match Path::new(parsed_command_line_arguments.traces_folder_path.as_str()).join(parsed_command_line_arguments.actual_world_file_name.clone()) [INFO] [stdout] 61 | .to_path_buf().to_str() [INFO] [stdout] 62 | { [INFO] [stdout] 63 ~ Some(s) => s.to_owned(), [INFO] [stdout] 64 | _ => return "While evaluating, actual world has an invalid file path (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | let trace_file_path_to_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trace_file_path_to_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 67 ~ [INFO] [stdout] 68 ~ let trace_file_path_to_str:String = match trace_file_direntry.path().to_str() [INFO] [stdout] 69 | { [INFO] [stdout] 70 ~ Some(s) => s.to_owned(), [INFO] [stdout] 71 | _ => return "While evaluating, an invalid trace file path appeared (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 72 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hypothesis.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if !trace_file_direntry_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hypothesis.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return "".to_string(); [INFO] [stdout] 160 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | let actual_world_full_path_as_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `actual_world_full_path_as_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 123 ~ [INFO] [stdout] 124 ~ let actual_world_full_path_as_str:String = match Path::new(parsed_command_line_arguments.traces_folder_path.as_str()).join( [INFO] [stdout] 125 | parsed_command_line_arguments.actual_world_file_name.clone()).to_path_buf().to_str() [INFO] [stdout] 126 | { [INFO] [stdout] 127 ~ Some(s) => s.to_owned(), [INFO] [stdout] 128 | _ => return "While evaluating, an invalid actual world path appeared (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 129 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | let trace_file_path_to_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trace_file_path_to_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 131 ~ [INFO] [stdout] 132 ~ let trace_file_path_to_str:String = match trace_file_direntry.path().to_str() [INFO] [stdout] 133 | { [INFO] [stdout] 134 ~ Some(s) => s.to_owned(), [INFO] [stdout] 135 | _ => return "While evaluating, an invalid file path appeared (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 136 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hypothesis.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | return evaluation_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - return evaluation_result; [INFO] [stdout] 287 + evaluation_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:212:39 [INFO] [stdout] | [INFO] [stdout] 212 | evaluation_result.0.push_str(&format!("The hypothesis is therefore rejected\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is therefore rejected\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:223:43 [INFO] [stdout] | [INFO] [stdout] 223 | evaluation_result.0.push_str(&format!("The hypothesis is therefore rejected\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is therefore rejected\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:228:43 [INFO] [stdout] | [INFO] [stdout] 228 | evaluation_result.0.push_str(&format!("The hypothesis is accepted\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is accepted\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:241:39 [INFO] [stdout] | [INFO] [stdout] 241 | evaluation_result.0.push_str(&format!("The hypothesis is therefore rejected\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is therefore rejected\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:247:39 [INFO] [stdout] | [INFO] [stdout] 247 | evaluation_result.0.push_str(&format!("The hypothesis is accepted\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is accepted\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/hypothesis.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | traces_closer_to_actual_world_than_smallest_good_trace = traces_closer_to_actual_world_than_smallest_good_trace + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `traces_closer_to_actual_world_than_smallest_good_trace += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/hypothesis.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 271 | traces_closer_to_actual_world_than_smallest_bad_trace = traces_closer_to_actual_world_than_smallest_bad_trace + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `traces_closer_to_actual_world_than_smallest_bad_trace += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/hypothesis.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | traces_with_intact_cause_effect_relationship = traces_with_intact_cause_effect_relationship + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `traces_with_intact_cause_effect_relationship += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 165 | if !(expected_next_argument == "option") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(expected_next_argument != "option")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:296:8 [INFO] [stdout] | [INFO] [stdout] 296 | if !traces_folder_iterator_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `traces_folder_iterator_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 305 | if !trace_file_direntry_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 313 | if !trace_file_direntry.path().to_str().is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry.path().to_str().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd_line.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if !trace_file_opened_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_opened_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cmd_line.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | return (parsed_command_line_arguments, error_message) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 409 - return (parsed_command_line_arguments, error_message) [INFO] [stdout] 409 + (parsed_command_line_arguments, error_message) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `command_line_arguments_index` is used to index `command_line_arguments` [INFO] [stdout] --> src/cmd_line.rs:55:41 [INFO] [stdout] | [INFO] [stdout] 55 | for command_line_arguments_index in 0..command_line_arguments.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 55 - for command_line_arguments_index in 0..command_line_arguments.len() [INFO] [stdout] 55 + for (command_line_arguments_index, ) in command_line_arguments.iter().enumerate() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:190:38 [INFO] [stdout] | [INFO] [stdout] 190 | ...sh_str(&(format!("Neither of the mandatory, mutually exclusive options --hypothesis and --grammar are present\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Neither of the mandatory, mutually exclusive options --hypothesis and --grammar are present\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:199:25 [INFO] [stdout] | [INFO] [stdout] 199 | if error_message != "".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:209:34 [INFO] [stdout] | [INFO] [stdout] 209 | error_message.push_str(&(format!("The argument of --rtlola-cli does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --rtlola-cli does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:219:46 [INFO] [stdout] | [INFO] [stdout] 219 | ...e.push_str(&(format!("The argument of --rtlola-cli does not point towards the RTLola CLI binary/executable\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --rtlola-cli does not point towards the RTLola CLI binary/executable\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:224:42 [INFO] [stdout] | [INFO] [stdout] 224 | error_message.push_str(&(format!("The argument of --rtlola-cli does not point towards a binary/ an executable\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --rtlola-cli does not point towards a binary/ an executable\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:232:34 [INFO] [stdout] | [INFO] [stdout] 232 | error_message.push_str(&(format!("The argument of --traces does not point towards a directory\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --traces does not point towards a directory\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:233:34 [INFO] [stdout] | [INFO] [stdout] 233 | error_message.push_str(&(format!("Therefore, the argument of --actual-world also does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Therefore, the argument of --actual-world also does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:242:38 [INFO] [stdout] | [INFO] [stdout] 242 | error_message.push_str(&(format!("The argument of --actual-world does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --actual-world does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:246:38 [INFO] [stdout] | [INFO] [stdout] 246 | error_message.push_str(&(format!("The argument of --actual-world does not point towards a file with type \".csv\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --actual-world does not point towards a file with type \".csv\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:253:34 [INFO] [stdout] | [INFO] [stdout] 253 | error_message.push_str(&(format!("The argument of --effect-property does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --effect-property does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:258:34 [INFO] [stdout] | [INFO] [stdout] 258 | error_message.push_str(&(format!("The argument of --effect-property does not point towards a file with type \".lola\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --effect-property does not point towards a file with type \".lola\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:264:34 [INFO] [stdout] | [INFO] [stdout] 264 | error_message.push_str(&(format!("The argument of --distance-metric does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --distance-metric does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:269:34 [INFO] [stdout] | [INFO] [stdout] 269 | error_message.push_str(&(format!("The argument of --distance-metric does not point towards a file with type \".lola\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --distance-metric does not point towards a file with type \".lola\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | error_message.push_str(&(format!("The argument of --grammar/--hypothesis does not point towards a file\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --grammar/--hypothesis does not point towards a file\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:280:34 [INFO] [stdout] | [INFO] [stdout] 280 | error_message.push_str(&(format!("The argument of --hypothesis does not point towards a file with type \".lola\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --hypothesis does not point towards a file with type \".lola\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cmd_line.rs:285:34 [INFO] [stdout] | [INFO] [stdout] 285 | error_message.push_str(&(format!("The argument of --grammar does not point towards a file with type \".json\"\n"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The argument of --grammar does not point towards a file with type \".json\"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:289:25 [INFO] [stdout] | [INFO] [stdout] 289 | if error_message != "".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if !database_connection_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `database_connection_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | if !database_connection.execute( [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | "CREATE TABLE IF NOT EXISTS generated_expressions ( [INFO] [stdout] 98 | | id INTEGER PRIMARY KEY, [INFO] [stdout] 99 | | parent TEXT NOT NULL, [INFO] [stdout] ... | [INFO] [stdout] 105 | | (), // empty list of parameters. [INFO] [stdout] 106 | | ).is_ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 96 ~ if database_connection.execute( [INFO] [stdout] 97 + "CREATE TABLE IF NOT EXISTS generated_expressions ( [INFO] [stdout] 98 + id INTEGER PRIMARY KEY, [INFO] [stdout] 99 + parent TEXT NOT NULL, [INFO] [stdout] 100 + weight INTEGER, [INFO] [stdout] 101 + compressed_tree TEXT NOT NULL, [INFO] [stdout] 102 + semantic_satisfaction INTEGER, [INFO] [stdout] 103 + hybrid_satisfaction INTEGER [INFO] [stdout] 104 + )", [INFO] [stdout] 105 + (), // empty list of parameters. [INFO] [stdout] 106 ~ ).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if flat_production.children.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flat_production.children.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:362:94 [INFO] [stdout] | [INFO] [stdout] 362 | if trace_file_column_names[parsed_command_line_arguments.csv_time_column_index-1] == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/cmd_line.rs:369:32 [INFO] [stdout] | [INFO] [stdout] 369 | if time_column_name == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:152:16 [INFO] [stdout] | [INFO] [stdout] 152 | if flat_production.1.children.len() == 0 && flat_production.1.weight != current_trigger_expression_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flat_production.1.children.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:163:16 [INFO] [stdout] | [INFO] [stdout] 163 | if flat_production.1.children.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flat_production.1.children.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:418:5 [INFO] [stdout] | [INFO] [stdout] 418 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/grammar.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:424:5 [INFO] [stdout] | [INFO] [stdout] 424 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `child_weight_combination` [INFO] [stdout] --> src/grammar.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | for index in 0..child_weight_combination.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 214 - for index in 0..child_weight_combination.len() [INFO] [stdout] 214 + for (index, ) in child_weight_combination.iter().enumerate() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:429:5 [INFO] [stdout] | [INFO] [stdout] 429 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:224:28 [INFO] [stdout] | [INFO] [stdout] 224 | if query_result.0.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query_result.0.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:435:5 [INFO] [stdout] | [INFO] [stdout] 435 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:441:5 [INFO] [stdout] | [INFO] [stdout] 441 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/cmd_line.rs:448:5 [INFO] [stdout] | [INFO] [stdout] 448 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/trace_operations.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return (false, "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return (false, "".to_owned()); [INFO] [stdout] 36 + (false, "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/grammar.rs:244:25 [INFO] [stdout] | [INFO] [stdout] 244 | id = id + 1; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `id += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/grammar.rs:309:29 [INFO] [stdout] | [INFO] [stdout] 309 | ... println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/trace_operations.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return (String::from(""), "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return (String::from(""), "".to_owned()); [INFO] [stdout] 77 + (String::from(""), "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | return vec![vec![sum]]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return vec![vec![sum]]; [INFO] [stdout] 350 + vec![vec![sum]] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 364 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 364 - return result; [INFO] [stdout] 364 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:383:14 [INFO] [stdout] | [INFO] [stdout] 383 | 0 => return Some(result), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - 0 => return Some(result), [INFO] [stdout] 383 + 0 => Some(result), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | return (distance_as_number, "".to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (distance_as_number, "".to_owned()) [INFO] [stdout] 39 + (distance_as_number, "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:384:14 [INFO] [stdout] | [INFO] [stdout] 384 | _ => return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 384 - _ => return None [INFO] [stdout] 384 + _ => None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | _ => return (-1.0, format!("The distance of {} and {} was not a number", first_trace, second_trace)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - _ => return (-1.0, format!("The distance of {} and {} was not a number", first_trace, second_trace)) [INFO] [stdout] 41 + _ => (-1.0, format!("The distance of {} and {} was not a number", first_trace, second_trace)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/grammar.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | id_cpy = id_cpy/choice_list.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_cpy /= choice_list.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:413:5 [INFO] [stdout] | [INFO] [stdout] 413 | return (hypothesis_evaluation_results.0, hypothesis_evaluation_results.1, "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 413 - return (hypothesis_evaluation_results.0, hypothesis_evaluation_results.1, "".to_owned()); [INFO] [stdout] 413 + (hypothesis_evaluation_results.0, hypothesis_evaluation_results.1, "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | return (temporary_file_path_to_str.to_owned(), "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 466 - return (temporary_file_path_to_str.to_owned(), "".to_owned()); [INFO] [stdout] 466 + (temporary_file_path_to_str.to_owned(), "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 359 | return (merged_file_full_path_to_str.to_owned(), error_message) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 359 - return (merged_file_full_path_to_str.to_owned(), error_message) [INFO] [stdout] 359 + (merged_file_full_path_to_str.to_owned(), error_message) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:481:5 [INFO] [stdout] | [INFO] [stdout] 481 | return trigger_expression.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 481 - return trigger_expression.to_string(); [INFO] [stdout] 481 + trigger_expression.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grammar.rs:478:64 [INFO] [stdout] | [INFO] [stdout] 478 | let child_string = trigger_expression_string_from_tree(&child, grammar); [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:501:8 [INFO] [stdout] | [INFO] [stdout] 501 | if !json_grammar_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `json_grammar_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | return (Some(grammar), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 552 - return (Some(grammar), "".to_string()); [INFO] [stdout] 552 + (Some(grammar), "".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:556:9 [INFO] [stdout] | [INFO] [stdout] 556 | return (None, error_message); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 556 - return (None, error_message); [INFO] [stdout] 556 + (None, error_message) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/distance.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | let merged_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `merged_file` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 ~ let merged_file = match File::create(merged_file_full_path_to_str) [INFO] [stdout] 159 | { [INFO] [stdout] 160 ~ Ok(m) => m, [INFO] [stdout] 161 | _ => return ("".to_owned(), format!("While merging, merge file {} could not be created\n", merged_file_full_path_to_str)) [INFO] [stdout] 162 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:165:65 [INFO] [stdout] | [INFO] [stdout] 165 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", first_file_column_names[time_column_index-1]))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `first_file_column_names[time_column_index-1].to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:168:69 [INFO] [stdout] | [INFO] [stdout] 168 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:169:69 [INFO] [stdout] | [INFO] [stdout] 169 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", merged_column_from_first_file.as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `merged_column_from_first_file.as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:570:8 [INFO] [stdout] | [INFO] [stdout] 570 | if !statement_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `statement_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:173:69 [INFO] [stdout] | [INFO] [stdout] 173 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:174:69 [INFO] [stdout] | [INFO] [stdout] 174 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", merged_column_from_second_file.as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `merged_column_from_second_file.as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:176:65 [INFO] [stdout] | [INFO] [stdout] 176 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:578:8 [INFO] [stdout] | [INFO] [stdout] 578 | if !query_results_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `query_results_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:626:18 [INFO] [stdout] | [INFO] [stdout] 626 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 626 - Ok(_) => return "".to_owned(), [INFO] [stdout] 626 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:627:14 [INFO] [stdout] | [INFO] [stdout] 627 | ... _ => return format!("Failed to insert (parent: {}, weight:{}, compressed_tree: {}, semantic_satisfaction: {}, hybrid_satisf... [INFO] [stdout] | ____________^ [INFO] [stdout] 628 | | ... parent, weight, compressed_tree, semantic_satisfaction, hybrid_satisfaction) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 627 ~ _ => format!("Failed to insert (parent: {}, weight:{}, compressed_tree: {}, semantic_satisfaction: {}, hybrid_satisfaction: {}) into the database\n", [INFO] [stdout] 628 + parent, weight, compressed_tree, semantic_satisfaction, hybrid_satisfaction) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 208 | if first_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 218 | if second_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:650:18 [INFO] [stdout] | [INFO] [stdout] 650 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 650 - Ok(_) => return "".to_owned(), [INFO] [stdout] 650 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:651:14 [INFO] [stdout] | [INFO] [stdout] 651 | _ => return "Error while attempting to clear the database\n".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 651 - _ => return "Error while attempting to clear the database\n".to_owned() [INFO] [stdout] 651 + _ => "Error while attempting to clear the database\n".to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:236:12 [INFO] [stdout] | [INFO] [stdout] 236 | if first_file_current_line_as_string == "" && second_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:236:55 [INFO] [stdout] | [INFO] [stdout] 236 | if first_file_current_line_as_string == "" && second_file_current_line_as_string == "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:662:5 [INFO] [stdout] | [INFO] [stdout] 662 | return compressed_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 662 - return compressed_tree; [INFO] [stdout] 662 + compressed_tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:677:5 [INFO] [stdout] | [INFO] [stdout] 677 | return compressed_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 677 - return compressed_tree; [INFO] [stdout] 677 + compressed_tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:246:91 [INFO] [stdout] | [INFO] [stdout] 246 | if first_file_current_line_entries_vector.len() != column_count_including_time && first_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:716:9 [INFO] [stdout] | [INFO] [stdout] 716 | return (trigger_expression_tree, "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 716 - return (trigger_expression_tree, "".to_string()); [INFO] [stdout] 716 + (trigger_expression_tree, "".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:251:92 [INFO] [stdout] | [INFO] [stdout] 251 | if second_file_current_line_entries_vector.len() != column_count_including_time && second_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:720:9 [INFO] [stdout] | [INFO] [stdout] 720 | ... return (TriggerExpressionTree{id: 0, children: Vec::new()}, format!("The compressed tree {} has an invalid structure\n", compressed_tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 720 - return (TriggerExpressionTree{id: 0, children: Vec::new()}, format!("The compressed tree {} has an invalid structure\n", compressed_tree)) [INFO] [stdout] 720 + (TriggerExpressionTree{id: 0, children: Vec::new()}, format!("The compressed tree {} has an invalid structure\n", compressed_tree)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 260 | if first_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!first_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 269 | if second_file_current_line_as_string != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!second_file_current_line_as_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grammar.rs:711:99 [INFO] [stdout] | [INFO] [stdout] 711 | recursive_decompress_generated_expression_from_string(&mut compressed_tree_split_numbers, &grammar); [INFO] [stdout] | ^^^^^^^^ help: change this to: `grammar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:714:35 [INFO] [stdout] | [INFO] [stdout] 714 | if success_decompress_tree && compressed_tree_split_numbers.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `compressed_tree_split_numbers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:287:73 [INFO] [stdout] | [INFO] [stdout] 287 | ..._wrapper(&merged_file, format!("{}", first_file_current_line_timestamp.to_string().as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `first_file_current_line_timestamp.to_string().as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:754:5 [INFO] [stdout] | [INFO] [stdout] 754 | return (trigger_expression_tree, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 754 - return (trigger_expression_tree, true); [INFO] [stdout] 754 + (trigger_expression_tree, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:730:8 [INFO] [stdout] | [INFO] [stdout] 730 | if compressed_tree_split_numbers.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `compressed_tree_split_numbers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `first_file_current_line_column_index` is used to index `first_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:288:57 [INFO] [stdout] | [INFO] [stdout] 288 | for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 288 - for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 288 + for (first_file_current_line_column_index, ) in first_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:292:81 [INFO] [stdout] | [INFO] [stdout] 292 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:762:18 [INFO] [stdout] | [INFO] [stdout] 762 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 762 - Ok(_) => return "".to_owned(), [INFO] [stdout] 762 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:293:81 [INFO] [stdout] | [INFO] [stdout] 293 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 294 | | first_file_current_line_entries_vector[first_file_current_line_column_index].as_str()))); [INFO] [stdout] | |______________________________________________________________________________________________________________^ help: consider using `.to_string()`: `first_file_current_line_entries_vector[first_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:763:14 [INFO] [stdout] | [INFO] [stdout] 763 | _ => return format!("unable to write '{}' to temporary hypothesis file\n", content) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 763 - _ => return format!("unable to write '{}' to temporary hypothesis file\n", content) [INFO] [stdout] 763 + _ => format!("unable to write '{}' to temporary hypothesis file\n", content) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `second_file_current_line_column_index` is used to index `second_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:297:58 [INFO] [stdout] | [INFO] [stdout] 297 | for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 297 - for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 297 + for (second_file_current_line_column_index, ) in second_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | if command_line_arguments.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command_line_arguments.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:301:81 [INFO] [stdout] | [INFO] [stdout] 301 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:302:81 [INFO] [stdout] | [INFO] [stdout] 302 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 303 | | second_file_current_line_entries_vector[second_file_current_line_column_index].as_str()))); [INFO] [stdout] | |________________________________________________________________________________________________________________^ help: consider using `.to_string()`: `second_file_current_line_entries_vector[second_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:306:73 [INFO] [stdout] | [INFO] [stdout] 306 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:314:73 [INFO] [stdout] | [INFO] [stdout] 314 | ..._wrapper(&merged_file, format!("{}", first_file_current_line_timestamp.to_string().as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `first_file_current_line_timestamp.to_string().as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `first_file_current_line_column_index` is used to index `first_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:315:57 [INFO] [stdout] | [INFO] [stdout] 315 | for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 315 - for first_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 315 + for (first_file_current_line_column_index, ) in first_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:319:81 [INFO] [stdout] | [INFO] [stdout] 319 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:320:81 [INFO] [stdout] | [INFO] [stdout] 320 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 321 | | first_file_current_line_entries_vector[first_file_current_line_column_index].as_str()))); [INFO] [stdout] | |______________________________________________________________________________________________________________^ help: consider using `.to_string()`: `first_file_current_line_entries_vector[first_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:326:77 [INFO] [stdout] | [INFO] [stdout] 326 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:327:77 [INFO] [stdout] | [INFO] [stdout] 327 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("#"))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `"#".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:329:73 [INFO] [stdout] | [INFO] [stdout] 329 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:335:73 [INFO] [stdout] | [INFO] [stdout] 335 | ..._wrapper(&merged_file, format!("{}", second_file_current_line_timestamp.to_string().as_str()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `second_file_current_line_timestamp.to_string().as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:338:77 [INFO] [stdout] | [INFO] [stdout] 338 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:339:77 [INFO] [stdout] | [INFO] [stdout] 339 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("#"))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `"#".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `second_file_current_line_column_index` is used to index `second_file_current_line_entries_vector` [INFO] [stdout] --> src/distance.rs:341:58 [INFO] [stdout] | [INFO] [stdout] 341 | for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 341 - for second_file_current_line_column_index in 0..column_count_including_time [INFO] [stdout] 341 + for (second_file_current_line_column_index, ) in second_file_current_line_entries_vector.iter().enumerate().take(column_count_including_time) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:345:81 [INFO] [stdout] | [INFO] [stdout] 345 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!(","))); [INFO] [stdout] | ^^^^^^^^^^^^ help: consider using `.to_string()`: `",".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:346:81 [INFO] [stdout] | [INFO] [stdout] 346 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("{}", [INFO] [stdout] | _________________________________________________________________________________^ [INFO] [stdout] 347 | | second_file_current_line_entries_vector[second_file_current_line_column_index].as_str()))); [INFO] [stdout] | |________________________________________________________________________________________________________________^ help: consider using `.to_string()`: `second_file_current_line_entries_vector[second_file_current_line_column_index].as_str().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/distance.rs:350:73 [INFO] [stdout] | [INFO] [stdout] 350 | error_message.push_str(&write_to_file_wrapper(&merged_file, format!("\n"))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/distance.rs:355:8 [INFO] [stdout] | [INFO] [stdout] 355 | if error_message != "" [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!error_message.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:367:18 [INFO] [stdout] | [INFO] [stdout] 367 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 367 - Ok(_) => return "".to_owned(), [INFO] [stdout] 367 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/distance.rs:368:14 [INFO] [stdout] | [INFO] [stdout] 368 | _ => return format!("unable to write '{}' to merge file\n", content) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 368 - _ => return format!("unable to write '{}' to merge file\n", content) [INFO] [stdout] 368 + _ => format!("unable to write '{}' to merge file\n", content) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/hypothesis.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 17 | if error_message != "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/hypothesis.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | if error_message != "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hypothesis.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | if !trace_file_direntry_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hypothesis.rs:99:5 [INFO] [stdout] | [INFO] [stdout] 99 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return "".to_string(); [INFO] [stdout] 99 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | let actual_world_full_path_as_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `actual_world_full_path_as_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 59 ~ [INFO] [stdout] 60 ~ let actual_world_full_path_as_str:String = match Path::new(parsed_command_line_arguments.traces_folder_path.as_str()).join(parsed_command_line_arguments.actual_world_file_name.clone()) [INFO] [stdout] 61 | .to_path_buf().to_str() [INFO] [stdout] 62 | { [INFO] [stdout] 63 ~ Some(s) => s.to_owned(), [INFO] [stdout] 64 | _ => return "While evaluating, actual world has an invalid file path (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 65 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | let trace_file_path_to_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trace_file_path_to_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 67 ~ [INFO] [stdout] 68 ~ let trace_file_path_to_str:String = match trace_file_direntry.path().to_str() [INFO] [stdout] 69 | { [INFO] [stdout] 70 ~ Some(s) => s.to_owned(), [INFO] [stdout] 71 | _ => return "While evaluating, an invalid trace file path appeared (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 72 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hypothesis.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if !trace_file_direntry_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `trace_file_direntry_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hypothesis.rs:160:5 [INFO] [stdout] | [INFO] [stdout] 160 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return "".to_string(); [INFO] [stdout] 160 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | let actual_world_full_path_as_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `actual_world_full_path_as_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 123 ~ [INFO] [stdout] 124 ~ let actual_world_full_path_as_str:String = match Path::new(parsed_command_line_arguments.traces_folder_path.as_str()).join( [INFO] [stdout] 125 | parsed_command_line_arguments.actual_world_file_name.clone()).to_path_buf().to_str() [INFO] [stdout] 126 | { [INFO] [stdout] 127 ~ Some(s) => s.to_owned(), [INFO] [stdout] 128 | _ => return "While evaluating, an invalid actual world path appeared (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 129 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/hypothesis.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | let trace_file_path_to_str:String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `trace_file_path_to_str` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 131 ~ [INFO] [stdout] 132 ~ let trace_file_path_to_str:String = match trace_file_direntry.path().to_str() [INFO] [stdout] 133 | { [INFO] [stdout] 134 ~ Some(s) => s.to_owned(), [INFO] [stdout] 135 | _ => return "While evaluating, an invalid file path appeared (technical explanation: to_str() failed)\n".to_owned() [INFO] [stdout] 136 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/hypothesis.rs:287:5 [INFO] [stdout] | [INFO] [stdout] 287 | return evaluation_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 287 - return evaluation_result; [INFO] [stdout] 287 + evaluation_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:212:39 [INFO] [stdout] | [INFO] [stdout] 212 | evaluation_result.0.push_str(&format!("The hypothesis is therefore rejected\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is therefore rejected\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:223:43 [INFO] [stdout] | [INFO] [stdout] 223 | evaluation_result.0.push_str(&format!("The hypothesis is therefore rejected\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is therefore rejected\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:228:43 [INFO] [stdout] | [INFO] [stdout] 228 | evaluation_result.0.push_str(&format!("The hypothesis is accepted\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is accepted\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:241:39 [INFO] [stdout] | [INFO] [stdout] 241 | evaluation_result.0.push_str(&format!("The hypothesis is therefore rejected\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is therefore rejected\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/hypothesis.rs:247:39 [INFO] [stdout] | [INFO] [stdout] 247 | evaluation_result.0.push_str(&format!("The hypothesis is accepted\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"The hypothesis is accepted\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/hypothesis.rs:266:13 [INFO] [stdout] | [INFO] [stdout] 266 | traces_closer_to_actual_world_than_smallest_good_trace = traces_closer_to_actual_world_than_smallest_good_trace + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `traces_closer_to_actual_world_than_smallest_good_trace += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/hypothesis.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 271 | traces_closer_to_actual_world_than_smallest_bad_trace = traces_closer_to_actual_world_than_smallest_bad_trace + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `traces_closer_to_actual_world_than_smallest_bad_trace += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/hypothesis.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | traces_with_intact_cause_effect_relationship = traces_with_intact_cause_effect_relationship + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `traces_with_intact_cause_effect_relationship += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | if !database_connection_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `database_connection_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 96 | if !database_connection.execute( [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | "CREATE TABLE IF NOT EXISTS generated_expressions ( [INFO] [stdout] 98 | | id INTEGER PRIMARY KEY, [INFO] [stdout] 99 | | parent TEXT NOT NULL, [INFO] [stdout] ... | [INFO] [stdout] 105 | | (), // empty list of parameters. [INFO] [stdout] 106 | | ).is_ok() [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 96 ~ if database_connection.execute( [INFO] [stdout] 97 + "CREATE TABLE IF NOT EXISTS generated_expressions ( [INFO] [stdout] 98 + id INTEGER PRIMARY KEY, [INFO] [stdout] 99 + parent TEXT NOT NULL, [INFO] [stdout] 100 + weight INTEGER, [INFO] [stdout] 101 + compressed_tree TEXT NOT NULL, [INFO] [stdout] 102 + semantic_satisfaction INTEGER, [INFO] [stdout] 103 + hybrid_satisfaction INTEGER [INFO] [stdout] 104 + )", [INFO] [stdout] 105 + (), // empty list of parameters. [INFO] [stdout] 106 ~ ).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:128:12 [INFO] [stdout] | [INFO] [stdout] 128 | if flat_production.children.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flat_production.children.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:152:16 [INFO] [stdout] | [INFO] [stdout] 152 | if flat_production.1.children.len() == 0 && flat_production.1.weight != current_trigger_expression_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flat_production.1.children.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:163:16 [INFO] [stdout] | [INFO] [stdout] 163 | if flat_production.1.children.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flat_production.1.children.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/grammar.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `child_weight_combination` [INFO] [stdout] --> src/grammar.rs:214:34 [INFO] [stdout] | [INFO] [stdout] 214 | for index in 0..child_weight_combination.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 214 - for index in 0..child_weight_combination.len() [INFO] [stdout] 214 + for (index, ) in child_weight_combination.iter().enumerate() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:224:28 [INFO] [stdout] | [INFO] [stdout] 224 | if query_result.0.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query_result.0.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/grammar.rs:244:25 [INFO] [stdout] | [INFO] [stdout] 244 | id = id + 1; [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `id += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/grammar.rs:309:29 [INFO] [stdout] | [INFO] [stdout] 309 | ... println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | return vec![vec![sum]]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 350 - return vec![vec![sum]]; [INFO] [stdout] 350 + vec![vec![sum]] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:364:9 [INFO] [stdout] | [INFO] [stdout] 364 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 364 - return result; [INFO] [stdout] 364 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:383:14 [INFO] [stdout] | [INFO] [stdout] 383 | 0 => return Some(result), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - 0 => return Some(result), [INFO] [stdout] 383 + 0 => Some(result), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:384:14 [INFO] [stdout] | [INFO] [stdout] 384 | _ => return None [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 384 - _ => return None [INFO] [stdout] 384 + _ => None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/grammar.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | id_cpy = id_cpy/choice_list.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `id_cpy /= choice_list.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:413:5 [INFO] [stdout] | [INFO] [stdout] 413 | return (hypothesis_evaluation_results.0, hypothesis_evaluation_results.1, "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 413 - return (hypothesis_evaluation_results.0, hypothesis_evaluation_results.1, "".to_owned()); [INFO] [stdout] 413 + (hypothesis_evaluation_results.0, hypothesis_evaluation_results.1, "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | return (temporary_file_path_to_str.to_owned(), "".to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 466 - return (temporary_file_path_to_str.to_owned(), "".to_owned()); [INFO] [stdout] 466 + (temporary_file_path_to_str.to_owned(), "".to_owned()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:481:5 [INFO] [stdout] | [INFO] [stdout] 481 | return trigger_expression.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 481 - return trigger_expression.to_string(); [INFO] [stdout] 481 + trigger_expression.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grammar.rs:478:64 [INFO] [stdout] | [INFO] [stdout] 478 | let child_string = trigger_expression_string_from_tree(&child, grammar); [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:501:8 [INFO] [stdout] | [INFO] [stdout] 501 | if !json_grammar_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `json_grammar_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | return (Some(grammar), "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 552 - return (Some(grammar), "".to_string()); [INFO] [stdout] 552 + (Some(grammar), "".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:556:9 [INFO] [stdout] | [INFO] [stdout] 556 | return (None, error_message); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 556 - return (None, error_message); [INFO] [stdout] 556 + (None, error_message) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:570:8 [INFO] [stdout] | [INFO] [stdout] 570 | if !statement_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `statement_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grammar.rs:578:8 [INFO] [stdout] | [INFO] [stdout] 578 | if !query_results_wrapped.is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `query_results_wrapped.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:626:18 [INFO] [stdout] | [INFO] [stdout] 626 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 626 - Ok(_) => return "".to_owned(), [INFO] [stdout] 626 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:627:14 [INFO] [stdout] | [INFO] [stdout] 627 | ... _ => return format!("Failed to insert (parent: {}, weight:{}, compressed_tree: {}, semantic_satisfaction: {}, hybrid_satisf... [INFO] [stdout] | ____________^ [INFO] [stdout] 628 | | ... parent, weight, compressed_tree, semantic_satisfaction, hybrid_satisfaction) [INFO] [stdout] | |__________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 627 ~ _ => format!("Failed to insert (parent: {}, weight:{}, compressed_tree: {}, semantic_satisfaction: {}, hybrid_satisfaction: {}) into the database\n", [INFO] [stdout] 628 + parent, weight, compressed_tree, semantic_satisfaction, hybrid_satisfaction) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:650:18 [INFO] [stdout] | [INFO] [stdout] 650 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 650 - Ok(_) => return "".to_owned(), [INFO] [stdout] 650 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:651:14 [INFO] [stdout] | [INFO] [stdout] 651 | _ => return "Error while attempting to clear the database\n".to_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 651 - _ => return "Error while attempting to clear the database\n".to_owned() [INFO] [stdout] 651 + _ => "Error while attempting to clear the database\n".to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:662:5 [INFO] [stdout] | [INFO] [stdout] 662 | return compressed_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 662 - return compressed_tree; [INFO] [stdout] 662 + compressed_tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:677:5 [INFO] [stdout] | [INFO] [stdout] 677 | return compressed_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 677 - return compressed_tree; [INFO] [stdout] 677 + compressed_tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:716:9 [INFO] [stdout] | [INFO] [stdout] 716 | return (trigger_expression_tree, "".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 716 - return (trigger_expression_tree, "".to_string()); [INFO] [stdout] 716 + (trigger_expression_tree, "".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:720:9 [INFO] [stdout] | [INFO] [stdout] 720 | ... return (TriggerExpressionTree{id: 0, children: Vec::new()}, format!("The compressed tree {} has an invalid structure\n", compressed_tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 720 - return (TriggerExpressionTree{id: 0, children: Vec::new()}, format!("The compressed tree {} has an invalid structure\n", compressed_tree)) [INFO] [stdout] 720 + (TriggerExpressionTree{id: 0, children: Vec::new()}, format!("The compressed tree {} has an invalid structure\n", compressed_tree)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grammar.rs:711:99 [INFO] [stdout] | [INFO] [stdout] 711 | recursive_decompress_generated_expression_from_string(&mut compressed_tree_split_numbers, &grammar); [INFO] [stdout] | ^^^^^^^^ help: change this to: `grammar` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:714:35 [INFO] [stdout] | [INFO] [stdout] 714 | if success_decompress_tree && compressed_tree_split_numbers.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `compressed_tree_split_numbers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:754:5 [INFO] [stdout] | [INFO] [stdout] 754 | return (trigger_expression_tree, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 754 - return (trigger_expression_tree, true); [INFO] [stdout] 754 + (trigger_expression_tree, true) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grammar.rs:730:8 [INFO] [stdout] | [INFO] [stdout] 730 | if compressed_tree_split_numbers.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `compressed_tree_split_numbers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:762:18 [INFO] [stdout] | [INFO] [stdout] 762 | Ok(_) => return "".to_owned(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 762 - Ok(_) => return "".to_owned(), [INFO] [stdout] 762 + Ok(_) => "".to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grammar.rs:763:14 [INFO] [stdout] | [INFO] [stdout] 763 | _ => return format!("unable to write '{}' to temporary hypothesis file\n", content) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 763 - _ => return format!("unable to write '{}' to temporary hypothesis file\n", content) [INFO] [stdout] 763 + _ => format!("unable to write '{}' to temporary hypothesis file\n", content) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 20 | if command_line_arguments.len() == 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command_line_arguments.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.32s [INFO] running `Command { std: "docker" "inspect" "a8f99ad4f44d72a10e2cce79da7e77c2fa20906aac2a50c161fa0e5b4835b4fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8f99ad4f44d72a10e2cce79da7e77c2fa20906aac2a50c161fa0e5b4835b4fd", kill_on_drop: false }` [INFO] [stdout] a8f99ad4f44d72a10e2cce79da7e77c2fa20906aac2a50c161fa0e5b4835b4fd