[INFO] cloning repository https://github.com/s-prechtl/wifi-connector-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/s-prechtl/wifi-connector-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs-prechtl%2Fwifi-connector-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs-prechtl%2Fwifi-connector-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 815c4db23bdca1813a502ccc9cdaafd8d136e8a1
[INFO] linting s-prechtl/wifi-connector-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fs-prechtl%2Fwifi-connector-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/s-prechtl/wifi-connector-rs
[INFO] finished tweaking git repo https://github.com/s-prechtl/wifi-connector-rs
[INFO] tweaked toml for git repo https://github.com/s-prechtl/wifi-connector-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/s-prechtl/wifi-connector-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/s-prechtl/wifi-connector-rs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 24fe48715ba10ef23e5223bf85b3f2e7f4c42e062a6dc828283f9016e320537f
[INFO] running `Command { std: "docker" "start" "-a" "24fe48715ba10ef23e5223bf85b3f2e7f4c42e062a6dc828283f9016e320537f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "24fe48715ba10ef23e5223bf85b3f2e7f4c42e062a6dc828283f9016e320537f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "24fe48715ba10ef23e5223bf85b3f2e7f4c42e062a6dc828283f9016e320537f", kill_on_drop: false }`
[INFO] [stdout] 24fe48715ba10ef23e5223bf85b3f2e7f4c42e062a6dc828283f9016e320537f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f61dc2d6bc6a3b791b3257bd85eeb8763d88705318277e02a7be8603eeb8517d
[INFO] running `Command { std: "docker" "start" "-a" "f61dc2d6bc6a3b791b3257bd85eeb8763d88705318277e02a7be8603eeb8517d", kill_on_drop: false }`
[INFO] [stderr]    Compiling anyhow v1.0.71
[INFO] [stderr]     Checking wifi-connector v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/network.rs:73:9
[INFO] [stdout]    |
[INFO] [stdout] 73 |         return network;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 73 -         return network;
[INFO] [stdout] 73 +         network
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/network.rs:11:62
[INFO] [stdout]    |
[INFO] [stdout] 11 |     pub fn from_nmcli_stdout(line: String, header_positions: &Vec<u8>) -> Self {
[INFO] [stdout]    |                                                              ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 11 -     pub fn from_nmcli_stdout(line: String, header_positions: &Vec<u8>) -> Self {
[INFO] [stdout] 11 +     pub fn from_nmcli_stdout(line: String, header_positions: &[u8]) -> Self {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `header_positions.get(0)`
[INFO] [stdout]   --> src/network.rs:30:17
[INFO] [stdout]    |
[INFO] [stdout] 30 | /                 header_positions
[INFO] [stdout] 31 | |                     .get(0)
[INFO] [stdout]    | |___________________________^ help: try: `header_positions.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/network.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return write!(f, "{} - {} - {} ", self.in_use, self.ssid, self.signal);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 -         return write!(f, "{} - {} - {} ", self.in_use, self.ssid, self.signal);
[INFO] [stdout] 79 +         write!(f, "{} - {} - {} ", self.in_use, self.ssid, self.signal)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/network.rs:73:9
[INFO] [stdout]    |
[INFO] [stdout] 73 |         return network;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 73 -         return network;
[INFO] [stdout] 73 +         network
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/network.rs:11:62
[INFO] [stdout]    |
[INFO] [stdout] 11 |     pub fn from_nmcli_stdout(line: String, header_positions: &Vec<u8>) -> Self {
[INFO] [stdout]    |                                                              ^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 11 -     pub fn from_nmcli_stdout(line: String, header_positions: &Vec<u8>) -> Self {
[INFO] [stdout] 11 +     pub fn from_nmcli_stdout(line: String, header_positions: &[u8]) -> Self {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `header_positions.get(0)`
[INFO] [stdout]   --> src/network.rs:30:17
[INFO] [stdout]    |
[INFO] [stdout] 30 | /                 header_positions
[INFO] [stdout] 31 | |                     .get(0)
[INFO] [stdout]    | |___________________________^ help: try: `header_positions.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/network.rs:79:9
[INFO] [stdout]    |
[INFO] [stdout] 79 |         return write!(f, "{} - {} - {} ", self.in_use, self.ssid, self.signal);
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 -         return write!(f, "{} - {} - {} ", self.in_use, self.ssid, self.signal);
[INFO] [stdout] 79 +         write!(f, "{} - {} - {} ", self.in_use, self.ssid, self.signal)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     return positions;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -     return positions;
[INFO] [stdout] 32 +     positions
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:16:42
[INFO] [stdout]    |
[INFO] [stdout] 16 | fn get_descriptor_positions(header_line: &String) -> Vec<u8> {
[INFO] [stdout]    |                                          ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 16 - fn get_descriptor_positions(header_line: &String) -> Vec<u8> {
[INFO] [stdout] 16 + fn get_descriptor_positions(header_line: &str) -> Vec<u8> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]   --> src/main.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 | /     let mut positions: Vec<u8> = vec![];
[INFO] [stdout] 18 | |
[INFO] [stdout] 19 | |     positions.push(0);
[INFO] [stdout] 20 | |     positions.push(
[INFO] [stdout] ...  |
[INFO] [stdout] 29 | |             .expect("SIGNAL not found in header string") as u8,
[INFO] [stdout] 30 | |     );
[INFO] [stdout]    | |______^ help: consider using the `vec![]` macro: `let positions: Vec<u8> = vec![..];`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]    = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 |     return all_networks;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -     return all_networks;
[INFO] [stdout] 51 +     all_networks
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> src/main.rs:40:38
[INFO] [stdout]    |
[INFO] [stdout] 40 |         nmcli_output.split('\n').map(|s| String::from(s)).collect();
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:59:14
[INFO] [stdout]    |
[INFO] [stdout] 59 |         .arg(&network.ssid.trim())
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `network.ssid.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:77:14
[INFO] [stdout]    |
[INFO] [stdout] 77 |         .arg(&network.ssid.trim())
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `network.ssid.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:88:29
[INFO] [stdout]    |
[INFO] [stdout] 88 | fn print_networks(networks: &Vec<Network>) {
[INFO] [stdout]    |                             ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 88 - fn print_networks(networks: &Vec<Network>) {
[INFO] [stdout] 88 + fn print_networks(networks: &[Network]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:130:5
[INFO] [stdout]     |
[INFO] [stdout] 130 |     return unique_networks.into_values().collect();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 130 -     return unique_networks.into_values().collect();
[INFO] [stdout] 130 +     unique_networks.into_values().collect()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:146:8
[INFO] [stdout]     |
[INFO] [stdout] 146 |     if !connected.is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^ help: try: `connected.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:148:40
[INFO] [stdout]     |
[INFO] [stdout] 148 |         connected = connect_to_network(&network, password.trim());
[INFO] [stdout]     |                                        ^^^^^^^^ help: change this to: `network`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     return positions;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -     return positions;
[INFO] [stdout] 32 +     positions
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:16:42
[INFO] [stdout]    |
[INFO] [stdout] 16 | fn get_descriptor_positions(header_line: &String) -> Vec<u8> {
[INFO] [stdout]    |                                          ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 16 - fn get_descriptor_positions(header_line: &String) -> Vec<u8> {
[INFO] [stdout] 16 + fn get_descriptor_positions(header_line: &str) -> Vec<u8> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]   --> src/main.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 | /     let mut positions: Vec<u8> = vec![];
[INFO] [stdout] 18 | |
[INFO] [stdout] 19 | |     positions.push(0);
[INFO] [stdout] 20 | |     positions.push(
[INFO] [stdout] ...  |
[INFO] [stdout] 29 | |             .expect("SIGNAL not found in header string") as u8,
[INFO] [stdout] 30 | |     );
[INFO] [stdout]    | |______^ help: consider using the `vec![]` macro: `let positions: Vec<u8> = vec![..];`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]    = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 |     return all_networks;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -     return all_networks;
[INFO] [stdout] 51 +     all_networks
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> src/main.rs:40:38
[INFO] [stdout]    |
[INFO] [stdout] 40 |         nmcli_output.split('\n').map(|s| String::from(s)).collect();
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:59:14
[INFO] [stdout]    |
[INFO] [stdout] 59 |         .arg(&network.ssid.trim())
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `network.ssid.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:77:14
[INFO] [stdout]    |
[INFO] [stdout] 77 |         .arg(&network.ssid.trim())
[INFO] [stdout]    |              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `network.ssid.trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:88:29
[INFO] [stdout]    |
[INFO] [stdout] 88 | fn print_networks(networks: &Vec<Network>) {
[INFO] [stdout]    |                             ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 88 - fn print_networks(networks: &Vec<Network>) {
[INFO] [stdout] 88 + fn print_networks(networks: &[Network]) {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:130:5
[INFO] [stdout]     |
[INFO] [stdout] 130 |     return unique_networks.into_values().collect();
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 130 -     return unique_networks.into_values().collect();
[INFO] [stdout] 130 +     unique_networks.into_values().collect()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:146:8
[INFO] [stdout]     |
[INFO] [stdout] 146 |     if !connected.is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^ help: try: `connected.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:148:40
[INFO] [stdout]     |
[INFO] [stdout] 148 |         connected = connect_to_network(&network, password.trim());
[INFO] [stdout]     |                                        ^^^^^^^^ help: change this to: `network`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.71s
[INFO] running `Command { std: "docker" "inspect" "f61dc2d6bc6a3b791b3257bd85eeb8763d88705318277e02a7be8603eeb8517d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f61dc2d6bc6a3b791b3257bd85eeb8763d88705318277e02a7be8603eeb8517d", kill_on_drop: false }`
[INFO] [stdout] f61dc2d6bc6a3b791b3257bd85eeb8763d88705318277e02a7be8603eeb8517d