[INFO] cloning repository https://github.com/ryebreadgit/fjwrap [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ryebreadgit/fjwrap" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fryebreadgit%2Ffjwrap", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fryebreadgit%2Ffjwrap'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3d68e7463863d64a85aa0e5472d47192ce876944 [INFO] linting ryebreadgit/fjwrap against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fryebreadgit%2Ffjwrap" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ryebreadgit/fjwrap [INFO] finished tweaking git repo https://github.com/ryebreadgit/fjwrap [INFO] tweaked toml for git repo https://github.com/ryebreadgit/fjwrap written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ryebreadgit/fjwrap on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ryebreadgit/fjwrap already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded prost-build v0.14.3 [INFO] [stderr] Downloaded compare v0.0.6 [INFO] [stderr] Downloaded interval-heap v0.0.5 [INFO] [stderr] Downloaded prost-derive v0.14.3 [INFO] [stderr] Downloaded tonic-prost v0.14.4 [INFO] [stderr] Downloaded varint-rs v2.2.0 [INFO] [stderr] Downloaded sfa v1.0.0 [INFO] [stderr] Downloaded async-compat v0.2.5 [INFO] [stderr] Downloaded byteview v0.10.0 [INFO] [stderr] Downloaded fracturedjson v0.1.1 [INFO] [stderr] Downloaded quick_cache v0.6.18 [INFO] [stderr] Downloaded pulldown-cmark v0.13.0 [INFO] [stderr] Downloaded fjall v3.0.1 [INFO] [stderr] Downloaded prost-types v0.14.3 [INFO] [stderr] Downloaded crossbeam-skiplist v0.1.3 [INFO] [stderr] Downloaded lz4_flex v0.11.5 [INFO] [stderr] Downloaded pulldown-cmark-to-cmark v22.0.0 [INFO] [stderr] Downloaded lsm-tree v3.0.1 [INFO] [stderr] Downloaded prost v0.14.3 [INFO] [stderr] Downloaded enum_dispatch v0.3.13 [INFO] [stderr] Downloaded zmij v1.0.15 [INFO] [stderr] Downloaded tonic-build v0.14.4 [INFO] [stderr] Downloaded tonic-prost-build v0.14.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a84413964823660855d4a5f773566941d99d8c84c8effe8dab22f27c066f31c3 [INFO] running `Command { std: "docker" "start" "-a" "a84413964823660855d4a5f773566941d99d8c84c8effe8dab22f27c066f31c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a84413964823660855d4a5f773566941d99d8c84c8effe8dab22f27c066f31c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a84413964823660855d4a5f773566941d99d8c84c8effe8dab22f27c066f31c3", kill_on_drop: false }` [INFO] [stdout] a84413964823660855d4a5f773566941d99d8c84c8effe8dab22f27c066f31c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 40e2ce4fd626c2ce4186ee0ebe32bc085e40512b5d7c11204e5aa81e0be55261 [INFO] running `Command { std: "docker" "start" "-a" "40e2ce4fd626c2ce4186ee0ebe32bc085e40512b5d7c11204e5aa81e0be55261", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling bitflags v2.10.0 [INFO] [stderr] Compiling pulldown-cmark v0.13.0 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Compiling foldhash v0.1.5 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Compiling regex-syntax v0.8.9 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling bytes v1.11.0 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling zmij v1.0.15 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling multimap v0.10.1 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking rustix v1.1.3 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking twox-hash v2.1.2 [INFO] [stderr] Checking compare v0.0.6 [INFO] [stderr] Checking interval-heap v0.0.5 [INFO] [stderr] Checking lz4_flex v0.11.5 [INFO] [stderr] Checking sfa v1.0.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking quick_cache v0.6.18 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking self_cell v1.2.2 [INFO] [stderr] Checking rustc-hash v2.1.1 [INFO] [stderr] Checking varint-rs v2.2.0 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking byteview v0.10.0 [INFO] [stderr] Checking flume v0.12.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking dashmap v6.1.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Compiling pulldown-cmark-to-cmark v22.0.0 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Compiling petgraph v0.8.3 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling prost-derive v0.14.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling tonic-build v0.14.4 [INFO] [stderr] Checking lsm-tree v3.0.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling prost v0.14.3 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Compiling prost-types v0.14.3 [INFO] [stderr] Checking fjall v3.0.1 [INFO] [stderr] Compiling prost-build v0.14.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Compiling tonic-prost-build v0.14.4 [INFO] [stderr] Checking kvwrap-core v0.1.0 (/opt/rustwide/workdir/crates/kvwrap-core) [INFO] [stderr] Checking fracturedjson v0.1.1 [INFO] [stderr] Compiling kvwrap-proto v0.1.0 (/opt/rustwide/workdir/crates/kvwrap-proto) [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking async-compat v0.2.5 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:54:29 [INFO] [stdout] | [INFO] [stdout] 54 | .keyspace(name, || KeyspaceCreateOptions::default())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `KeyspaceCreateOptions::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `key` [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | let key = key; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `key` is initially defined here [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let key = key.to_vec(); [INFO] [stdout] | ^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `value` [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let value = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `value` is initially defined here [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | let value = value.to_vec(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> crates/kvwrap-core/src/backend/sled.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | .cache_capacity(config.cache_size as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ config.cache_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:54:29 [INFO] [stdout] | [INFO] [stdout] 54 | .keyspace(name, || KeyspaceCreateOptions::default())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `KeyspaceCreateOptions::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `key` [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | let key = key; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `key` is initially defined here [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let key = key.to_vec(); [INFO] [stdout] | ^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] = note: `#[warn(clippy::redundant_locals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant redefinition of a binding `value` [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let value = value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: `value` is initially defined here [INFO] [stdout] --> crates/kvwrap-core/src/backend/fjall.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | let value = value.to_vec(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> crates/kvwrap-core/src/backend/sled.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | .cache_capacity(config.cache_size as u64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `{ config.cache_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-timeout v0.5.2 [INFO] [stderr] Checking tonic v0.14.2 [INFO] [stderr] Checking tonic-prost v0.14.4 [INFO] [stderr] Checking kvwrap-distributed v0.1.0 (/opt/rustwide/workdir/crates/kvwrap-distributed) [INFO] [stderr] Checking kvwrap-client v0.1.0 (/opt/rustwide/workdir/crates/kvwrap-client) [INFO] [stdout] warning: enum `ConfigError` is never used [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/error.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum ConfigError { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `KeyRangeExt` is never used [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/traits.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait KeyRangeExt { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `node_id` is never read [INFO] [stdout] --> crates/kvwrap-distributed/src/server/server.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct KvServiceImpl { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 16 | node_id: NodeId, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|b| b.as_slice())` on an `Option` value [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | let begin = range.begin.as_ref().map(|b| b.as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `range.begin.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|e| e.as_slice())` on an `Option` value [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:44:27 [INFO] [stdout] | [INFO] [stdout] 44 | let end = range.end.as_ref().map(|e| e.as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `range.end.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | / if (begin.is_none() || shard_key.as_slice() >= begin.unwrap()) [INFO] [stdout] 46 | | && (end.is_none() || shard_key.as_slice() < end.unwrap()) [INFO] [stdout] 47 | | { [INFO] [stdout] 48 | | if shard.status() == ShardStatus::Active { [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 46 ~ && (end.is_none() || shard_key.as_slice() < end.unwrap()) [INFO] [stdout] 47 ~ && shard.status() == ShardStatus::Active { [INFO] [stdout] 48 | return Ok(shard.id.clone().unwrap()); [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `ConfigError` is never used [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/error.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum ConfigError { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `KeyRangeExt` is never used [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/traits.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait KeyRangeExt { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `node_id` is never read [INFO] [stdout] --> crates/kvwrap-distributed/src/server/server.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct KvServiceImpl { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 16 | node_id: NodeId, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:49:35 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(shard.id.clone().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `shard.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ShardId` which implements the `Copy` trait [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:62:46 [INFO] [stdout] | [INFO] [stdout] 62 | .ok_or(RouteError::ShardNotFound(shard_id.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `shard_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:81:32 [INFO] [stdout] | [INFO] [stdout] 81 | shard_ids.push(shard.id.clone().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `shard.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/types.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | / if let Some(begin) = &self.begin { [INFO] [stdout] 9 | | if key < begin.as_slice() { [INFO] [stdout] 10 | | return false; [INFO] [stdout] 11 | | } [INFO] [stdout] 12 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 8 ~ if let Some(begin) = &self.begin [INFO] [stdout] 9 ~ && key < begin.as_slice() { [INFO] [stdout] 10 | return false; [INFO] [stdout] 11 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / if let Some(end) = &self.end { [INFO] [stdout] 14 | | if key >= end.as_slice() { [INFO] [stdout] 15 | | return false; [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 13 ~ if let Some(end) = &self.end [INFO] [stdout] 14 ~ && key >= end.as_slice() { [INFO] [stdout] 15 | return false; [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/types.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if let Some(end) = &self.end { [INFO] [stdout] 22 | | if prefix >= end.as_slice() { [INFO] [stdout] 23 | | return false; [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Some(end) = &self.end [INFO] [stdout] 22 ~ && prefix >= end.as_slice() { [INFO] [stdout] 23 | return false; [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> crates/kvwrap-distributed/src/server/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod server; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> crates/kvwrap-distributed/src/server/server.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 28 | let local_shard_nodes = match router.node_shard_ids(&node_id) { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 29 | | Ok(shard_ids) => shard_ids, [INFO] [stdout] 30 | | Err(_) => Vec::new(), [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ help: replace it with: `router.node_shard_ids(&node_id).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|b| b.as_slice())` on an `Option` value [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 43 | let begin = range.begin.as_ref().map(|b| b.as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `range.begin.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|e| e.as_slice())` on an `Option` value [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:44:27 [INFO] [stdout] | [INFO] [stdout] 44 | let end = range.end.as_ref().map(|e| e.as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `range.end.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | / if (begin.is_none() || shard_key.as_slice() >= begin.unwrap()) [INFO] [stdout] 46 | | && (end.is_none() || shard_key.as_slice() < end.unwrap()) [INFO] [stdout] 47 | | { [INFO] [stdout] 48 | | if shard.status() == ShardStatus::Active { [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 46 ~ && (end.is_none() || shard_key.as_slice() < end.unwrap()) [INFO] [stdout] 47 ~ && shard.status() == ShardStatus::Active { [INFO] [stdout] 48 | return Ok(shard.id.clone().unwrap()); [INFO] [stdout] 49 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/kvwrap-distributed/src/server/server.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / request [INFO] [stdout] 71 | | .metadata() [INFO] [stdout] 72 | | .get(PROXIED_HEADER) [INFO] [stdout] 73 | | .map_or(false, |v| v == "true") [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 73 - .map_or(false, |v| v == "true") [INFO] [stdout] 73 + .is_some_and(|v| v == "true") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:49:35 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(shard.id.clone().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `shard.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ShardId` which implements the `Copy` trait [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:62:46 [INFO] [stdout] | [INFO] [stdout] 62 | .ok_or(RouteError::ShardNotFound(shard_id.clone()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `shard_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/router.rs:81:32 [INFO] [stdout] | [INFO] [stdout] 81 | shard_ids.push(shard.id.clone().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `shard.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/types.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | / if let Some(begin) = &self.begin { [INFO] [stdout] 9 | | if key < begin.as_slice() { [INFO] [stdout] 10 | | return false; [INFO] [stdout] 11 | | } [INFO] [stdout] 12 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 8 ~ if let Some(begin) = &self.begin [INFO] [stdout] 9 ~ && key < begin.as_slice() { [INFO] [stdout] 10 | return false; [INFO] [stdout] 11 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/types.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | / if let Some(end) = &self.end { [INFO] [stdout] 14 | | if key >= end.as_slice() { [INFO] [stdout] 15 | | return false; [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 13 ~ if let Some(end) = &self.end [INFO] [stdout] 14 ~ && key >= end.as_slice() { [INFO] [stdout] 15 | return false; [INFO] [stdout] 16 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> crates/kvwrap-distributed/src/routing/types.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if let Some(end) = &self.end { [INFO] [stdout] 22 | | if prefix >= end.as_slice() { [INFO] [stdout] 23 | | return false; [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 21 ~ if let Some(end) = &self.end [INFO] [stdout] 22 ~ && prefix >= end.as_slice() { [INFO] [stdout] 23 | return false; [INFO] [stdout] 24 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> crates/kvwrap-distributed/src/server/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod server; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> crates/kvwrap-distributed/src/server/server.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 28 | let local_shard_nodes = match router.node_shard_ids(&node_id) { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 29 | | Ok(shard_ids) => shard_ids, [INFO] [stdout] 30 | | Err(_) => Vec::new(), [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ help: replace it with: `router.node_shard_ids(&node_id).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> crates/kvwrap-distributed/src/server/server.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / request [INFO] [stdout] 71 | | .metadata() [INFO] [stdout] 72 | | .get(PROXIED_HEADER) [INFO] [stdout] 73 | | .map_or(false, |v| v == "true") [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 73 - .map_or(false, |v| v == "true") [INFO] [stdout] 73 + .is_some_and(|v| v == "true") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking kvwrap v0.1.0 (/opt/rustwide/workdir/crates/kvwrap) [INFO] [stderr] Checking kvwrap-bin v0.1.0 (/opt/rustwide/workdir/crates/kvwrap-bin) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/kvwrap-bin/src/main.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | if !fs::metadata(&args.router_config_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&args.router_config_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> crates/kvwrap-bin/src/main.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | if !fs::metadata(&args.router_config_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&args.router_config_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.11s [INFO] running `Command { std: "docker" "inspect" "40e2ce4fd626c2ce4186ee0ebe32bc085e40512b5d7c11204e5aa81e0be55261", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40e2ce4fd626c2ce4186ee0ebe32bc085e40512b5d7c11204e5aa81e0be55261", kill_on_drop: false }` [INFO] [stdout] 40e2ce4fd626c2ce4186ee0ebe32bc085e40512b5d7c11204e5aa81e0be55261