[INFO] cloning repository https://github.com/rskntroot/r53-ddns [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rskntroot/r53-ddns" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frskntroot%2Fr53-ddns", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frskntroot%2Fr53-ddns'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 815518716b534ecbb46e3980233f24045295757b [INFO] linting rskntroot/r53-ddns against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frskntroot%2Fr53-ddns" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rskntroot/r53-ddns [INFO] finished tweaking git repo https://github.com/rskntroot/r53-ddns [INFO] tweaked toml for git repo https://github.com/rskntroot/r53-ddns written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rskntroot/r53-ddns on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rskntroot/r53-ddns already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded enum-as-inner v0.6.0 [INFO] [stderr] Downloaded clap_derive v4.5.11 [INFO] [stderr] Downloaded trust-dns-resolver v0.23.2 [INFO] [stderr] Downloaded aws-smithy-xml v0.60.8 [INFO] [stderr] Downloaded aws-credential-types v1.2.0 [INFO] [stderr] Downloaded aws-smithy-json v0.60.7 [INFO] [stderr] Downloaded aws-smithy-async v1.2.1 [INFO] [stderr] Downloaded aws-types v1.3.3 [INFO] [stderr] Downloaded clap v4.5.11 [INFO] [stderr] Downloaded bytes v1.6.1 [INFO] [stderr] Downloaded aws-sdk-sso v1.36.0 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.37.0 [INFO] [stderr] Downloaded aws-smithy-runtime v1.6.2 [INFO] [stderr] Downloaded aws-config v1.5.4 [INFO] [stderr] Downloaded aws-sdk-sts v1.36.0 [INFO] [stderr] Downloaded clap_builder v4.5.11 [INFO] [stderr] Downloaded aws-sigv4 v1.2.3 [INFO] [stderr] Downloaded aws-runtime v1.3.1 [INFO] [stderr] Downloaded aws-smithy-runtime-api v1.7.1 [INFO] [stderr] Downloaded aws-smithy-types v1.2.0 [INFO] [stderr] Downloaded aws-smithy-http v0.60.9 [INFO] [stderr] Downloaded object v0.36.2 [INFO] [stderr] Downloaded trust-dns-proto v0.23.2 [INFO] [stderr] Downloaded aws-sdk-route53 v1.37.0 [INFO] [stderr] Downloaded tokio v1.39.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cde6bb1a609b870e9b18823a7ff7a94a13323285b9507ada95be5c5b6ec85b6b [INFO] running `Command { std: "docker" "start" "-a" "cde6bb1a609b870e9b18823a7ff7a94a13323285b9507ada95be5c5b6ec85b6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cde6bb1a609b870e9b18823a7ff7a94a13323285b9507ada95be5c5b6ec85b6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cde6bb1a609b870e9b18823a7ff7a94a13323285b9507ada95be5c5b6ec85b6b", kill_on_drop: false }` [INFO] [stdout] cde6bb1a609b870e9b18823a7ff7a94a13323285b9507ada95be5c5b6ec85b6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6d0bdb7b8c35c9b37a0f6fa48e1879450f4cb4e1519d66b0eb24dbec1ae94fc [INFO] running `Command { std: "docker" "start" "-a" "b6d0bdb7b8c35c9b37a0f6fa48e1879450f4cb4e1519d66b0eb24dbec1ae94fc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking outref v0.5.1 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling aws-types v1.3.3 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking resolv-conf v0.7.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking aws-smithy-xml v0.60.8 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling enum-as-inner v0.6.0 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking aws-smithy-async v1.2.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking trust-dns-proto v0.23.2 [INFO] [stderr] Checking aws-smithy-types v1.2.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking aws-smithy-runtime-api v1.7.1 [INFO] [stderr] Checking aws-smithy-json v0.60.7 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-credential-types v1.2.0 [INFO] [stderr] Checking aws-smithy-http v0.60.9 [INFO] [stderr] Checking trust-dns-resolver v0.23.2 [INFO] [stderr] Checking aws-sigv4 v1.2.3 [INFO] [stderr] Checking aws-runtime v1.3.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking aws-smithy-runtime v1.6.2 [INFO] [stderr] Checking aws-sdk-sso v1.36.0 [INFO] [stderr] Checking aws-sdk-sts v1.36.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.37.0 [INFO] [stderr] Checking aws-sdk-route53 v1.37.0 [INFO] [stderr] Checking aws-config v1.5.4 [INFO] [stderr] Checking r53-ddns v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dns.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if !record_ip.is_none() && record_ip == Some(ip_addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `record_ip.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/route53.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | true => return Err(Box::new(Route53UpdateError::NoRecordAvailable)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - true => return Err(Box::new(Route53UpdateError::NoRecordAvailable)), [INFO] [stdout] 28 + true => Err(Box::new(Route53UpdateError::NoRecordAvailable)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/route53.rs:25:40 [INFO] [stdout] | [INFO] [stdout] 25 | get_single_record_set(&client, &dns_zone_id, &domain_name, &record_type).await?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `dns_zone_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/route53.rs:25:54 [INFO] [stdout] | [INFO] [stdout] 25 | get_single_record_set(&client, &dns_zone_id, &domain_name, &record_type).await?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `domain_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/route53.rs:34:20 [INFO] [stdout] | [INFO] [stdout] 34 | return Ok(submit_single_change_request( [INFO] [stdout] | ____________________^ [INFO] [stdout] 35 | | &client, [INFO] [stdout] 36 | | resource_record_set.unwrap(), [INFO] [stdout] 37 | | &public_ip, [INFO] [stdout] ... | [INFO] [stdout] 40 | | .await?); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 34 ~ return submit_single_change_request( [INFO] [stdout] 35 | &client, [INFO] [stdout] ... [INFO] [stdout] 39 | ) [INFO] [stdout] 40 ~ .await; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/route53.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | &dns_zone_id, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `dns_zone_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/route53.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | .ttl(resource_record_set.ttl.clone().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resource_record_set.ttl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/route53.rs:106:23 [INFO] [stdout] | [INFO] [stdout] 106 | let msg: String = format!("ISP provided dynamic IP has drifted."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ISP provided dynamic IP has drifted.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AAAA` contains a capitalized acronym [INFO] [stdout] --> src/route53.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | AAAA, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aaaa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/dns.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if !record_ip.is_none() && record_ip == Some(ip_addr) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `record_ip.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/dns.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | / assert_eq!( [INFO] [stdout] 48 | | super::is_addr_current(domain, ip_addr).await.unwrap(), [INFO] [stdout] 49 | | false [INFO] [stdout] 50 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 47 ~ assert!( [INFO] [stdout] 48 ~ !super::is_addr_current(domain, ip_addr).await.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/route53.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | true => return Err(Box::new(Route53UpdateError::NoRecordAvailable)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - true => return Err(Box::new(Route53UpdateError::NoRecordAvailable)), [INFO] [stdout] 28 + true => Err(Box::new(Route53UpdateError::NoRecordAvailable)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/route53.rs:25:40 [INFO] [stdout] | [INFO] [stdout] 25 | get_single_record_set(&client, &dns_zone_id, &domain_name, &record_type).await?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `dns_zone_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/route53.rs:25:54 [INFO] [stdout] | [INFO] [stdout] 25 | get_single_record_set(&client, &dns_zone_id, &domain_name, &record_type).await?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `domain_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/route53.rs:34:20 [INFO] [stdout] | [INFO] [stdout] 34 | return Ok(submit_single_change_request( [INFO] [stdout] | ____________________^ [INFO] [stdout] 35 | | &client, [INFO] [stdout] 36 | | resource_record_set.unwrap(), [INFO] [stdout] 37 | | &public_ip, [INFO] [stdout] ... | [INFO] [stdout] 40 | | .await?); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 34 ~ return submit_single_change_request( [INFO] [stdout] 35 | &client, [INFO] [stdout] ... [INFO] [stdout] 39 | ) [INFO] [stdout] 40 ~ .await; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/route53.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | &dns_zone_id, [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `dns_zone_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/route53.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | .ttl(resource_record_set.ttl.clone().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `resource_record_set.ttl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/route53.rs:106:23 [INFO] [stdout] | [INFO] [stdout] 106 | let msg: String = format!("ISP provided dynamic IP has drifted."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"ISP provided dynamic IP has drifted.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AAAA` contains a capitalized acronym [INFO] [stdout] --> src/route53.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | AAAA, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Aaaa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.18s [INFO] running `Command { std: "docker" "inspect" "b6d0bdb7b8c35c9b37a0f6fa48e1879450f4cb4e1519d66b0eb24dbec1ae94fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6d0bdb7b8c35c9b37a0f6fa48e1879450f4cb4e1519d66b0eb24dbec1ae94fc", kill_on_drop: false }` [INFO] [stdout] b6d0bdb7b8c35c9b37a0f6fa48e1879450f4cb4e1519d66b0eb24dbec1ae94fc