[INFO] cloning repository https://github.com/rot1024/nicodo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rot1024/nicodo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frot1024%2Fnicodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frot1024%2Fnicodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 62f806e79eb5ab1678138d737b1fd767a9be6db3 [INFO] linting rot1024/nicodo against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frot1024%2Fnicodo" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-5-tc1/source/rust-toolchain [INFO] started tweaking git repo https://github.com/rot1024/nicodo [INFO] finished tweaking git repo https://github.com/rot1024/nicodo [INFO] tweaked toml for git repo https://github.com/rot1024/nicodo written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rot1024/nicodo on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rot1024/nicodo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded string_cache v0.8.1 [INFO] [stderr] Downloaded siphasher v0.3.7 [INFO] [stderr] Downloaded markup5ever v0.10.1 [INFO] [stderr] Downloaded dtoa-short v0.3.3 [INFO] [stderr] Downloaded tokio-macros v1.4.1 [INFO] [stderr] Downloaded ego-tree v0.6.2 [INFO] [stderr] Downloaded confy v0.4.0 [INFO] [stderr] Downloaded cssparser-macros v0.6.0 [INFO] [stderr] Downloaded httpdate v1.0.1 [INFO] [stderr] Downloaded tendril v0.4.2 [INFO] [stderr] Downloaded scraper v0.12.0 [INFO] [stderr] Downloaded http-body v0.4.3 [INFO] [stderr] Downloaded clap_derive v3.0.2 [INFO] [stderr] Downloaded dialoguer v0.9.0 [INFO] [stderr] Downloaded tokio-util v0.6.8 [INFO] [stderr] Downloaded bumpalo v3.7.1 [INFO] [stderr] Downloaded http v0.2.5 [INFO] [stderr] Downloaded h2 v0.3.6 [INFO] [stderr] Downloaded hyper v0.14.13 [INFO] [stderr] Downloaded clap v3.0.4 [INFO] [stderr] Downloaded tokio v1.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c622b9cb36e27942e64856276882957a521d91be5d6986782c815177f628bd79 [INFO] running `Command { std: "docker" "start" "-a" "c622b9cb36e27942e64856276882957a521d91be5d6986782c815177f628bd79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c622b9cb36e27942e64856276882957a521d91be5d6986782c815177f628bd79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c622b9cb36e27942e64856276882957a521d91be5d6986782c815177f628bd79", kill_on_drop: false }` [INFO] [stdout] c622b9cb36e27942e64856276882957a521d91be5d6986782c815177f628bd79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a92029403ccd0fe530307caaca1e9226fedeefbe62025ec2485846061daa606 [INFO] running `Command { std: "docker" "start" "-a" "4a92029403ccd0fe530307caaca1e9226fedeefbe62025ec2485846061daa606", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling siphasher v0.3.7 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling cc v1.0.71 [INFO] [stderr] Compiling pkg-config v0.3.20 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling tokio v1.12.0 [INFO] [stderr] Compiling futures-task v0.3.17 [INFO] [stderr] Compiling futures-util v0.3.17 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Compiling openssl v0.10.36 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Checking futures-sink v0.3.17 [INFO] [stderr] Compiling futures-channel v0.3.17 [INFO] [stderr] Checking futf v0.1.4 [INFO] [stderr] Checking tinyvec v1.5.0 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking dtoa-short v0.3.3 [INFO] [stderr] Checking tendril v0.4.2 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking httpdate v1.0.1 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking thin-slice v0.1.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking zeroize v1.4.2 [INFO] [stderr] Checking ego-tree v0.6.2 [INFO] [stderr] Checking quick-xml v0.22.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Compiling openssl-sys v0.9.67 [INFO] [stderr] Checking console v0.14.1 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking http-body v0.4.3 [INFO] [stderr] Checking dialoguer v0.9.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.1 [INFO] [stderr] Compiling selectors v0.22.0 [INFO] [stderr] Compiling markup5ever v0.10.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling tokio-macros v1.4.1 [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling cssparser v0.27.2 [INFO] [stderr] Compiling cssparser-macros v0.6.0 [INFO] [stderr] Compiling html5ever v0.25.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.0.2 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking clap v3.0.4 [INFO] [stderr] Checking tokio-util v0.6.8 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.6 [INFO] [stderr] Checking string_cache v0.8.1 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking serde_json v1.0.74 [INFO] [stderr] Checking hyper v0.14.13 [INFO] [stderr] Checking confy v0.4.0 [INFO] [stderr] Checking scraper v0.12.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.8 [INFO] [stderr] Checking nicodo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/nicodo/comment.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | const API_ENDPOINT: &'static str = "https://nvcomment.nicovideo.jp/legacy/api.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/nicodo/info.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | const FORMAT: &'static str = "%Y-%m-%dT%H:%M:%S+09:00"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/nicodo/comment.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | const API_ENDPOINT: &'static str = "https://nvcomment.nicovideo.jp/legacy/api.json"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/nicodo/info.rs:112:20 [INFO] [stdout] | [INFO] [stdout] 112 | const FORMAT: &'static str = "%Y-%m-%dT%H:%M:%S+09:00"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/nicodo/comment.rs:135:36 [INFO] [stdout] | [INFO] [stdout] 135 | let mut comments: Vec<_> = comments.into_iter().map(|(_, c)| c).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `comments.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/nicodo/comment.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | comments.sort_by(|a, b| a.vpos.cmp(&b.vpos)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 136 - comments.sort_by(|a, b| a.vpos.cmp(&b.vpos)); [INFO] [stdout] 136 + comments.sort_by_key(|a| a.vpos); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/nicodo/comment_body.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | let content = serde_json::to_string(&body).unwrap(); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 189 | [INFO] [stdout] 190 | content [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 188 ~ [INFO] [stdout] 189 | [INFO] [stdout] 190 ~ serde_json::to_string(&body).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/nicodo/comment_body.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | + (if opts.info.video.duration % 60 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!opts.info.video.duration.is_multiple_of(60)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/nicodo/comment_body.rs:128:20 [INFO] [stdout] | [INFO] [stdout] 128 | if let Some(_) = opts.wayback { [INFO] [stdout] | -------^^^^^^^--------------- help: try: `if opts.wayback.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/nicodo/comment_body.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | waybackkey: if let Some(w) = opts.wayback.as_ref() { [INFO] [stdout] | _____________________^ [INFO] [stdout] 135 | | Some(w.waybackkey.to_string()) [INFO] [stdout] 136 | | } else { [INFO] [stdout] 137 | | None [INFO] [stdout] 138 | | }, [INFO] [stdout] | |_________^ help: try: `opts.wayback.as_ref().map(|w| w.waybackkey.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/nicodo/comment_body.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 139 | when: if let Some(w) = opts.wayback.as_ref() { [INFO] [stdout] | _______________^ [INFO] [stdout] 140 | | Some(w.wayback.timestamp()) [INFO] [stdout] 141 | | } else { [INFO] [stdout] 142 | | None [INFO] [stdout] 143 | | }, [INFO] [stdout] | |_________^ help: try: `opts.wayback.as_ref().map(|w| w.wayback.timestamp())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nicodo/comment_body.rs:151:41 [INFO] [stdout] | [INFO] [stdout] 151 | .filter(|t| t.is_active && (!opts.wayback.is_some() || t.is_thread_key_required)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opts.wayback.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/nicodo/comment_wayback.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Self::Latest = self { [INFO] [stdout] 29 | | false [INFO] [stdout] 30 | | } else { [INFO] [stdout] 31 | | true [INFO] [stdout] 32 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 28 - if let Self::Latest = self { [INFO] [stdout] 29 - false [INFO] [stdout] 30 - } else { [INFO] [stdout] 31 - true [INFO] [stdout] 32 - } [INFO] [stdout] 28 + !matches!(self, Self::Latest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/nicodo/info.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn thread_id<'a>(&'a self) -> Option { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 31 - pub fn thread_id<'a>(&'a self) -> Option { [INFO] [stdout] 31 + pub fn thread_id(&self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/nicodo/info.rs:98:64 [INFO] [stdout] | [INFO] [stdout] 98 | let info = serde_json::from_str::(&data).map_err(|err| Error::InvalidInfo(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Error::InvalidInfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/nicodo/info.rs:98:49 [INFO] [stdout] | [INFO] [stdout] 98 | let info = serde_json::from_str::(&data).map_err(|err| Error::InvalidInfo(err))?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/nicodo/xml.rs:15:49 [INFO] [stdout] | [INFO] [stdout] 15 | let mut w = Writer::new_with_indent(writer, ' ' as u8, 0); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b' '` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/nicodo/comment.rs:135:36 [INFO] [stdout] | [INFO] [stdout] 135 | let mut comments: Vec<_> = comments.into_iter().map(|(_, c)| c).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `comments.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/nicodo/comment.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | comments.sort_by(|a, b| a.vpos.cmp(&b.vpos)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 136 - comments.sort_by(|a, b| a.vpos.cmp(&b.vpos)); [INFO] [stdout] 136 + comments.sort_by_key(|a| a.vpos); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/nicodo/comment_body.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | let content = serde_json::to_string(&body).unwrap(); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 189 | [INFO] [stdout] 190 | content [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 188 ~ [INFO] [stdout] 189 | [INFO] [stdout] 190 ~ serde_json::to_string(&body).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/nicodo/comment_body.rs:76:19 [INFO] [stdout] | [INFO] [stdout] 76 | + (if opts.info.video.duration % 60 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!opts.info.video.duration.is_multiple_of(60)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/nicodo/comment_body.rs:128:20 [INFO] [stdout] | [INFO] [stdout] 128 | if let Some(_) = opts.wayback { [INFO] [stdout] | -------^^^^^^^--------------- help: try: `if opts.wayback.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/nicodo/comment_body.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | waybackkey: if let Some(w) = opts.wayback.as_ref() { [INFO] [stdout] | _____________________^ [INFO] [stdout] 135 | | Some(w.waybackkey.to_string()) [INFO] [stdout] 136 | | } else { [INFO] [stdout] 137 | | None [INFO] [stdout] 138 | | }, [INFO] [stdout] | |_________^ help: try: `opts.wayback.as_ref().map(|w| w.waybackkey.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/nicodo/comment_body.rs:139:15 [INFO] [stdout] | [INFO] [stdout] 139 | when: if let Some(w) = opts.wayback.as_ref() { [INFO] [stdout] | _______________^ [INFO] [stdout] 140 | | Some(w.wayback.timestamp()) [INFO] [stdout] 141 | | } else { [INFO] [stdout] 142 | | None [INFO] [stdout] 143 | | }, [INFO] [stdout] | |_________^ help: try: `opts.wayback.as_ref().map(|w| w.wayback.timestamp())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nicodo/comment_body.rs:151:41 [INFO] [stdout] | [INFO] [stdout] 151 | .filter(|t| t.is_active && (!opts.wayback.is_some() || t.is_thread_key_required)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `opts.wayback.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/nicodo/comment_wayback.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / if let Self::Latest = self { [INFO] [stdout] 29 | | false [INFO] [stdout] 30 | | } else { [INFO] [stdout] 31 | | true [INFO] [stdout] 32 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 28 - if let Self::Latest = self { [INFO] [stdout] 29 - false [INFO] [stdout] 30 - } else { [INFO] [stdout] 31 - true [INFO] [stdout] 32 - } [INFO] [stdout] 28 + !matches!(self, Self::Latest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/nicodo/info.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn thread_id<'a>(&'a self) -> Option { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 31 - pub fn thread_id<'a>(&'a self) -> Option { [INFO] [stdout] 31 + pub fn thread_id(&self) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/nicodo/info.rs:98:64 [INFO] [stdout] | [INFO] [stdout] 98 | let info = serde_json::from_str::(&data).map_err(|err| Error::InvalidInfo(err))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Error::InvalidInfo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/nicodo/info.rs:98:49 [INFO] [stdout] | [INFO] [stdout] 98 | let info = serde_json::from_str::(&data).map_err(|err| Error::InvalidInfo(err))?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/nicodo/xml.rs:15:49 [INFO] [stdout] | [INFO] [stdout] 15 | let mut w = Writer::new_with_indent(writer, ' ' as u8, 0); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b' '` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | confy::store(APP_NAME, &self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/datetime.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | DateTime(NaiveDateTime), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/config.rs:16:32 [INFO] [stdout] | [INFO] [stdout] 16 | confy::store(APP_NAME, &self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/datetime.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | DateTime(NaiveDateTime), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Error(Box), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | Error(Box), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/id.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Ok(Self::Video( [INFO] [stdout] 29 | | s.replace("https://www.nicovideo.jp/watch/", ""), [INFO] [stdout] 30 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Ok(Self::Video( [INFO] [stdout] 29 + s.replace("https://www.nicovideo.jp/watch/", ""), [INFO] [stdout] 30 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/id.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return Ok(Self::Video( [INFO] [stdout] 29 | | s.replace("https://www.nicovideo.jp/watch/", ""), [INFO] [stdout] 30 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ Ok(Self::Video( [INFO] [stdout] 29 + s.replace("https://www.nicovideo.jp/watch/", ""), [INFO] [stdout] 30 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XML` contains a capitalized acronym [INFO] [stdout] --> src/process.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | XML, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/process.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XML` contains a capitalized acronym [INFO] [stdout] --> src/process.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | XML, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xml` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `JSON` contains a capitalized acronym [INFO] [stdout] --> src/process.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | JSON, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Json` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.64s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: html5ever v0.25.1, quick-xml v0.22.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "4a92029403ccd0fe530307caaca1e9226fedeefbe62025ec2485846061daa606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a92029403ccd0fe530307caaca1e9226fedeefbe62025ec2485846061daa606", kill_on_drop: false }` [INFO] [stdout] 4a92029403ccd0fe530307caaca1e9226fedeefbe62025ec2485846061daa606