[INFO] cloning repository https://github.com/rossjjennings/rustcalc
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rossjjennings/rustcalc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frossjjennings%2Frustcalc", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frossjjennings%2Frustcalc'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b66ed995c621a2df15eeeea3d8180cfdcc5f60cc
[INFO] linting rossjjennings/rustcalc against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frossjjennings%2Frustcalc" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/rossjjennings/rustcalc
[INFO] finished tweaking git repo https://github.com/rossjjennings/rustcalc
[INFO] tweaked toml for git repo https://github.com/rossjjennings/rustcalc written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/rossjjennings/rustcalc on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/rossjjennings/rustcalc already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 85e075940509c763c1c367907a62b0a5787742b7767e9143e8ae30ef8dde992d
[INFO] running `Command { std: "docker" "start" "-a" "85e075940509c763c1c367907a62b0a5787742b7767e9143e8ae30ef8dde992d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "85e075940509c763c1c367907a62b0a5787742b7767e9143e8ae30ef8dde992d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "85e075940509c763c1c367907a62b0a5787742b7767e9143e8ae30ef8dde992d", kill_on_drop: false }`
[INFO] [stdout] 85e075940509c763c1c367907a62b0a5787742b7767e9143e8ae30ef8dde992d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] e51899a1c4b89a9576b9b6399a661ef7d131e43383d37c00fecd73d827327ab5
[INFO] running `Command { std: "docker" "start" "-a" "e51899a1c4b89a9576b9b6399a661ef7d131e43383d37c00fecd73d827327ab5", kill_on_drop: false }`
[INFO] [stderr]    Compiling ryu v1.0.2
[INFO] [stderr]     Checking rustcalc v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/lib.rs:96:17
[INFO] [stdout]    |
[INFO] [stdout] 96 |     let front = queue.front().map(|&chr| chr);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `queue.front().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:103:37
[INFO] [stdout]     |
[INFO] [stdout] 103 |     while let Some(b) = next_binary(&queue) {
[INFO] [stdout]     |                                     ^^^^^^ help: change this to: `queue`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:127:5
[INFO] [stdout]     |
[INFO] [stdout] 127 |     if let Some(op) = b { Some(Rc::new(op)) } else { None }
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b.map(Rc::new)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:131:33
[INFO] [stdout]     |
[INFO] [stdout] 131 |     if let Some(u) = next_unary(&queue) {
[INFO] [stdout]     |                                 ^^^^^^ help: change this to: `queue`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]    --> src/lib.rs:135:15
[INFO] [stdout]     |
[INFO] [stdout] 135 |     } else if queue.front().map(|&chr| chr) == Some('(') {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `queue.front().copied()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:138:16
[INFO] [stdout]     |
[INFO] [stdout] 138 |         expect(&queue, Some(')'))?;
[INFO] [stdout]     |                ^^^^^^ help: change this to: `queue`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression assigns a bool literal
[INFO] [stdout]    --> src/lib.rs:175:9
[INFO] [stdout]     |
[INFO] [stdout] 175 | /         if chr == &'e' || chr == &'E' {
[INFO] [stdout] 176 | |             last_was_e = true
[INFO] [stdout] 177 | |         } else {
[INFO] [stdout] 178 | |             last_was_e = false
[INFO] [stdout] 179 | |         }
[INFO] [stdout]     | |_________^ help: you can reduce it to: `last_was_e = chr == &'e' || chr == &'E';`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool_assign)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:184:8
[INFO] [stdout]     |
[INFO] [stdout] 184 |     if literal.len() == 0 { return Ok(None); }
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:226:17
[INFO] [stdout]     |
[INFO] [stdout] 226 |         assert!(!result.is_err());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]   --> src/lib.rs:96:17
[INFO] [stdout]    |
[INFO] [stdout] 96 |     let front = queue.front().map(|&chr| chr);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `queue.front().copied()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]    = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:103:37
[INFO] [stdout]     |
[INFO] [stdout] 103 |     while let Some(b) = next_binary(&queue) {
[INFO] [stdout]     |                                     ^^^^^^ help: change this to: `queue`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:127:5
[INFO] [stdout]     |
[INFO] [stdout] 127 |     if let Some(op) = b { Some(Rc::new(op)) } else { None }
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b.map(Rc::new)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:131:33
[INFO] [stdout]     |
[INFO] [stdout] 131 |     if let Some(u) = next_unary(&queue) {
[INFO] [stdout]     |                                 ^^^^^^ help: change this to: `queue`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for copying elements
[INFO] [stdout]    --> src/lib.rs:135:15
[INFO] [stdout]     |
[INFO] [stdout] 135 |     } else if queue.front().map(|&chr| chr) == Some('(') {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `queue.front().copied()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:138:16
[INFO] [stdout]     |
[INFO] [stdout] 138 |         expect(&queue, Some(')'))?;
[INFO] [stdout]     |                ^^^^^^ help: change this to: `queue`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this if-then-else expression assigns a bool literal
[INFO] [stdout]    --> src/lib.rs:175:9
[INFO] [stdout]     |
[INFO] [stdout] 175 | /         if chr == &'e' || chr == &'E' {
[INFO] [stdout] 176 | |             last_was_e = true
[INFO] [stdout] 177 | |         } else {
[INFO] [stdout] 178 | |             last_was_e = false
[INFO] [stdout] 179 | |         }
[INFO] [stdout]     | |_________^ help: you can reduce it to: `last_was_e = chr == &'e' || chr == &'E';`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
[INFO] [stdout]     = note: `#[warn(clippy::needless_bool_assign)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:184:8
[INFO] [stdout]     |
[INFO] [stdout] 184 |     if literal.len() == 0 { return Ok(None); }
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `literal.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]  --> src/main.rs:7:8
[INFO] [stdout]   |
[INFO] [stdout] 7 |     if arg == None {
[INFO] [stdout]   |        ^^^^^^^^^^^ help: use `Option::is_none()` instead: `arg.is_none()`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]   = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]  --> src/main.rs:7:8
[INFO] [stdout]   |
[INFO] [stdout] 7 |     if arg == None {
[INFO] [stdout]   |        ^^^^^^^^^^^ help: use `Option::is_none()` instead: `arg.is_none()`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]   = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.92s
[INFO] running `Command { std: "docker" "inspect" "e51899a1c4b89a9576b9b6399a661ef7d131e43383d37c00fecd73d827327ab5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "e51899a1c4b89a9576b9b6399a661ef7d131e43383d37c00fecd73d827327ab5", kill_on_drop: false }`
[INFO] [stdout] e51899a1c4b89a9576b9b6399a661ef7d131e43383d37c00fecd73d827327ab5