[INFO] cloning repository https://github.com/roninlp/rust-projector [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/roninlp/rust-projector" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froninlp%2Frust-projector", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froninlp%2Frust-projector'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9916c7b97fe82c6b941239eb4923686956ebfce0 [INFO] linting roninlp/rust-projector against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froninlp%2Frust-projector" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/roninlp/rust-projector [INFO] finished tweaking git repo https://github.com/roninlp/rust-projector [INFO] tweaked toml for git repo https://github.com/roninlp/rust-projector written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/roninlp/rust-projector on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/roninlp/rust-projector already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.11 [INFO] [stderr] Downloaded clap_derive v4.5.11 [INFO] [stderr] Downloaded collection_macros v0.2.0 [INFO] [stderr] Downloaded serde_json v1.0.121 [INFO] [stderr] Downloaded clap_builder v4.5.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d1f3c06c794eeba9074257febd61a9a6326b4de6372b9bc82172231f71a5220b [INFO] running `Command { std: "docker" "start" "-a" "d1f3c06c794eeba9074257febd61a9a6326b4de6372b9bc82172231f71a5220b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d1f3c06c794eeba9074257febd61a9a6326b4de6372b9bc82172231f71a5220b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1f3c06c794eeba9074257febd61a9a6326b4de6372b9bc82172231f71a5220b", kill_on_drop: false }` [INFO] [stdout] d1f3c06c794eeba9074257febd61a9a6326b4de6372b9bc82172231f71a5220b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 610aab93c2e8ffe0958edbe7f786e594ace4f1de0ed07b9c73c895d83701d2b2 [INFO] running `Command { std: "docker" "start" "-a" "610aab93c2e8ffe0958edbe7f786e594ace4f1de0ed07b9c73c895d83701d2b2", kill_on_drop: false }` [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking collection_macros v0.2.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking projector v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / return Ok(Config { [INFO] [stdout] 23 | | operation, [INFO] [stdout] 24 | | config, [INFO] [stdout] 25 | | pwd, [INFO] [stdout] 26 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Ok(Config { [INFO] [stdout] 23 + operation, [INFO] [stdout] 24 + config, [INFO] [stdout] 25 + pwd, [INFO] [stdout] 26 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return Ok(Operation::Print(Some(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Ok(Operation::Print(Some(arg))); [INFO] [stdout] 74 + Ok(Operation::Print(Some(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | let term = value.get(0).expect("expected to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Ok(loc); [INFO] [stdout] 89 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] 97 + Ok(std::env::current_dir().context("errored getting current directory")?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 97 - return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] 97 + return std::env::current_dir().context("errored getting current directory"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return out; [INFO] [stdout] 41 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | / return Ok(Config { [INFO] [stdout] 23 | | operation, [INFO] [stdout] 24 | | config, [INFO] [stdout] 25 | | pwd, [INFO] [stdout] 26 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 ~ Ok(Config { [INFO] [stdout] 23 + operation, [INFO] [stdout] 24 + config, [INFO] [stdout] 25 + pwd, [INFO] [stdout] 26 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return out; [INFO] [stdout] 58 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/projector.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 | | x.remove(key); [INFO] [stdout] 72 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 70 - self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 - x.remove(key); [INFO] [stdout] 72 - }); [INFO] [stdout] 70 + if let Some(x) = self.data.projector.get_mut(&self.pwd) { x.remove(key); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Ok(()); [INFO] [stdout] 85 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return Ok(Operation::Print(Some(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Ok(Operation::Print(Some(arg))); [INFO] [stdout] 74 + Ok(Operation::Print(Some(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/config.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 42 | if value.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / return Projector { [INFO] [stdout] 98 | | config, [INFO] [stdout] 99 | | pwd, [INFO] [stdout] 100 | | data: default_data(), [INFO] [stdout] 101 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ Projector { [INFO] [stdout] 98 + config, [INFO] [stdout] 99 + pwd, [INFO] [stdout] 100 + data: default_data(), [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `value.get(0)` [INFO] [stdout] --> src/config.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | let term = value.get(0).expect("expected to exist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `value.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | return Ok(loc); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Ok(loc); [INFO] [stdout] 89 + Ok(loc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] 97 + Ok(std::env::current_dir().context("errored getting current directory")?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/config.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 97 | return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 97 - return Ok(std::env::current_dir().context("errored getting current directory")?); [INFO] [stdout] 97 + return std::env::current_dir().context("errored getting current directory"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return out; [INFO] [stdout] 41 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return out; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return out; [INFO] [stdout] 58 + out [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/projector.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 | | x.remove(key); [INFO] [stdout] 72 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 70 - self.data.projector.get_mut(&self.pwd).map(|x| { [INFO] [stdout] 71 - x.remove(key); [INFO] [stdout] 72 - }); [INFO] [stdout] 70 + if let Some(x) = self.data.projector.get_mut(&self.pwd) { x.remove(key); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/projector.rs:77:16 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&p).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Ok(()); [INFO] [stdout] 85 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/projector.rs:77:35 [INFO] [stdout] | [INFO] [stdout] 77 | if !std::fs::metadata(&p).is_ok() { [INFO] [stdout] | ^^ help: change this to: `p` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / return Projector { [INFO] [stdout] 98 | | config, [INFO] [stdout] 99 | | pwd, [INFO] [stdout] 100 | | data: default_data(), [INFO] [stdout] 101 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ Projector { [INFO] [stdout] 98 + config, [INFO] [stdout] 99 + pwd, [INFO] [stdout] 100 + data: default_data(), [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | / return hashmap! { [INFO] [stdout] 115 | | PathBuf::from("/") => hashmap! { [INFO] [stdout] 116 | | "foo".into() => "bar1".into(), [INFO] [stdout] 117 | | "fem".into() => "is_great".into(), [INFO] [stdout] ... | [INFO] [stdout] 124 | | }, [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 ~ hashmap! { [INFO] [stdout] 115 + PathBuf::from("/") => hashmap! { [INFO] [stdout] 116 + "foo".into() => "bar1".into(), [INFO] [stdout] 117 + "fem".into() => "is_great".into(), [INFO] [stdout] 118 + }, [INFO] [stdout] 119 + PathBuf::from("/foo") => hashmap! { [INFO] [stdout] 120 + "foo".into() => "bar2".into(), [INFO] [stdout] 121 + }, [INFO] [stdout] 122 + PathBuf::from("/foo/bar") => hashmap! { [INFO] [stdout] 123 + "foo".into() => "bar3".into(), [INFO] [stdout] 124 + }, [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/projector.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | / return Projector { [INFO] [stdout] 130 | | config: PathBuf::from(""), [INFO] [stdout] 131 | | pwd, [INFO] [stdout] 132 | | data: Data { [INFO] [stdout] 133 | | projector: get_data(), [INFO] [stdout] 134 | | }, [INFO] [stdout] 135 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 129 ~ Projector { [INFO] [stdout] 130 + config: PathBuf::from(""), [INFO] [stdout] 131 + pwd, [INFO] [stdout] 132 + data: Data { [INFO] [stdout] 133 + projector: get_data(), [INFO] [stdout] 134 + }, [INFO] [stdout] 135 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/projector.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(()); [INFO] [stdout] 33 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 21 - proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] 21 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.71s [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/projector.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(()); [INFO] [stdout] 33 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/bin/projector.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 21 - proj.get_value(&k).map(|x| println!("{}", x)); [INFO] [stdout] 21 + if let Some(x) = proj.get_value(&k) { println!("{}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "610aab93c2e8ffe0958edbe7f786e594ace4f1de0ed07b9c73c895d83701d2b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "610aab93c2e8ffe0958edbe7f786e594ace4f1de0ed07b9c73c895d83701d2b2", kill_on_drop: false }` [INFO] [stdout] 610aab93c2e8ffe0958edbe7f786e594ace4f1de0ed07b9c73c895d83701d2b2