[INFO] cloning repository https://github.com/romanpopp/uml-generator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/romanpopp/uml-generator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fromanpopp%2Fuml-generator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fromanpopp%2Fuml-generator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5467eb64fe003a769e56c5f593477a952c9e4211 [INFO] linting romanpopp/uml-generator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fromanpopp%2Fuml-generator" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/romanpopp/uml-generator [INFO] finished tweaking git repo https://github.com/romanpopp/uml-generator [INFO] tweaked toml for git repo https://github.com/romanpopp/uml-generator written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/romanpopp/uml-generator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/romanpopp/uml-generator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0573f9eba8baf9bd4a3cc4b75d13841f52626ac18aade0b3edd59e77edd5c7fe [INFO] running `Command { std: "docker" "start" "-a" "0573f9eba8baf9bd4a3cc4b75d13841f52626ac18aade0b3edd59e77edd5c7fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0573f9eba8baf9bd4a3cc4b75d13841f52626ac18aade0b3edd59e77edd5c7fe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0573f9eba8baf9bd4a3cc4b75d13841f52626ac18aade0b3edd59e77edd5c7fe", kill_on_drop: false }` [INFO] [stdout] 0573f9eba8baf9bd4a3cc4b75d13841f52626ac18aade0b3edd59e77edd5c7fe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44e3cad4201e8febd165f86ee9e8696d9c503f5bba967498f83ecdd57861d51a [INFO] running `Command { std: "docker" "start" "-a" "44e3cad4201e8febd165f86ee9e8696d9c503f5bba967498f83ecdd57861d51a", kill_on_drop: false }` [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking uml-generator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | && !(arrow.start == arrow.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(arrow.start != arrow.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/main.rs:119:26 [INFO] [stdout] | [INFO] [stdout] 119 | .map(|line| line.replace('<', "~").replace('>', "~")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['<', '>'], "~")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:141:22 [INFO] [stdout] | [INFO] [stdout] 141 | let re = Regex::new(r"~[^~]*~").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | / for line in contents [INFO] [stdout] 117 | | .lines() [INFO] [stdout] 118 | | .map(str::trim) [INFO] [stdout] 119 | | .map(|line| line.replace('<', "~").replace('>', "~")) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | if param.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `param.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:186:32 [INFO] [stdout] | [INFO] [stdout] 186 | return format!(""); [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if values.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 280 | / match data_context { [INFO] [stdout] 281 | | Some(value) => { [INFO] [stdout] 282 | | let arrow = Arrow { [INFO] [stdout] 283 | | start: class_name.clone(), [INFO] [stdout] ... | [INFO] [stdout] 289 | | None => (), [INFO] [stdout] 290 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 280 ~ if let Some(value) = data_context { [INFO] [stdout] 281 + let arrow = Arrow { [INFO] [stdout] 282 + start: class_name.clone(), [INFO] [stdout] 283 + end: value.to_owned(), [INFO] [stdout] 284 + arrow_type: ArrowType::Realization, [INFO] [stdout] 285 + }; [INFO] [stdout] 286 + arrow_list.push(arrow); [INFO] [stdout] 287 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | / match (chars.next(), chars.next()) { [INFO] [stdout] 297 | | (Some('I'), Some(c)) if c.is_uppercase() => true, [INFO] [stdout] 298 | | _ => false, [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 296 - match (chars.next(), chars.next()) { [INFO] [stdout] 297 - (Some('I'), Some(c)) if c.is_uppercase() => true, [INFO] [stdout] 298 - _ => false, [INFO] [stdout] 299 - } [INFO] [stdout] 296 + matches!((chars.next(), chars.next()), (Some('I'), Some(c)) if c.is_uppercase()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 78 | && !(arrow.start == arrow.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(arrow.start != arrow.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/main.rs:119:26 [INFO] [stdout] | [INFO] [stdout] 119 | .map(|line| line.replace('<', "~").replace('>', "~")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['<', '>'], "~")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: compiling a regex in a loop [INFO] [stdout] --> src/main.rs:141:22 [INFO] [stdout] | [INFO] [stdout] 141 | let re = Regex::new(r"~[^~]*~").unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: move the regex construction outside this loop [INFO] [stdout] --> src/main.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 116 | / for line in contents [INFO] [stdout] 117 | | .lines() [INFO] [stdout] 118 | | .map(str::trim) [INFO] [stdout] 119 | | .map(|line| line.replace('<', "~").replace('>', "~")) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#regex_creation_in_loops [INFO] [stdout] = note: `#[warn(clippy::regex_creation_in_loops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:185:24 [INFO] [stdout] | [INFO] [stdout] 185 | if param.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `param.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:186:32 [INFO] [stdout] | [INFO] [stdout] 186 | return format!(""); [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if values.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!values.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 280 | / match data_context { [INFO] [stdout] 281 | | Some(value) => { [INFO] [stdout] 282 | | let arrow = Arrow { [INFO] [stdout] 283 | | start: class_name.clone(), [INFO] [stdout] ... | [INFO] [stdout] 289 | | None => (), [INFO] [stdout] 290 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 280 ~ if let Some(value) = data_context { [INFO] [stdout] 281 + let arrow = Arrow { [INFO] [stdout] 282 + start: class_name.clone(), [INFO] [stdout] 283 + end: value.to_owned(), [INFO] [stdout] 284 + arrow_type: ArrowType::Realization, [INFO] [stdout] 285 + }; [INFO] [stdout] 286 + arrow_list.push(arrow); [INFO] [stdout] 287 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | / match (chars.next(), chars.next()) { [INFO] [stdout] 297 | | (Some('I'), Some(c)) if c.is_uppercase() => true, [INFO] [stdout] 298 | | _ => false, [INFO] [stdout] 299 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 296 - match (chars.next(), chars.next()) { [INFO] [stdout] 297 - (Some('I'), Some(c)) if c.is_uppercase() => true, [INFO] [stdout] 298 - _ => false, [INFO] [stdout] 299 - } [INFO] [stdout] 296 + matches!((chars.next(), chars.next()), (Some('I'), Some(c)) if c.is_uppercase()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `Command { std: "docker" "inspect" "44e3cad4201e8febd165f86ee9e8696d9c503f5bba967498f83ecdd57861d51a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44e3cad4201e8febd165f86ee9e8696d9c503f5bba967498f83ecdd57861d51a", kill_on_drop: false }` [INFO] [stdout] 44e3cad4201e8febd165f86ee9e8696d9c503f5bba967498f83ecdd57861d51a