[INFO] cloning repository https://github.com/rolftimmermans/slope [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rolftimmermans/slope" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frolftimmermans%2Fslope", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frolftimmermans%2Fslope'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b357650671869758f43d35f04eb47c80174662f8 [INFO] linting rolftimmermans/slope against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frolftimmermans%2Fslope" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rolftimmermans/slope [INFO] finished tweaking git repo https://github.com/rolftimmermans/slope [INFO] tweaked toml for git repo https://github.com/rolftimmermans/slope written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rolftimmermans/slope on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rolftimmermans/slope already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded smol_str v0.1.16 [INFO] [stderr] Downloaded mimalloc v0.1.20 [INFO] [stderr] Downloaded rustyline-derive v0.3.1 [INFO] [stderr] Downloaded nom_locate v2.0.0 [INFO] [stderr] Downloaded sized-chunks v0.6.2 [INFO] [stderr] Downloaded ahash v0.4.4 [INFO] [stderr] Downloaded lasso v0.3.1 [INFO] [stderr] Downloaded simple_logger v1.6.0 [INFO] [stderr] Downloaded bytecount v0.6.0 [INFO] [stderr] Downloaded im-rc v15.0.0 [INFO] [stderr] Downloaded rand_xoshiro v0.4.0 [INFO] [stderr] Downloaded libmimalloc-sys v0.1.16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0441ff00d0ceba2e90b8eb5924aab3ce35d5726aedd192d364eae2ae1898c26 [INFO] running `Command { std: "docker" "start" "-a" "e0441ff00d0ceba2e90b8eb5924aab3ce35d5726aedd192d364eae2ae1898c26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0441ff00d0ceba2e90b8eb5924aab3ce35d5726aedd192d364eae2ae1898c26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0441ff00d0ceba2e90b8eb5924aab3ce35d5726aedd192d364eae2ae1898c26", kill_on_drop: false }` [INFO] [stdout] e0441ff00d0ceba2e90b8eb5924aab3ce35d5726aedd192d364eae2ae1898c26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 949d7a4d43ed3f78bbd2c23cb6a5140a46025d8cee8d95a62533071c45aa2ef7 [INFO] running `Command { std: "docker" "start" "-a" "949d7a4d43ed3f78bbd2c23cb6a5140a46025d8cee8d95a62533071c45aa2ef7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling im-rc v15.0.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.9 [INFO] [stderr] Compiling siphasher v0.3.3 [INFO] [stderr] Compiling hashbrown v0.8.2 [INFO] [stderr] Compiling indexmap v1.5.1 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling regex-syntax v0.6.18 [INFO] [stderr] Compiling cc v1.0.59 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking bytecount v0.6.0 [INFO] [stderr] Compiling aho-corasick v0.7.13 [INFO] [stderr] Checking smol_str v0.1.16 [INFO] [stderr] Compiling cmake v0.1.44 [INFO] [stderr] Checking typenum v1.12.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking sized-chunks v0.6.2 [INFO] [stderr] Checking unicode-xid v0.2.1 [INFO] [stderr] Compiling libmimalloc-sys v0.1.16 [INFO] [stderr] Checking bitflags v1.2.1 [INFO] [stderr] Checking simple_logger v1.6.0 [INFO] [stderr] Checking unicode_categories v0.1.1 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking nom_locate v2.0.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking slope-parse v0.1.0 (/opt/rustwide/workdir/slope-parse) [INFO] [stderr] Checking rand_xoshiro v0.4.0 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stdout] warning: enum `FileName` is never used [INFO] [stdout] --> slope-parse/src/source.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum FileName { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SourceFile` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct SourceFile { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CharPos` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CharPos(u32); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PosInfo` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct PosInfo { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `lookup_pos_info`, and `lookup_line` are never used [INFO] [stdout] --> slope-parse/src/source.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl SourceFile { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 37 | pub fn new(name: FileName, offset: BytePos, source: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn lookup_pos_info(&self, offset: BytePos) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn lookup_line(&self, offset: BytePos) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Atom` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> slope-parse/src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-parse/src/lib.rs:324:20 [INFO] [stdout] | [INFO] [stdout] 324 | const TRUE: &str = &"#t"; [INFO] [stdout] | ^^^^^ help: change this to: `"#t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-parse/src/lib.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | const FALSE: &str = &"#f"; [INFO] [stdout] | ^^^^^ help: change this to: `"#f"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> slope-parse/src/lib.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 777 | / match self { [INFO] [stdout] 778 | | SourceNode::Atom { [INFO] [stdout] 779 | | kind: AtomKind::Comment, [INFO] [stdout] 780 | | .. [INFO] [stdout] ... | [INFO] [stdout] 786 | | _ => false, [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 777 ~ matches!(self, SourceNode::Atom { [INFO] [stdout] 778 + kind: AtomKind::Comment, [INFO] [stdout] 779 + .. [INFO] [stdout] 780 + } | SourceNode::Atom { [INFO] [stdout] 781 + kind: AtomKind::Whitespace, [INFO] [stdout] 782 + .. [INFO] [stdout] 783 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:844:18 [INFO] [stdout] | [INFO] [stdout] 844 | } => format!("boolean"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:848:18 [INFO] [stdout] | [INFO] [stdout] 848 | } => format!("symbol"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"symbol".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:852:18 [INFO] [stdout] | [INFO] [stdout] 852 | } => format!("number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:856:18 [INFO] [stdout] | [INFO] [stdout] 856 | } => format!("string"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"string".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:860:18 [INFO] [stdout] | [INFO] [stdout] 860 | } => format!("comment"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"comment".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:864:18 [INFO] [stdout] | [INFO] [stdout] 864 | } => format!("whitespace"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"whitespace".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:865:40 [INFO] [stdout] | [INFO] [stdout] 865 | SourceNode::Cons { .. } => format!("improper list"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"improper list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:869:21 [INFO] [stdout] | [INFO] [stdout] 869 | format!("list") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:871:21 [INFO] [stdout] | [INFO] [stdout] 871 | format!("empty list") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"empty list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Checking ahash v0.4.4 [INFO] [stderr] Checking lasso v0.3.1 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stdout] warning: enum `FileName` is never used [INFO] [stdout] --> slope-parse/src/source.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum FileName { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SourceFile` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct SourceFile { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CharPos` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | pub struct CharPos(u32); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PosInfo` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct PosInfo { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `lookup_pos_info`, and `lookup_line` are never used [INFO] [stdout] --> slope-parse/src/source.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl SourceFile { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 37 | pub fn new(name: FileName, offset: BytePos, source: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn lookup_pos_info(&self, offset: BytePos) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | pub fn lookup_line(&self, offset: BytePos) -> Option { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stdout] warning: struct `Atom` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> slope-parse/src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-parse/src/lib.rs:324:20 [INFO] [stdout] | [INFO] [stdout] 324 | const TRUE: &str = &"#t"; [INFO] [stdout] | ^^^^^ help: change this to: `"#t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-parse/src/lib.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | const FALSE: &str = &"#f"; [INFO] [stdout] | ^^^^^ help: change this to: `"#f"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> slope-parse/src/lib.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 777 | / match self { [INFO] [stdout] 778 | | SourceNode::Atom { [INFO] [stdout] 779 | | kind: AtomKind::Comment, [INFO] [stdout] 780 | | .. [INFO] [stdout] ... | [INFO] [stdout] 786 | | _ => false, [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 777 ~ matches!(self, SourceNode::Atom { [INFO] [stdout] 778 + kind: AtomKind::Comment, [INFO] [stdout] 779 + .. [INFO] [stdout] 780 + } | SourceNode::Atom { [INFO] [stdout] 781 + kind: AtomKind::Whitespace, [INFO] [stdout] 782 + .. [INFO] [stdout] 783 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:844:18 [INFO] [stdout] | [INFO] [stdout] 844 | } => format!("boolean"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:848:18 [INFO] [stdout] | [INFO] [stdout] 848 | } => format!("symbol"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"symbol".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:852:18 [INFO] [stdout] | [INFO] [stdout] 852 | } => format!("number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:856:18 [INFO] [stdout] | [INFO] [stdout] 856 | } => format!("string"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"string".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:860:18 [INFO] [stdout] | [INFO] [stdout] 860 | } => format!("comment"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"comment".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:864:18 [INFO] [stdout] | [INFO] [stdout] 864 | } => format!("whitespace"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"whitespace".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:865:40 [INFO] [stdout] | [INFO] [stdout] 865 | SourceNode::Cons { .. } => format!("improper list"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"improper list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:869:21 [INFO] [stdout] | [INFO] [stdout] 869 | format!("list") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:871:21 [INFO] [stdout] | [INFO] [stdout] 871 | format!("empty list") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"empty list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling regex v1.3.9 [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> slope-parse/src/source.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | Virtual(String), [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FileName` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 - Virtual(String), [INFO] [stdout] 8 + Virtual(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Named` is never constructed [INFO] [stdout] --> slope-parse/src/source.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum FileName { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 7 | Named(PathBuf), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileName` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> slope-parse/src/source.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct SourceFile { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 13 | name: FileName, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SourceFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> slope-parse/src/source.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl SourceFile { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 37 | pub fn new(name: FileName, offset: BytePos, source: &str) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking mimalloc v0.1.20 [INFO] [stdout] warning: struct `Atom` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> slope-parse/src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-parse/src/lib.rs:324:20 [INFO] [stdout] | [INFO] [stdout] 324 | const TRUE: &str = &"#t"; [INFO] [stdout] | ^^^^^ help: change this to: `"#t"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-parse/src/lib.rs:325:21 [INFO] [stdout] | [INFO] [stdout] 325 | const FALSE: &str = &"#f"; [INFO] [stdout] | ^^^^^ help: change this to: `"#f"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> slope-parse/src/lib.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 777 | / match self { [INFO] [stdout] 778 | | SourceNode::Atom { [INFO] [stdout] 779 | | kind: AtomKind::Comment, [INFO] [stdout] 780 | | .. [INFO] [stdout] ... | [INFO] [stdout] 786 | | _ => false, [INFO] [stdout] 787 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 777 ~ matches!(self, SourceNode::Atom { [INFO] [stdout] 778 + kind: AtomKind::Comment, [INFO] [stdout] 779 + .. [INFO] [stdout] 780 + } | SourceNode::Atom { [INFO] [stdout] 781 + kind: AtomKind::Whitespace, [INFO] [stdout] 782 + .. [INFO] [stdout] 783 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:844:18 [INFO] [stdout] | [INFO] [stdout] 844 | } => format!("boolean"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"boolean".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:848:18 [INFO] [stdout] | [INFO] [stdout] 848 | } => format!("symbol"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"symbol".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:852:18 [INFO] [stdout] | [INFO] [stdout] 852 | } => format!("number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:856:18 [INFO] [stdout] | [INFO] [stdout] 856 | } => format!("string"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"string".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:860:18 [INFO] [stdout] | [INFO] [stdout] 860 | } => format!("comment"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"comment".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:864:18 [INFO] [stdout] | [INFO] [stdout] 864 | } => format!("whitespace"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"whitespace".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:865:40 [INFO] [stdout] | [INFO] [stdout] 865 | SourceNode::Cons { .. } => format!("improper list"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"improper list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:869:21 [INFO] [stdout] | [INFO] [stdout] 869 | format!("list") [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> slope-parse/src/lib.rs:871:21 [INFO] [stdout] | [INFO] [stdout] 871 | format!("empty list") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"empty list".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking quickcheck v0.9.2 [INFO] [stderr] Checking rustyline v6.2.0 [INFO] [stderr] Compiling slope-vm v0.1.0 (/opt/rustwide/workdir/slope-vm) [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> slope-vm/build.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | / for entry in read_dir("tests/").unwrap() { [INFO] [stdout] 16 | | if let Ok(entry) = entry { [INFO] [stdout] 17 | | if let Some(ext) = entry.path().extension() { [INFO] [stdout] 18 | | if ext == "sl" { [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> slope-vm/build.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / if let Ok(entry) = entry { [INFO] [stdout] 17 | | if let Some(ext) = entry.path().extension() { [INFO] [stdout] 18 | | if ext == "sl" { [INFO] [stdout] 19 | | println!("cargo:rerun-if-changed={}", entry.path().display()); [INFO] [stdout] ... | [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 ~ for entry in read_dir("tests/").unwrap().flatten() { [INFO] [stdout] 16 + if let Some(ext) = entry.path().extension() { [INFO] [stdout] 17 + if ext == "sl" { [INFO] [stdout] 18 + println!("cargo:rerun-if-changed={}", entry.path().display()); [INFO] [stdout] 19 + write_tests(&mut output, entry.path()).unwrap(); [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> slope-vm/build.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / for sub in cap.iter().skip(1) { [INFO] [stdout] 104 | | if let Some(sub) = sub { [INFO] [stdout] 105 | | buf += sub.as_str(); [INFO] [stdout] 106 | | } [INFO] [stdout] 107 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> slope-vm/build.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some(sub) = sub { [INFO] [stdout] 105 | | buf += sub.as_str(); [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 103 ~ for sub in cap.iter().skip(1).flatten() { [INFO] [stdout] 104 + buf += sub.as_str(); [INFO] [stdout] 105 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking synstructure v0.12.4 [INFO] [stderr] Checking slope-derive v0.1.0 (/opt/rustwide/workdir/slope-derive) [INFO] [stderr] Compiling phf_macros v0.8.0 [INFO] [stderr] Compiling rustyline-derive v0.3.1 [INFO] [stderr] Compiling quickcheck_macros v0.9.1 [INFO] [stderr] Checking slope-types v0.1.0 (/opt/rustwide/workdir/slope-types) [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> slope-types/src/gc.rs:350:29 [INFO] [stdout] | [INFO] [stdout] 350 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 351 | | Self { [INFO] [stdout] 352 | | ptr: self.ptr, [INFO] [stdout] 353 | | _marker: PhantomData, [INFO] [stdout] 354 | | } [INFO] [stdout] 355 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> slope-types/src/gc.rs:350:29 [INFO] [stdout] | [INFO] [stdout] 350 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 351 | | Self { [INFO] [stdout] 352 | | ptr: self.ptr, [INFO] [stdout] 353 | | _marker: PhantomData, [INFO] [stdout] 354 | | } [INFO] [stdout] 355 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> slope-types/src/gc.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 484 | pub unsafe trait Managed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> slope-types/src/gc.rs:512:17 [INFO] [stdout] | [INFO] [stdout] 512 | unsafe impl<'gc> Managed for Function { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> slope-types/src/gc.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 484 | pub unsafe trait Managed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> slope-types/src/gc.rs:512:17 [INFO] [stdout] | [INFO] [stdout] 512 | unsafe impl<'gc> Managed for Function { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-types/src/symbol.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 74 | write!(fmt, "{}", interner.resolve(&self))?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> slope-types/src/trace.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 67 | for t in &self[..] { [INFO] [stdout] | ^^^^^^^^^ help: use the original value instead: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> slope-types/src/trace.rs:97:39 [INFO] [stdout] | [INFO] [stdout] 97 | unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> slope-types/src/trace.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | ^^^^ [INFO] [stdout] = note: ...because `Copy` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` on by default [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 97 - unsafe impl Trace for std::cell::Cell { [INFO] [stdout] 97 + unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> slope-types/src/value.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | const NIL: u64 = 1 as u64 | QUIET_NAN; [INFO] [stdout] | ^^^^^^^^ help: try: `1_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> slope-types/src/value.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | const ZERO_VAL: u64 = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-types/src/symbol.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 74 | write!(fmt, "{}", interner.resolve(&self))?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> slope-types/src/trace.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 67 | for t in &self[..] { [INFO] [stdout] | ^^^^^^^^^ help: use the original value instead: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> slope-types/src/trace.rs:97:39 [INFO] [stdout] | [INFO] [stdout] 97 | unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> slope-types/src/trace.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | ^^^^ [INFO] [stdout] = note: ...because `Copy` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` on by default [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 97 - unsafe impl Trace for std::cell::Cell { [INFO] [stdout] 97 + unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking phf v0.8.0 [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> slope-types/src/value.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | const NIL: u64 = 1 as u64 | QUIET_NAN; [INFO] [stdout] | ^^^^^^^^ help: try: `1_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> slope-types/src/value.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | const ZERO_VAL: u64 = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> slope-types/src/trace.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | for t in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 177 - for t in self { [INFO] [stdout] 177 + while let Some(t) = self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 177 - for t in self { [INFO] [stdout] 177 + if let Some(t) = self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> slope-types/src/trace.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | for t in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 177 - for t in self { [INFO] [stdout] 177 + while let Some(t) = self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 177 - for t in self { [INFO] [stdout] 177 + if let Some(t) = self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Test` is never constructed [INFO] [stdout] --> slope-types/src/value.rs:375:12 [INFO] [stdout] | [INFO] [stdout] 375 | struct Test(T); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> slope-types/src/gc.rs:350:29 [INFO] [stdout] | [INFO] [stdout] 350 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 351 | | Self { [INFO] [stdout] 352 | | ptr: self.ptr, [INFO] [stdout] 353 | | _marker: PhantomData, [INFO] [stdout] 354 | | } [INFO] [stdout] 355 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> slope-types/src/gc.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 484 | pub unsafe trait Managed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> slope-types/src/gc.rs:512:17 [INFO] [stdout] | [INFO] [stdout] 512 | unsafe impl<'gc> Managed for Function { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-types/src/symbol.rs:74:44 [INFO] [stdout] | [INFO] [stdout] 74 | write!(fmt, "{}", interner.resolve(&self))?; [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> slope-types/src/trace.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 67 | for t in &self[..] { [INFO] [stdout] | ^^^^^^^^^ help: use the original value instead: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> slope-types/src/trace.rs:97:39 [INFO] [stdout] | [INFO] [stdout] 97 | unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> slope-types/src/trace.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 97 | unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | ^^^^ [INFO] [stdout] = note: ...because `Copy` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` on by default [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 97 - unsafe impl Trace for std::cell::Cell { [INFO] [stdout] 97 + unsafe impl Trace for std::cell::Cell { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> slope-types/src/value.rs:45:18 [INFO] [stdout] | [INFO] [stdout] 45 | const NIL: u64 = 1 as u64 | QUIET_NAN; [INFO] [stdout] | ^^^^^^^^ help: try: `1_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> slope-types/src/value.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | const ZERO_VAL: u64 = 0 as u64; [INFO] [stdout] | ^^^^^^^^ help: try: `0_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> slope-types/src/value.rs:411:28 [INFO] [stdout] | [INFO] [stdout] 411 | value.is_bool() && value.is_false() == !inner [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `value.is_false() != inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> slope-types/src/trace.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | for t in self { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 177 - for t in self { [INFO] [stdout] 177 + while let Some(t) = self { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 177 - for t in self { [INFO] [stdout] 177 + if let Some(t) = self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ops::Range` and `swap` [INFO] [stdout] --> slope-vm/src/vm.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | mem::{replace, size_of, swap, take, transmute}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | ops::Range, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Module` and `self` [INFO] [stdout] --> slope-vm/src/vm.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | compile::{self, Compiler, Module, Scope, SyntaxError}, [INFO] [stdout] | ^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ops::Range` and `swap` [INFO] [stdout] --> slope-vm/src/vm.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | mem::{replace, size_of, swap, take, transmute}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | ops::Range, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Module` and `self` [INFO] [stdout] --> slope-vm/src/vm.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | compile::{self, Compiler, Module, Scope, SyntaxError}, [INFO] [stdout] | ^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ops::Range` and `swap` [INFO] [stdout] --> slope-vm/src/vm.rs:15:29 [INFO] [stdout] | [INFO] [stdout] 15 | mem::{replace, size_of, swap, take, transmute}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 16 | ops::Range, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Module` and `self` [INFO] [stdout] --> slope-vm/src/vm.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | compile::{self, Compiler, Module, Scope, SyntaxError}, [INFO] [stdout] | ^^^^ ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BuiltinIndex` is never constructed [INFO] [stdout] --> slope-vm/src/vm.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub struct BuiltinIndex(u16); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Display` is never constructed [INFO] [stdout] --> slope-vm/src/vm.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 134 | pub enum Instruction { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 242 | Display { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Instruction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `disasm` is never used [INFO] [stdout] --> slope-vm/src/vm.rs:756:12 [INFO] [stdout] | [INFO] [stdout] 755 | impl<'gc> Executable<'gc> { [INFO] [stdout] | ------------------------- method in this implementation [INFO] [stdout] 756 | pub fn disasm(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'm [INFO] [stdout] --> slope-vm/src/compile.rs:271:30 [INFO] [stdout] | [INFO] [stdout] 271 | pub(crate) fn compile_module<'m, 'gc>( [INFO] [stdout] | ^^ [INFO] [stdout] 272 | ctx: &'m mut AllocationContext<'gc>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 271 ~ pub(crate) fn compile_module<'gc>( [INFO] [stdout] 272 ~ ctx: &mut AllocationContext<'gc>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:331:59 [INFO] [stdout] | [INFO] [stdout] 331 | let pair = Pair::new(transform_value(ctx, &next)?, list); [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:366:54 [INFO] [stdout] | [INFO] [stdout] 366 | let value = transform_value(context.ctx, &inner)?; [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BuiltinIndex` is never constructed [INFO] [stdout] --> slope-vm/src/vm.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub struct BuiltinIndex(u16); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Display` is never constructed [INFO] [stdout] --> slope-vm/src/vm.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 134 | pub enum Instruction { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 242 | Display { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Instruction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | let value = transform_value(context.ctx, &node)?; [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `disasm` is never used [INFO] [stdout] --> slope-vm/src/vm.rs:756:12 [INFO] [stdout] | [INFO] [stdout] 755 | impl<'gc> Executable<'gc> { [INFO] [stdout] | ------------------------- method in this implementation [INFO] [stdout] 756 | pub fn disasm(&self) -> impl Iterator { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> slope-vm/src/compile.rs:665:9 [INFO] [stdout] | [INFO] [stdout] 665 | Ok(transform_sequence(context, form.body.iter())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 665 - Ok(transform_sequence(context, form.body.iter())?) [INFO] [stdout] 665 + transform_sequence(context, form.body.iter()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'm [INFO] [stdout] --> slope-vm/src/compile.rs:271:30 [INFO] [stdout] | [INFO] [stdout] 271 | pub(crate) fn compile_module<'m, 'gc>( [INFO] [stdout] | ^^ [INFO] [stdout] 272 | ctx: &'m mut AllocationContext<'gc>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 271 ~ pub(crate) fn compile_module<'gc>( [INFO] [stdout] 272 ~ ctx: &mut AllocationContext<'gc>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:331:59 [INFO] [stdout] | [INFO] [stdout] 331 | let pair = Pair::new(transform_value(ctx, &next)?, list); [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:366:54 [INFO] [stdout] | [INFO] [stdout] 366 | let value = transform_value(context.ctx, &inner)?; [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | let value = transform_value(context.ctx, &node)?; [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> slope-vm/src/compile.rs:665:9 [INFO] [stdout] | [INFO] [stdout] 665 | Ok(transform_sequence(context, form.body.iter())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 665 - Ok(transform_sequence(context, form.body.iter())?) [INFO] [stdout] 665 + transform_sequence(context, form.body.iter()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> slope-vm/src/form.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | syntax.literals = literals.filter_map(Match::into_single).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `form::SyntaxRulesMatch { literals: literals.filter_map(Match::into_single).collect(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> slope-vm/src/form.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | let mut syntax = SyntaxRulesMatch::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Symbol` which implements the `Copy` trait [INFO] [stdout] --> slope-vm/src/syntax.rs:183:48 [INFO] [stdout] | [INFO] [stdout] 183 | pattern.patterns[0] = Pattern::Literal(self.keyword.clone().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Symbol` which implements the `Copy` trait [INFO] [stdout] --> slope-vm/src/syntax.rs:228:42 [INFO] [stdout] | [INFO] [stdout] 228 | Pattern::Literal(symbol.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `(*symbol)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> slope-vm/src/syntax.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | ctx: &mut AllocationContext<'gc>, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> slope-vm/src/syntax.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | ctx, [INFO] [stdout] | ^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/syntax.rs:432:41 [INFO] [stdout] | [INFO] [stdout] 432 | Ok(transform_value(ctx, &node)? == *pat) // todo, what about symbols, rounding? [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/syntax.rs:439:51 [INFO] [stdout] | [INFO] [stdout] 439 | list.extract_matches(ctx, &inner, matches, repeats) [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> slope-vm/src/syntax.rs:463:42 [INFO] [stdout] | [INFO] [stdout] 463 | Error::MacroExpansionOverflow { .. } => write!(fmt, "macro expansion overflow"), [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> slope-vm/src/syntax.rs:571:14 [INFO] [stdout] | [INFO] [stdout] 571 | .map(Match::into_single) [INFO] [stdout] | ______________^ [INFO] [stdout] 572 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(Match::into_single)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> slope-vm/src/form.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | syntax.literals = literals.filter_map(Match::into_single).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `form::SyntaxRulesMatch { literals: literals.filter_map(Match::into_single).collect(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> slope-vm/src/form.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | let mut syntax = SyntaxRulesMatch::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Symbol` which implements the `Copy` trait [INFO] [stdout] --> slope-vm/src/syntax.rs:183:48 [INFO] [stdout] | [INFO] [stdout] 183 | pattern.patterns[0] = Pattern::Literal(self.keyword.clone().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Symbol` which implements the `Copy` trait [INFO] [stdout] --> slope-vm/src/syntax.rs:228:42 [INFO] [stdout] | [INFO] [stdout] 228 | Pattern::Literal(symbol.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `(*symbol)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:274:26 [INFO] [stdout] | [INFO] [stdout] 274 | let node = parse(&source).collect::, _>>()?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> slope-vm/src/syntax.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | ctx: &mut AllocationContext<'gc>, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> slope-vm/src/syntax.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | ctx, [INFO] [stdout] | ^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let node = parse(&source).collect::, _>>()?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/syntax.rs:432:41 [INFO] [stdout] | [INFO] [stdout] 432 | Ok(transform_value(ctx, &node)? == *pat) // todo, what about symbols, rounding? [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/syntax.rs:439:51 [INFO] [stdout] | [INFO] [stdout] 439 | list.extract_matches(ctx, &inner, matches, repeats) [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> slope-vm/src/syntax.rs:463:42 [INFO] [stdout] | [INFO] [stdout] 463 | Error::MacroExpansionOverflow { .. } => write!(fmt, "macro expansion overflow"), [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | &self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:502:9 [INFO] [stdout] | [INFO] [stdout] 502 | &mut self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:530:9 [INFO] [stdout] | [INFO] [stdout] 530 | &self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:536:9 [INFO] [stdout] | [INFO] [stdout] 536 | &mut self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> slope-vm/src/syntax.rs:571:14 [INFO] [stdout] | [INFO] [stdout] 571 | .map(Match::into_single) [INFO] [stdout] | ______________^ [INFO] [stdout] 572 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(Match::into_single)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> slope-vm/src/vm.rs:590:23 [INFO] [stdout] | [INFO] [stdout] 590 | debug_assert!(offset % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> slope-vm/src/vm.rs:600:23 [INFO] [stdout] | [INFO] [stdout] 600 | debug_assert!(offset % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:607:22 [INFO] [stdout] | [INFO] [stdout] 607 | unsafe { transmute(&self.stack[0..len]) } [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[std::cell::Cell>], &[slope_types::Value<'_>]>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:609:22 [INFO] [stdout] | [INFO] [stdout] 609 | unsafe { transmute(self.stack.get_unchecked(0..len)) } [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[std::cell::Cell>], &[slope_types::Value<'_>]>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> slope-vm/src/vm.rs:674:22 [INFO] [stdout] | [INFO] [stdout] 674 | unsafe { &*self.frame.closure.upvalues().get_unchecked(idx.0 as usize) }.get() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.frame.closure.upvalues().get_unchecked(idx.0 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:717:29 [INFO] [stdout] | [INFO] [stdout] 717 | stack: unsafe { transmute(vec![Value::ZERO; STACK_SIZE].into_boxed_slice()) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::]>, std::pin::Pin>]>>>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:274:26 [INFO] [stdout] | [INFO] [stdout] 274 | let node = parse(&source).collect::, _>>()?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let node = parse(&source).collect::, _>>()?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | &self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:502:9 [INFO] [stdout] | [INFO] [stdout] 502 | &mut self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:530:9 [INFO] [stdout] | [INFO] [stdout] 530 | &self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:536:9 [INFO] [stdout] | [INFO] [stdout] 536 | &mut self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> slope-vm/src/vm.rs:590:23 [INFO] [stdout] | [INFO] [stdout] 590 | debug_assert!(offset % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> slope-vm/src/vm.rs:600:23 [INFO] [stdout] | [INFO] [stdout] 600 | debug_assert!(offset % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:607:22 [INFO] [stdout] | [INFO] [stdout] 607 | unsafe { transmute(&self.stack[0..len]) } [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[std::cell::Cell>], &[slope_types::Value<'_>]>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:609:22 [INFO] [stdout] | [INFO] [stdout] 609 | unsafe { transmute(self.stack.get_unchecked(0..len)) } [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[std::cell::Cell>], &[slope_types::Value<'_>]>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> slope-vm/src/vm.rs:674:22 [INFO] [stdout] | [INFO] [stdout] 674 | unsafe { &*self.frame.closure.upvalues().get_unchecked(idx.0 as usize) }.get() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.frame.closure.upvalues().get_unchecked(idx.0 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:717:29 [INFO] [stdout] | [INFO] [stdout] 717 | stack: unsafe { transmute(vec![Value::ZERO; STACK_SIZE].into_boxed_slice()) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::]>, std::pin::Pin>]>>>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking slope v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/repl.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | panic::PanicInfo, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn panic_handler(info: &PanicInfo) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/repl.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | panic::PanicInfo, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn panic_handler(info: &PanicInfo) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/repl.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | validator: ExpressionValidator::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 27 - validator: ExpressionValidator::default(), [INFO] [stdout] 27 + validator: ExpressionValidator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BuiltinIndex` is never constructed [INFO] [stdout] --> slope-vm/src/vm.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub struct BuiltinIndex(u16); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Display` is never constructed [INFO] [stdout] --> slope-vm/src/vm.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 134 | pub enum Instruction { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 242 | Display { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Instruction` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `expr::VariableId` [INFO] [stdout] --> slope-vm/src/assemble.rs:441:31 [INFO] [stdout] | [INFO] [stdout] 441 | argument: VariableId(0).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `VariableId(0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/repl.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use dirs; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | panic::PanicInfo, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn panic_handler(info: &PanicInfo) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/repl.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | validator: ExpressionValidator::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 27 - validator: ExpressionValidator::default(), [INFO] [stdout] 27 + validator: ExpressionValidator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/repl.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | validator: ExpressionValidator::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 27 - validator: ExpressionValidator::default(), [INFO] [stdout] 27 + validator: ExpressionValidator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'm [INFO] [stdout] --> slope-vm/src/compile.rs:271:30 [INFO] [stdout] | [INFO] [stdout] 271 | pub(crate) fn compile_module<'m, 'gc>( [INFO] [stdout] | ^^ [INFO] [stdout] 272 | ctx: &'m mut AllocationContext<'gc>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 271 ~ pub(crate) fn compile_module<'gc>( [INFO] [stdout] 272 ~ ctx: &mut AllocationContext<'gc>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:331:59 [INFO] [stdout] | [INFO] [stdout] 331 | let pair = Pair::new(transform_value(ctx, &next)?, list); [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:366:54 [INFO] [stdout] | [INFO] [stdout] 366 | let value = transform_value(context.ctx, &inner)?; [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | let value = transform_value(context.ctx, &node)?; [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> slope-vm/src/compile.rs:665:9 [INFO] [stdout] | [INFO] [stdout] 665 | Ok(transform_sequence(context, form.body.iter())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 665 - Ok(transform_sequence(context, form.body.iter())?) [INFO] [stdout] 665 + transform_sequence(context, form.body.iter()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1129:42 [INFO] [stdout] | [INFO] [stdout] 1129 | assert_eq!(compile_str(&mut ctx, &"1").unwrap(), Value::from(1).into()); [INFO] [stdout] | ^^^^ help: change this to: `"1"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1132:35 [INFO] [stdout] | [INFO] [stdout] 1132 | compile_str(&mut ctx, &"\"foo\"").unwrap(), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `"\"foo\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1137:35 [INFO] [stdout] | [INFO] [stdout] 1137 | compile_str(&mut ctx, &"'bar").unwrap(), [INFO] [stdout] | ^^^^^^^ help: change this to: `"'bar"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1148:35 [INFO] [stdout] | [INFO] [stdout] 1148 | compile_str(&mut ctx, &"(let ((a 1)) a)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `"(let ((a 1)) a)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1162:35 [INFO] [stdout] | [INFO] [stdout] 1162 | compile_str(&mut ctx, &"(let ((a 1) (b 2)) a)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(let ((a 1) (b 2)) a)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1176:35 [INFO] [stdout] | [INFO] [stdout] 1176 | compile_str(&mut ctx, &"(let ((a 1) (b a)) b)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(let ((a 1) (b a)) b)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1190:35 [INFO] [stdout] | [INFO] [stdout] 1190 | compile_str(&mut ctx, &"(let ((a (let ((b 1)) b))) a)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(let ((a (let ((b 1)) b))) a)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1204:35 [INFO] [stdout] | [INFO] [stdout] 1204 | compile_str(&mut ctx, &"(begin (def a 1) a)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(begin (def a 1) a)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1218:35 [INFO] [stdout] | [INFO] [stdout] 1218 | compile_str(&mut ctx, &"(begin (def a 1) (def b 2) a)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(begin (def a 1) (def b 2) a)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1256:35 [INFO] [stdout] | [INFO] [stdout] 1256 | compile_str(&mut ctx, &"(begin (+ 1 2) 3)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(begin (+ 1 2) 3)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/compile.rs:1271:35 [INFO] [stdout] | [INFO] [stdout] 1271 | compile_str(&mut ctx, &"(if (= 1 2) 'yes 'no)").unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"(if (= 1 2) 'yes 'no)"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> slope-vm/src/form.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | syntax.literals = literals.filter_map(Match::into_single).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `form::SyntaxRulesMatch { literals: literals.filter_map(Match::into_single).collect(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> slope-vm/src/form.rs:303:5 [INFO] [stdout] | [INFO] [stdout] 303 | let mut syntax = SyntaxRulesMatch::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Symbol` which implements the `Copy` trait [INFO] [stdout] --> slope-vm/src/syntax.rs:183:48 [INFO] [stdout] | [INFO] [stdout] 183 | pattern.patterns[0] = Pattern::Literal(self.keyword.clone().into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Symbol` which implements the `Copy` trait [INFO] [stdout] --> slope-vm/src/syntax.rs:228:42 [INFO] [stdout] | [INFO] [stdout] 228 | Pattern::Literal(symbol.clone().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `(*symbol)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> slope-vm/src/syntax.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | ctx: &mut AllocationContext<'gc>, [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> slope-vm/src/syntax.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | ctx, [INFO] [stdout] | ^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/syntax.rs:432:41 [INFO] [stdout] | [INFO] [stdout] 432 | Ok(transform_value(ctx, &node)? == *pat) // todo, what about symbols, rounding? [INFO] [stdout] | ^^^^^ help: change this to: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/syntax.rs:439:51 [INFO] [stdout] | [INFO] [stdout] 439 | list.extract_matches(ctx, &inner, matches, repeats) [INFO] [stdout] | ^^^^^^ help: change this to: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> slope-vm/src/syntax.rs:463:42 [INFO] [stdout] | [INFO] [stdout] 463 | Error::MacroExpansionOverflow { .. } => write!(fmt, "macro expansion overflow"), [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> slope-vm/src/syntax.rs:571:14 [INFO] [stdout] | [INFO] [stdout] 571 | .map(Match::into_single) [INFO] [stdout] | ______________^ [INFO] [stdout] 572 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(Match::into_single)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:274:26 [INFO] [stdout] | [INFO] [stdout] 274 | let node = parse(&source).collect::, _>>()?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:288:26 [INFO] [stdout] | [INFO] [stdout] 288 | let node = parse(&source).collect::, _>>()?; [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | &self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:502:9 [INFO] [stdout] | [INFO] [stdout] 502 | &mut self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:530:9 [INFO] [stdout] | [INFO] [stdout] 530 | &self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> slope-vm/src/vm.rs:536:9 [INFO] [stdout] | [INFO] [stdout] 536 | &mut self.inner.root [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> slope-vm/src/vm.rs:590:23 [INFO] [stdout] | [INFO] [stdout] 590 | debug_assert!(offset % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> slope-vm/src/vm.rs:600:23 [INFO] [stdout] | [INFO] [stdout] 600 | debug_assert!(offset % size_of::() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `offset.is_multiple_of(size_of::())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:607:22 [INFO] [stdout] | [INFO] [stdout] 607 | unsafe { transmute(&self.stack[0..len]) } [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[std::cell::Cell>], &[slope_types::Value<'_>]>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:609:22 [INFO] [stdout] | [INFO] [stdout] 609 | unsafe { transmute(self.stack.get_unchecked(0..len)) } [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&[std::cell::Cell>], &[slope_types::Value<'_>]>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> slope-vm/src/vm.rs:674:22 [INFO] [stdout] | [INFO] [stdout] 674 | unsafe { &*self.frame.closure.upvalues().get_unchecked(idx.0 as usize) }.get() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `self.frame.closure.upvalues().get_unchecked(idx.0 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> slope-vm/src/vm.rs:717:29 [INFO] [stdout] | [INFO] [stdout] 717 | stack: unsafe { transmute(vec![Value::ZERO; STACK_SIZE].into_boxed_slice()) }, [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::]>, std::pin::Pin>]>>>` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.20s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 6` [INFO] running `Command { std: "docker" "inspect" "949d7a4d43ed3f78bbd2c23cb6a5140a46025d8cee8d95a62533071c45aa2ef7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "949d7a4d43ed3f78bbd2c23cb6a5140a46025d8cee8d95a62533071c45aa2ef7", kill_on_drop: false }` [INFO] [stdout] 949d7a4d43ed3f78bbd2c23cb6a5140a46025d8cee8d95a62533071c45aa2ef7