[INFO] cloning repository https://github.com/rogday/tic_tac_toe [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rogday/tic_tac_toe" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frogday%2Ftic_tac_toe", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frogday%2Ftic_tac_toe'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a11c3583dff920b66c7d069946565d824054f6a3 [INFO] linting rogday/tic_tac_toe against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frogday%2Ftic_tac_toe" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rogday/tic_tac_toe [INFO] finished tweaking git repo https://github.com/rogday/tic_tac_toe [INFO] tweaked toml for git repo https://github.com/rogday/tic_tac_toe written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rogday/tic_tac_toe on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rogday/tic_tac_toe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e45a8910cd2696ad87d1cff5548b0159c186faa44a6bde6e4916b6e50c48b1e [INFO] running `Command { std: "docker" "start" "-a" "5e45a8910cd2696ad87d1cff5548b0159c186faa44a6bde6e4916b6e50c48b1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e45a8910cd2696ad87d1cff5548b0159c186faa44a6bde6e4916b6e50c48b1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e45a8910cd2696ad87d1cff5548b0159c186faa44a6bde6e4916b6e50c48b1e", kill_on_drop: false }` [INFO] [stdout] 5e45a8910cd2696ad87d1cff5548b0159c186faa44a6bde6e4916b6e50c48b1e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a7d1a190471ef6f4a6bb8abd3148b2f4f6f1a293678f76b3f25d71bbd4561bf [INFO] running `Command { std: "docker" "start" "-a" "5a7d1a190471ef6f4a6bb8abd3148b2f4f6f1a293678f76b3f25d71bbd4561bf", kill_on_drop: false }` [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking tic_tac_toe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | if !board[j].is_none() && (j..).step_by(d + 1).take(3).map(|x| board[x]).all_equal() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `board[j].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | if !self.board[place].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.board[place].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:95:60 [INFO] [stdout] | [INFO] [stdout] 95 | let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 95 - let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] 95 + let m = self.get_best_move(self.board.clone(), i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:95:75 [INFO] [stdout] | [INFO] [stdout] 95 | let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 95 - let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] 95 + let m = self.get_best_move(self.board.clone(), std::i64::MIN, i64::MAX, true, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 141 | if !board[i].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `board[i].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | std::i64::MIN [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 132 - std::i64::MIN [INFO] [stdout] 132 + i64::MIN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | std::i64::MAX [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 134 - std::i64::MAX [INFO] [stdout] 134 + i64::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 52 | if !board[j].is_none() && (j..).step_by(d + 1).take(3).map(|x| board[x]).all_equal() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `board[j].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:16 [INFO] [stdout] | [INFO] [stdout] 84 | if !self.board[place].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.board[place].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:95:60 [INFO] [stdout] | [INFO] [stdout] 95 | let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 95 - let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] 95 + let m = self.get_best_move(self.board.clone(), i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:95:75 [INFO] [stdout] | [INFO] [stdout] 95 | let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 95 - let m = self.get_best_move(self.board.clone(), std::i64::MIN, std::i64::MAX, true, 0); [INFO] [stdout] 95 + let m = self.get_best_move(self.board.clone(), std::i64::MIN, i64::MAX, true, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:141:20 [INFO] [stdout] | [INFO] [stdout] 141 | if !board[i].is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `board[i].is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:132:21 [INFO] [stdout] | [INFO] [stdout] 132 | std::i64::MIN [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 132 - std::i64::MIN [INFO] [stdout] 132 + i64::MIN [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/main.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | std::i64::MAX [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 134 - std::i64::MAX [INFO] [stdout] 134 + i64::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `Command { std: "docker" "inspect" "5a7d1a190471ef6f4a6bb8abd3148b2f4f6f1a293678f76b3f25d71bbd4561bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a7d1a190471ef6f4a6bb8abd3148b2f4f6f1a293678f76b3f25d71bbd4561bf", kill_on_drop: false }` [INFO] [stdout] 5a7d1a190471ef6f4a6bb8abd3148b2f4f6f1a293678f76b3f25d71bbd4561bf