[INFO] cloning repository https://github.com/roesnera/update_packages
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/roesnera/update_packages" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froesnera%2Fupdate_packages", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froesnera%2Fupdate_packages'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] bfd04f017568d64c10699c67e05da21e850b003c
[INFO] linting roesnera/update_packages against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froesnera%2Fupdate_packages" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/roesnera/update_packages
[INFO] finished tweaking git repo https://github.com/roesnera/update_packages
[INFO] tweaked toml for git repo https://github.com/roesnera/update_packages written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/roesnera/update_packages on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/roesnera/update_packages already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1d45f9d3b57c2e54c7acfe183da6759503e98b72892be156b16d84bd3a4a6e20
[INFO] running `Command { std: "docker" "start" "-a" "1d45f9d3b57c2e54c7acfe183da6759503e98b72892be156b16d84bd3a4a6e20", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1d45f9d3b57c2e54c7acfe183da6759503e98b72892be156b16d84bd3a4a6e20", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1d45f9d3b57c2e54c7acfe183da6759503e98b72892be156b16d84bd3a4a6e20", kill_on_drop: false }`
[INFO] [stdout] 1d45f9d3b57c2e54c7acfe183da6759503e98b72892be156b16d84bd3a4a6e20
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 2e650ccc514b0413e850675a6db4c0a52bdce02f1dbecdd15f3da1134505ada2
[INFO] running `Command { std: "docker" "start" "-a" "2e650ccc514b0413e850675a6db4c0a52bdce02f1dbecdd15f3da1134505ada2", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.94
[INFO] [stderr]    Compiling libc v0.2.170
[INFO] [stderr]    Compiling serde v1.0.218
[INFO] [stderr]    Compiling serde_json v1.0.140
[INFO] [stderr]     Checking either v1.15.0
[INFO] [stderr]     Checking textwrap v0.11.0
[INFO] [stderr]     Checking anyhow v1.0.97
[INFO] [stderr]     Checking rayon v1.10.0
[INFO] [stderr]    Compiling quote v1.0.39
[INFO] [stderr]    Compiling syn v2.0.99
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking clap v2.34.0
[INFO] [stderr]    Compiling serde_derive v1.0.218
[INFO] [stderr]     Checking check-packages v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:26:8
[INFO] [stdout]    |
[INFO] [stdout] 26 |     if !fs::metadata("package.json").is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("package.json").is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:34:27
[INFO] [stdout]    |
[INFO] [stdout] 34 |     let file = File::open(&path_to_package_json).expect("Failed to open package.json");
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path_to_package_json`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/main.rs:51:8
[INFO] [stdout]    |
[INFO] [stdout] 51 |     if to_update.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `to_update.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:72:13
[INFO] [stdout]    |
[INFO] [stdout] 72 |             return Err(format_err!("Error: Could not fetch version for {}", package_name))
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -             return Err(format_err!("Error: Could not fetch version for {}", package_name))
[INFO] [stdout] 72 +             Err(format_err!("Error: Could not fetch version for {}", package_name))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:75:13
[INFO] [stdout]    |
[INFO] [stdout] 75 |             return Ok((package_name.to_string(), latest_version))
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 75 -             return Ok((package_name.to_string(), latest_version))
[INFO] [stdout] 75 +             Ok((package_name.to_string(), latest_version))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:26:8
[INFO] [stdout]    |
[INFO] [stdout] 26 |     if !fs::metadata("package.json").is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata("package.json").is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:34:27
[INFO] [stdout]    |
[INFO] [stdout] 34 |     let file = File::open(&path_to_package_json).expect("Failed to open package.json");
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path_to_package_json`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/main.rs:51:8
[INFO] [stdout]    |
[INFO] [stdout] 51 |     if to_update.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `to_update.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:72:13
[INFO] [stdout]    |
[INFO] [stdout] 72 |             return Err(format_err!("Error: Could not fetch version for {}", package_name))
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -             return Err(format_err!("Error: Could not fetch version for {}", package_name))
[INFO] [stdout] 72 +             Err(format_err!("Error: Could not fetch version for {}", package_name))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:75:13
[INFO] [stdout]    |
[INFO] [stdout] 75 |             return Ok((package_name.to_string(), latest_version))
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 75 -             return Ok((package_name.to_string(), latest_version))
[INFO] [stdout] 75 +             Ok((package_name.to_string(), latest_version))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.95s
[INFO] running `Command { std: "docker" "inspect" "2e650ccc514b0413e850675a6db4c0a52bdce02f1dbecdd15f3da1134505ada2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "2e650ccc514b0413e850675a6db4c0a52bdce02f1dbecdd15f3da1134505ada2", kill_on_drop: false }`
[INFO] [stdout] 2e650ccc514b0413e850675a6db4c0a52bdce02f1dbecdd15f3da1134505ada2