[INFO] cloning repository https://github.com/roelderickx/battleship-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/roelderickx/battleship-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froelderickx%2Fbattleship-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froelderickx%2Fbattleship-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] a8ca0f6df3e47f81e61c5167cde03da8b1183b97
[INFO] linting roelderickx/battleship-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froelderickx%2Fbattleship-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/roelderickx/battleship-rs
[INFO] finished tweaking git repo https://github.com/roelderickx/battleship-rs
[INFO] tweaked toml for git repo https://github.com/roelderickx/battleship-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/roelderickx/battleship-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/roelderickx/battleship-rs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded colored_text v0.3.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0d14a6d39050c5b0a0c49afe78f43edb590cd325b41f6586c3a26f0099ce4562
[INFO] running `Command { std: "docker" "start" "-a" "0d14a6d39050c5b0a0c49afe78f43edb590cd325b41f6586c3a26f0099ce4562", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0d14a6d39050c5b0a0c49afe78f43edb590cd325b41f6586c3a26f0099ce4562", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0d14a6d39050c5b0a0c49afe78f43edb590cd325b41f6586c3a26f0099ce4562", kill_on_drop: false }`
[INFO] [stdout] 0d14a6d39050c5b0a0c49afe78f43edb590cd325b41f6586c3a26f0099ce4562
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 544453ad154659808743e1238fa5e4c50165e7d4c0a21cde3b92103e3683b215
[INFO] running `Command { std: "docker" "start" "-a" "544453ad154659808743e1238fa5e4c50165e7d4c0a21cde3b92103e3683b215", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.182
[INFO] [stderr]     Checking colored_text v0.3.0
[INFO] [stderr]     Checking getrandom v0.4.2
[INFO] [stderr]     Checking rand v0.10.0
[INFO] [stderr]     Checking battleship-rs v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: implicitly performing saturating subtraction
[INFO] [stdout]   --> src/battlefield.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 | /         if x1 > 0 {
[INFO] [stdout] 36 | |             x1 -= 1;
[INFO] [stdout] 37 | |         }
[INFO] [stdout]    | |_________^ help: try: `x1 = x1.saturating_sub(1);`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub
[INFO] [stdout]    = note: `#[warn(clippy::implicit_saturating_sub)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implicitly performing saturating subtraction
[INFO] [stdout]   --> src/battlefield.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 39 | /         if y1 > 0 {
[INFO] [stdout] 40 | |             y1 -= 1;
[INFO] [stdout] 41 | |         }
[INFO] [stdout]    | |_________^ help: try: `y1 = y1.saturating_sub(1);`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/player.rs:34:9
[INFO] [stdout]    |
[INFO] [stdout] 34 |         return self.opponent_field.all_ships_destroyed();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 34 -         return self.opponent_field.all_ships_destroyed();
[INFO] [stdout] 34 +         self.opponent_field.all_ships_destroyed()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/player.rs:46:13
[INFO] [stdout]    |
[INFO] [stdout] 46 |             println!("");
[INFO] [stdout]    |             ^^^^^^^^^--^
[INFO] [stdout]    |                      |
[INFO] [stdout]    |                      help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/player.rs:65:9
[INFO] [stdout]    |
[INFO] [stdout] 65 |         return &mut self.base_player;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 65 -         return &mut self.base_player;
[INFO] [stdout] 65 +         &mut self.base_player
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/player.rs:129:16
[INFO] [stdout]     |
[INFO] [stdout] 129 |             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if !(x < 1 || y > 10) {
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if x >= 1 && y <= 10 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/player.rs:129:16
[INFO] [stdout]     |
[INFO] [stdout] 129 |             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if !(x < 1 || y > 10) && y <= 10 {
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if x >= 1 && y <= 10 && y <= 10 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/player.rs:214:9
[INFO] [stdout]     |
[INFO] [stdout] 214 |         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 214 -         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout] 214 +         self.base_player.all_opponent_ships_destroyed()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/player.rs:248:9
[INFO] [stdout]     |
[INFO] [stdout] 248 |         return &mut self.base_player;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 248 -         return &mut self.base_player;
[INFO] [stdout] 248 +         &mut self.base_player
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/player.rs:467:9
[INFO] [stdout]     |
[INFO] [stdout] 467 |         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 467 -         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout] 467 +         self.base_player.all_opponent_ships_destroyed()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implicitly performing saturating subtraction
[INFO] [stdout]   --> src/battlefield.rs:35:9
[INFO] [stdout]    |
[INFO] [stdout] 35 | /         if x1 > 0 {
[INFO] [stdout] 36 | |             x1 -= 1;
[INFO] [stdout] 37 | |         }
[INFO] [stdout]    | |_________^ help: try: `x1 = x1.saturating_sub(1);`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub
[INFO] [stdout]    = note: `#[warn(clippy::implicit_saturating_sub)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: implicitly performing saturating subtraction
[INFO] [stdout]   --> src/battlefield.rs:39:9
[INFO] [stdout]    |
[INFO] [stdout] 39 | /         if y1 > 0 {
[INFO] [stdout] 40 | |             y1 -= 1;
[INFO] [stdout] 41 | |         }
[INFO] [stdout]    | |_________^ help: try: `y1 = y1.saturating_sub(1);`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/player.rs:34:9
[INFO] [stdout]    |
[INFO] [stdout] 34 |         return self.opponent_field.all_ships_destroyed();
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 34 -         return self.opponent_field.all_ships_destroyed();
[INFO] [stdout] 34 +         self.opponent_field.all_ships_destroyed()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/player.rs:46:13
[INFO] [stdout]    |
[INFO] [stdout] 46 |             println!("");
[INFO] [stdout]    |             ^^^^^^^^^--^
[INFO] [stdout]    |                      |
[INFO] [stdout]    |                      help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/player.rs:65:9
[INFO] [stdout]    |
[INFO] [stdout] 65 |         return &mut self.base_player;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 65 -         return &mut self.base_player;
[INFO] [stdout] 65 +         &mut self.base_player
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/player.rs:129:16
[INFO] [stdout]     |
[INFO] [stdout] 129 |             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if !(x < 1 || y > 10) {
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if x >= 1 && y <= 10 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/player.rs:129:16
[INFO] [stdout]     |
[INFO] [stdout] 129 |             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if !(x < 1 || y > 10) && y <= 10 {
[INFO] [stdout]     |
[INFO] [stdout] 129 -             if x >= 1 && y <= 10 && x >= 1 && y <= 10 {
[INFO] [stdout] 129 +             if x >= 1 && y <= 10 && y <= 10 {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/player.rs:214:9
[INFO] [stdout]     |
[INFO] [stdout] 214 |         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 214 -         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout] 214 +         self.base_player.all_opponent_ships_destroyed()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/player.rs:248:9
[INFO] [stdout]     |
[INFO] [stdout] 248 |         return &mut self.base_player;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 248 -         return &mut self.base_player;
[INFO] [stdout] 248 +         &mut self.base_player
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/player.rs:467:9
[INFO] [stdout]     |
[INFO] [stdout] 467 |         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 467 -         return self.base_player.all_opponent_ships_destroyed();
[INFO] [stdout] 467 +         self.base_player.all_opponent_ships_destroyed()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.08s
[INFO] running `Command { std: "docker" "inspect" "544453ad154659808743e1238fa5e4c50165e7d4c0a21cde3b92103e3683b215", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "544453ad154659808743e1238fa5e4c50165e7d4c0a21cde3b92103e3683b215", kill_on_drop: false }`
[INFO] [stdout] 544453ad154659808743e1238fa5e4c50165e7d4c0a21cde3b92103e3683b215