[INFO] cloning repository https://github.com/roeeshoshani/egraph [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/roeeshoshani/egraph" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froeeshoshani%2Fegraph", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froeeshoshani%2Fegraph'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 88ab61ffca19deb6c8a531150b4a4d0a73fa79b0 [INFO] linting roeeshoshani/egraph against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Froeeshoshani%2Fegraph" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/roeeshoshani/egraph [INFO] finished tweaking git repo https://github.com/roeeshoshani/egraph [INFO] tweaked toml for git repo https://github.com/roeeshoshani/egraph written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/roeeshoshani/egraph on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/roeeshoshani/egraph already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gexf v0.1.1 [INFO] [stderr] Downloaded enum-display-macro v0.2.1 [INFO] [stderr] Downloaded enum_all_values_const v0.1.1 [INFO] [stderr] Downloaded enum_variant_accessors v1.0.1 [INFO] [stderr] Downloaded os_pipe v1.2.3 [INFO] [stderr] Downloaded is-terminal v0.4.16 [INFO] [stderr] Downloaded shared_child v1.1.1 [INFO] [stderr] Downloaded enum-display v0.2.1 [INFO] [stderr] Downloaded shared_thread v0.2.0 [INFO] [stderr] Downloaded sigchld v0.2.4 [INFO] [stderr] Downloaded derive-debug v0.1.2 [INFO] [stderr] Downloaded bimap v0.6.3 [INFO] [stderr] Downloaded oorandom v11.1.5 [INFO] [stderr] Downloaded convert_case v0.7.1 [INFO] [stderr] Downloaded duct v1.1.0 [INFO] [stderr] Downloaded assert_unordered v0.3.5 [INFO] [stderr] Downloaded half v2.7.0 [INFO] [stderr] Downloaded clap v4.5.48 [INFO] [stderr] Downloaded regex v1.12.1 [INFO] [stderr] Downloaded clap_builder v4.5.48 [INFO] [stderr] Downloaded syn v2.0.107 [INFO] [stderr] Downloaded regex-syntax v0.8.7 [INFO] [stderr] Downloaded regex-automata v0.4.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 41e4c23104ece2be1fa0fadcb8eafd33bc44b275368f3bee24dc514b92ced074 [INFO] running `Command { std: "docker" "start" "-a" "41e4c23104ece2be1fa0fadcb8eafd33bc44b275368f3bee24dc514b92ced074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "41e4c23104ece2be1fa0fadcb8eafd33bc44b275368f3bee24dc514b92ced074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41e4c23104ece2be1fa0fadcb8eafd33bc44b275368f3bee24dc514b92ced074", kill_on_drop: false }` [INFO] [stdout] 41e4c23104ece2be1fa0fadcb8eafd33bc44b275368f3bee24dc514b92ced074 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2d83e6bf4fdf4206428a5e2cab8bdb8f569a3684d8dbacb182382ebd904446a5 [INFO] running `Command { std: "docker" "start" "-a" "2d83e6bf4fdf4206428a5e2cab8bdb8f569a3684d8dbacb182382ebd904446a5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling unicode-ident v1.0.19 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Checking cfg-if v1.0.3 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Compiling regex-syntax v0.8.7 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking os_pipe v1.2.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking sigchld v0.2.4 [INFO] [stderr] Checking shared_thread v0.2.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking shared_child v1.1.1 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking no-std-compat v0.2.0 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking stable-vec v0.4.1 [INFO] [stderr] Checking duct v1.1.0 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking assert_unordered v0.3.5 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Compiling syn v2.0.107 [INFO] [stderr] Checking regex-automata v0.4.12 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking regex v1.12.1 [INFO] [stderr] Compiling enum-display-macro v0.2.1 [INFO] [stderr] Compiling derive-debug v0.1.2 [INFO] [stderr] Checking enum-display v0.2.1 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling enum_variant_accessors v1.0.1 [INFO] [stderr] Compiling enum_all_values_const v0.1.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking gexf v0.1.1 [INFO] [stderr] Checking half v2.7.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking egraph v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/egraph/extract.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | score: score, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/egraph/rewrite/template_rewrite.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | rhs: rhs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rec_node.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | rhs: rhs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egraph/dot.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / return format!( [INFO] [stdout] 99 | | r##" [INFO] [stdout] 100 | | digraph egraph {{ [INFO] [stdout] 101 | | compound=true; [INFO] [stdout] ... | [INFO] [stdout] 117 | | out [INFO] [stdout] 118 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ format!( [INFO] [stdout] 99 + r##" [INFO] [stdout] 100 + digraph egraph {{ [INFO] [stdout] 101 + compound=true; [INFO] [stdout] 102 + rankdir=TB; [INFO] [stdout] 103 + bgcolor="#181818" [INFO] [stdout] 104 + node [ [INFO] [stdout] 105 + fontcolor = "#e6e6e6", [INFO] [stdout] 106 + style = filled, [INFO] [stdout] 107 + color = "#e6e6e6", [INFO] [stdout] 108 + fillcolor = "#333333" [INFO] [stdout] 109 + ] [INFO] [stdout] 110 + edge [ [INFO] [stdout] 111 + color = "#e6e6e6", [INFO] [stdout] 112 + fontcolor = "#e6e6e6" [INFO] [stdout] 113 + ] [INFO] [stdout] 114 + {} [INFO] [stdout] 115 + }} [INFO] [stdout] 116 + "##, [INFO] [stdout] 117 + out [INFO] [stdout] 118 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/egraph/rewrite/template_rewrite.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 296 | if !(index < self.0.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index >= self.0.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egraph/rewrite/mod.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - QueryMatchLinkRes::NoMatch => { [INFO] [stdout] 204 - return; [INFO] [stdout] 203 + QueryMatchLinkRes::NoMatch => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egraph/rewrite/mod.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - QueryMatchENodeRes::NoMatch => { [INFO] [stdout] 318 - return; [INFO] [stdout] 317 + QueryMatchENodeRes::NoMatch => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ENodesUnionFind` [INFO] [stdout] --> src/egraph/mod.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | / pub fn new() -> Self { [INFO] [stdout] 126 | | Self(UnionFind::new()) [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 123 + impl Default for ENodesUnionFind { [INFO] [stdout] 124 + fn default() -> Self { [INFO] [stdout] 125 + Self::new() [INFO] [stdout] 126 + } [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ENodesUnionFind` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/egraph/mod.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EGraph` [INFO] [stdout] --> src/egraph/mod.rs:371:5 [INFO] [stdout] | [INFO] [stdout] 371 | / pub fn new() -> Self { [INFO] [stdout] 372 | | Self { [INFO] [stdout] 373 | | union_find: ENodesUnionFind::new(), [INFO] [stdout] 374 | | hashmap: RefCell::new(HashMap::new()), [INFO] [stdout] 375 | | } [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 369 + impl Default for EGraph { [INFO] [stdout] 370 + fn default() -> Self { [INFO] [stdout] 371 + Self::new() [INFO] [stdout] 372 + } [INFO] [stdout] 373 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GraphToEgraphTranslationMap` [INFO] [stdout] --> src/egraph/mod.rs:586:5 [INFO] [stdout] | [INFO] [stdout] 586 | / pub fn new() -> Self { [INFO] [stdout] 587 | | Self(HashMap::new()) [INFO] [stdout] 588 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 584 + impl Default for GraphToEgraphTranslationMap { [INFO] [stdout] 585 + fn default() -> Self { [INFO] [stdout] 586 + Self::new() [INFO] [stdout] 587 + } [INFO] [stdout] 588 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Graph` [INFO] [stdout] --> src/graph.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / pub fn new() -> Self { [INFO] [stdout] 48 | | Self { [INFO] [stdout] 49 | | nodes: GraphNodes::new(), [INFO] [stdout] 50 | | node_to_id: HashMap::new(), [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 45 + impl Default for Graph { [INFO] [stdout] 46 + fn default() -> Self { [INFO] [stdout] 47 + Self::new() [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `UnionFind` [INFO] [stdout] --> src/union_find.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / pub fn new() -> Self { [INFO] [stdout] 58 | | Self { [INFO] [stdout] 59 | | items: Vec::new(), [INFO] [stdout] 60 | | parent_of_item: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 55 + impl Default for UnionFind { [INFO] [stdout] 56 + fn default() -> Self { [INFO] [stdout] 57 + Self::new() [INFO] [stdout] 58 + } [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnionFind` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/union_find.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NonZeroUsizeAllocator` [INFO] [stdout] --> src/utils.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / pub fn new() -> Self { [INFO] [stdout] 52 | | Self { [INFO] [stdout] 53 | | next: Cell::new(unsafe { NonZeroUsize::new_unchecked(1) }), [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 49 + impl Default for NonZeroUsizeAllocator { [INFO] [stdout] 50 + fn default() -> Self { [INFO] [stdout] 51 + Self::new() [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/egraph/extract.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | score: score, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `score` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/egraph/rewrite/template_rewrite.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | rhs: rhs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/rec_node.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | rhs: rhs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egraph/dot.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / return format!( [INFO] [stdout] 99 | | r##" [INFO] [stdout] 100 | | digraph egraph {{ [INFO] [stdout] 101 | | compound=true; [INFO] [stdout] ... | [INFO] [stdout] 117 | | out [INFO] [stdout] 118 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ format!( [INFO] [stdout] 99 + r##" [INFO] [stdout] 100 + digraph egraph {{ [INFO] [stdout] 101 + compound=true; [INFO] [stdout] 102 + rankdir=TB; [INFO] [stdout] 103 + bgcolor="#181818" [INFO] [stdout] 104 + node [ [INFO] [stdout] 105 + fontcolor = "#e6e6e6", [INFO] [stdout] 106 + style = filled, [INFO] [stdout] 107 + color = "#e6e6e6", [INFO] [stdout] 108 + fillcolor = "#333333" [INFO] [stdout] 109 + ] [INFO] [stdout] 110 + edge [ [INFO] [stdout] 111 + color = "#e6e6e6", [INFO] [stdout] 112 + fontcolor = "#e6e6e6" [INFO] [stdout] 113 + ] [INFO] [stdout] 114 + {} [INFO] [stdout] 115 + }} [INFO] [stdout] 116 + "##, [INFO] [stdout] 117 + out [INFO] [stdout] 118 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/egraph/rewrite/template_rewrite.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 296 | if !(index < self.0.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(index >= self.0.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egraph/rewrite/mod.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - QueryMatchLinkRes::NoMatch => { [INFO] [stdout] 204 - return; [INFO] [stdout] 203 + QueryMatchLinkRes::NoMatch => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/egraph/rewrite/mod.rs:318:17 [INFO] [stdout] | [INFO] [stdout] 318 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 317 - QueryMatchENodeRes::NoMatch => { [INFO] [stdout] 318 - return; [INFO] [stdout] 317 + QueryMatchENodeRes::NoMatch => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ENodesUnionFind` [INFO] [stdout] --> src/egraph/mod.rs:125:5 [INFO] [stdout] | [INFO] [stdout] 125 | / pub fn new() -> Self { [INFO] [stdout] 126 | | Self(UnionFind::new()) [INFO] [stdout] 127 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 123 + impl Default for ENodesUnionFind { [INFO] [stdout] 124 + fn default() -> Self { [INFO] [stdout] 125 + Self::new() [INFO] [stdout] 126 + } [INFO] [stdout] 127 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ENodesUnionFind` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/egraph/mod.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EGraph` [INFO] [stdout] --> src/egraph/mod.rs:371:5 [INFO] [stdout] | [INFO] [stdout] 371 | / pub fn new() -> Self { [INFO] [stdout] 372 | | Self { [INFO] [stdout] 373 | | union_find: ENodesUnionFind::new(), [INFO] [stdout] 374 | | hashmap: RefCell::new(HashMap::new()), [INFO] [stdout] 375 | | } [INFO] [stdout] 376 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 369 + impl Default for EGraph { [INFO] [stdout] 370 + fn default() -> Self { [INFO] [stdout] 371 + Self::new() [INFO] [stdout] 372 + } [INFO] [stdout] 373 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GraphToEgraphTranslationMap` [INFO] [stdout] --> src/egraph/mod.rs:586:5 [INFO] [stdout] | [INFO] [stdout] 586 | / pub fn new() -> Self { [INFO] [stdout] 587 | | Self(HashMap::new()) [INFO] [stdout] 588 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 584 + impl Default for GraphToEgraphTranslationMap { [INFO] [stdout] 585 + fn default() -> Self { [INFO] [stdout] 586 + Self::new() [INFO] [stdout] 587 + } [INFO] [stdout] 588 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Graph` [INFO] [stdout] --> src/graph.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / pub fn new() -> Self { [INFO] [stdout] 48 | | Self { [INFO] [stdout] 49 | | nodes: GraphNodes::new(), [INFO] [stdout] 50 | | node_to_id: HashMap::new(), [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 45 + impl Default for Graph { [INFO] [stdout] 46 + fn default() -> Self { [INFO] [stdout] 47 + Self::new() [INFO] [stdout] 48 + } [INFO] [stdout] 49 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `UnionFind` [INFO] [stdout] --> src/union_find.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / pub fn new() -> Self { [INFO] [stdout] 58 | | Self { [INFO] [stdout] 59 | | items: Vec::new(), [INFO] [stdout] 60 | | parent_of_item: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 55 + impl Default for UnionFind { [INFO] [stdout] 56 + fn default() -> Self { [INFO] [stdout] 57 + Self::new() [INFO] [stdout] 58 + } [INFO] [stdout] 59 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `UnionFind` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/union_find.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NonZeroUsizeAllocator` [INFO] [stdout] --> src/utils.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / pub fn new() -> Self { [INFO] [stdout] 52 | | Self { [INFO] [stdout] 53 | | next: Cell::new(unsafe { NonZeroUsize::new_unchecked(1) }), [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 49 + impl Default for NonZeroUsizeAllocator { [INFO] [stdout] 50 + fn default() -> Self { [INFO] [stdout] 51 + Self::new() [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.35s [INFO] running `Command { std: "docker" "inspect" "2d83e6bf4fdf4206428a5e2cab8bdb8f569a3684d8dbacb182382ebd904446a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d83e6bf4fdf4206428a5e2cab8bdb8f569a3684d8dbacb182382ebd904446a5", kill_on_drop: false }` [INFO] [stdout] 2d83e6bf4fdf4206428a5e2cab8bdb8f569a3684d8dbacb182382ebd904446a5