[INFO] cloning repository https://github.com/rodesousa/jellysmack-star [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rodesousa/jellysmack-star" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frodesousa%2Fjellysmack-star", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frodesousa%2Fjellysmack-star'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b23b1e88e420c2cbdf534991d6ef40cec388f3a [INFO] linting rodesousa/jellysmack-star against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frodesousa%2Fjellysmack-star" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rodesousa/jellysmack-star [INFO] finished tweaking git repo https://github.com/rodesousa/jellysmack-star [INFO] tweaked toml for git repo https://github.com/rodesousa/jellysmack-star written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rodesousa/jellysmack-star on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rodesousa/jellysmack-star already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d7c6c2b23395f8268dd9ba89e5c367274868f15d0471a80d8bc369658135973 [INFO] running `Command { std: "docker" "start" "-a" "1d7c6c2b23395f8268dd9ba89e5c367274868f15d0471a80d8bc369658135973", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d7c6c2b23395f8268dd9ba89e5c367274868f15d0471a80d8bc369658135973", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d7c6c2b23395f8268dd9ba89e5c367274868f15d0471a80d8bc369658135973", kill_on_drop: false }` [INFO] [stdout] 1d7c6c2b23395f8268dd9ba89e5c367274868f15d0471a80d8bc369658135973 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 899b1480de41cf902e0f9c07f0280c443be81cd2fa559c285ea42852a4bb1bee [INFO] running `Command { std: "docker" "start" "-a" "899b1480de41cf902e0f9c07f0280c443be81cd2fa559c285ea42852a4bb1bee", kill_on_drop: false }` [INFO] [stderr] Checking jellysmack-star v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !(start == target) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(start != target)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 41 | fn start_transformation(s: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn start_transformation(s: &String) -> Result { [INFO] [stdout] 41 + fn start_transformation(s: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/core.rs:88:16 [INFO] [stdout] | [INFO] [stdout] 88 | if count < 1 || count > 25 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=25).contains(&count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/error.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub enum StarError { [INFO] [stdout] 6 | | InputError, [INFO] [stdout] 7 | | EqualSizeError, [INFO] [stdout] 8 | | FormatError, [INFO] [stdout] ... | [INFO] [stdout] 11 | | LengthError(usize), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !(start == target) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(start != target)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 41 | fn start_transformation(s: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn start_transformation(s: &String) -> Result { [INFO] [stdout] 41 + fn start_transformation(s: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/core.rs:88:16 [INFO] [stdout] | [INFO] [stdout] 88 | if count < 1 || count > 25 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=25).contains(&count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/error.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | / pub enum StarError { [INFO] [stdout] 6 | | InputError, [INFO] [stdout] 7 | | EqualSizeError, [INFO] [stdout] 8 | | FormatError, [INFO] [stdout] ... | [INFO] [stdout] 11 | | LengthError(usize), [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "899b1480de41cf902e0f9c07f0280c443be81cd2fa559c285ea42852a4bb1bee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "899b1480de41cf902e0f9c07f0280c443be81cd2fa559c285ea42852a4bb1bee", kill_on_drop: false }` [INFO] [stdout] 899b1480de41cf902e0f9c07f0280c443be81cd2fa559c285ea42852a4bb1bee