[INFO] cloning repository https://github.com/robot-accomplice/rpg [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/robot-accomplice/rpg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobot-accomplice%2Frpg", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobot-accomplice%2Frpg'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 98133024925f321d2b36ad31a040cfc67b1fbf41 [INFO] linting robot-accomplice/rpg against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobot-accomplice%2Frpg" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/robot-accomplice/rpg [INFO] finished tweaking git repo https://github.com/robot-accomplice/rpg [INFO] tweaked toml for git repo https://github.com/robot-accomplice/rpg written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/robot-accomplice/rpg on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/robot-accomplice/rpg already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded is-terminal v0.4.17 [INFO] [stderr] Downloaded flate2 v1.1.8 [INFO] [stderr] Downloaded zerocopy-derive v0.8.30 [INFO] [stderr] Downloaded criterion v0.5.1 [INFO] [stderr] Downloaded zerocopy v0.8.30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 68fbf8b0c72da1cfa357931065a51fd70a87b66cee99e301dd6c3a889b092b50 [INFO] running `Command { std: "docker" "start" "-a" "68fbf8b0c72da1cfa357931065a51fd70a87b66cee99e301dd6c3a889b092b50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "68fbf8b0c72da1cfa357931065a51fd70a87b66cee99e301dd6c3a889b092b50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68fbf8b0c72da1cfa357931065a51fd70a87b66cee99e301dd6c3a889b092b50", kill_on_drop: false }` [INFO] [stdout] 68fbf8b0c72da1cfa357931065a51fd70a87b66cee99e301dd6c3a889b092b50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0c1b62376dc8e1428bae777479a30a82dde7dcdced1e3a9bdbeb027232ca5c9 [INFO] running `Command { std: "docker" "start" "-a" "d0c1b62376dc8e1428bae777479a30a82dde7dcdced1e3a9bdbeb027232ca5c9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling zerocopy v0.8.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.30 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking rpg-util v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:6:15 [INFO] [stdout] | [INFO] [stdout] 6 | .args(&["3", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["3", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | .args(&["1", "--length", "20", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--length", "20", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_test.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | && !(l.chars().filter(|&c| c == '@').count() > 5) // Filter banner lines (many @ chars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(l.chars().filter(|&c| c == '@').count() <= 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 59 | .args(&["1", "--seed", "12345", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--seed", "12345", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:64:15 [INFO] [stdout] | [INFO] [stdout] 64 | .args(&["1", "--seed", "12345", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--seed", "12345", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_test.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | && !(l.chars().filter(|&c| c == '@').count() > 5) // Filter banner lines (many @ chars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(l.chars().filter(|&c| c == '@').count() <= 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_test.rs:89:20 [INFO] [stdout] | [INFO] [stdout] 89 | && !(l.chars().filter(|&c| c == '@').count() > 5) // Filter banner lines (many @ chars) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(l.chars().filter(|&c| c == '@').count() <= 5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:99:15 [INFO] [stdout] | [INFO] [stdout] 99 | .args(&["1", "--exclude-chars", "z-a", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--exclude-chars", "z-a", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 113 | .args(&["1", "--include-chars", "z-a", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--include-chars", "z-a", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:127:15 [INFO] [stdout] | [INFO] [stdout] 127 | .args(&["1", "--pattern", "LLX", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--pattern", "LLX", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:141:15 [INFO] [stdout] | [INFO] [stdout] 141 | .args(&["1", "--length", "0", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--length", "0", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 153 | .args(&["1", "--length", "10001", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--length", "10001", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:165:15 [INFO] [stdout] | [INFO] [stdout] 165 | .args(&["2", "--length", "10", "--format", "json", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["2", "--length", "10", "--format", "json", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:187:15 [INFO] [stdout] | [INFO] [stdout] 187 | .args(&["6", "--table", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["6", "--table", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:209:15 [INFO] [stdout] | [INFO] [stdout] 209 | .args(&["6", "--table"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["6", "--table"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 223 | .args(&["3", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `["3", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:242:15 [INFO] [stdout] | [INFO] [stdout] 242 | .args(&["1", "--pattern", "LLLNNNSSS", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--pattern", "LLLNNNSSS", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:248:20 [INFO] [stdout] | [INFO] [stdout] 248 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 249 | | .lines() [INFO] [stdout] 250 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 251 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 248 ~ let password = stdout [INFO] [stdout] 249 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:272:15 [INFO] [stdout] | [INFO] [stdout] 272 | .args(&["1", "--pattern", "lllununss", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--pattern", "lllununss", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:278:20 [INFO] [stdout] | [INFO] [stdout] 278 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 279 | | .lines() [INFO] [stdout] 280 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 281 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 278 ~ let password = stdout [INFO] [stdout] 279 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:291:15 [INFO] [stdout] | [INFO] [stdout] 291 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 292 | | "1", [INFO] [stdout] 293 | | "--length", [INFO] [stdout] 294 | | "10", [INFO] [stdout] ... | [INFO] [stdout] 301 | | "--quiet", [INFO] [stdout] 302 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 291 ~ .args([ [INFO] [stdout] 292 + "1", [INFO] [stdout] 293 + "--length", [INFO] [stdout] 294 + "10", [INFO] [stdout] 295 + "--min-capitals", [INFO] [stdout] 296 + "2", [INFO] [stdout] 297 + "--min-numerals", [INFO] [stdout] 298 + "2", [INFO] [stdout] 299 + "--min-symbols", [INFO] [stdout] 300 + "2", [INFO] [stdout] 301 + "--quiet", [INFO] [stdout] 302 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:308:20 [INFO] [stdout] | [INFO] [stdout] 308 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 309 | | .lines() [INFO] [stdout] 310 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 311 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 308 ~ let password = stdout [INFO] [stdout] 309 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:328:15 [INFO] [stdout] | [INFO] [stdout] 328 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 329 | | "1", [INFO] [stdout] 330 | | "--seed", [INFO] [stdout] 331 | | "999", [INFO] [stdout] ... | [INFO] [stdout] 336 | | "--quiet", [INFO] [stdout] 337 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 328 ~ .args([ [INFO] [stdout] 329 + "1", [INFO] [stdout] 330 + "--seed", [INFO] [stdout] 331 + "999", [INFO] [stdout] 332 + "--length", [INFO] [stdout] 333 + "20", [INFO] [stdout] 334 + "--min-capitals", [INFO] [stdout] 335 + "3", [INFO] [stdout] 336 + "--quiet", [INFO] [stdout] 337 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:342:15 [INFO] [stdout] | [INFO] [stdout] 342 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 343 | | "1", [INFO] [stdout] 344 | | "--seed", [INFO] [stdout] 345 | | "999", [INFO] [stdout] ... | [INFO] [stdout] 350 | | "--quiet", [INFO] [stdout] 351 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 342 ~ .args([ [INFO] [stdout] 343 + "1", [INFO] [stdout] 344 + "--seed", [INFO] [stdout] 345 + "999", [INFO] [stdout] 346 + "--length", [INFO] [stdout] 347 + "20", [INFO] [stdout] 348 + "--min-capitals", [INFO] [stdout] 349 + "3", [INFO] [stdout] 350 + "--quiet", [INFO] [stdout] 351 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:369:15 [INFO] [stdout] | [INFO] [stdout] 369 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 370 | | "1", [INFO] [stdout] 371 | | "--include-chars", [INFO] [stdout] 372 | | "a,b,c,1,2,3", [INFO] [stdout] ... | [INFO] [stdout] 375 | | "--quiet", [INFO] [stdout] 376 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 369 ~ .args([ [INFO] [stdout] 370 + "1", [INFO] [stdout] 371 + "--include-chars", [INFO] [stdout] 372 + "a,b,c,1,2,3", [INFO] [stdout] 373 + "--length", [INFO] [stdout] 374 + "10", [INFO] [stdout] 375 + "--quiet", [INFO] [stdout] 376 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:382:20 [INFO] [stdout] | [INFO] [stdout] 382 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 383 | | .lines() [INFO] [stdout] 384 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 385 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 382 ~ let password = stdout [INFO] [stdout] 383 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:399:15 [INFO] [stdout] | [INFO] [stdout] 399 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 400 | | "1", [INFO] [stdout] 401 | | "--include-chars", [INFO] [stdout] 402 | | "a,b,c", [INFO] [stdout] ... | [INFO] [stdout] 407 | | "--quiet", [INFO] [stdout] 408 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 399 ~ .args([ [INFO] [stdout] 400 + "1", [INFO] [stdout] 401 + "--include-chars", [INFO] [stdout] 402 + "a,b,c", [INFO] [stdout] 403 + "--exclude-chars", [INFO] [stdout] 404 + "a", [INFO] [stdout] 405 + "--length", [INFO] [stdout] 406 + "10", [INFO] [stdout] 407 + "--quiet", [INFO] [stdout] 408 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 414 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 415 | | .lines() [INFO] [stdout] 416 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 417 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 414 ~ let password = stdout [INFO] [stdout] 415 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:431:15 [INFO] [stdout] | [INFO] [stdout] 431 | .args(&[ [INFO] [stdout] | _______________^ [INFO] [stdout] 432 | | "1", [INFO] [stdout] 433 | | "--include-chars", [INFO] [stdout] 434 | | "a-z,0-9", [INFO] [stdout] ... | [INFO] [stdout] 437 | | "--quiet", [INFO] [stdout] 438 | | ]) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 431 ~ .args([ [INFO] [stdout] 432 + "1", [INFO] [stdout] 433 + "--include-chars", [INFO] [stdout] 434 + "a-z,0-9", [INFO] [stdout] 435 + "--length", [INFO] [stdout] 436 + "10", [INFO] [stdout] 437 + "--quiet", [INFO] [stdout] 438 ~ ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:444:20 [INFO] [stdout] | [INFO] [stdout] 444 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 445 | | .lines() [INFO] [stdout] 446 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 447 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 444 ~ let password = stdout [INFO] [stdout] 445 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:462:15 [INFO] [stdout] | [INFO] [stdout] 462 | .args(&["1", "--capitals-off", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--capitals-off", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:468:20 [INFO] [stdout] | [INFO] [stdout] 468 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 469 | | .lines() [INFO] [stdout] 470 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 471 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 468 ~ let password = stdout [INFO] [stdout] 469 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:483:15 [INFO] [stdout] | [INFO] [stdout] 483 | .args(&["1", "--pattern", "LLL", "--length", "20", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--pattern", "LLL", "--length", "20", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:489:20 [INFO] [stdout] | [INFO] [stdout] 489 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 490 | | .lines() [INFO] [stdout] 491 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 492 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 489 ~ let password = stdout [INFO] [stdout] 490 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/integration_test.rs:503:15 [INFO] [stdout] | [INFO] [stdout] 503 | .args(&["1", "--exclude-chars", "a-z", "--quiet"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["1", "--exclude-chars", "a-z", "--quiet"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> tests/integration_test.rs:509:20 [INFO] [stdout] | [INFO] [stdout] 509 | let password = stdout [INFO] [stdout] | ____________________^ [INFO] [stdout] 510 | | .lines() [INFO] [stdout] 511 | | .filter(|l| !l.is_empty()) [INFO] [stdout] 512 | | .next() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 509 ~ let password = stdout [INFO] [stdout] 510 + .lines().find(|l| !l.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:665:17 [INFO] [stdout] | [INFO] [stdout] 665 | assert!(cols >= 2 && cols <= 5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(2..=5).contains(&cols)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.35s [INFO] running `Command { std: "docker" "inspect" "d0c1b62376dc8e1428bae777479a30a82dde7dcdced1e3a9bdbeb027232ca5c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0c1b62376dc8e1428bae777479a30a82dde7dcdced1e3a9bdbeb027232ca5c9", kill_on_drop: false }` [INFO] [stdout] d0c1b62376dc8e1428bae777479a30a82dde7dcdced1e3a9bdbeb027232ca5c9