[INFO] cloning repository https://github.com/robo-hamburger/recents
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/robo-hamburger/recents" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobo-hamburger%2Frecents", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobo-hamburger%2Frecents'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 52ca03f7745986d1df0c51f5a5e973b614f4447f
[INFO] linting robo-hamburger/recents against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobo-hamburger%2Frecents" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/robo-hamburger/recents
[INFO] finished tweaking git repo https://github.com/robo-hamburger/recents
[INFO] tweaked toml for git repo https://github.com/robo-hamburger/recents written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/robo-hamburger/recents on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/robo-hamburger/recents already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded time v0.1.35
[INFO] [stderr]   Downloaded num-integer v0.1.32
[INFO] [stderr]   Downloaded num v0.1.36
[INFO] [stderr]   Downloaded num-traits v0.1.36
[INFO] [stderr]   Downloaded num-iter v0.1.32
[INFO] [stderr]   Downloaded chrono v0.2.25
[INFO] [stderr]   Downloaded libc v0.2.18
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 44056b4e3208084639a46e1f3f9f8ad47b4d388eb3e3a4232210c2c540080d95
[INFO] running `Command { std: "docker" "start" "-a" "44056b4e3208084639a46e1f3f9f8ad47b4d388eb3e3a4232210c2c540080d95", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "44056b4e3208084639a46e1f3f9f8ad47b4d388eb3e3a4232210c2c540080d95", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "44056b4e3208084639a46e1f3f9f8ad47b4d388eb3e3a4232210c2c540080d95", kill_on_drop: false }`
[INFO] [stdout] 44056b4e3208084639a46e1f3f9f8ad47b4d388eb3e3a4232210c2c540080d95
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8e4cb2dfa0cd25d26c959544a1b8e12fa63bcc0627309eed63ddc3803912a669
[INFO] running `Command { std: "docker" "start" "-a" "8e4cb2dfa0cd25d26c959544a1b8e12fa63bcc0627309eed63ddc3803912a669", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]    Compiling winapi-build v0.1.1
[INFO] [stderr]     Checking num-traits v0.1.36
[INFO] [stderr]     Checking winapi v0.2.8
[INFO] [stderr]     Checking libc v0.2.18
[INFO] [stderr]    Compiling kernel32-sys v0.2.2
[INFO] [stderr]     Checking num-integer v0.1.32
[INFO] [stderr]     Checking time v0.1.35
[INFO] [stderr]     Checking num-iter v0.1.32
[INFO] [stderr]     Checking num v0.1.36
[INFO] [stderr]     Checking chrono v0.2.25
[INFO] [stderr]     Checking recents v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:11:8
[INFO] [stdout]    |
[INFO] [stdout] 11 |     if !result.is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: try: `result.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 | /     return entries.filter_map(|entry| entry.ok()).filter_map(
[INFO] [stdout] 18 | |         |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata)))
[INFO] [stdout] 19 | |     ).collect();
[INFO] [stdout]    | |_______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 ~     entries.filter_map(|entry| entry.ok()).filter_map(
[INFO] [stdout] 18 +         |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata)))
[INFO] [stdout] 19 ~     ).collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value
[INFO] [stdout]   --> src/main.rs:18:17
[INFO] [stdout]    |
[INFO] [stdout] 18 |         |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata)))
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `entry.metadata().ok().map(|metadata| (entry.path(), metadata))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stdout]    = note: `#[warn(clippy::option_map_or_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:11:8
[INFO] [stdout]    |
[INFO] [stdout] 11 |     if !result.is_ok() {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: try: `result.is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 | /     return paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold(
[INFO] [stdout] 50 | |         metadata.modified().ok(),
[INFO] [stdout] 51 | |         |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b)
[INFO] [stdout] 52 | |     );
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 49 ~     paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold(
[INFO] [stdout] 50 +         metadata.modified().ok(),
[INFO] [stdout] 51 +         |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b)
[INFO] [stdout] 52 ~     )
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 17 | /     return entries.filter_map(|entry| entry.ok()).filter_map(
[INFO] [stdout] 18 | |         |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata)))
[INFO] [stdout] 19 | |     ).collect();
[INFO] [stdout]    | |_______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 17 ~     entries.filter_map(|entry| entry.ok()).filter_map(
[INFO] [stdout] 18 +         |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata)))
[INFO] [stdout] 19 ~     ).collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value
[INFO] [stdout]   --> src/main.rs:18:17
[INFO] [stdout]    |
[INFO] [stdout] 18 |         |entry| entry.metadata().ok().map_or(None, |metadata| Some((entry.path(), metadata)))
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `entry.metadata().ok().map(|metadata| (entry.path(), metadata))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stdout]    = note: `#[warn(clippy::option_map_or_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> src/main.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `std::cmp::max`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 | /     return paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold(
[INFO] [stdout] 50 | |         metadata.modified().ok(),
[INFO] [stdout] 51 | |         |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b)
[INFO] [stdout] 52 | |     );
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 49 ~     paths_with_subdir_mtime.iter().map(|&(_, _, mtime)| mtime).fold(
[INFO] [stdout] 50 +         metadata.modified().ok(),
[INFO] [stdout] 51 +         |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b)
[INFO] [stdout] 52 ~     )
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]   --> src/main.rs:51:9
[INFO] [stdout]    |
[INFO] [stdout] 51 |         |mtime_a, mtime_b| std::cmp::max(mtime_a, mtime_b)
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `std::cmp::max`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]    = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.70s
[INFO] running `Command { std: "docker" "inspect" "8e4cb2dfa0cd25d26c959544a1b8e12fa63bcc0627309eed63ddc3803912a669", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8e4cb2dfa0cd25d26c959544a1b8e12fa63bcc0627309eed63ddc3803912a669", kill_on_drop: false }`
[INFO] [stdout] 8e4cb2dfa0cd25d26c959544a1b8e12fa63bcc0627309eed63ddc3803912a669