[INFO] cloning repository https://github.com/robertkottelin/GameOfLife-Rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/robertkottelin/GameOfLife-Rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobertkottelin%2FGameOfLife-Rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobertkottelin%2FGameOfLife-Rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eae8382b0ed5c88115344fcb6618fbbe670e7610 [INFO] linting robertkottelin/GameOfLife-Rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frobertkottelin%2FGameOfLife-Rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/robertkottelin/GameOfLife-Rust [INFO] finished tweaking git repo https://github.com/robertkottelin/GameOfLife-Rust [INFO] tweaked toml for git repo https://github.com/robertkottelin/GameOfLife-Rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/robertkottelin/GameOfLife-Rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/robertkottelin/GameOfLife-Rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f10abb19b353ef9c74f5ec6cd3273766f1c26accba9aebf9c5c8f5c76060ff91 [INFO] running `Command { std: "docker" "start" "-a" "f10abb19b353ef9c74f5ec6cd3273766f1c26accba9aebf9c5c8f5c76060ff91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f10abb19b353ef9c74f5ec6cd3273766f1c26accba9aebf9c5c8f5c76060ff91", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f10abb19b353ef9c74f5ec6cd3273766f1c26accba9aebf9c5c8f5c76060ff91", kill_on_drop: false }` [INFO] [stdout] f10abb19b353ef9c74f5ec6cd3273766f1c26accba9aebf9c5c8f5c76060ff91 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ec6d50470b916529077cce0561d8ee6f79ececa422666016dc2621663a1a0206 [INFO] running `Command { std: "docker" "start" "-a" "ec6d50470b916529077cce0561d8ee6f79ececa422666016dc2621663a1a0206", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.141 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.14 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking game_of_life-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | ... = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 - let next_state = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] 61 + let next_state = !(!current_generation[row][col] && live_neighbors != 3 || live_neighbors != 2 && live_neighbors != 3); [INFO] [stdout] | [INFO] [stdout] 61 - let next_state = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] 61 + let next_state = (live_neighbors == 3 || live_neighbors == 2) && (live_neighbors == 3 || current_generation[row][col]); [INFO] [stdout] | [INFO] [stdout] 61 - let next_state = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] 61 + let next_state = live_neighbors == 3 || current_generation[row][col] && live_neighbors == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | ... = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 61 - let next_state = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] 61 + let next_state = !(!current_generation[row][col] && live_neighbors != 3 || live_neighbors != 2 && live_neighbors != 3); [INFO] [stdout] | [INFO] [stdout] 61 - let next_state = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] 61 + let next_state = (live_neighbors == 3 || live_neighbors == 2) && (live_neighbors == 3 || current_generation[row][col]); [INFO] [stdout] | [INFO] [stdout] 61 - let next_state = current_generation[row][col] && (live_neighbors == 2 || live_neighbors == 3) || !current_generation[row][col] && live_neighbors == 3; [INFO] [stdout] 61 + let next_state = live_neighbors == 3 || current_generation[row][col] && live_neighbors == 2; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.48s [INFO] running `Command { std: "docker" "inspect" "ec6d50470b916529077cce0561d8ee6f79ececa422666016dc2621663a1a0206", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec6d50470b916529077cce0561d8ee6f79ececa422666016dc2621663a1a0206", kill_on_drop: false }` [INFO] [stdout] ec6d50470b916529077cce0561d8ee6f79ececa422666016dc2621663a1a0206