[INFO] cloning repository https://github.com/rob-b/spr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rob-b/spr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frob-b%2Fspr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frob-b%2Fspr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 27e050c554a775b840f0cf733ab6a2e57887aa91 [INFO] linting rob-b/spr against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frob-b%2Fspr" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rob-b/spr [INFO] finished tweaking git repo https://github.com/rob-b/spr [INFO] tweaked toml for git repo https://github.com/rob-b/spr written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rob-b/spr on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rob-b/spr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy-regex v2.5.0 [INFO] [stderr] Downloaded graphql_query_derive v0.11.0 [INFO] [stderr] Downloaded textwrap v0.15.2 [INFO] [stderr] Downloaded graphql_client v0.11.0 [INFO] [stderr] Downloaded lazy-regex-proc_macros v2.4.1 [INFO] [stderr] Downloaded indoc v1.0.9 [INFO] [stderr] Downloaded git2-ext v0.6.3 [INFO] [stderr] Downloaded hyperx v1.4.0 [INFO] [stderr] Downloaded octocrab v0.16.0 [INFO] [stderr] Downloaded rustix v0.37.28 [INFO] [stderr] Downloaded graphql_client_codegen v0.11.0 [INFO] [stderr] Downloaded tokio v1.43.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9fdacf8373e93d10e2171911cbc84869d6e3d041a4566bef0152ba5a27f3a7e6 [INFO] running `Command { std: "docker" "start" "-a" "9fdacf8373e93d10e2171911cbc84869d6e3d041a4566bef0152ba5a27f3a7e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9fdacf8373e93d10e2171911cbc84869d6e3d041a4566bef0152ba5a27f3a7e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9fdacf8373e93d10e2171911cbc84869d6e3d041a4566bef0152ba5a27f3a7e6", kill_on_drop: false }` [INFO] [stdout] 9fdacf8373e93d10e2171911cbc84869d6e3d041a4566bef0152ba5a27f3a7e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 05d4146699c4dedbe6e5033a6d83937c2a719fd48038a3fb060fbc3cf89da2a6 [INFO] running `Command { std: "docker" "start" "-a" "05d4146699c4dedbe6e5033a6d83937c2a719fd48038a3fb060fbc3cf89da2a6", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling rustix v1.0.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking tinyvec v1.9.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Compiling zerocopy v0.8.24 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Compiling combine v4.6.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking getrandom v0.3.2 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libz-sys v1.1.22 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling libgit2-sys v0.15.2+1.6.4 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling hyperx v1.4.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.43.1 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling graphql-parser v0.4.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking tempfile v3.19.1 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking pem v1.1.1 [INFO] [stderr] Checking terminal_size v0.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking env_home v0.1.0 [INFO] [stderr] Checking which v7.0.3 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Compiling lazy-regex-proc_macros v2.4.1 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking terminal_size v0.2.6 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking url v2.3.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Compiling graphql-introspection-query v0.2.0 [INFO] [stderr] Checking jsonwebtoken v8.3.0 [INFO] [stderr] Checking serde_path_to_error v0.1.17 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Checking textwrap v0.15.2 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking lazy-regex v2.5.0 [INFO] [stderr] Compiling graphql_client_codegen v0.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Compiling graphql_query_derive v0.11.0 [INFO] [stderr] Checking octocrab v0.16.0 [INFO] [stderr] Checking graphql_client v0.11.0 [INFO] [stderr] Checking git2 v0.17.2 [INFO] [stderr] Checking git2-ext v0.6.3 [INFO] [stderr] Checking spr v1.3.5-beta.1 (/opt/rustwide/workdir/spr) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> spr/src/commit_message.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | subject: subject, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> spr/src/commit_message.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | body: body, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> spr/src/commit_message.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | trailers: trailers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trailers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> spr/src/commit_message.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | subject: subject, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `subject` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> spr/src/commit_message.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | body: body, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> spr/src/commit_message.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | trailers: trailers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `trailers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> spr/src/commands/diff.rs:93:42 [INFO] [stdout] | [INFO] [stdout] 93 | zip(prepared_commits.iter_mut(), pull_request_tasks.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/adapters/zip.rs:70:7 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 93 - zip(prepared_commits.iter_mut(), pull_request_tasks.into_iter()) [INFO] [stdout] 93 + zip(prepared_commits.iter_mut(), pull_request_tasks) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> spr/src/commands/diff.rs:93:42 [INFO] [stdout] | [INFO] [stdout] 93 | zip(prepared_commits.iter_mut(), pull_request_tasks.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/adapters/zip.rs:70:7 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 93 - zip(prepared_commits.iter_mut(), pull_request_tasks.into_iter()) [INFO] [stdout] 93 + zip(prepared_commits.iter_mut(), pull_request_tasks) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> spr/src/config.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new( [INFO] [stdout] 29 | | owner: String, [INFO] [stdout] 30 | | repo: String, [INFO] [stdout] 31 | | remote_name: String, [INFO] [stdout] ... | [INFO] [stdout] 39 | | add_skip_ci_comment: bool, [INFO] [stdout] 40 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> spr/src/error.rs:156:35 [INFO] [stdout] | [INFO] [stdout] 156 | e.messages.extend(error.messages.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 156 - e.messages.extend(error.messages.into_iter()); [INFO] [stdout] 156 + e.messages.extend(error.messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> spr/src/config.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / pub fn new( [INFO] [stdout] 29 | | owner: String, [INFO] [stdout] 30 | | repo: String, [INFO] [stdout] 31 | | remote_name: String, [INFO] [stdout] ... | [INFO] [stdout] 39 | | add_skip_ci_comment: bool, [INFO] [stdout] 40 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> spr/src/error.rs:156:35 [INFO] [stdout] | [INFO] [stdout] 156 | e.messages.extend(error.messages.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 156 - e.messages.extend(error.messages.into_iter()); [INFO] [stdout] 156 + e.messages.extend(error.messages); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> spr/src/message.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if !message_section_by_label(k).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `message_section_by_label(k).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:116:50 [INFO] [stdout] | [INFO] [stdout] 116 | if top_section <= MessageSection::Summary && cmsg.body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmsg.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:145:8 [INFO] [stdout] | [INFO] [stdout] 145 | if cmsg.trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmsg.trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 156 | if extra_trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!extra_trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if text.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | if ret.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ret.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> spr/src/message.rs:230:31 [INFO] [stdout] | [INFO] [stdout] 230 | for (_, rendered_text) in &trailers { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 230 - for (_, rendered_text) in &trailers { [INFO] [stdout] 230 + for rendered_text in trailers.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> spr/src/message.rs:231:22 [INFO] [stdout] | [INFO] [stdout] 231 | ret.push_str(&rendered_text); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `rendered_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if self.subject.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.subject.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | if self.body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if self.trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> spr/src/commit_message.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | if trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> spr/src/git.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn repo(&self) -> std::sync::MutexGuard { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 44 | pub fn repo(&self) -> std::sync::MutexGuard<'_, git2::Repository> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> spr/src/git.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | fn hooks(&self) -> std::sync::MutexGuard { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 48 | fn hooks(&self) -> std::sync::MutexGuard<'_, git2_ext::hooks::Hooks> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> spr/src/commit_message.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | drop(child_stdin); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut std::process::ChildStdin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 138 - drop(child_stdin); [INFO] [stdout] 138 + let _ = child_stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> spr/src/message.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if !message_section_by_label(k).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `message_section_by_label(k).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:116:50 [INFO] [stdout] | [INFO] [stdout] 116 | if top_section <= MessageSection::Summary && cmsg.body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmsg.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:145:8 [INFO] [stdout] | [INFO] [stdout] 145 | if cmsg.trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cmsg.trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 156 | if extra_trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!extra_trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 215 | if text.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `text.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/message.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 220 | if ret.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ret.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> spr/src/message.rs:230:31 [INFO] [stdout] | [INFO] [stdout] 230 | for (_, rendered_text) in &trailers { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 230 - for (_, rendered_text) in &trailers { [INFO] [stdout] 230 + for rendered_text in trailers.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> spr/src/message.rs:231:22 [INFO] [stdout] | [INFO] [stdout] 231 | ret.push_str(&rendered_text); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `rendered_text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | if self.subject.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.subject.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | if self.body.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if self.trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> spr/src/commit_message.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | ret.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> spr/src/commit_message.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | if trailers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!trailers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> spr/src/git.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn repo(&self) -> std::sync::MutexGuard { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 44 | pub fn repo(&self) -> std::sync::MutexGuard<'_, git2::Repository> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> spr/src/git.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | fn hooks(&self) -> std::sync::MutexGuard { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 48 | fn hooks(&self) -> std::sync::MutexGuard<'_, git2_ext::hooks::Hooks> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> spr/src/commit_message.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | drop(child_stdin); [INFO] [stdout] | ^^^^^-----------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut std::process::ChildStdin` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 138 - drop(child_stdin); [INFO] [stdout] 138 + let _ = child_stdin; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 32s [INFO] running `Command { std: "docker" "inspect" "05d4146699c4dedbe6e5033a6d83937c2a719fd48038a3fb060fbc3cf89da2a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05d4146699c4dedbe6e5033a6d83937c2a719fd48038a3fb060fbc3cf89da2a6", kill_on_drop: false }` [INFO] [stdout] 05d4146699c4dedbe6e5033a6d83937c2a719fd48038a3fb060fbc3cf89da2a6