[INFO] cloning repository https://github.com/rishabhpoddar/bitpet-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/rishabhpoddar/bitpet-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frishabhpoddar%2Fbitpet-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frishabhpoddar%2Fbitpet-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b267ebf75c4788edc867a615b00a3e8b9dc4dc6 [INFO] linting rishabhpoddar/bitpet-cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frishabhpoddar%2Fbitpet-cli" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/rishabhpoddar/bitpet-cli [INFO] finished tweaking git repo https://github.com/rishabhpoddar/bitpet-cli [INFO] tweaked toml for git repo https://github.com/rishabhpoddar/bitpet-cli written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/rishabhpoddar/bitpet-cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/rishabhpoddar/bitpet-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen v0.2.102 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.102 [INFO] [stderr] Downloaded js-sys v0.3.79 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.52 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.102 [INFO] [stderr] Downloaded windows-result v0.4.0 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.102 [INFO] [stderr] Downloaded windows-core v0.62.0 [INFO] [stderr] Downloaded windows-strings v0.5.0 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.102 [INFO] [stderr] Downloaded indexmap v2.11.3 [INFO] [stderr] Downloaded web-sys v0.3.79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5e4e747880a4b4d3ab00ccdfb64bfadffa12a724ced2c8b2116777086372dbb [INFO] running `Command { std: "docker" "start" "-a" "c5e4e747880a4b4d3ab00ccdfb64bfadffa12a724ced2c8b2116777086372dbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5e4e747880a4b4d3ab00ccdfb64bfadffa12a724ced2c8b2116777086372dbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5e4e747880a4b4d3ab00ccdfb64bfadffa12a724ced2c8b2116777086372dbb", kill_on_drop: false }` [INFO] [stdout] c5e4e747880a4b4d3ab00ccdfb64bfadffa12a724ced2c8b2116777086372dbb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e8c03864ec8428e5a12d0f96bc63e69ce944521eb3642013d4479c115a95e28d [INFO] running `Command { std: "docker" "start" "-a" "e8c03864ec8428e5a12d0f96bc63e69ce944521eb3642013d4479c115a95e28d", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.1 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling serde_core v1.0.225 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling serde v1.0.225 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Compiling cc v1.2.37 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Compiling anyhow v1.0.99 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking clap_builder v4.5.47 [INFO] [stderr] Checking nix v0.30.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking indexmap v2.11.3 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking open v5.3.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking ctrlc v3.5.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.225 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking clap v4.5.47 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking reqwest-middleware v0.4.2 [INFO] [stderr] Checking BitPet v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / /// Get the path to the config file [INFO] [stdout] 29 | | [INFO] [stdout] | |_^ [INFO] [stdout] 30 | pub fn config_path() -> Result { [INFO] [stdout] | ------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / /// Load config from file, creating a default one if it doesn't exist [INFO] [stdout] 46 | | [INFO] [stdout] | |_^ [INFO] [stdout] 47 | pub fn load() -> Result { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / /// Save config to file [INFO] [stdout] 69 | | [INFO] [stdout] | |_^ [INFO] [stdout] 70 | pub fn save(&self) -> Result<(), ConfigError> { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/utils.rs:152:1 [INFO] [stdout] | [INFO] [stdout] 152 | / /// Print an error and its full chain of causes [INFO] [stdout] 153 | | [INFO] [stdout] | |_^ [INFO] [stdout] 154 | pub fn print_error_chain(error: Box) { [INFO] [stdout] | ------------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / /// Get the path to the config file [INFO] [stdout] 29 | | [INFO] [stdout] | |_^ [INFO] [stdout] 30 | pub fn config_path() -> Result { [INFO] [stdout] | ------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / /// Load config from file, creating a default one if it doesn't exist [INFO] [stdout] 46 | | [INFO] [stdout] | |_^ [INFO] [stdout] 47 | pub fn load() -> Result { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/config.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / /// Save config to file [INFO] [stdout] 69 | | [INFO] [stdout] | |_^ [INFO] [stdout] 70 | pub fn save(&self) -> Result<(), ConfigError> { [INFO] [stdout] | ----------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/utils.rs:152:1 [INFO] [stdout] | [INFO] [stdout] 152 | / /// Print an error and its full chain of causes [INFO] [stdout] 153 | | [INFO] [stdout] | |_^ [INFO] [stdout] 154 | pub fn print_error_chain(error: Box) { [INFO] [stdout] | ------------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | let user = require_auth(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 110 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:176:16 [INFO] [stdout] | [INFO] [stdout] 176 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 70 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 71 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 82 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 83 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 94 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 95 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 110 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 111 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:136:29 [INFO] [stdout] | [INFO] [stdout] 135 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 136 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:154:29 [INFO] [stdout] | [INFO] [stdout] 153 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 154 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 176 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 177 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `previous_image` after checking its variant with `is_some` [INFO] [stdout] --> src/http_mocking.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 241 | if previous_image.is_some() && previous_colours.is_some() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 245 | image: previous_image.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `previous_colours` after checking its variant with `is_some` [INFO] [stdout] --> src/http_mocking.rs:246:30 [INFO] [stdout] | [INFO] [stdout] 241 | if previous_image.is_some() && previous_colours.is_some() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 246 | colours: previous_colours.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_mocking.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | return Animation { windows, fps }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return Animation { windows, fps }; [INFO] [stdout] 268 + Animation { windows, fps } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/http_mocking.rs:211:57 [INFO] [stdout] | [INFO] [stdout] 211 | let delta_y_from_center = if curr_frame == 0 || curr_frame % 15 != 0 || total_jumps >= 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `!curr_frame.is_multiple_of(15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/http_mocking.rs:290:19 [INFO] [stdout] | [INFO] [stdout] 290 | eyes = if curr_frame % 40 == 0 && curr_frame != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `curr_frame.is_multiple_of(40)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/http_mocking.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | format!("/\\_/\\"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/\\_/\\".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:55:28 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(format!( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 56 | | "You have not yet created a pet! Please visit https://bitpet.dev/dashboard to create one." [INFO] [stdout] 57 | | ) [INFO] [stdout] | |_________________^ help: consider using `.to_string()`: `"You have not yet created a pet! Please visit https://bitpet.dev/dashboard to create one.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/auth.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | let user = require_auth(&config)?; [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/pet.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / impl Default for ChallengeAnswerType { [INFO] [stdout] 151 | | fn default() -> Self { [INFO] [stdout] 152 | | Self::Text [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 145 + #[derive(Default)] [INFO] [stdout] 146 | pub enum ChallengeAnswerType { [INFO] [stdout] 147 ~ #[default] [INFO] [stdout] 148 ~ Text, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 291 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:82:16 [INFO] [stdout] | [INFO] [stdout] 82 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:94:16 [INFO] [stdout] | [INFO] [stdout] 94 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:110:16 [INFO] [stdout] | [INFO] [stdout] 110 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:135:16 [INFO] [stdout] | [INFO] [stdout] 135 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:153:16 [INFO] [stdout] | [INFO] [stdout] 153 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_mocking.rs:176:16 [INFO] [stdout] | [INFO] [stdout] 176 | if !token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 70 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 71 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 82 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 83 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:95:29 [INFO] [stdout] | [INFO] [stdout] 94 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 95 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 110 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 111 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:136:29 [INFO] [stdout] | [INFO] [stdout] 135 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 136 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:154:29 [INFO] [stdout] | [INFO] [stdout] 153 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 154 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `token` after checking its variant with `is_none` [INFO] [stdout] --> src/http_mocking.rs:177:29 [INFO] [stdout] | [INFO] [stdout] 176 | if !token.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 177 | let token = token.unwrap().to_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `previous_image` after checking its variant with `is_some` [INFO] [stdout] --> src/http_mocking.rs:245:28 [INFO] [stdout] | [INFO] [stdout] 241 | if previous_image.is_some() && previous_colours.is_some() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 245 | image: previous_image.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `previous_colours` after checking its variant with `is_some` [INFO] [stdout] --> src/http_mocking.rs:246:30 [INFO] [stdout] | [INFO] [stdout] 241 | if previous_image.is_some() && previous_colours.is_some() { [INFO] [stdout] | -------------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 246 | colours: previous_colours.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/http_mocking.rs:268:5 [INFO] [stdout] | [INFO] [stdout] 268 | return Animation { windows, fps }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 268 - return Animation { windows, fps }; [INFO] [stdout] 268 + Animation { windows, fps } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/http_mocking.rs:211:57 [INFO] [stdout] | [INFO] [stdout] 211 | let delta_y_from_center = if curr_frame == 0 || curr_frame % 15 != 0 || total_jumps >= 3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `!curr_frame.is_multiple_of(15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/http_mocking.rs:290:19 [INFO] [stdout] | [INFO] [stdout] 290 | eyes = if curr_frame % 40 == 0 && curr_frame != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace with: `curr_frame.is_multiple_of(40)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ui.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 94 | colours: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - colours: &Vec>, [INFO] [stdout] 94 + colours: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/http_mocking.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | format!("/\\_/\\"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"/\\_/\\".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/ui.rs:105:33 [INFO] [stdout] | [INFO] [stdout] 105 | let styled = if hex == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hex.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | / match crossterm::event::read()? { [INFO] [stdout] 229 | | crossterm::event::Event::Resize(nw, nh) => { [INFO] [stdout] 230 | | w = nw; [INFO] [stdout] 231 | | h = nh; [INFO] [stdout] 232 | | } [INFO] [stdout] 233 | | _ => (), [INFO] [stdout] 234 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 228 ~ if let crossterm::event::Event::Resize(nw, nh) = crossterm::event::read()? { [INFO] [stdout] 229 + w = nw; [INFO] [stdout] 230 + h = nh; [INFO] [stdout] 231 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui.rs:264:57 [INFO] [stdout] | [INFO] [stdout] 264 | .queue(crossterm::cursor::MoveRight(BOX_WIDTH as u16 - 2))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `BOX_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 286 | BOX_WIDTH as u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `BOX_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui.rs:287:17 [INFO] [stdout] | [INFO] [stdout] 287 | BOX_HEIGHT as u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `BOX_HEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:55:28 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(format!( [INFO] [stdout] | ____________________________^ [INFO] [stdout] 56 | | "You have not yet created a pet! Please visit https://bitpet.dev/dashboard to create one." [INFO] [stdout] 57 | | ) [INFO] [stdout] | |_________________^ help: consider using `.to_string()`: `"You have not yet created a pet! Please visit https://bitpet.dev/dashboard to create one.".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/ui.rs:351:18 [INFO] [stdout] | [INFO] [stdout] 351 | pet.level.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/ui.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 354 | pet.streak.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/ui.rs:355:17 [INFO] [stdout] | [INFO] [stdout] 355 | age_days.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(format!("You are already logged in with email: {}", _user.email).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Err(format!("You are already logged in with email: {}", _user.email).into()); [INFO] [stdout] 68 + Err(format!("You are already logged in with email: {}", _user.email).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/pet.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / impl Default for ChallengeAnswerType { [INFO] [stdout] 151 | | fn default() -> Self { [INFO] [stdout] 152 | | Self::Text [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 145 + #[derive(Default)] [INFO] [stdout] 146 | pub enum ChallengeAnswerType { [INFO] [stdout] 147 ~ #[default] [INFO] [stdout] 148 ~ Text, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/main.rs:352:12 [INFO] [stdout] | [INFO] [stdout] 352 | if let Some(_) = config.challenge.clone() { [INFO] [stdout] | -------^^^^^^^--------------------------- help: try: `if config.challenge.clone().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:381:26 [INFO] [stdout] | [INFO] [stdout] 380 | if response.is_ok() && response.as_ref().unwrap().status().is_success() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 381 | let api_result = response.unwrap().json::().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:246:13 [INFO] [stdout] | [INFO] [stdout] 246 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `api_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:383:30 [INFO] [stdout] | [INFO] [stdout] 382 | if api_result.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = api_result` [INFO] [stdout] 383 | let api_result = api_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/pet.rs:291:13 [INFO] [stdout] | [INFO] [stdout] 291 | Err(format!("Oops! Please login again!").into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Oops! Please login again!".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/ui.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 94 | colours: &Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - colours: &Vec>, [INFO] [stdout] 94 + colours: &[Vec], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/ui.rs:105:33 [INFO] [stdout] | [INFO] [stdout] 105 | let styled = if hex == "" { [INFO] [stdout] | ^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hex.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/ui.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | / match crossterm::event::read()? { [INFO] [stdout] 229 | | crossterm::event::Event::Resize(nw, nh) => { [INFO] [stdout] 230 | | w = nw; [INFO] [stdout] 231 | | h = nh; [INFO] [stdout] 232 | | } [INFO] [stdout] 233 | | _ => (), [INFO] [stdout] 234 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 228 ~ if let crossterm::event::Event::Resize(nw, nh) = crossterm::event::read()? { [INFO] [stdout] 229 + w = nw; [INFO] [stdout] 230 + h = nh; [INFO] [stdout] 231 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui.rs:264:57 [INFO] [stdout] | [INFO] [stdout] 264 | .queue(crossterm::cursor::MoveRight(BOX_WIDTH as u16 - 2))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `BOX_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui.rs:286:17 [INFO] [stdout] | [INFO] [stdout] 286 | BOX_WIDTH as u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `BOX_WIDTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui.rs:287:17 [INFO] [stdout] | [INFO] [stdout] 287 | BOX_HEIGHT as u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `BOX_HEIGHT` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/ui.rs:351:18 [INFO] [stdout] | [INFO] [stdout] 351 | pet.level.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/ui.rs:354:19 [INFO] [stdout] | [INFO] [stdout] 354 | pet.streak.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/ui.rs:355:17 [INFO] [stdout] | [INFO] [stdout] 355 | age_days.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(format!("You are already logged in with email: {}", _user.email).into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Err(format!("You are already logged in with email: {}", _user.email).into()); [INFO] [stdout] 68 + Err(format!("You are already logged in with email: {}", _user.email).into()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/main.rs:352:12 [INFO] [stdout] | [INFO] [stdout] 352 | if let Some(_) = config.challenge.clone() { [INFO] [stdout] | -------^^^^^^^--------------------------- help: try: `if config.challenge.clone().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `response` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:381:26 [INFO] [stdout] | [INFO] [stdout] 380 | if response.is_ok() && response.as_ref().unwrap().status().is_success() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 381 | let api_result = response.unwrap().json::().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `api_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/main.rs:383:30 [INFO] [stdout] | [INFO] [stdout] 382 | if api_result.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = api_result` [INFO] [stdout] 383 | let api_result = api_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.05s [INFO] running `Command { std: "docker" "inspect" "e8c03864ec8428e5a12d0f96bc63e69ce944521eb3642013d4479c115a95e28d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8c03864ec8428e5a12d0f96bc63e69ce944521eb3642013d4479c115a95e28d", kill_on_drop: false }` [INFO] [stdout] e8c03864ec8428e5a12d0f96bc63e69ce944521eb3642013d4479c115a95e28d