[INFO] cloning repository https://github.com/ricky26/sodoku [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ricky26/sodoku" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fricky26%2Fsodoku", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fricky26%2Fsodoku'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 86b37ac472252df40984635c8f2d770407ba12a7 [INFO] linting ricky26/sodoku against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fricky26%2Fsodoku" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ricky26/sodoku [INFO] finished tweaking git repo https://github.com/ricky26/sodoku [INFO] tweaked toml for git repo https://github.com/ricky26/sodoku written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ricky26/sodoku on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ricky26/sodoku already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 186ea73437d2090cd22cc0673c322936ec6ace5d719ce6c9f4f793fbc9b11108 [INFO] running `Command { std: "docker" "start" "-a" "186ea73437d2090cd22cc0673c322936ec6ace5d719ce6c9f4f793fbc9b11108", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "186ea73437d2090cd22cc0673c322936ec6ace5d719ce6c9f4f793fbc9b11108", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "186ea73437d2090cd22cc0673c322936ec6ace5d719ce6c9f4f793fbc9b11108", kill_on_drop: false }` [INFO] [stdout] 186ea73437d2090cd22cc0673c322936ec6ace5d719ce6c9f4f793fbc9b11108 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 12ff64ddeef2abf42ab2034138dfee15e0b89a09568d18fb6a870fb8a4272c57 [INFO] running `Command { std: "docker" "start" "-a" "12ff64ddeef2abf42ab2034138dfee15e0b89a09568d18fb6a870fb8a4272c57", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.87 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking sodoku v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/main.rs:185:1 [INFO] [stdout] | [INFO] [stdout] 185 | / impl Default for SubGrid { [INFO] [stdout] 186 | | fn default() -> Self { [INFO] [stdout] 187 | | Self { [INFO] [stdout] 188 | | cells: [GridCell::default(); 9], [INFO] [stdout] ... | [INFO] [stdout] 191 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 128 + #[derive(Default)] [INFO] [stdout] 129 | pub struct SubGrid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 266 | if !set.first_one().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `set.first_one().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/main.rs:185:1 [INFO] [stdout] | [INFO] [stdout] 185 | / impl Default for SubGrid { [INFO] [stdout] 186 | | fn default() -> Self { [INFO] [stdout] 187 | | Self { [INFO] [stdout] 188 | | cells: [GridCell::default(); 9], [INFO] [stdout] ... | [INFO] [stdout] 191 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 128 + #[derive(Default)] [INFO] [stdout] 129 | pub struct SubGrid { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / loop { [INFO] [stdout] 385 | | let Some(c) = chars.next() else { break }; [INFO] [stdout] 386 | | match c { [INFO] [stdout] 387 | | '1'..='9' => { [INFO] [stdout] ... | [INFO] [stdout] 411 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(c) = chars.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:419:9 [INFO] [stdout] | [INFO] [stdout] 419 | write!(f, "╔═══════╤═══════╤═══════╗\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 419 - write!(f, "╔═══════╤═══════╤═══════╗\n")?; [INFO] [stdout] 419 + writeln!(f, "╔═══════╤═══════╤═══════╗")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:424:17 [INFO] [stdout] | [INFO] [stdout] 424 | write!(f, "╟───────┼───────┼───────╢\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 424 - write!(f, "╟───────┼───────┼───────╢\n")?; [INFO] [stdout] 424 + writeln!(f, "╟───────┼───────┼───────╢")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 266 | if !set.first_one().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `set.first_one().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:441:17 [INFO] [stdout] | [INFO] [stdout] 441 | write!(f, "║ {v0} {v1} {v2} │ {v3} {v4} {v5} │ {v6} {v7} {v8} ║\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 441 - write!(f, "║ {v0} {v1} {v2} │ {v3} {v4} {v5} │ {v6} {v7} {v8} ║\n")?; [INFO] [stdout] 441 + writeln!(f, "║ {v0} {v1} {v2} │ {v3} {v4} {v5} │ {v6} {v7} {v8} ║")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | write!(f, "╚═══════╧═══════╧═══════╝\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 445 - write!(f, "╚═══════╧═══════╧═══════╝\n") [INFO] [stdout] 445 + writeln!(f, "╚═══════╧═══════╧═══════╝") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / loop { [INFO] [stdout] 385 | | let Some(c) = chars.next() else { break }; [INFO] [stdout] 386 | | match c { [INFO] [stdout] 387 | | '1'..='9' => { [INFO] [stdout] ... | [INFO] [stdout] 411 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(c) = chars.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:419:9 [INFO] [stdout] | [INFO] [stdout] 419 | write!(f, "╔═══════╤═══════╤═══════╗\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 419 - write!(f, "╔═══════╤═══════╤═══════╗\n")?; [INFO] [stdout] 419 + writeln!(f, "╔═══════╤═══════╤═══════╗")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:424:17 [INFO] [stdout] | [INFO] [stdout] 424 | write!(f, "╟───────┼───────┼───────╢\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 424 - write!(f, "╟───────┼───────┼───────╢\n")?; [INFO] [stdout] 424 + writeln!(f, "╟───────┼───────┼───────╢")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:441:17 [INFO] [stdout] | [INFO] [stdout] 441 | write!(f, "║ {v0} {v1} {v2} │ {v3} {v4} {v5} │ {v6} {v7} {v8} ║\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 441 - write!(f, "║ {v0} {v1} {v2} │ {v3} {v4} {v5} │ {v6} {v7} {v8} ║\n")?; [INFO] [stdout] 441 + writeln!(f, "║ {v0} {v1} {v2} │ {v3} {v4} {v5} │ {v6} {v7} {v8} ║")?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:445:9 [INFO] [stdout] | [INFO] [stdout] 445 | write!(f, "╚═══════╧═══════╧═══════╝\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 445 - write!(f, "╚═══════╧═══════╧═══════╝\n") [INFO] [stdout] 445 + writeln!(f, "╚═══════╧═══════╧═══════╝") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.29s [INFO] running `Command { std: "docker" "inspect" "12ff64ddeef2abf42ab2034138dfee15e0b89a09568d18fb6a870fb8a4272c57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "12ff64ddeef2abf42ab2034138dfee15e0b89a09568d18fb6a870fb8a4272c57", kill_on_drop: false }` [INFO] [stdout] 12ff64ddeef2abf42ab2034138dfee15e0b89a09568d18fb6a870fb8a4272c57