[INFO] cloning repository https://github.com/richardjs/lineage [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/richardjs/lineage" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frichardjs%2Flineage", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frichardjs%2Flineage'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 36a7bfff85f622ebe4844b4fa27a1790e09092b0 [INFO] linting richardjs/lineage against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Frichardjs%2Flineage" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/richardjs/lineage [INFO] finished tweaking git repo https://github.com/richardjs/lineage [INFO] tweaked toml for git repo https://github.com/richardjs/lineage written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/richardjs/lineage on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/richardjs/lineage already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded chess v3.0.1 [INFO] [stderr] Downloaded cc v1.0.35 [INFO] [stderr] Downloaded bs58 v0.2.2 [INFO] [stderr] Downloaded libc v0.2.51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 120a014bed76426544ae636521489e7b9139736bf96409cd131130af3b6cd7e4 [INFO] running `Command { std: "docker" "start" "-a" "120a014bed76426544ae636521489e7b9139736bf96409cd131130af3b6cd7e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "120a014bed76426544ae636521489e7b9139736bf96409cd131130af3b6cd7e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "120a014bed76426544ae636521489e7b9139736bf96409cd131130af3b6cd7e4", kill_on_drop: false }` [INFO] [stdout] 120a014bed76426544ae636521489e7b9139736bf96409cd131130af3b6cd7e4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 55482ac093ce92062f9fd5d512039a4395b2656bce79ed137751014c4d9dfc46 [INFO] running `Command { std: "docker" "start" "-a" "55482ac093ce92062f9fd5d512039a4395b2656bce79ed137751014c4d9dfc46", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling cc v1.0.35 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking spin v0.5.0 [INFO] [stderr] Checking bs58 v0.2.2 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Compiling chess v3.0.1 [INFO] [stderr] Checking lineage v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:20:37 [INFO] [stdout] | [INFO] [stdout] 20 | white_bytes.copy_from_slice(&white_public_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `white_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:22:37 [INFO] [stdout] | [INFO] [stdout] 22 | black_bytes.copy_from_slice(&black_public_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `black_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:172:13 [INFO] [stdout] | [INFO] [stdout] 172 | return Ok(chain); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return Ok(chain); [INFO] [stdout] 172 + Ok(chain) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | return Err("Chain does not verify."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return Err("Chain does not verify."); [INFO] [stdout] 174 + Err("Chain does not verify.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:147:52 [INFO] [stdout] | [INFO] [stdout] 147 | let challenge = ChallengeBlock::from_bytes(&bytes); [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return Ok(()); [INFO] [stdout] 210 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return Ok(()); [INFO] [stdout] 220 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:222:13 [INFO] [stdout] | [INFO] [stdout] 222 | return Err("There are already two signatures on this chain."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Err("There are already two signatures on this chain."); [INFO] [stdout] 222 + Err("There are already two signatures on this chain.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return true; [INFO] [stdout] 311 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:20:37 [INFO] [stdout] | [INFO] [stdout] 20 | white_bytes.copy_from_slice(&white_public_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `white_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:22:37 [INFO] [stdout] | [INFO] [stdout] 22 | black_bytes.copy_from_slice(&black_public_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `black_public_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:384:17 [INFO] [stdout] | [INFO] [stdout] 384 | assert!(!chain.accept(&white).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chain.accept(&white).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/block.rs:499:17 [INFO] [stdout] | [INFO] [stdout] 499 | assert!(!chain [INFO] [stdout] | _________________^ [INFO] [stdout] 500 | | .make_move_block( [INFO] [stdout] 501 | | &white, [INFO] [stdout] 502 | | Action::MakeMove(ChessMove::new( [INFO] [stdout] ... | [INFO] [stdout] 508 | | .is_ok()); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 499 ~ assert!(chain [INFO] [stdout] 500 + .make_move_block( [INFO] [stdout] 501 + &white, [INFO] [stdout] 502 + Action::MakeMove(ChessMove::new( [INFO] [stdout] 503 + Square::from_string("e5".to_string()).unwrap(), [INFO] [stdout] 504 + Square::from_string("f4".to_string()).unwrap(), [INFO] [stdout] 505 + None, [INFO] [stdout] 506 + )), [INFO] [stdout] 507 ~ ).is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:172:13 [INFO] [stdout] | [INFO] [stdout] 172 | return Ok(chain); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return Ok(chain); [INFO] [stdout] 172 + Ok(chain) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | return Err("Chain does not verify."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return Err("Chain does not verify."); [INFO] [stdout] 174 + Err("Chain does not verify.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/block.rs:147:52 [INFO] [stdout] | [INFO] [stdout] 147 | let challenge = ChallengeBlock::from_bytes(&bytes); [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/crypto.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | key_pair.sign(msg).as_ref().iter().cloned().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return Ok(()); [INFO] [stdout] 210 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - return Ok(()); [INFO] [stdout] 220 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:222:13 [INFO] [stdout] | [INFO] [stdout] 222 | return Err("There are already two signatures on this chain."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Err("There are already two signatures on this chain."); [INFO] [stdout] 222 + Err("There are already two signatures on this chain.") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/block.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return true; [INFO] [stdout] 311 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/crypto.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | key_pair.sign(msg).as_ref().iter().cloned().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.78s [INFO] running `Command { std: "docker" "inspect" "55482ac093ce92062f9fd5d512039a4395b2656bce79ed137751014c4d9dfc46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55482ac093ce92062f9fd5d512039a4395b2656bce79ed137751014c4d9dfc46", kill_on_drop: false }` [INFO] [stdout] 55482ac093ce92062f9fd5d512039a4395b2656bce79ed137751014c4d9dfc46