[INFO] cloning repository https://github.com/ricardombiot/3sat_machine_original_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ricardombiot/3sat_machine_original_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fricardombiot%2F3sat_machine_original_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fricardombiot%2F3sat_machine_original_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 083ded6816848e3b9f1c7fa8f964de9412119f8d [INFO] linting ricardombiot/3sat_machine_original_rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fricardombiot%2F3sat_machine_original_rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ricardombiot/3sat_machine_original_rs [INFO] finished tweaking git repo https://github.com/ricardombiot/3sat_machine_original_rs [INFO] tweaked toml for git repo https://github.com/ricardombiot/3sat_machine_original_rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ricardombiot/3sat_machine_original_rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ricardombiot/3sat_machine_original_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a461b14ae5e6915bb5e99589000c75697669aaa8dad068562939c1c8b6a5cccb [INFO] running `Command { std: "docker" "start" "-a" "a461b14ae5e6915bb5e99589000c75697669aaa8dad068562939c1c8b6a5cccb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a461b14ae5e6915bb5e99589000c75697669aaa8dad068562939c1c8b6a5cccb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a461b14ae5e6915bb5e99589000c75697669aaa8dad068562939c1c8b6a5cccb", kill_on_drop: false }` [INFO] [stdout] a461b14ae5e6915bb5e99589000c75697669aaa8dad068562939c1c8b6a5cccb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ba22a221163f2cafc0c235c8fb0e915f12b37a3c44fe8c18896e5d084b913cd [INFO] running `Command { std: "docker" "start" "-a" "4ba22a221163f2cafc0c235c8fb0e915f12b37a3c44fe8c18896e5d084b913cd", kill_on_drop: false }` [INFO] [stderr] Checking abs3sat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/test/sat_machine/test_sat_machine.rs:5:29 [INFO] [stdout] | [INFO] [stdout] 5 | use crate::abssat::reader::{self, Reader}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Instant` [INFO] [stdout] --> src/test/sat_machine/test_sat_cnf.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::time::Instant; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::abssat::sat_machine::SatMachine` [INFO] [stdout] --> src/test/sat_machine/test_sat_cnf.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::abssat::sat_machine::SatMachine; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Owners49` [INFO] [stdout] --> src/abssat/gpath/owners/constructor.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn new() -> Self { [INFO] [stdout] 7 | | let table: Vec = Vec::new(); [INFO] [stdout] 8 | | let total_step: i32 = 0; [INFO] [stdout] 9 | | let is_valid = true; [INFO] [stdout] 10 | | Self { table , total_step ,is_valid} [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 5 + impl Default for Owners49 { [INFO] [stdout] 6 + fn default() -> Self { [INFO] [stdout] 7 + Self::new() [INFO] [stdout] 8 + } [INFO] [stdout] 9 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return self.total_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return self.total_step; [INFO] [stdout] 8 + self.total_step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.is_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.is_valid; [INFO] [stdout] 12 + self.is_valid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return match self.get(step) { [INFO] [stdout] 17 | | Some(_value) => false, [INFO] [stdout] 18 | | None => true [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ match self.get(step) { [INFO] [stdout] 17 + Some(_value) => false, [INFO] [stdout] 18 + None => true [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return format!("{:#064b}", value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return format!("{:#064b}", value); [INFO] [stdout] 24 + format!("{:#064b}", value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return match self.get(step) { [INFO] [stdout] 29 | | Some(value) => value, [INFO] [stdout] 30 | | None => 0 [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ match self.get(step) { [INFO] [stdout] 29 + Some(value) => value, [INFO] [stdout] 30 + None => 0 [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | return match self.get(step) { [INFO] [stdout] | ________________^ [INFO] [stdout] 29 | | Some(value) => value, [INFO] [stdout] 30 | | None => 0 [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.get(step).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Some(self.table[step]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Some(self.table[step]); [INFO] [stdout] 39 + Some(self.table[step]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return result != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return result != 0; [INFO] [stdout] 51 + result != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return false; [INFO] [stdout] 53 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | mask = mask << index_write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask <<= index_write` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 49 | let value_copy = self.table[step].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.table[step]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | adder = adder << index_write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adder <<= index_write` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | *value = *value | adder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value |= adder` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | subber = subber << index_write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subber <<= index_write` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | let mut mask: i64 = i64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 75 - let mut mask: i64 = i64::max_value(); [INFO] [stdout] 75 + let mut mask: i64 = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | mask = mask ^ subber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask ^= subber` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | *value = *value & mask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value &= mask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | *value = *value | value_b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value |= value_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 117 | *value = *value & value_b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value &= value_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:143:16 [INFO] [stdout] | [INFO] [stdout] 143 | return !(require_add > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(require_add <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return !(require_add > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return !(require_add > 0); [INFO] [stdout] 143 + !(require_add > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/indexing.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return (step_destine as usize, index as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return (step_destine as usize, index as usize); [INFO] [stdout] 16 + (step_destine as usize, index as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/to_list.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return list; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return list; [INFO] [stdout] 42 + list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GPow` [INFO] [stdout] --> src/abssat/gpath/gpow/constructor.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Self { [INFO] [stdout] 9 | | let lines_table : HashMap = HashMap::new(); [INFO] [stdout] 10 | | let owners_table: HashMap = HashMap::new(); [INFO] [stdout] 11 | | let owners: Owners49 = Owners49::new(); [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for GPow { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `set_owners_node_a` after checking its variant with `is_none` [INFO] [stdout] --> src/abssat/gpath/gpow/join.rs:22:50 [INFO] [stdout] | [INFO] [stdout] 19 | if set_owners_node_a.is_none() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = set_owners_node_a` [INFO] [stdout] ... [INFO] [stdout] 22 | let set_owners_node_a = set_owners_node_a.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/join.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return eq_map_parent_id && eq_current_step && both_valids [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return eq_map_parent_id && eq_current_step && both_valids [INFO] [stdout] 38 + eq_map_parent_id && eq_current_step && both_valids [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return &self.map_parent_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return &self.map_parent_id; [INFO] [stdout] 12 + &self.map_parent_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.current_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.current_step; [INFO] [stdout] 16 + self.current_step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return self.owners.is(path_id_node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return self.owners.is(path_id_node); [INFO] [stdout] 20 + self.owners.is(path_id_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return result; [INFO] [stdout] 29 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.owners_table.get(&path_id_node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.owners_table.get(&path_id_node); [INFO] [stdout] 33 + self.owners_table.get(&path_id_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return set_parents; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return set_parents; [INFO] [stdout] 52 + set_parents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `set_step` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 64 | if set_step.is_some(){ [INFO] [stdout] | --------------------- help: try: `if let Some() = set_step` [INFO] [stdout] 65 | for path_id_node_son in set_step.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return set_sons; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return set_sons; [INFO] [stdout] 74 + set_sons [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:68:65 [INFO] [stdout] | [INFO] [stdout] 68 | let owners_node = self.owners_table.get_mut(&path_id_node).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `path_id_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:106:73 [INFO] [stdout] | [INFO] [stdout] 106 | ... let owners_node = self.owners_table.get_mut(&path_id_node).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `path_id_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:145:73 [INFO] [stdout] | [INFO] [stdout] 145 | ... let owners_node = self.owners_table.get_mut(&path_id_node).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `path_id_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return self.nodes_to_remove.contains(&path_id_node) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return self.nodes_to_remove.contains(&path_id_node) [INFO] [stdout] 163 + self.nodes_to_remove.contains(&path_id_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/path_diagram.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return &self.dot_txt [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return &self.dot_txt [INFO] [stdout] 17 + &self.dot_txt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/path_diagram/build_diagram.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return txt; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return txt; [INFO] [stdout] 68 + txt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/abssat/gpath/path_diagram/export_diagram.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | let mut file = match File::create(&path_input_file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `path_input_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return path_node_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return path_node_id; [INFO] [stdout] 25 + path_node_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/abssat/utils/alias.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | let parent_id = match parent_id { [INFO] [stdout] | _____________________^ [INFO] [stdout] 20 | | None => (-1,0), [INFO] [stdout] 21 | | Some(value_parent_id) => value_parent_id [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_____^ help: replace with: `parent_id.unwrap_or((-1,0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return format!("{}_{}",destine,origin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return format!("{}_{}",destine,origin); [INFO] [stdout] 31 + format!("{}_{}",destine,origin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return "r".to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return "r".to_owned(); [INFO] [stdout] 36 + "r".to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return format!("k{}_{}",map_id_node.0,map_id_node.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return format!("k{}_{}",map_id_node.0,map_id_node.1); [INFO] [stdout] 39 + format!("k{}_{}",map_id_node.0,map_id_node.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return step < 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return step < 0; [INFO] [stdout] 51 + step < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return timeline; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return timeline; [INFO] [stdout] 19 + timeline [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/initialize.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return machine; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return machine; [INFO] [stdout] 20 + machine [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | return self.is_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return self.is_valid; [INFO] [stdout] 8 + self.is_valid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.n_vars; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.n_vars; [INFO] [stdout] 12 + self.n_vars [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.is_valid && self.is_close; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.is_valid && self.is_close; [INFO] [stdout] 16 + self.is_valid && self.is_close [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | return Some(self.get_gpath_fusion()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Some(self.get_gpath_fusion()); [INFO] [stdout] 21 + Some(self.get_gpath_fusion()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return None; [INFO] [stdout] 23 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return self.current_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return self.current_step; [INFO] [stdout] 28 + self.current_step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return self.timeline[index].as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return self.timeline[index].as_ref(); [INFO] [stdout] 32 + self.timeline[index].as_ref() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | return self.timeline[0].as_ref().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return self.timeline[0].as_ref().unwrap() [INFO] [stdout] 36 + self.timeline[0].as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/literals.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return (a,b,c); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return (a,b,c); [INFO] [stdout] 13 + (a,b,c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/literals.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return step; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return step; [INFO] [stdout] 24 + step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/literals.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return requires; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return requires; [INFO] [stdout] 36 + requires [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cell_tl` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 21 | if cell_tl.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = cell_tl` [INFO] [stdout] ... [INFO] [stdout] 25 | let gpath = cell_tl.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cell_tl` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 107 | if cell_tl.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = cell_tl` [INFO] [stdout] ... [INFO] [stdout] 111 | let gpath = cell_tl.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `fusion_gpath` after checking its variant with `is_none` [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:117:44 [INFO] [stdout] | [INFO] [stdout] 114 | if fusion_gpath.is_none() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &mut fusion_gpath` [INFO] [stdout] ... [INFO] [stdout] 117 | let gpath_joined = fusion_gpath.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:118:46 [INFO] [stdout] | [INFO] [stdout] 118 | gpath_joined.do_join(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | return SatMachine::build_using_cnf_file(file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return SatMachine::build_using_cnf_file(file) [INFO] [stdout] 16 + SatMachine::build_using_cnf_file(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `machine` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:46:53 [INFO] [stdout] | [INFO] [stdout] 45 | if machine.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &mut machine` [INFO] [stdout] 46 | let can_have_solution = machine.as_mut() [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 47 | | .unwrap() [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `machine` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 61 | if machine.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &mut machine` [INFO] [stdout] 62 | machine.as_mut().unwrap().make_close_step(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return machine; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return machine; [INFO] [stdout] 65 + machine [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | let is_eof = line == "" && bytes == 0; [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return self.is_valid(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self.is_valid(); [INFO] [stdout] 82 + self.is_valid() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | fn make_step_reading_clause(&mut self, line : &String) -> bool{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 - fn make_step_reading_clause(&mut self, line : &String) -> bool{ [INFO] [stdout] 68 + fn make_step_reading_clause(&mut self, line : &str) -> bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return Some(machine); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Some(machine); [INFO] [stdout] 95 + Some(machine) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | fn init_reading_cnf_config(line : &String) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - fn init_reading_cnf_config(line : &String) -> Option { [INFO] [stdout] 85 + fn init_reading_cnf_config(line : &str) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/constructor.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return Reader { [INFO] [stdout] 17 | | gpath, n_vars, solution, [INFO] [stdout] 18 | | current_step, last_selected, last_requires, [INFO] [stdout] 19 | | is_finished [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ Reader { [INFO] [stdout] 17 + gpath, n_vars, solution, [INFO] [stdout] 18 + current_step, last_selected, last_requires, [INFO] [stdout] 19 + is_finished [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Owners49` [INFO] [stdout] --> src/abssat/gpath/owners/constructor.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn new() -> Self { [INFO] [stdout] 7 | | let table: Vec = Vec::new(); [INFO] [stdout] 8 | | let total_step: i32 = 0; [INFO] [stdout] 9 | | let is_valid = true; [INFO] [stdout] 10 | | Self { table , total_step ,is_valid} [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 5 + impl Default for Owners49 { [INFO] [stdout] 6 + fn default() -> Self { [INFO] [stdout] 7 + Self::new() [INFO] [stdout] 8 + } [INFO] [stdout] 9 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/read.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self.current_step >= self.get_stop_step(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self.current_step >= self.get_stop_step(); [INFO] [stdout] 62 + self.current_step >= self.get_stop_step() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/getters.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | return self.n_vars*2 as Step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return self.n_vars*2 as Step; [INFO] [stdout] 7 + self.n_vars*2 as Step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/getters.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return &self.solution; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return &self.solution; [INFO] [stdout] 11 + &self.solution [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/getters.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | return self.is_finished [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return self.is_finished [INFO] [stdout] 15 + self.is_finished [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/derive.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return derive_readers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return derive_readers; [INFO] [stdout] 23 + derive_readers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | return self.total_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return self.total_step; [INFO] [stdout] 8 + self.total_step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.is_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.is_valid; [INFO] [stdout] 12 + self.is_valid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return match self.get(step) { [INFO] [stdout] 17 | | Some(_value) => false, [INFO] [stdout] 18 | | None => true [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ match self.get(step) { [INFO] [stdout] 17 + Some(_value) => false, [INFO] [stdout] 18 + None => true [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader_exp.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return ReaderExp { [INFO] [stdout] 22 | | list_readers, [INFO] [stdout] 23 | | list_solutions, [INFO] [stdout] 24 | | is_finished [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ ReaderExp { [INFO] [stdout] 22 + list_readers, [INFO] [stdout] 23 + list_solutions, [INFO] [stdout] 24 + is_finished [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/abssat/reader_exp.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / let mut list_readers : Vec = Vec::new(); [INFO] [stdout] 17 | | list_readers.push(reader_seed); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let list_readers: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return format!("{:#064b}", value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return format!("{:#064b}", value); [INFO] [stdout] 24 + format!("{:#064b}", value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | / return match self.get(step) { [INFO] [stdout] 29 | | Some(value) => value, [INFO] [stdout] 30 | | None => 0 [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ match self.get(step) { [INFO] [stdout] 29 + Some(value) => value, [INFO] [stdout] 30 + None => 0 [INFO] [stdout] 31 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | return match self.get(step) { [INFO] [stdout] | ________________^ [INFO] [stdout] 29 | | Some(value) => value, [INFO] [stdout] 30 | | None => 0 [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ help: replace it with: `self.get(step).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Some(self.table[step]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Some(self.table[step]); [INFO] [stdout] 39 + Some(self.table[step]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader_exp.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return &self.list_solutions; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return &self.list_solutions; [INFO] [stdout] 58 + &self.list_solutions [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | return result != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return result != 0; [INFO] [stdout] 51 + result != 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return false; [INFO] [stdout] 53 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mode` after checking its variant with `is_some` [INFO] [stdout] --> src/program.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 21 | if mode.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = mode` [INFO] [stdout] 22 | let mode = mode.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `instance_name` after checking its variant with `is_some` [INFO] [stdout] --> src/program.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 47 | if instance_name.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = instance_name` [INFO] [stdout] 48 | let instance_name = instance_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `instance_name` after checking its variant with `is_some` [INFO] [stdout] --> src/program.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 59 | if instance_name.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = instance_name` [INFO] [stdout] 60 | let instance_name = instance_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/program.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return machine; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return machine; [INFO] [stdout] 96 + machine [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | mask = mask << index_write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask <<= index_write` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:49:30 [INFO] [stdout] | [INFO] [stdout] 49 | let value_copy = self.table[step].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.table[step]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | adder = adder << index_write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adder <<= index_write` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | *value = *value | adder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value |= adder` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:89:43 [INFO] [stdout] | [INFO] [stdout] 89 | let path_instance = get_path_instance(&instance_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `instance_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | subber = subber << index_write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subber <<= index_write` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:75:33 [INFO] [stdout] | [INFO] [stdout] 75 | let mut mask: i64 = i64::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 75 - let mut mask: i64 = i64::max_value(); [INFO] [stdout] 75 + let mut mask: i64 = i64::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | mask = mask ^ subber; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mask ^= subber` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | *value = *value & mask; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value &= mask` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:96:21 [INFO] [stdout] | [INFO] [stdout] 96 | *value = *value | value_b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value |= value_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:100:44 [INFO] [stdout] | [INFO] [stdout] 100 | let output_file_path = get_output_file(&instance_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `instance_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 117 | *value = *value & value_b; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*value &= value_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:106:45 [INFO] [stdout] | [INFO] [stdout] 106 | let mut reader_exp = ReaderExp::new(&machine); [INFO] [stdout] | ^^^^^^^^ help: change this to: `machine` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:143:16 [INFO] [stdout] | [INFO] [stdout] 143 | return !(require_add > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(require_add <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/methods.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | return !(require_add > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return !(require_add > 0); [INFO] [stdout] 143 + !(require_add > 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:138:44 [INFO] [stdout] | [INFO] [stdout] 138 | let output_file_path = get_output_file(&instance_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `instance_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:144:38 [INFO] [stdout] | [INFO] [stdout] 144 | let mut reader = Reader::new(&machine); [INFO] [stdout] | ^^^^^^^^ help: change this to: `machine` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/indexing.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return (step_destine as usize, index as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return (step_destine as usize, index as usize); [INFO] [stdout] 16 + (step_destine as usize, index as usize) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/program.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | return base_path_instances; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return base_path_instances; [INFO] [stdout] 172 + base_path_instances [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/owners/to_list.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return list; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return list; [INFO] [stdout] 42 + list [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/program.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return output_file_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return output_file_path; [INFO] [stdout] 180 + output_file_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/program.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn get_output_file(instance_name : &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 175 - pub fn get_output_file(instance_name : &String) -> String { [INFO] [stdout] 175 + pub fn get_output_file(instance_name : &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GPow` [INFO] [stdout] --> src/abssat/gpath/gpow/constructor.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new() -> Self { [INFO] [stdout] 9 | | let lines_table : HashMap = HashMap::new(); [INFO] [stdout] 10 | | let owners_table: HashMap = HashMap::new(); [INFO] [stdout] 11 | | let owners: Owners49 = Owners49::new(); [INFO] [stdout] ... | [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 7 + impl Default for GPow { [INFO] [stdout] 8 + fn default() -> Self { [INFO] [stdout] 9 + Self::new() [INFO] [stdout] 10 + } [INFO] [stdout] 11 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test/gpath/gpow/test_diagram.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(()); [INFO] [stdout] 29 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | assert_eq!(gpath.get_map_parent_id().is_none(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 15 - assert_eq!(gpath.get_map_parent_id().is_none(), true); [INFO] [stdout] 15 + assert!(gpath.get_map_parent_id().is_none()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | assert_eq!(gpath.is(path_node_id_expected), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 21 - assert_eq!(gpath.is(path_node_id_expected), false); [INFO] [stdout] 21 + assert!(!gpath.is(path_node_id_expected)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | assert_eq!(gpath.is(path_node_id_expected), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 23 - assert_eq!(gpath.is(path_node_id_expected), true); [INFO] [stdout] 23 + assert!(gpath.is(path_node_id_expected)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(gpath.get_map_parent_id().is_none(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(gpath.get_map_parent_id().is_none(), false); [INFO] [stdout] 25 + assert!(!gpath.get_map_parent_id().is_none()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(gpath.get_map_parent_id().is_some(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(gpath.get_map_parent_id().is_some(), true); [INFO] [stdout] 32 + assert!(gpath.get_map_parent_id().is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `set_owners_node_a` after checking its variant with `is_none` [INFO] [stdout] --> src/abssat/gpath/gpow/join.rs:22:50 [INFO] [stdout] | [INFO] [stdout] 19 | if set_owners_node_a.is_none() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = set_owners_node_a` [INFO] [stdout] ... [INFO] [stdout] 22 | let set_owners_node_a = set_owners_node_a.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | assert_eq!(gpath.is(path_node_id_expected), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 39 - assert_eq!(gpath.is(path_node_id_expected), false); [INFO] [stdout] 39 + assert!(!gpath.is(path_node_id_expected)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/join.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | return eq_map_parent_id && eq_current_step && both_valids [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return eq_map_parent_id && eq_current_step && both_valids [INFO] [stdout] 38 + eq_map_parent_id && eq_current_step && both_valids [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | assert_eq!(gpath.is(path_node_id_expected), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 41 - assert_eq!(gpath.is(path_node_id_expected), true); [INFO] [stdout] 41 + assert!(gpath.is(path_node_id_expected)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return &self.map_parent_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return &self.map_parent_id; [INFO] [stdout] 12 + &self.map_parent_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.current_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.current_step; [INFO] [stdout] 16 + self.current_step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return self.owners.is(path_id_node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return self.owners.is(path_id_node); [INFO] [stdout] 20 + self.owners.is(path_id_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return result; [INFO] [stdout] 29 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self.owners_table.get(&path_id_node); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.owners_table.get(&path_id_node); [INFO] [stdout] 33 + self.owners_table.get(&path_id_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return set_parents; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return set_parents; [INFO] [stdout] 52 + set_parents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `set_step` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:65:41 [INFO] [stdout] | [INFO] [stdout] 64 | if set_step.is_some(){ [INFO] [stdout] | --------------------- help: try: `if let Some() = set_step` [INFO] [stdout] 65 | for path_id_node_son in set_step.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/getters.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return set_sons; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return set_sons; [INFO] [stdout] 74 + set_sons [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(gpath.is(path_node_id_expected), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 78 - assert_eq!(gpath.is(path_node_id_expected), false); [INFO] [stdout] 78 + assert!(!gpath.is(path_node_id_expected)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/gpow/test_gpow.rs:80:5 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(gpath.is(path_node_id_expected), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(gpath.is(path_node_id_expected), true); [INFO] [stdout] 80 + assert!(gpath.is(path_node_id_expected)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:68:65 [INFO] [stdout] | [INFO] [stdout] 68 | let owners_node = self.owners_table.get_mut(&path_id_node).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `path_id_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:106:73 [INFO] [stdout] | [INFO] [stdout] 106 | ... let owners_node = self.owners_table.get_mut(&path_id_node).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `path_id_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:145:73 [INFO] [stdout] | [INFO] [stdout] 145 | ... let owners_node = self.owners_table.get_mut(&path_id_node).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `path_id_node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/gpow/filter.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | return self.nodes_to_remove.contains(&path_id_node) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return self.nodes_to_remove.contains(&path_id_node) [INFO] [stdout] 163 + self.nodes_to_remove.contains(&path_id_node) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/path_diagram.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | return &self.dot_txt [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return &self.dot_txt [INFO] [stdout] 17 + &self.dot_txt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/gpath/gpow/test_join.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | let mut diagram = PathDiagram::new(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test/gpath/gpow/test_build.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | return (current_step, gpath_fusion); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - return (current_step, gpath_fusion); [INFO] [stdout] 71 + (current_step, gpath_fusion) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/gpath/path_diagram/build_diagram.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return txt; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return txt; [INFO] [stdout] 68 + txt [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/gpath/gpow/test_build.rs:108:40 [INFO] [stdout] | [INFO] [stdout] 108 | let mut diagram = PathDiagram::new(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/abssat/gpath/path_diagram/export_diagram.rs:19:43 [INFO] [stdout] | [INFO] [stdout] 19 | let mut file = match File::create(&path_input_file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `path_input_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return path_node_id; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return path_node_id; [INFO] [stdout] 25 + path_node_id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/abssat/utils/alias.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | let parent_id = match parent_id { [INFO] [stdout] | _____________________^ [INFO] [stdout] 20 | | None => (-1,0), [INFO] [stdout] 21 | | Some(value_parent_id) => value_parent_id [INFO] [stdout] 22 | | }; [INFO] [stdout] | |_____^ help: replace with: `parent_id.unwrap_or((-1,0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return format!("{}_{}",destine,origin); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return format!("{}_{}",destine,origin); [INFO] [stdout] 31 + format!("{}_{}",destine,origin) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return "r".to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return "r".to_owned(); [INFO] [stdout] 36 + "r".to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return format!("k{}_{}",map_id_node.0,map_id_node.1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return format!("k{}_{}",map_id_node.0,map_id_node.1); [INFO] [stdout] 39 + format!("k{}_{}",map_id_node.0,map_id_node.1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/utils/alias.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return step < 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return step < 0; [INFO] [stdout] 51 + step < 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return timeline; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return timeline; [INFO] [stdout] 19 + timeline [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/initialize.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return machine; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return machine; [INFO] [stdout] 20 + machine [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return id0_1_root; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return id0_1_root; [INFO] [stdout] 17 + id0_1_root [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return id1_0_0_1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return id1_0_0_1; [INFO] [stdout] 25 + id1_0_0_1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return id1_1_0_1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return id1_1_0_1; [INFO] [stdout] 33 + id1_1_0_1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | return self.is_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 8 - return self.is_valid; [INFO] [stdout] 8 + self.is_valid [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | return self.n_vars; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return self.n_vars; [INFO] [stdout] 12 + self.n_vars [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return self.is_valid && self.is_close; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return self.is_valid && self.is_close; [INFO] [stdout] 16 + self.is_valid && self.is_close [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | return Some(self.get_gpath_fusion()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Some(self.get_gpath_fusion()); [INFO] [stdout] 21 + Some(self.get_gpath_fusion()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return None; [INFO] [stdout] 23 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return self.current_step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return self.current_step; [INFO] [stdout] 28 + self.current_step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return self.timeline[index].as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return self.timeline[index].as_ref(); [INFO] [stdout] 32 + self.timeline[index].as_ref() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/getters.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | return self.timeline[0].as_ref().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return self.timeline[0].as_ref().unwrap() [INFO] [stdout] 36 + self.timeline[0].as_ref().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/literals.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return (a,b,c); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return (a,b,c); [INFO] [stdout] 13 + (a,b,c) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/literals.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return step; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return step; [INFO] [stdout] 24 + step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | return owners; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return owners; [INFO] [stdout] 108 + owners [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/literals.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return requires; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return requires; [INFO] [stdout] 36 + requires [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cell_tl` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:25:33 [INFO] [stdout] | [INFO] [stdout] 21 | if cell_tl.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = cell_tl` [INFO] [stdout] ... [INFO] [stdout] 25 | let gpath = cell_tl.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | assert_eq!(owners_full_step2.is_valid(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 121 - assert_eq!(owners_full_step2.is_valid(), true); [INFO] [stdout] 121 + assert!(owners_full_step2.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | assert_eq!(owners_full_step2.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 128 - assert_eq!(owners_full_step2.is(id1_1_0_1), true); [INFO] [stdout] 128 + assert!(owners_full_step2.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 129 - assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] 129 + assert!(owners.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | assert_eq!(owners_full_step2.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 133 - assert_eq!(owners_full_step2.is(id1_1_0_1), true); [INFO] [stdout] 133 + assert!(owners_full_step2.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 134 - assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] 134 + assert!(owners.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cell_tl` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:111:33 [INFO] [stdout] | [INFO] [stdout] 107 | if cell_tl.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = cell_tl` [INFO] [stdout] ... [INFO] [stdout] 111 | let gpath = cell_tl.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | assert_eq!(owners.is_valid(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 135 - assert_eq!(owners.is_valid(), true); [INFO] [stdout] 135 + assert!(owners.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `fusion_gpath` after checking its variant with `is_none` [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:117:44 [INFO] [stdout] | [INFO] [stdout] 114 | if fusion_gpath.is_none() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &mut fusion_gpath` [INFO] [stdout] ... [INFO] [stdout] 117 | let gpath_joined = fusion_gpath.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | assert_eq!(owners_full_step2.is_valid(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 136 - assert_eq!(owners_full_step2.is_valid(), true); [INFO] [stdout] 136 + assert!(owners_full_step2.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/abssat/sat_machine/step_or.rs:118:46 [INFO] [stdout] | [INFO] [stdout] 118 | gpath_joined.do_join(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | assert_eq!(owners_full_step2.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 142 - assert_eq!(owners_full_step2.is(id1_1_0_1), true); [INFO] [stdout] 142 + assert!(owners_full_step2.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | return SatMachine::build_using_cnf_file(file) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return SatMachine::build_using_cnf_file(file) [INFO] [stdout] 16 + SatMachine::build_using_cnf_file(file) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `machine` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:46:53 [INFO] [stdout] | [INFO] [stdout] 45 | if machine.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &mut machine` [INFO] [stdout] 46 | let can_have_solution = machine.as_mut() [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 47 | | .unwrap() [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `machine` after checking its variant with `is_some` [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 61 | if machine.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &mut machine` [INFO] [stdout] 62 | machine.as_mut().unwrap().make_close_step(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | return machine; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return machine; [INFO] [stdout] 65 + machine [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 143 - assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] 143 + assert!(owners.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | let is_eof = line == "" && bytes == 0; [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | assert_eq!(owners.is_valid(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 144 - assert_eq!(owners.is_valid(), true); [INFO] [stdout] 144 + assert!(owners.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | assert_eq!(owners_full_step2.is_valid(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 145 - assert_eq!(owners_full_step2.is_valid(), true); [INFO] [stdout] 145 + assert!(owners_full_step2.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | assert_eq!(owners.is_valid(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 149 - assert_eq!(owners.is_valid(), false); [INFO] [stdout] 149 + assert!(!owners.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return self.is_valid(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return self.is_valid(); [INFO] [stdout] 82 + self.is_valid() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:68:51 [INFO] [stdout] | [INFO] [stdout] 68 | fn make_step_reading_clause(&mut self, line : &String) -> bool{ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 - fn make_step_reading_clause(&mut self, line : &String) -> bool{ [INFO] [stdout] 68 + fn make_step_reading_clause(&mut self, line : &str) -> bool{ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return Some(machine); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Some(machine); [INFO] [stdout] 95 + Some(machine) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/abssat/sat_machine/load_cnf.rs:85:39 [INFO] [stdout] | [INFO] [stdout] 85 | fn init_reading_cnf_config(line : &String) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 85 - fn init_reading_cnf_config(line : &String) -> Option { [INFO] [stdout] 85 + fn init_reading_cnf_config(line : &str) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | assert_eq!(owners.is(id1_0_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 192 - assert_eq!(owners.is(id1_0_0_1), true); [INFO] [stdout] 192 + assert!(owners.is(id1_0_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/constructor.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / return Reader { [INFO] [stdout] 17 | | gpath, n_vars, solution, [INFO] [stdout] 18 | | current_step, last_selected, last_requires, [INFO] [stdout] 19 | | is_finished [INFO] [stdout] 20 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 ~ Reader { [INFO] [stdout] 17 + gpath, n_vars, solution, [INFO] [stdout] 18 + current_step, last_selected, last_requires, [INFO] [stdout] 19 + is_finished [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 193 - assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] 193 + assert!(owners.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | assert_eq!(owners.is(id1_0_0_1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 197 - assert_eq!(owners.is(id1_0_0_1), false); [INFO] [stdout] 197 + assert!(!owners.is(id1_0_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/read.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | return self.current_step >= self.get_stop_step(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return self.current_step >= self.get_stop_step(); [INFO] [stdout] 62 + self.current_step >= self.get_stop_step() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 198 - assert_eq!(owners.is(id1_1_0_1), true); [INFO] [stdout] 198 + assert!(owners.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/getters.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | return self.n_vars*2 as Step; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return self.n_vars*2 as Step; [INFO] [stdout] 7 + self.n_vars*2 as Step [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/getters.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return &self.solution; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return &self.solution; [INFO] [stdout] 11 + &self.solution [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/getters.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | return self.is_finished [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return self.is_finished [INFO] [stdout] 15 + self.is_finished [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader/derive.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return derive_readers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return derive_readers; [INFO] [stdout] 23 + derive_readers [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | assert_eq!(owners.is_valid(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 200 - assert_eq!(owners.is_valid(), true); [INFO] [stdout] 200 + assert!(owners.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | assert_eq!(owners.is(id1_0_0_1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 203 - assert_eq!(owners.is(id1_0_0_1), false); [INFO] [stdout] 203 + assert!(!owners.is(id1_0_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | assert_eq!(owners.is(id1_1_0_1), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 204 - assert_eq!(owners.is(id1_1_0_1), false); [INFO] [stdout] 204 + assert!(!owners.is(id1_1_0_1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/gpath/owners/test_owners.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 207 | assert_eq!(owners.is_valid(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 207 - assert_eq!(owners.is_valid(), false); [INFO] [stdout] 207 + assert!(!owners.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader_exp.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / return ReaderExp { [INFO] [stdout] 22 | | list_readers, [INFO] [stdout] 23 | | list_solutions, [INFO] [stdout] 24 | | is_finished [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 ~ ReaderExp { [INFO] [stdout] 22 + list_readers, [INFO] [stdout] 23 + list_solutions, [INFO] [stdout] 24 + is_finished [INFO] [stdout] 25 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/abssat/reader_exp.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | / let mut list_readers : Vec = Vec::new(); [INFO] [stdout] 17 | | list_readers.push(reader_seed); [INFO] [stdout] | |_______________________________________^ help: consider using the `vec![]` macro: `let list_readers: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/sat_machine/test_sat_machine.rs:15:40 [INFO] [stdout] | [INFO] [stdout] 15 | let mut diagram = PathDiagram::new(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/abssat/reader_exp.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return &self.list_solutions; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return &self.list_solutions; [INFO] [stdout] 58 + &self.list_solutions [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mode` after checking its variant with `is_some` [INFO] [stdout] --> src/program.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 21 | if mode.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = mode` [INFO] [stdout] 22 | let mode = mode.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/sat_machine/test_sat_machine.rs:29:40 [INFO] [stdout] | [INFO] [stdout] 29 | let mut diagram = PathDiagram::new(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `instance_name` after checking its variant with `is_some` [INFO] [stdout] --> src/program.rs:48:29 [INFO] [stdout] | [INFO] [stdout] 47 | if instance_name.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = instance_name` [INFO] [stdout] 48 | let instance_name = instance_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/sat_machine/test_sat_machine.rs:59:40 [INFO] [stdout] | [INFO] [stdout] 59 | let mut diagram = PathDiagram::new(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `instance_name` after checking its variant with `is_some` [INFO] [stdout] --> src/program.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 59 | if instance_name.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = instance_name` [INFO] [stdout] 60 | let instance_name = instance_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test/sat_machine/test_sat_machine.rs:82:40 [INFO] [stdout] | [INFO] [stdout] 82 | let mut diagram = PathDiagram::new(&gpath); [INFO] [stdout] | ^^^^^^ help: change this to: `gpath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/program.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 96 | return machine; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return machine; [INFO] [stdout] 96 + machine [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:89:43 [INFO] [stdout] | [INFO] [stdout] 89 | let path_instance = get_path_instance(&instance_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `instance_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:100:44 [INFO] [stdout] | [INFO] [stdout] 100 | let output_file_path = get_output_file(&instance_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `instance_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:106:45 [INFO] [stdout] | [INFO] [stdout] 106 | let mut reader_exp = ReaderExp::new(&machine); [INFO] [stdout] | ^^^^^^^^ help: change this to: `machine` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | assert_eq!(machine.is_valid(),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 10 - assert_eq!(machine.is_valid(),true); [INFO] [stdout] 10 + assert!(machine.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | assert_eq!(machine.have_solution(),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 11 - assert_eq!(machine.have_solution(),true); [INFO] [stdout] 11 + assert!(machine.have_solution()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:138:44 [INFO] [stdout] | [INFO] [stdout] 138 | let output_file_path = get_output_file(&instance_name); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `instance_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.52s [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/program.rs:144:38 [INFO] [stdout] | [INFO] [stdout] 144 | let mut reader = Reader::new(&machine); [INFO] [stdout] | ^^^^^^^^ help: change this to: `machine` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/program.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | return base_path_instances; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return base_path_instances; [INFO] [stdout] 172 + base_path_instances [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | assert_eq!(machine.is_valid(),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 24 - assert_eq!(machine.is_valid(),true); [INFO] [stdout] 24 + assert!(machine.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | assert_eq!(machine.have_solution(),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 25 - assert_eq!(machine.have_solution(),true); [INFO] [stdout] 25 + assert!(machine.have_solution()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(machine.is_valid(),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(machine.is_valid(),true); [INFO] [stdout] 32 + assert!(machine.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/program.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 180 | return output_file_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return output_file_path; [INFO] [stdout] 180 + output_file_path [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | assert_eq!(machine.have_solution(),true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 33 - assert_eq!(machine.have_solution(),true); [INFO] [stdout] 33 + assert!(machine.have_solution()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/program.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn get_output_file(instance_name : &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 175 - pub fn get_output_file(instance_name : &String) -> String { [INFO] [stdout] 175 + pub fn get_output_file(instance_name : &str) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(machine.is_valid(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(machine.is_valid(),false); [INFO] [stdout] 40 + assert!(!machine.is_valid()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/test/sat_machine/test_sat_machine_cnf.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | assert_eq!(machine.have_solution(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 41 - assert_eq!(machine.have_solution(),false); [INFO] [stdout] 41 + assert!(!machine.have_solution()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/abssat/gpath/path_diagram.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(graph : &'a GPow) -> PathDiagram { [INFO] [stdout] | -- ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(graph : &'a GPow) -> PathDiagram<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/abssat/gpath/path_diagram.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(graph : &'a GPow) -> PathDiagram { [INFO] [stdout] | -- ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(graph : &'a GPow) -> PathDiagram<'a> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "4ba22a221163f2cafc0c235c8fb0e915f12b37a3c44fe8c18896e5d084b913cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ba22a221163f2cafc0c235c8fb0e915f12b37a3c44fe8c18896e5d084b913cd", kill_on_drop: false }` [INFO] [stdout] 4ba22a221163f2cafc0c235c8fb0e915f12b37a3c44fe8c18896e5d084b913cd