[INFO] cloning repository https://github.com/reynantlntno/rnix [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reynantlntno/rnix" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freynantlntno%2Frnix", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freynantlntno%2Frnix'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2f4c1fa657744e309cd1f9b6ccf265d715b9e547 [INFO] linting reynantlntno/rnix against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freynantlntno%2Frnix" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reynantlntno/rnix [INFO] finished tweaking git repo https://github.com/reynantlntno/rnix [INFO] tweaked toml for git repo https://github.com/reynantlntno/rnix written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reynantlntno/rnix on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reynantlntno/rnix already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fatfs v0.3.6 [INFO] [stderr] Downloaded syn v2.0.53 [INFO] [stderr] Downloaded chrono v0.4.35 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee3b1970856cb6ba001bc9f40e2639082fd93151bf4b48838913bd9a1f115dd3 [INFO] running `Command { std: "docker" "start" "-a" "ee3b1970856cb6ba001bc9f40e2639082fd93151bf4b48838913bd9a1f115dd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee3b1970856cb6ba001bc9f40e2639082fd93151bf4b48838913bd9a1f115dd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee3b1970856cb6ba001bc9f40e2639082fd93151bf4b48838913bd9a1f115dd3", kill_on_drop: false }` [INFO] [stdout] ee3b1970856cb6ba001bc9f40e2639082fd93151bf4b48838913bd9a1f115dd3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b503731b6a9998a4caa2c6c91ffd511dc557b9c3a7e69ee64fc1f3bb3f5648c [INFO] running `Command { std: "docker" "start" "-a" "1b503731b6a9998a4caa2c6c91ffd511dc557b9c3a7e69ee64fc1f3bb3f5648c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking chrono v0.4.35 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking blowfish v0.9.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bcrypt v0.15.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking fatfs v0.3.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rnix v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/libs.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 73 | | io::ErrorKind::Other, [INFO] [stdout] 74 | | "No user accounts found", [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 72 ~ Err(io::Error::other( [INFO] [stdout] 73 ~ "No user accounts found", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if !root_dir.open_dir(&mount_point).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir(&mount_point).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if !root_dir.open_dir("internal").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir("internal").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | if !internal_dir.open_dir("bin").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `internal_dir.open_dir("bin").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !root_dir.open_dir("home").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir("home").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if !root_dir.open_dir("volumes").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir("volumes").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/libs.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | Err(io::Error::new( [INFO] [stdout] | _____________^ [INFO] [stdout] 73 | | io::ErrorKind::Other, [INFO] [stdout] 74 | | "No user accounts found", [INFO] [stdout] 75 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 72 ~ Err(io::Error::other( [INFO] [stdout] 73 ~ "No user accounts found", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/main.rs:98:34 [INFO] [stdout] | [INFO] [stdout] 98 | let mut args = input.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/libs.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if !root_dir.open_dir(&mount_point).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir(&mount_point).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:167:36 [INFO] [stdout] | [INFO] [stdout] 167 | let require_sudo = match command { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 168 | | "mount" | "umount" => true, [INFO] [stdout] 169 | | _ => false, [INFO] [stdout] 170 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 167 - let require_sudo = match command { [INFO] [stdout] 168 - "mount" | "umount" => true, [INFO] [stdout] 169 - _ => false, [INFO] [stdout] 170 - }; [INFO] [stdout] 167 + let require_sudo = matches!(command, "mount" | "umount"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:192:32 [INFO] [stdout] | [INFO] [stdout] 192 | "mount" => Ok({ [INFO] [stdout] | ________________________________^ [INFO] [stdout] 193 | | let disk_name = match args.next() { [INFO] [stdout] 194 | | Some(name) => name, [INFO] [stdout] 195 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 200 | | mountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 201 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 200 - mountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 200 + mountdisk(disk_name, &mut mounted_disks, &mut root_dir)? [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 192 ~ "mount" => { [INFO] [stdout] 193 + { [INFO] [stdout] 194 + let disk_name = match args.next() { [INFO] [stdout] 195 + Some(name) => name, [INFO] [stdout] 196 + None => { [INFO] [stdout] 197 + println!("Usage: mount "); [INFO] [stdout] 198 + continue; [INFO] [stdout] 199 + } [INFO] [stdout] 200 + }; [INFO] [stdout] 201 + mountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 202 + }; [INFO] [stdout] 203 + Ok(()) [INFO] [stdout] 204 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:202:33 [INFO] [stdout] | [INFO] [stdout] 202 | "umount" => Ok({ [INFO] [stdout] | _________________________________^ [INFO] [stdout] 203 | | let disk_name = match args.next() { [INFO] [stdout] 204 | | Some(name) => name, [INFO] [stdout] 205 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 210 | | umountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 211 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 210 - umountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 210 + umountdisk(disk_name, &mut mounted_disks, &mut root_dir)? [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 202 ~ "umount" => { [INFO] [stdout] 203 + { [INFO] [stdout] 204 + let disk_name = match args.next() { [INFO] [stdout] 205 + Some(name) => name, [INFO] [stdout] 206 + None => { [INFO] [stdout] 207 + println!("Usage: umount "); [INFO] [stdout] 208 + continue; [INFO] [stdout] 209 + } [INFO] [stdout] 210 + }; [INFO] [stdout] 211 + umountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 212 + }; [INFO] [stdout] 213 + Ok(()) [INFO] [stdout] 214 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:346:29 [INFO] [stdout] | [INFO] [stdout] 346 | "cd" => Ok({ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 347 | | let new_dir_name = match args.next() { [INFO] [stdout] 348 | | Some(name) => name, [INFO] [stdout] 349 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 354 | | cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)?; [INFO] [stdout] 355 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 354 - cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)?; [INFO] [stdout] 354 + cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)? [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 346 ~ "cd" => { [INFO] [stdout] 347 + { [INFO] [stdout] 348 + let new_dir_name = match args.next() { [INFO] [stdout] 349 + Some(name) => name, [INFO] [stdout] 350 + None => { [INFO] [stdout] 351 + println!("Usage: cd "); [INFO] [stdout] 352 + continue; [INFO] [stdout] 353 + } [INFO] [stdout] 354 + }; [INFO] [stdout] 355 + cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)?; [INFO] [stdout] 356 + }; [INFO] [stdout] 357 + Ok(()) [INFO] [stdout] 358 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:360:35 [INFO] [stdout] | [INFO] [stdout] 360 | "readdisk" => Ok({ [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 361 | | let disk_path = match args.next() { [INFO] [stdout] 362 | | Some(path) => path, [INFO] [stdout] 363 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 372 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 360 ~ "readdisk" => { [INFO] [stdout] 361 + let _: () = { [INFO] [stdout] 362 + let disk_path = match args.next() { [INFO] [stdout] 363 + Some(path) => path, [INFO] [stdout] 364 + None => { [INFO] [stdout] 365 + println!("Usage: readdisk "); [INFO] [stdout] 366 + continue; [INFO] [stdout] 367 + } [INFO] [stdout] 368 + }; [INFO] [stdout] 369 + match displaydisk(disk_path) { [INFO] [stdout] 370 + Ok(_) => {} [INFO] [stdout] 371 + Err(err) => println!("Error reading disk image: {}", err), [INFO] [stdout] 372 + } [INFO] [stdout] 373 + }; [INFO] [stdout] 374 + Ok(()) [INFO] [stdout] 375 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if !root_dir.open_dir("internal").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir("internal").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | if !internal_dir.open_dir("bin").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `internal_dir.open_dir("bin").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if !root_dir.open_dir("home").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir("home").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if !root_dir.open_dir("volumes").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_dir.open_dir("volumes").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/main.rs:98:34 [INFO] [stdout] | [INFO] [stdout] 98 | let mut args = input.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:167:36 [INFO] [stdout] | [INFO] [stdout] 167 | let require_sudo = match command { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 168 | | "mount" | "umount" => true, [INFO] [stdout] 169 | | _ => false, [INFO] [stdout] 170 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 167 - let require_sudo = match command { [INFO] [stdout] 168 - "mount" | "umount" => true, [INFO] [stdout] 169 - _ => false, [INFO] [stdout] 170 - }; [INFO] [stdout] 167 + let require_sudo = matches!(command, "mount" | "umount"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:192:32 [INFO] [stdout] | [INFO] [stdout] 192 | "mount" => Ok({ [INFO] [stdout] | ________________________________^ [INFO] [stdout] 193 | | let disk_name = match args.next() { [INFO] [stdout] 194 | | Some(name) => name, [INFO] [stdout] 195 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 200 | | mountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 201 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 200 - mountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 200 + mountdisk(disk_name, &mut mounted_disks, &mut root_dir)? [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 192 ~ "mount" => { [INFO] [stdout] 193 + { [INFO] [stdout] 194 + let disk_name = match args.next() { [INFO] [stdout] 195 + Some(name) => name, [INFO] [stdout] 196 + None => { [INFO] [stdout] 197 + println!("Usage: mount "); [INFO] [stdout] 198 + continue; [INFO] [stdout] 199 + } [INFO] [stdout] 200 + }; [INFO] [stdout] 201 + mountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 202 + }; [INFO] [stdout] 203 + Ok(()) [INFO] [stdout] 204 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:202:33 [INFO] [stdout] | [INFO] [stdout] 202 | "umount" => Ok({ [INFO] [stdout] | _________________________________^ [INFO] [stdout] 203 | | let disk_name = match args.next() { [INFO] [stdout] 204 | | Some(name) => name, [INFO] [stdout] 205 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 210 | | umountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 211 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 210 - umountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 210 + umountdisk(disk_name, &mut mounted_disks, &mut root_dir)? [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 202 ~ "umount" => { [INFO] [stdout] 203 + { [INFO] [stdout] 204 + let disk_name = match args.next() { [INFO] [stdout] 205 + Some(name) => name, [INFO] [stdout] 206 + None => { [INFO] [stdout] 207 + println!("Usage: umount "); [INFO] [stdout] 208 + continue; [INFO] [stdout] 209 + } [INFO] [stdout] 210 + }; [INFO] [stdout] 211 + umountdisk(disk_name, &mut mounted_disks, &mut root_dir)?; [INFO] [stdout] 212 + }; [INFO] [stdout] 213 + Ok(()) [INFO] [stdout] 214 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:346:29 [INFO] [stdout] | [INFO] [stdout] 346 | "cd" => Ok({ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 347 | | let new_dir_name = match args.next() { [INFO] [stdout] 348 | | Some(name) => name, [INFO] [stdout] 349 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 354 | | cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)?; [INFO] [stdout] 355 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: remove the semicolon from the last statement in the block [INFO] [stdout] | [INFO] [stdout] 354 - cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)?; [INFO] [stdout] 354 + cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)? [INFO] [stdout] | [INFO] [stdout] help: or move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 346 ~ "cd" => { [INFO] [stdout] 347 + { [INFO] [stdout] 348 + let new_dir_name = match args.next() { [INFO] [stdout] 349 + Some(name) => name, [INFO] [stdout] 350 + None => { [INFO] [stdout] 351 + println!("Usage: cd "); [INFO] [stdout] 352 + continue; [INFO] [stdout] 353 + } [INFO] [stdout] 354 + }; [INFO] [stdout] 355 + cd(&mut root_dir, new_dir_name, &mut current_dir_path, false)?; [INFO] [stdout] 356 + }; [INFO] [stdout] 357 + Ok(()) [INFO] [stdout] 358 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/main.rs:360:35 [INFO] [stdout] | [INFO] [stdout] 360 | "readdisk" => Ok({ [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 361 | | let disk_path = match args.next() { [INFO] [stdout] 362 | | Some(path) => path, [INFO] [stdout] 363 | | None => { [INFO] [stdout] ... | [INFO] [stdout] 372 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 360 ~ "readdisk" => { [INFO] [stdout] 361 + let _: () = { [INFO] [stdout] 362 + let disk_path = match args.next() { [INFO] [stdout] 363 + Some(path) => path, [INFO] [stdout] 364 + None => { [INFO] [stdout] 365 + println!("Usage: readdisk "); [INFO] [stdout] 366 + continue; [INFO] [stdout] 367 + } [INFO] [stdout] 368 + }; [INFO] [stdout] 369 + match displaydisk(disk_path) { [INFO] [stdout] 370 + Ok(_) => {} [INFO] [stdout] 371 + Err(err) => println!("Error reading disk image: {}", err), [INFO] [stdout] 372 + } [INFO] [stdout] 373 + }; [INFO] [stdout] 374 + Ok(()) [INFO] [stdout] 375 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.87s [INFO] running `Command { std: "docker" "inspect" "1b503731b6a9998a4caa2c6c91ffd511dc557b9c3a7e69ee64fc1f3bb3f5648c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b503731b6a9998a4caa2c6c91ffd511dc557b9c3a7e69ee64fc1f3bb3f5648c", kill_on_drop: false }` [INFO] [stdout] 1b503731b6a9998a4caa2c6c91ffd511dc557b9c3a7e69ee64fc1f3bb3f5648c