[INFO] cloning repository https://github.com/reuschj/HighestNumberPairingsRustVersion [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reuschj/HighestNumberPairingsRustVersion" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freuschj%2FHighestNumberPairingsRustVersion", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freuschj%2FHighestNumberPairingsRustVersion'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 794ebe214eae0acd02a33a13a811c8aa2dc72a5a [INFO] linting reuschj/HighestNumberPairingsRustVersion against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freuschj%2FHighestNumberPairingsRustVersion" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reuschj/HighestNumberPairingsRustVersion [INFO] finished tweaking git repo https://github.com/reuschj/HighestNumberPairingsRustVersion [INFO] tweaked toml for git repo https://github.com/reuschj/HighestNumberPairingsRustVersion written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reuschj/HighestNumberPairingsRustVersion on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reuschj/HighestNumberPairingsRustVersion already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f6a3b30ffabb72032a09e64014693eaae7448217b76e54fdc1ff1d43b38961a [INFO] running `Command { std: "docker" "start" "-a" "5f6a3b30ffabb72032a09e64014693eaae7448217b76e54fdc1ff1d43b38961a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f6a3b30ffabb72032a09e64014693eaae7448217b76e54fdc1ff1d43b38961a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f6a3b30ffabb72032a09e64014693eaae7448217b76e54fdc1ff1d43b38961a", kill_on_drop: false }` [INFO] [stdout] 5f6a3b30ffabb72032a09e64014693eaae7448217b76e54fdc1ff1d43b38961a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6355177f1c9882fca5ba6f09690abc499e718a49c595c589ea218821142e950b [INFO] running `Command { std: "docker" "start" "-a" "6355177f1c9882fca5ba6f09690abc499e718a49c595c589ea218821142e950b", kill_on_drop: false }` [INFO] [stderr] Checking highest_number_pairings v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/defs/number_pairing.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | Self::validate_and_correct_input(requested_number, &sum) [INFO] [stdout] | ^^^^ help: change this to: `sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/defs/number_pairing.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | (sums_are_equal && stored_are_equal) || (sums_are_equal && stored_is_equal_to_inverse) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 - (sums_are_equal && stored_are_equal) || (sums_are_equal && stored_is_equal_to_inverse) [INFO] [stdout] 95 + !(!sums_are_equal || !stored_are_equal && !stored_is_equal_to_inverse) [INFO] [stdout] | [INFO] [stdout] 95 - (sums_are_equal && stored_are_equal) || (sums_are_equal && stored_is_equal_to_inverse) [INFO] [stdout] 95 + (stored_is_equal_to_inverse || stored_are_equal) && sums_are_equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/defs/number_pairing_problem.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 124 | let conversion = (1.0 / precision) * &multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `multiplier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/defs/number_pairing_problem.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | if &this_result > &seq_best_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 133 - if &this_result > &seq_best_result { [INFO] [stdout] 133 + if this_result > seq_best_result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/defs/number_pairing_problem.rs:149:23 [INFO] [stdout] | [INFO] [stdout] 149 | } else if &this_result == &seq_best_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 149 - } else if &this_result == &seq_best_result { [INFO] [stdout] 149 + } else if this_result == seq_best_result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/defs/number_pairing_problem.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | best_list.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `best_list.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/defs/number_pairing_problem.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 261 | other_list.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `other_list.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/defs/number_pairing_problem.rs:265:131 [INFO] [stdout] | [INFO] [stdout] 265 | ...ts:\n{}", other_list) } else { format!("") }; [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/defs/number_pairing.rs:59:60 [INFO] [stdout] | [INFO] [stdout] 59 | Self::validate_and_correct_input(requested_number, &sum) [INFO] [stdout] | ^^^^ help: change this to: `sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/defs/number_pairing.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | (sums_are_equal && stored_are_equal) || (sums_are_equal && stored_is_equal_to_inverse) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 95 - (sums_are_equal && stored_are_equal) || (sums_are_equal && stored_is_equal_to_inverse) [INFO] [stdout] 95 + !(!sums_are_equal || !stored_are_equal && !stored_is_equal_to_inverse) [INFO] [stdout] | [INFO] [stdout] 95 - (sums_are_equal && stored_are_equal) || (sums_are_equal && stored_is_equal_to_inverse) [INFO] [stdout] 95 + (stored_is_equal_to_inverse || stored_are_equal) && sums_are_equal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/defs/number_pairing_problem.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 124 | let conversion = (1.0 / precision) * &multiplier; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `multiplier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/defs/number_pairing_problem.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | if &this_result > &seq_best_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 133 - if &this_result > &seq_best_result { [INFO] [stdout] 133 + if this_result > seq_best_result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/defs/number_pairing_problem.rs:149:23 [INFO] [stdout] | [INFO] [stdout] 149 | } else if &this_result == &seq_best_result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 149 - } else if &this_result == &seq_best_result { [INFO] [stdout] 149 + } else if this_result == seq_best_result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/defs/number_pairing_problem.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | best_list.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `best_list.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/defs/number_pairing_problem.rs:261:21 [INFO] [stdout] | [INFO] [stdout] 261 | other_list.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `other_list.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/defs/number_pairing_problem.rs:265:131 [INFO] [stdout] | [INFO] [stdout] 265 | ...ts:\n{}", other_list) } else { format!("") }; [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "6355177f1c9882fca5ba6f09690abc499e718a49c595c589ea218821142e950b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6355177f1c9882fca5ba6f09690abc499e718a49c595c589ea218821142e950b", kill_on_drop: false }` [INFO] [stdout] 6355177f1c9882fca5ba6f09690abc499e718a49c595c589ea218821142e950b