[INFO] cloning repository https://github.com/reshane/aoc2015 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reshane/aoc2015" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freshane%2Faoc2015", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freshane%2Faoc2015'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 120b416f645d604fa0da373a9cc9aa20c7a166a0 [INFO] linting reshane/aoc2015 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freshane%2Faoc2015" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reshane/aoc2015 [INFO] finished tweaking git repo https://github.com/reshane/aoc2015 [INFO] tweaked toml for git repo https://github.com/reshane/aoc2015 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reshane/aoc2015 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reshane/aoc2015 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d6fbd649922af4f9ad325b1736e610657ec7c86a2507525acb73a9981d9db75 [INFO] running `Command { std: "docker" "start" "-a" "5d6fbd649922af4f9ad325b1736e610657ec7c86a2507525acb73a9981d9db75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d6fbd649922af4f9ad325b1736e610657ec7c86a2507525acb73a9981d9db75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d6fbd649922af4f9ad325b1736e610657ec7c86a2507525acb73a9981d9db75", kill_on_drop: false }` [INFO] [stdout] 5d6fbd649922af4f9ad325b1736e610657ec7c86a2507525acb73a9981d9db75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dede01866c649fb64bebec0f6eaf99c1dff6c027354a1721513615f0100261df [INFO] running `Command { std: "docker" "start" "-a" "dede01866c649fb64bebec0f6eaf99c1dff6c027354a1721513615f0100261df", kill_on_drop: false }` [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking aoc2015 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day5.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | const VOWELS: &'static [char] = &[ [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day5.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | / !(w[0] == b'a' && w[1] == b'b') && [INFO] [stdout] 25 | | !(w[0] == b'c' && w[1] == b'd') && [INFO] [stdout] | |___________________________________________________^ help: try: `!(w[0] == b'a' && w[1] == b'b' || w[0] == b'c' && w[1] == b'd')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | return acc; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return acc; [INFO] [stdout] 35 + acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 69 | for x in ins.x.0..=ins.x.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 69 - for x in ins.x.0..=ins.x.1 { [INFO] [stdout] 69 + for in grid.iter_mut().take(ins.x.1 + 1).skip(ins.x.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | for y in ins.y.0..=ins.y.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 70 - for y in ins.y.0..=ins.y.1 { [INFO] [stdout] 70 + for in grid.iter_mut().take(ins.y.1 + 1).skip(ins.y.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | for x in ins.x.0..=ins.x.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 105 - for x in ins.x.0..=ins.x.1 { [INFO] [stdout] 105 + for in grid.iter_mut().take(ins.x.1 + 1).skip(ins.x.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | for y in ins.y.0..=ins.y.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 106 - for y in ins.y.0..=ins.y.1 { [INFO] [stdout] 106 + for in grid.iter_mut().take(ins.y.1 + 1).skip(ins.y.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/day5.rs:10:16 [INFO] [stdout] | [INFO] [stdout] 10 | const VOWELS: &'static [char] = &[ [INFO] [stdout] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day5.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | / !(w[0] == b'a' && w[1] == b'b') && [INFO] [stdout] 25 | | !(w[0] == b'c' && w[1] == b'd') && [INFO] [stdout] | |___________________________________________________^ help: try: `!(w[0] == b'a' && w[1] == b'b' || w[0] == b'c' && w[1] == b'd')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day5.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | return acc; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return acc; [INFO] [stdout] 35 + acc [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:69:18 [INFO] [stdout] | [INFO] [stdout] 69 | for x in ins.x.0..=ins.x.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 69 - for x in ins.x.0..=ins.x.1 { [INFO] [stdout] 69 + for in grid.iter_mut().take(ins.x.1 + 1).skip(ins.x.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 70 | for y in ins.y.0..=ins.y.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 70 - for y in ins.y.0..=ins.y.1 { [INFO] [stdout] 70 + for in grid.iter_mut().take(ins.y.1 + 1).skip(ins.y.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:105:18 [INFO] [stdout] | [INFO] [stdout] 105 | for x in ins.x.0..=ins.x.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 105 - for x in ins.x.0..=ins.x.1 { [INFO] [stdout] 105 + for in grid.iter_mut().take(ins.x.1 + 1).skip(ins.x.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is only used to index `grid` [INFO] [stdout] --> src/day6.rs:106:22 [INFO] [stdout] | [INFO] [stdout] 106 | for y in ins.y.0..=ins.y.1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 106 - for y in ins.y.0..=ins.y.1 { [INFO] [stdout] 106 + for in grid.iter_mut().take(ins.y.1 + 1).skip(ins.y.0) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/day2.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | let input = vec![ [INFO] [stdout] | _________________^ [INFO] [stdout] 28 | | "2x3x4", [INFO] [stdout] 29 | | ]; [INFO] [stdout] | |_____^ help: you can use an array directly: `["2x3x4"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/day2.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | let input = vec![ [INFO] [stdout] | _________________^ [INFO] [stdout] 53 | | "1x1x10", [INFO] [stdout] 54 | | "2x3x4", [INFO] [stdout] 55 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 52 ~ let input = ["1x1x10", [INFO] [stdout] 53 ~ "2x3x4"]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.65s [INFO] running `Command { std: "docker" "inspect" "dede01866c649fb64bebec0f6eaf99c1dff6c027354a1721513615f0100261df", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dede01866c649fb64bebec0f6eaf99c1dff6c027354a1721513615f0100261df", kill_on_drop: false }` [INFO] [stdout] dede01866c649fb64bebec0f6eaf99c1dff6c027354a1721513615f0100261df