[INFO] cloning repository https://github.com/reliaburger/reliaburger [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/reliaburger/reliaburger" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freliaburger%2Freliaburger", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freliaburger%2Freliaburger'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 91d264a164921eae3f1e36837248c393e74b7528 [INFO] linting reliaburger/reliaburger against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Freliaburger%2Freliaburger" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/reliaburger/reliaburger [INFO] finished tweaking git repo https://github.com/reliaburger/reliaburger [INFO] tweaked toml for git repo https://github.com/reliaburger/reliaburger written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/reliaburger/reliaburger on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/reliaburger/reliaburger already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded byte-unit v5.2.0 [INFO] [stderr] Downloaded validit v0.2.5 [INFO] [stderr] Downloaded openraft-macros v0.9.21 [INFO] [stderr] Downloaded anyerror v0.1.13 [INFO] [stderr] Downloaded jwt v0.16.0 [INFO] [stderr] Downloaded borsh-derive v1.6.0 [INFO] [stderr] Downloaded http-auth v0.1.10 [INFO] [stderr] Downloaded toml_edit v0.25.4+spec-1.1.0 [INFO] [stderr] Downloaded oci-distribution v0.11.0 [INFO] [stderr] Downloaded borsh v1.6.0 [INFO] [stderr] Downloaded insta v1.46.3 [INFO] [stderr] Downloaded rkyv v0.7.46 [INFO] [stderr] Downloaded rust_decimal v1.40.0 [INFO] [stderr] Downloaded uuid v1.22.0 [INFO] [stderr] Downloaded rkyv_derive v0.7.46 [INFO] [stderr] Downloaded olpc-cjson v0.1.4 [INFO] [stderr] Downloaded openraft v0.9.21 [INFO] [stderr] Downloaded proptest v1.10.0 [INFO] [stderr] Downloaded toml_datetime v1.0.0+spec-1.1.0 [INFO] [stderr] Downloaded proc-macro-crate v3.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d9515614db16d8b727ac7560e6b384c736f14fa87a77c562aa3d879b3225d17 [INFO] running `Command { std: "docker" "start" "-a" "8d9515614db16d8b727ac7560e6b384c736f14fa87a77c562aa3d879b3225d17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d9515614db16d8b727ac7560e6b384c736f14fa87a77c562aa3d879b3225d17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d9515614db16d8b727ac7560e6b384c736f14fa87a77c562aa3d879b3225d17", kill_on_drop: false }` [INFO] [stdout] 8d9515614db16d8b727ac7560e6b384c736f14fa87a77c562aa3d879b3225d17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c99892a6f2a205282688de3b9fbc091d4ae2ca54cf60e68fb5d40798881a879e [INFO] running `Command { std: "docker" "start" "-a" "c99892a6f2a205282688de3b9fbc091d4ae2ca54cf60e68fb5d40798881a879e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Compiling chrono v0.4.44 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking utf8-width v0.1.8 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking byte-unit v5.2.0 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking http-auth v0.1.10 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerocopy-derive v0.8.40 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Compiling openraft-macros v0.9.21 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking anyerror v0.1.13 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking validit v0.2.5 [INFO] [stderr] Checking jwt v0.16.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking olpc-cjson v0.1.4 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking insta v1.46.3 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking proptest v1.10.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking oci-distribution v0.11.0 [INFO] [stderr] Checking openraft v0.9.21 [INFO] [stderr] Checking reliaburger v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/meat/score.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | let bin_pack = if node.allocatable.cpu_millicores == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 65 | let utilisation = (allocated_after * 100 / node.allocatable.cpu_millicores).min(100); [INFO] [stdout] | --------------------------------------------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `NodeStatus` [INFO] [stdout] --> tests/agent_cluster.rs:13:70 [INFO] [stdout] | [INFO] [stdout] 13 | use reliaburger::bun::agent::{AgentCommand, BunAgent, ClusterHandle, NodeStatus}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ScheduleError` [INFO] [stdout] --> tests/scheduling.rs:12:36 [INFO] [stdout] | [INFO] [stdout] 12 | use reliaburger::meat::scheduler::{ScheduleError, Scheduler}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `tokio_util::sync::CancellationToken` [INFO] [stdout] --> tests/chaos.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use tokio_util::sync::CancellationToken; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `reliaburger::meat::NodeId` [INFO] [stdout] --> tests/chaos.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | use reliaburger::meat::NodeId; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/chaos.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / if let Some(lid) = node.current_leader().await { [INFO] [stdout] 121 | | if majority.contains(&lid) { [INFO] [stdout] 122 | | majority_leader = Some(lid); [INFO] [stdout] 123 | | break; [INFO] [stdout] 124 | | } [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 120 ~ if let Some(lid) = node.current_leader().await [INFO] [stdout] 121 ~ && majority.contains(&lid) { [INFO] [stdout] 122 | majority_leader = Some(lid); [INFO] [stdout] 123 | break; [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/council/node.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | / if let Some(leader) = node.current_leader().await { [INFO] [stdout] 259 | | if exclude.is_none_or(|ex| leader != ex) { [INFO] [stdout] 260 | | return Some(leader); [INFO] [stdout] 261 | | } [INFO] [stdout] 262 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 258 ~ if let Some(leader) = node.current_leader().await [INFO] [stdout] 259 ~ && exclude.is_none_or(|ex| leader != ex) { [INFO] [stdout] 260 | return Some(leader); [INFO] [stdout] 261 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/grill/rootless.rs:276:40 [INFO] [stdout] | [INFO] [stdout] 276 | .find(|m| m.destination == PathBuf::from("/sys")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `*"/sys"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grill/runc.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 338 | if !std::env::var("RELIABURGER_IMAGE_PULL_TESTS").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("RELIABURGER_IMAGE_PULL_TESTS").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/meat/score.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 61 | let bin_pack = if node.allocatable.cpu_millicores == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ check performed here [INFO] [stdout] ... [INFO] [stdout] 65 | let utilisation = (allocated_after * 100 / node.allocatable.cpu_millicores).min(100); [INFO] [stdout] | --------------------------------------------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 10s [INFO] running `Command { std: "docker" "inspect" "c99892a6f2a205282688de3b9fbc091d4ae2ca54cf60e68fb5d40798881a879e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c99892a6f2a205282688de3b9fbc091d4ae2ca54cf60e68fb5d40798881a879e", kill_on_drop: false }` [INFO] [stdout] c99892a6f2a205282688de3b9fbc091d4ae2ca54cf60e68fb5d40798881a879e